Kolab Groupware OBS

kolab-syncroton.spec Changed

@@ -34,10 +34,9 @@
 %endif
 
 %global _ap_sysconfdir %{_sysconfdir}/%{httpd_name}
-%global upstream_version 2.4.2
 
 Name:           kolab-syncroton
-Version: 2.4.2.18
+Version:        2.3.22
 Release:        1%{?dist}
 Summary:        ActiveSync for Kolab Groupware
 
@@ -45,32 +44,49 @@
 License:        LGPLv2
 URL:            http://www.syncroton.org
 
-Source0:        %{name}-%{upstream_version}.tar.gz
+Source0:        https://mirror.kolabenterprise.com/pub/releases/%{name}-%{version}.tar.gz
 Source1:        kolab-syncroton.logrotate
 Source2:        plesk.kolab_syncroton.inc.php
+Patch0:         0002-Report-INVALID_SOURCE-if-the-move-fails.patch
 
 BuildArch:      noarch
 
+# Use this build requirement to make sure we are using
+# up to date vendorized copies of the plugins.
+%if 0%{?plesk} < 1
+BuildRequires:  roundcubemail-plugin-kolab_auth >= 3.2
+%endif
+BuildRequires:  roundcubemail-plugin-kolab_folders >= 3.2
+BuildRequires:  roundcubemail-plugin-libcalendaring >= 3.2
+BuildRequires:  roundcubemail-plugin-libkolab >= 3.2
+
 %if 0%{?rhel} < 8
 %if 0%{?suse_version}
 BuildRequires:  roundcubemail
 Requires:       php
 Requires:       php-pear-Auth_SASL
 Requires:       php-pear-MDB2_Driver_mysqli
+Requires:       php-pear-Net_IDNA2
 Requires:       php-pear-Net_SMTP
 Requires:       php-pear-Net_Socket
 %else
-BuildRequires:  roundcubemail >= 1.5
 Requires:       php-common >= 5.3
 Requires:       php-pear-Auth-SASL
 Requires:       php-pear-MDB2-Driver-mysqli
+Requires:       php-pear-Net-IDNA2
 Requires:       php-pear-Net-SMTP
 Requires:       php-pear-Net-Socket
 %endif
 %endif
 
-Requires:       roundcubemail
 Requires:       logrotate
+Requires:       roundcubemail(core)
+%if 0%{?plesk} < 1
+Requires:       roundcubemail-plugin-kolab_auth >= 3.2
+%endif
+Requires:       roundcubemail-plugin-kolab_folders >= 3.2
+Requires:       roundcubemail-plugin-libcalendaring >= 3.2
+Requires:       roundcubemail-plugin-libkolab >= 3.2
 %if 0%{?rhel} < 8
 Requires:       php-kolabformat
 Requires:       php-pear-MDB2
@@ -83,8 +99,8 @@
 and Tasks though this package - based on Syncroton technology.
 
 %prep
-%setup -q -n %{name}-%{upstream_version}
-#%patch0 -p1
+%setup -q -n %{name}-%{version}
+%patch0 -p1
 
 %build
 
@@ -172,19 +188,8 @@
     fi
 fi
 
-if  -f "/usr/lib/systemd/system/php-fpm.service" ; then
-    /bin/systemctl reload php-fpm.service || :
-fi
-
-
-%if 0%{?plesk} > 0 && 0%{?rhel} == 7
-php="/opt/plesk/php/7.4/bin/php"
-%else
-php="/usr/bin/php"
-%endif
-
-${php} /usr/share/roundcubemail/bin/updatedb.sh \
-    --dir /usr/share/doc/kolab-syncroton/SQL/ \
+/usr/share/roundcubemail/bin/updatedb.sh \
+    --dir /usr/share/doc/kolab-syncroton-%{version}/SQL/ \
     --package syncroton \
     >/dev/null 2>&1 || :
 
@@ -205,15 +210,6 @@
 %attr(0770,%{httpd_user},%{httpd_group}) %{_var}/log/%{name}
 
 %changelog
-* Thu Jul 27 2023 Christian Mollekopf <mollekopf@apheleia-it.ch> - 2.4.2-1
-- Release version 2.4.2
-
-* Mon Jul 17 2023 Christian Mollekopf <mollekopf@apheleia-it.ch> - 2.4.1-1
-- Release version 2.4.1
-
-* Wed May 10 2023 Christian Mollekopf <mollekopf@apheleia-it.ch> - 2.4.0-1
-- Release version 2.4.0
-
 * Fri Feb 04 2022 Jeroen van Meeuwen <vanmeeuwen@apheleia-it.ch> - 2.3.22-1
 - Release version 2.3.22

0002-Report-INVALID_SOURCE-if-the-move-fails.patch Added

@@ -0,0 +1,36 @@
+From 0a8e797ea62be331a2530440e45cc1c9edc786ee Mon Sep 17 00:00:00 2001
+From: Christian Mollekopf <mollekopf@apheleia-it.ch>
+Date: Tue, 30 Aug 2022 16:21:45 +0200
+Subject: PATCH 2/2 Report INVALID_SOURCE if the move fails
+
+A nonexistent source message is at least one reason for the failure,
+and returning SUCCESS without a destination msgid is clearly not
+correct.
+May fix an iphone issue where it keeps sending the same move command
+over and over.
+---
+ lib/ext/Syncroton/Command/MoveItems.php | 7 +++++--
+ 1 file changed, 5 insertions(+), 2 deletions(-)
+
+diff --git a/lib/ext/Syncroton/Command/MoveItems.php b/lib/ext/Syncroton/Command/MoveItems.php
+index 73e57dd..3f89b34 100644
+--- a/lib/ext/Syncroton/Command/MoveItems.php
++++ b/lib/ext/Syncroton/Command/MoveItems.php
+@@ -79,9 +79,12 @@ class Syncroton_Command_MoveItems extends Syncroton_Command_Wbxml
+                 $dataController = Syncroton_Data_Factory::factory($sourceFolder->class, $this->_device, $this->_syncTimeStamp);
+                 $newId          = $dataController->moveItem($move'srcFldId', $move'srcMsgId', $move'dstFldId');
+ 
++                if (!$newId) {
++                    throw new Syncroton_Exception_Status_MoveItems(Syncroton_Exception_Status_MoveItems::INVALID_SOURCE);
++                }
++
+                 $response->appendChild($this->_outputDom->createElementNS('uri:Move', 'Status', Syncroton_Command_MoveItems::STATUS_SUCCESS));
+-                if ($newId)
+-                    $response->appendChild($this->_outputDom->createElementNS('uri:Move', 'DstMsgId', $newId));
++                $response->appendChild($this->_outputDom->createElementNS('uri:Move', 'DstMsgId', $newId));
+             } catch (Syncroton_Exception_Status $e) {
+                 $response->appendChild($this->_outputDom->createElementNS('uri:Move', 'Status', $e->getCode()));
+             } catch (Exception $e) {
+-- 
+2.37.1
+

buildtarball.sh Deleted

debian.changelog Changed

debian.control Changed

kolab-syncroton-2.4.2.tar.gz -> kolab-syncroton-2.3.22.tar.gz Changed

kolab-syncroton.dsc Changed

plesk.kolab_syncroton.inc.php Changed

release.sh Deleted

Changes of Revision 2