Request 3268 (superseded)

This request is superseded by request 3271 (Show diff)

Overview

Request 3268 (superseded)

New release 2.4.2.12

Created by mollekopf 10 months ago
In state superseded
Supersedes 3266
Superseded by 3271
Open review for Admin
Open review for vanmeeuwen
Open review for mollekopf
Open review for kolab-developers

Submit kolab-syncroton

Submit package Kolab:16:Testing / kolab-syncroton to package Kolab:16 / kolab-syncroton

kolab-syncroton.spec Changed

@@ -17,12 +17,6 @@
 
 %{!?php_inidir: %global php_inidir %{_sysconfdir}/php.d}
 
-%if 0%{?suse_version} < 1 && 0%{?fedora} < 1 && 0%{?rhel} < 7
-%global with_systemd 0
-%else
-%global with_systemd 1
-%endif
-
 %if 0%{?suse_version}
 %global httpd_group www
 %global httpd_name apache2
@@ -43,7 +37,7 @@
 %global upstream_version 2.4.2
 
 Name:           kolab-syncroton
-Version: 2.4.2.36
+Version: 2.4.2.12
 Release:        1%{?dist}
 Summary:        ActiveSync for Kolab Groupware
 
@@ -112,7 +106,6 @@
 
 cp -a lib %{buildroot}/%{_datadir}/%{name}/.
 cp -a index.php %{buildroot}/%{_datadir}/%{name}/.
-cp -a bin %{buildroot}/%{_datadir}/%{name}/.
 
 %if 0%{?plesk}
 cp -a %SOURCE2 %{buildroot}/%{_sysconfdir}/roundcubemail/kolab_syncroton.inc.php
@@ -171,7 +164,7 @@
 %post
 if  -f "%{php_inidir}/apc.ini" -o -f "%{php_inidir}/apcu.ini" ; then
     if  ! -z "`grep ^apc.enabled=1 %{php_inidir}/apc{,u}.ini 2>/dev/null`" ; then
-%if 0%{?with_systemd}
+%if 0%{?fedora} > 15
         /bin/systemctl condrestart %{httpd_name}.service
 %else
         /sbin/service %{httpd_name} condrestart
@@ -183,35 +176,7 @@
     /bin/systemctl reload php-fpm.service || :
 fi
 
-if  -f "/usr/lib/systemd/system/plesk-php74-fpm.service" ; then
-    /bin/systemctl reload plesk-php74-fpm.service || :
-fi
-
-if  -f "/usr/lib/systemd/system/plesk-php80-fpm.service" ; then
-    /bin/systemctl reload plesk-php80-fpm.service || :
-fi
-
-if  -f "/usr/lib/systemd/system/plesk-php81-fpm.service" ; then
-    /bin/systemctl reload plesk-php81-fpm.service || :
-fi
-
-if  -f "/usr/lib/systemd/system/plesk-php82-fpm.service" ; then
-    /bin/systemctl reload plesk-php82-fpm.service || :
-fi
-
-if  -f "/usr/lib/systemd/system/plesk-php83-fpm.service" ; then
-    /bin/systemctl reload plesk-php83-fpm.service || :
-fi
-
-
-
-%if 0%{?plesk} > 0 && 0%{?rhel} == 7
-php="/opt/plesk/php/7.4/bin/php"
-%else
-php="/usr/bin/php"
-%endif
-
-${php} /usr/share/roundcubemail/bin/updatedb.sh \
+/usr/share/roundcubemail/bin/updatedb.sh \
     --dir /usr/share/doc/kolab-syncroton/SQL/ \
     --package syncroton \
     >/dev/null 2>&1 || :

debian.changelog Changed

debian.tar.gz/dirs Changed

debian.tar.gz/install Changed

kolab-syncroton-2.4.2.tar.gz/.gitignore Deleted

kolab-syncroton-2.4.2.tar.gz/.php-cs-fixer.php Changed

kolab-syncroton-2.4.2.tar.gz/bin Deleted

kolab-syncroton-2.4.2.tar.gz/bin/analyzelogs.php Deleted

@@ -1,149 +0,0 @@
-#!/usr/bin/env php
-<?php
-/*
- +--------------------------------------------------------------------------+
- | Kolab Sync (ActiveSync for Kolab)                                        |
- |                                                                          |
- | Copyright (C) 2024, Apheleia IT AG <contact@apheleia-it.ch>         |
- |                                                                          |
- | This program is free software: you can redistribute it and/or modify     |
- | it under the terms of the GNU Affero General Public License as published |
- | by the Free Software Foundation, either version 3 of the License, or     |
- | (at your option) any later version.                                      |
- |                                                                          |
- | This program is distributed in the hope that it will be useful,          |
- | but WITHOUT ANY WARRANTY; without even the implied warranty of           |
- | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the             |
- | GNU Affero General Public License for more details.                      |
- |                                                                          |
- | You should have received a copy of the GNU Affero General Public License |
- | along with this program. If not, see <http://www.gnu.org/licenses/>      |
- +--------------------------------------------------------------------------+
- | Author: Christian Mollekopf <mollekopf@apheleia-it.ch>                      |
- +--------------------------------------------------------------------------+
-*/
-
-
-define('RCUBE_INSTALL_PATH', realpath(dirname(__FILE__) . '/../') . '/');
-
-// Define include path
-$include_path  = RCUBE_INSTALL_PATH . 'lib' . PATH_SEPARATOR;
-$include_path .= RCUBE_INSTALL_PATH . 'lib/ext' . PATH_SEPARATOR;
-$include_path .= ini_get('include_path');
-set_include_path($include_path);
-
-require_once "Syncroton/Command/ICommand.php";
-require_once "Syncroton/Command/Wbxml.php";
-require_once "Syncroton/Command/Sync.php";
-require_once "Syncroton/Command/Ping.php";
-require_once "Syncroton/Command/MoveItems.php";
-require_once "Syncroton/Command/FolderSync.php";
-
-$filename = $argv1;
-
-$content = file_get_contents($filename);
-
-// Split up the log files into chunks that hopefully match the commands
-$parts = preg_split("/\.*\: " . preg_quote("DEBUG Syncroton_Server::handle::65 REQUEST METHOD: POST", '/') . "/", $content, -1, PREG_SPLIT_NO_EMPTY | PREG_SPLIT_DELIM_CAPTURE);
-
-function getStatusConstants($classname)
-{
-    $reflect = new ReflectionClass($classname);
-    $result = $reflect->getConstants();
-    $result = array_filter($result, function ($val) {
-        return str_starts_with($val, "STATUS_");
-    }, ARRAY_FILTER_USE_KEY);
-    $result = array_flip($result);
-    return $result;
-}
-
-function explainStatus($command, $status)
-{
-    if (!$status) {
-        return "none";
-    }
-    switch ($command) {
-        case "Ping":
-            $result = getStatusConstants("Syncroton_Command_Ping");
-            return $result$status ?? "Unknown";
-        case "Sync":
-            $result = getStatusConstants("Syncroton_Command_Sync");
-            return $result$status ?? "Unknown";
-        case "MoveItems":
-            $result = getStatusConstants("Syncroton_Command_MoveItems");
-            return $result$status ?? "Unknown";
-        case "FolderSync":
-            $result = getStatusConstants("Syncroton_Command_FolderSync");
-            return $result$status ?? "Unknown";
-    }
-    return "Unknown command";
-}
-
-foreach ($parts as $part) {
-    preg_match('/\(.*)\: /', $part, $matches);
-    $timestamp = $matches1;
-
-    preg_match('/\command\ => (.*)/', $part, $matches);
-    $command = $matches1;
-
-    preg_match('/\<Status\>(.*)\<\/Status\>/', $part, $matches);
-    $status = $matches1 ?? null;
-
-    $statusExplained = explainStatus($command, $status);
-
-    print(" Command: " . str_pad($command, 10) . str_pad("\tStatus: $status ($statusExplained)", 45) . "\tTimestamp: $timestamp\n");
-    if ($command == "Sync") {
-        // Find collections within this sync
-        // 25-Sep-2024 09:16:35.347730: INFO Syncroton_Command_Sync::handle::221 SyncKey is 7301 Class: Email CollectionId: 38b950ebd62cd9a66929c89615d0fc04
-        if (preg_match_all('/SyncKey is (.*) Class: (.*) CollectionId: (.*)/', $part, $matches, PREG_OFFSET_CAPTURE | PREG_SET_ORDER)) {
-            foreach ($matches as $set) {
-                $offset = $set01;
-                $collectionId = $set30;
-                $class = $set20;
-                $synckey = $set10;
-                print(str_pad("  Collection: $collectionId ($class)", 58) . "\tSyncKey: $synckey\n");
-
-                //Find the offset for this collections messages
-                if (preg_match("/Processing $collectionId\.\.\./", $part, $match, PREG_OFFSET_CAPTURE, $offset)) {
-                    // print_r($match);
-                    $offset = $match01 ?? null;
-                    //Find the actual changes
-                    if ($offset && preg_match('/found $added\/changed\/deleted$ (.*)\/(.*)\/(.*) entries for sync from server to client/', $part, $changesMatch, PREG_OFFSET_CAPTURE, $offset)) {
-                        // If the offset is too large we are looking at the next collection.
-                        if ($changesMatch01 - $offset < 200) {
-                            print("    " . $changesMatch00 . "\n");
-                        }
-                    }
-                }
-                //TODO We could figure out what the diff per collection was in terms of synckey to the last sync
-                //TODO We could figure out what we actually return in the response compared to the detected changeset
-                //TODO Warn if a collection is repeatedly synced with the same synckey, but changes are detected. It may be stuck in a sync loop.
-            }
-        }
-
-        // Detect entries that are being added from the client
-        if (preg_match_all('/found (.*) entries to be added on server/', $part, $matches)) {
-            foreach ($matches0 ??  as $match) {
-                print("  " . $match . "\n");
-            }
-        }
-
-        if (preg_match_all('/found (.*) entries to be updated on server/', $part, $matches)) {
-            foreach ($matches0 ??  as $match) {
-                print("  " . $match . "\n");
-            }
-        }
-
-        if (preg_match_all('/found (.*) entries to be deleted on server/', $part, $matches)) {
-            foreach ($matches0 ??  as $match) {
-                print("  " . $match . "\n");
-            }
-        }
-    }
-    //TODO on Sync:
-    //* number of Add/Change/Remove from client and from server
-    //* Synckey
-    //* list involved folders
-    //TODO on Sync:
-    //* Reason for interruption
-}

kolab-syncroton-2.4.2.tar.gz/bin/delete-device.php Deleted

@@ -1,97 +0,0 @@
-#!/usr/bin/env php
-<?php
-/*
- +--------------------------------------------------------------------------+
- | Kolab Sync (ActiveSync for Kolab)                                        |
- |                                                                          |
- | Copyright (C) 2024, Apheleia IT AG <contact@apheleia-it.ch>         |
- |                                                                          |
- | This program is free software: you can redistribute it and/or modify     |
- | it under the terms of the GNU Affero General Public License as published |
- | by the Free Software Foundation, either version 3 of the License, or     |
- | (at your option) any later version.                                      |
- |                                                                          |
- | This program is distributed in the hope that it will be useful,          |
- | but WITHOUT ANY WARRANTY; without even the implied warranty of           |
- | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the             |
- | GNU Affero General Public License for more details.                      |
- |                                                                          |
- | You should have received a copy of the GNU Affero General Public License |
- | along with this program. If not, see <http://www.gnu.org/licenses/>      |
- +--------------------------------------------------------------------------+
- | Author: Christian Mollekopf <mollekopf@apheleia-it.ch>                      |
- +--------------------------------------------------------------------------+
-*/
-
-
-define('RCUBE_INSTALL_PATH', realpath(dirname(__FILE__) . '/../') . '/');
-define('RCUBE_PLUGINS_DIR', RCUBE_INSTALL_PATH . 'lib/plugins/');
-
-// Define include path
-$include_path  = RCUBE_INSTALL_PATH . 'lib' . PATH_SEPARATOR;
-$include_path .= RCUBE_INSTALL_PATH . 'lib/ext' . PATH_SEPARATOR;
-$include_path .= ini_get('include_path');
-set_include_path($include_path);
-
-// include composer autoloader (if available)
-if (@file_exists(RCUBE_INSTALL_PATH . 'vendor/autoload.php')) {
-    require RCUBE_INSTALL_PATH . 'vendor/autoload.php';
-}
-
-// include global functions from Roundcube Framework
-require_once 'Roundcube/bootstrap.php';
-
-$opts = rcube_utils::get_opt(
-    's' => 'since', // Deletes *all* devices that haven't been used since the given timestamp. Doesn't take owner and device id into account. Timestamp format e.g.: "2024-11-01"
-    'o' => 'owner',
-    'd' => 'deviceid',
-);
-
-$rcube = \rcube::get_instance();
-$db    = $rcube->get_dbh();
-
-if (!empty($opts'since')) {
-    $since = $opts'since';
-    $since = new DateTime($since);
-    print("Removing all devices that haven't been used since: " . $since->format('Y-m-d H:i:s') . "\n");
-
-    $db->query(
-        "DELETE FROM `syncroton_device`"
-        . " WHERE `lastping` < ? OR `lastping` = NULL",
-        $since->format('Y-m-d H:i:s')
-    );
-    return;
-}
-
-if (empty($opts'deviceid')) {
-    rcube::raise_error("Device id not specified (--deviceid).", false, true);
-}
-$device = $opts'deviceid';
-
-if (empty($opts'owner')) {
-    rcube::raise_error("owner not specified (--owner).", false, true);
-}
-$owner = $opts'owner';
-
-$select = $db->query(
-    "SELECT `user_id` FROM `users`"
-    . " WHERE `username` = ?"
-    . " ORDER BY `user_id` DESC",
-    \strtolower($owner)
-);
-
-if ($data = $db->fetch_assoc($select)) {
-    $userid = $data'user_id';
-} else {
-    rcube::raise_error("User not found in roundcube database, aborting: $email.", false, true);
-}
-
-print("Found the user with id: $userid\n");
-
-$db->query(
-    "DELETE FROM syncroton_device WHERE owner_id = ? AND deviceid = ?",
-    $userid,
-    $device
-);
-
-print("Deleted the device with the deviceid: $deviceid\n");

kolab-syncroton-2.4.2.tar.gz/bin/inspect.php Deleted

@@ -1,343 +0,0 @@
-#!/usr/bin/env php
-<?php
-/*
- +--------------------------------------------------------------------------+
- | Kolab Sync (ActiveSync for Kolab)                                        |
- |                                                                          |
- | Copyright (C) 2024, Apheleia IT AG <contact@apheleia-it.ch>         |
- |                                                                          |
- | This program is free software: you can redistribute it and/or modify     |
- | it under the terms of the GNU Affero General Public License as published |
- | by the Free Software Foundation, either version 3 of the License, or     |
- | (at your option) any later version.                                      |
- |                                                                          |
- | This program is distributed in the hope that it will be useful,          |
- | but WITHOUT ANY WARRANTY; without even the implied warranty of           |
- | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the             |
- | GNU Affero General Public License for more details.                      |
- |                                                                          |
- | You should have received a copy of the GNU Affero General Public License |
- | along with this program. If not, see <http://www.gnu.org/licenses/>      |
- +--------------------------------------------------------------------------+
- | Author: Christian Mollekopf <mollekopf@apheleia-it.ch>                      |
- +--------------------------------------------------------------------------+
-*/
-
-
-define('RCUBE_INSTALL_PATH', realpath(dirname(__FILE__) . '/../') . '/');
-define('RCUBE_PLUGINS_DIR', RCUBE_INSTALL_PATH . 'lib/plugins/');
-
-// Define include path
-$include_path  = RCUBE_INSTALL_PATH . 'lib' . PATH_SEPARATOR;
-$include_path .= RCUBE_INSTALL_PATH . 'lib/ext' . PATH_SEPARATOR;
-$include_path .= ini_get('include_path');
-set_include_path($include_path);
-
-// include composer autoloader (if available)
-if (@file_exists(RCUBE_INSTALL_PATH . 'vendor/autoload.php')) {
-    require RCUBE_INSTALL_PATH . 'vendor/autoload.php';
-}
-
-// include global functions from Roundcube Framework
-require_once 'Roundcube/bootstrap.php';
-
-
-function filterTypeToIMAPSearch($filter_type = 0)
-{
-    switch ($filter_type) {
-        case 1:
-            $mod = '-1 day';
-            break;
-        case 2:
-            $mod = '-3 days';
-            break;
-        case 3:
-            $mod = '-1 week';
-            break;
-        case 4:
-            $mod = '-2 weeks';
-            break;
-        case 5:
-            $mod = '-1 month';
-            break;
-    }
-
-    if (!empty($mod)) {
-        $dt = new DateTime('now', new DateTimeZone('UTC'));
-        $dt->modify($mod);
-        // RFC3501: IMAP SEARCH
-        return 'SINCE ' . $dt->format('d-M-Y');
-    }
-
-    return "";
-}
-
-
-$opts = rcube_utils::get_opt(
-    'e' => 'email',
-    'p' => 'adminpassword',
-    'd' => 'debug',
-);
-
-if (empty($opts'email')) {
-    rcube::raise_error("Email address not specified (--email).", false, true);
-}
-$email = $opts'email';
-
-$proxyAuth = false;
-if ($password = $opts'adminpassword') {
-    $proxyAuth = true;
-    $user = "cyrus-admin";
-} else {
-    $password = $opts'password';
-}
-
-if (empty($password)) {
-    rcube::raise_error("Password not specified (--adminpassword/--password).", false, true);
-}
-
-$rcube = rcube::get_instance();
-$default_port = $rcube->config->get('default_port', 143);
-$default_host = $rcube->config->get('default_host');
-$imap = new \rcube_imap_generic();
-if ($proxyAuth) {
-    $options'auth_cid' = $user;
-    $options'auth_pw' = $password;
-}
-$options'auth_type' = 'PLAIN';
-$options'port' = $default_port;
-$options'socket_options' = 
-    'ssl' => 
-        'verify_peer_name' => false,
-        'verify_peer' => false,
-        'allow_self_signed' => true,
-    ,
-;
-
-ini_set('display_errors', 1);
-error_reporting(E_ALL);
-
-$debug = !empty($opts'debug');
-
-$imap->setDebug($debug);
-if (!$imap->connect($default_host, $email, $password, $options)) {
-    rcube::raise_error("Failed to connect to imap.", false, true);
-}
-
-$rcube = \rcube::get_instance();
-$db    = $rcube->get_dbh();
-
-$select = $db->query(
-    "SELECT `user_id` FROM `users`"
-    . " WHERE `username` = ?"
-    . " ORDER BY `user_id` DESC",
-    \strtolower($email)
-);
-
-if ($data = $db->fetch_assoc($select)) {
-    $userid = $data'user_id';
-} else {
-    rcube::raise_error("User not found in roundcube database (only available after first login): $email.", false, true);
-}
-
-print("Found the user with id: $userid\n");
-
-$devicesSelect = $db->query(
-    "SELECT `id`, `deviceid`, `devicetype` FROM `syncroton_device`"
-    . " WHERE `owner_id` = ?",
-    $userid
-);
-
-$result = ;
-while ($data = $db->fetch_assoc($devicesSelect)) {
-    $deviceid = $data"deviceid";
-    $device_id = $data"id";
-
-    $result$device_id'deviceid' = $deviceid;
-    $result$device_id'devicetype' = $data"devicetype";
-
-    $select = $db->limitquery(
-        "SELECT `counter`, `lastsync` FROM `syncroton_synckey`"
-        . " WHERE `device_id` = ? AND `type` = 'FolderSync'"
-        . " ORDER BY `counter` DESC",
-        0,
-        1,
-        $device_id
-    );
-
-    if ($data = $db->fetch_assoc($select)) {
-        $result$device_id'FolderSync' = 
-            "counter" => $data'counter',
-            "lastsync" => $data'lastsync',
-        ;
-    } else {
-        echo("Synckey not found.\n");
-    }
-
-    $folderSelect = $db->query(
-        "SELECT * FROM `syncroton_folder`"
-        . " WHERE `device_id` = ?",
-        $device_id
-    );
-
-    while ($folder = $db->fetch_assoc($folderSelect)) {
-        $select = $db->limitquery(
-            "SELECT `counter`, `lastsync`, `extra_data` FROM `syncroton_synckey`"
-            . " WHERE `device_id` = ? AND `type` = ?"
-            . " ORDER BY `counter` DESC",
-            0,
-            1,
-            $device_id,
-            $folder'id'
-        );
-
-        if ($data = $db->fetch_assoc($select)) {
-            $result$device_id'folders'$folder'id' = 
-                "counter" => $data'counter',
-                "lastsync" => $data'lastsync',
-                "modseq" => $data'extra_data' ? json_decode($data'extra_data')->modseq : null,
-            ;
-        }
-
-        $result$device_id'folders'$folder'id''name' = $folder'displayname';
-        $result$device_id'folders'$folder'id''class' = $folder'class';
-        $result$device_id'folders'$folder'id''lastfiltertype' = $folder'lastfiltertype' ?? null;
-
-        $imap->select($folder'displayname');
-        $result$device_id'folders'$folder'id''imapModseq' = $imap->data'HIGHESTMODSEQ' ?? null;
-
-        $index = $imap->search(
-            $folder'displayname',
-            'ALL UNDELETED ' . filterTypeToIMAPSearch($folder'lastfiltertype'),
-            false,
-            'COUNT'
-        );
-        if (!$index->is_error()) {
-            $result$device_id'folders'$folder'id''imapMessagecount' = $index->count();
-        }
-
-        $select = $db->query(
-            "SELECT count(*) FROM `syncroton_content`"
-            . " WHERE `device_id` = ? AND `folder_id` = ?",
-            $device_id,
-            $folder'id'
-        );
-
-        if ($data = $db->fetch_assoc($select)) {
-            $result$device_id'folders'$folder'id''contentCount' = array_values($data)0;
-        }
-    }
-}
-
-if ($debug) {
-    var_export($result);
-}
-
-function println($output)
-{
-    print("{$output}\n");
-}
-
-function filterType($value)
-{
-    if (!$value) {
-        return "No filter";
-    }
-    switch($value) {
-        case 0: return "No filter";
-        case 1: return "1 day";
-        case 2: return "3 days";
-        case 3: return "1 week";
-        case 4: return "2 weeks";
-        case 5: return "1 month";
-        case 6: return "3 months (WARNING: not implemented)";
-        case 7: return "6 months (WARNING: not implemented)";
-        case 8: return "Filter by incomplete tasks";
-    }
-    return "Unknown value: $value";
-}
-
-function getContentUids($db, $device_id, $folder_id)
-{
-    $contentSelect = $db->query(
-        "SELECT contentid FROM `syncroton_content`"
-        . " WHERE `device_id` = ? AND `folder_id` = ? AND `is_deleted` = 0",
-        $device_id,
-        $folder_id
-    );
-
-    $contentUids = ;
-    while ($content = $db->fetch_assoc($contentSelect)) {
-        $contentUids = explode('::', $content'contentid')1;
-    }
-    return $contentUids;
-}
-
-function getImapUids($imap, $folder, $lastfiltertype)
-{
-    $imap->select($folder);
-    $index = $imap->search($folder, 'ALL UNDELETED ' . filterTypeToIMAPSearch($lastfiltertype), true);
-    if (!$index->is_error()) {
-        return $index->get();
-    }
-    return ;
-}
-
-println("");
-foreach ($result  as $deviceId => $values) {
-    println("Device: $deviceId");
-    println("  Last folder sync: " . $values'FolderSync''lastsync');
-    println("  Folder sync count: " . $values'FolderSync''counter');
-    println("  Folders:");
-    foreach ($values'folders' ??  as $folderId => $folder) {
-        println("    " . $folder'name' . " ($folderId)");
-        $messageCount = $folder'contentCount';
-        $totalCount = $folder'imapMessagecount' ?? "unknown";
-        $modseq = $folder'modseq' ?? "none";
-        $imapModseq = $folder'imapModseq';
-        // We're not using modseq for groupware folders
-        if ($messageCount == $totalCount && ($modseq == "none" || $modseq == $imapModseq)) {
-            println("    Status: Fully Synced ($messageCount messages)");
-        } else {
-            println("    Status: Incomplete ($messageCount/$totalCount messages)");
-            println("    Modseq: " . $modseq . "/" . $imapModseq);
-        }
-        println("    Last sync: " . ($folder'lastsync' ?? "None"));
-        println("    Number of syncs: " . ($folder'counter' ?? "None"));
-        println("    Filter type: " . filterType($folder'lastfiltertype' ?? null));
-
-        if (($folder'class' == "Email") && ($folder'counter' ?? false) && $messageCount != $totalCount && ($modseq == "none" || $modseq == $imapModseq)) {
-            if (($folder'lastfiltertype' ?? false) && $messageCount > $totalCount) {
-                // This doesn't have to indicate an issue, since the timewindow of the filter wanders, so some messages that have been synchronized may no longer match the window.
-            } else {
-                println("    Issue Detected: The sync state seems to be inconsistent. The device should be fully synced, but the sync counts differ.");
-                println("    There are $messageCount ContentParts (should match number of messages on the device), but $totalCount messages in IMAP matching the filter.");
-
-                $contentUids = getContentUids($db, $deviceId, $folderId);
-                $imapUids = getImapUids($imap, $folder'name', $folder'lastfiltertype' ?? null);
-
-                $entries = array_diff($imapUids, $contentUids);
-                if (!empty($entries)) {
-                    println("       The following messages are on the server, but not the device:");
-                    foreach ($entries as $uid) {
-                        println("           $uid");
-                        //TODO get details from imap?
-                    }
-                }
-
-                $entries = array_diff($contentUids, $imapUids);
-                if (!empty($entries)) {
-                    println("       The following messages are on the device, but not the server:");
-                    foreach ($entries as $uid) {
-                        println("           $uid");
-                        //TODO get details from the content part?
-                        //TODO display creation_synckey?
-                    }
-                }
-                println("");
-            }
-        }
-
-        println("");
-    }
-}

kolab-syncroton-2.4.2.tar.gz/bin/resync.php Deleted

@@ -1,116 +0,0 @@
-#!/usr/bin/php
-<?php
-/*
- +--------------------------------------------------------------------------+
- | Kolab Sync (ActiveSync for Kolab)                                        |
- |                                                                          |
- | Copyright (C) 2024, Apheleia IT AG <contact@apheleia-it.ch>              |
- |                                                                          |
- | This program is free software: you can redistribute it and/or modify     |
- | it under the terms of the GNU Affero General Public License as published |
- | by the Free Software Foundation, either version 3 of the License, or     |
- | (at your option) any later version.                                      |
- |                                                                          |
- | This program is distributed in the hope that it will be useful,          |
- | but WITHOUT ANY WARRANTY; without even the implied warranty of           |
- | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the             |
- | GNU Affero General Public License for more details.                      |
- |                                                                          |
- | You should have received a copy of the GNU Affero General Public License |
- | along with this program. If not, see <http://www.gnu.org/licenses/>      |
- +--------------------------------------------------------------------------+
- | Author: Aleksander Machniak <machniak@apheleia-it.ch>                    |
- +--------------------------------------------------------------------------+
-*/
-
-define('RCUBE_INSTALL_PATH', realpath(dirname(__FILE__) . '/../') . '/');
-define('RCUBE_PLUGINS_DIR', RCUBE_INSTALL_PATH . 'lib/plugins/');
-
-// Define include path
-$include_path  = RCUBE_INSTALL_PATH . 'lib' . PATH_SEPARATOR;
-$include_path .= RCUBE_INSTALL_PATH . 'lib/ext' . PATH_SEPARATOR;
-$include_path .= ini_get('include_path');
-set_include_path($include_path);
-
-// include composer autoloader (if available)
-if (@file_exists(RCUBE_INSTALL_PATH . 'vendor/autoload.php')) {
-    require RCUBE_INSTALL_PATH . 'vendor/autoload.php';
-}
-
-// include global functions from Roundcube Framework
-require_once 'Roundcube/bootstrap.php';
-
-$opts = rcube_utils::get_opt(
-    'o' => 'owner',
-    'f' => 'folder',
-    'd' => 'deviceid',
-    't' => 'devicetype', // e.g. WindowsOutlook15 or iPhone
-);
-
-$rcube = \rcube::get_instance();
-$db    = $rcube->get_dbh();
-
-if (empty($opts'owner')) {
-    rcube::raise_error("Owner not specified (--owner).", false, true);
-}
-if (empty($opts'folder')) {
-    rcube::raise_error("Folder name not specified (--folder).", false, true);
-}
-
-$select = $db->query(
-    "SELECT `user_id` FROM `users` WHERE `username` = ? ORDER BY `user_id` DESC",
-    \strtolower($opts'owner')
-);
-
-if ($data = $db->fetch_assoc($select)) {
-    $userid = $data'user_id';
-} else {
-    rcube::raise_error("User not found in Roundcube database.", false, true);
-}
-
-$devices = ;
-if (!empty($opts'deviceid')) {
-    $select = $db->query(
-        "SELECT `id` FROM `syncroton_device` WHERE `owner_id` = ? AND `deviceid` = ?",
-        $userid,
-        $opts'deviceid'
-    );
-    while ($record = $db->fetch_assoc($select)) {
-        $devices = $record'id';
-    }
-} elseif (!empty($opts'devicetype')) {
-    $select = $db->query(
-        "SELECT `id` FROM `syncroton_device` WHERE `owner_id` = ? AND `devicetype` = ?",
-        $userid,
-        $opts'devicetype'
-    );
-    while ($record = $db->fetch_assoc($select)) {
-        $devices = $record'id';
-    }
-} else {
-    $select = $db->query("SELECT `id` FROM `syncroton_device` WHERE `owner_id` = ?", $userid);
-    while ($record = $db->fetch_assoc($select)) {
-        $devices = $record'id';
-    }
-}
-
-if (empty($devices)) {
-    rcube::raise_error("Device not found.", false, true);
-}
-
-// TODO: Support not only top-level folders
-
-$select = $db->query(
-    "SELECT `id`, `displayname`, `folderid` FROM `syncroton_folder`"
-    . " WHERE `device_id` IN (" . $db->array2list($devices) . ")"
-    . " AND `parentid` = '0' AND `displayname` = " . $db->quote($opts'folder')
-);
-
-while ($record = $db->fetch_assoc($select)) {
-    if (!empty($opts'dry-run')) {
-        print("DRY-RUN {$record'displayname'} ({$record'id'}:{$record'folderid'})\n");
-    } else {
-        $db->query("UPDATE `syncroton_folder` SET `resync` = 1 WHERE id = ?", $record'id');
-        print("{$record'displayname'} ({$record'id'}:{$record'folderid'})\n");
-    }
-}

kolab-syncroton-2.4.2.tar.gz/docs/SQL/mysql.initial.sql Changed

@@ -44,10 +44,8 @@
     `displayname` varchar(254) NOT NULL,
     `type` int(11) NOT NULL,
     `creation_time` datetime NOT NULL,
-    `creation_synckey` int(11) NOT NULL DEFAULT '0',
     `lastfiltertype` int(11) DEFAULT NULL,
     `supportedfields` longblob DEFAULT NULL,
-    `resync` tinyint(1) DEFAULT NULL,
     PRIMARY KEY (`id`),
     UNIQUE KEY `device_id--class--folderid` (`device_id`(40),`class`(40),`folderid`(40)),
     KEY `folderstates::device_id--devices::id` (`device_id`),
@@ -62,7 +60,6 @@
     `lastsync` datetime DEFAULT NULL,
     `pendingdata` longblob,
     `client_id_map` longblob DEFAULT NULL,
-    `extra_data` longblob DEFAULT NULL,
     PRIMARY KEY (`id`),
     UNIQUE KEY `device_id--type--counter` (`device_id`,`type`,`counter`),
     CONSTRAINT `syncroton_synckey::device_id--syncroton_device::id` FOREIGN KEY (`device_id`) REFERENCES `syncroton_device` (`id`) ON DELETE CASCADE ON UPDATE CASCADE
@@ -99,6 +96,16 @@
     PRIMARY KEY (`id`)
 ) /*!40000 ENGINE=INNODB */ /*!40101 CHARACTER SET utf8 COLLATE utf8_general_ci */;
 
+CREATE TABLE IF NOT EXISTS `syncroton_modseq` (
+    `device_id` varchar(40) NOT NULL,
+    `folder_id` varchar(40) NOT NULL,
+    `synctime` datetime NOT NULL,
+    `data` longblob,
+    PRIMARY KEY (`device_id`,`folder_id`,`synctime`),
+    KEY `syncroton_modseq::device_id` (`device_id`),
+    CONSTRAINT `syncroton_modseq::device_id--syncroton_device::id` FOREIGN KEY (`device_id`) REFERENCES `syncroton_device` (`id`) ON DELETE CASCADE ON UPDATE CASCADE
+) /*!40000 ENGINE=INNODB */ /*!40101 CHARACTER SET utf8 COLLATE utf8_general_ci */;
+
 CREATE TABLE IF NOT EXISTS `syncroton_relations_state` (
     `device_id` varchar(40) NOT NULL,
     `folder_id` varchar(40) NOT NULL,
@@ -117,4 +124,4 @@
  PRIMARY KEY(`name`)
 ) /*!40000 ENGINE=INNODB */ /*!40101 CHARACTER SET utf8 COLLATE utf8_general_ci */;
 
-INSERT INTO `system` (`name`, `value`) VALUES ('syncroton-version', '2024102300');
+INSERT INTO `system` (`name`, `value`) VALUES ('syncroton-version', '2023100500');

kolab-syncroton-2.4.2.tar.gz/docs/SQL/mysql/2024031100.sql Deleted

kolab-syncroton-2.4.2.tar.gz/docs/SQL/mysql/2024101700.sql Deleted

kolab-syncroton-2.4.2.tar.gz/docs/SQL/mysql/2024102300.sql Deleted

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Backend/ABackend.php Changed

@@ -19,22 +19,22 @@
 {
     /**
      * the database adapter
-     *
+     * 
      * @var Zend_Db_Adapter_Abstract
      */
     protected $_db;
-
+    
     protected $_tablePrefix;
-
+    
     protected $_tableName;
-
+    
     protected $_modelClassName;
-
+    
     protected $_modelInterfaceName;
-
+    
     /**
      * the constructor
-     *
+     * 
      * @param  Zend_Db_Adapter_Abstract  $_db
      * @param  string                    $_tablePrefix
      */
@@ -46,7 +46,7 @@
 
     /**
      * create new device
-     *
+     * 
      * @param Syncroton_Model_AEntry $model
      * @return Syncroton_Model_AEntry
      */
@@ -55,71 +55,70 @@
         if (! $model instanceof $this->_modelInterfaceName) {
             throw new InvalidArgumentException('$model must be instance of ' . $this->_modelInterfaceName);
         }
-
+        
         $data = $this->_convertModelToArray($model);
-
-        $data'id' = sha1(mt_rand() . microtime());
+        
+        $data'id' = sha1(mt_rand(). microtime());
 
         $this->_db->insert($this->_tablePrefix . $this->_tableName, $data);
-
+        
         return $this->get($data'id');
     }
-
+    
     /**
      * convert iteratable object to array
-     *
+     * 
      * @param  Syncroton_Model_AEntry   $model
      * @return array
      */
     protected function _convertModelToArray($model)
     {
-        $data = ;
-
+        $data = array();
+        
         foreach ($model as $key => $value) {
             if ($value instanceof DateTime) {
                 $value = $value->format('Y-m-d H:i:s');
             } elseif (is_object($value) && isset($value->id)) {
                 $value = $value->id;
             }
-
+        
             $data$this->_fromCamelCase($key) = $value;
         }
-
+        
         return $data;
     }
-
+    
     /**
-     * @param string $id
-     *
+     * @param string  $_id
      * @throws Syncroton_Exception_NotFound
-     * @return Syncroton_Model_AEntry
+     * @return Syncroton_Model_IDevice
      */
     public function get($id)
     {
         $id = $id instanceof $this->_modelInterfaceName ? $id->id : $id;
-
+        
         if (empty($id)) {
             throw new Syncroton_Exception_NotFound('id can not be empty');
         }
-
+        
         $select = $this->_db->select()
             ->from($this->_tablePrefix . $this->_tableName)
             ->where('id = ?', $id);
-
+            
         $stmt = $this->_db->query($select);
         $data = $stmt->fetch();
         $stmt = null; # see https://bugs.php.net/bug.php?id=44081
-
+        
         if ($data === false) {
             throw new Syncroton_Exception_NotFound('id not found');
         }
 
         return $this->_getObject($data);
     }
-
+    
     /**
      * convert array to object
-     *
+     * 
      * @param  array  $data
      * @return object
      */
@@ -127,30 +126,30 @@
     {
         foreach ($data as $key => $value) {
             unset($data$key);
-
+            
             if (!empty($value) && preg_match('/^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $value)) { # 2012-08-12 07:43:26
                 $value = new DateTime($value, new DateTimeZone('UTC'));
             }
-
+            
             $data$this->_toCamelCase($key, false) = $value;
         }
-
+        
         return new $this->_modelClassName($data);
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Backend_IBackend::delete()
      */
     public function delete($id)
     {
-        $id = $id instanceof $this->_modelInterfaceName ? $id->id : $id; // @phpstan-ignore-line
-
-        $result = $this->_db->delete($this->_tablePrefix . $this->_tableName, 'id = ?' => $id);
-
+        $id = $id instanceof $this->_modelInterfaceName ? $id->id : $id;
+        
+        $result = $this->_db->delete($this->_tablePrefix . $this->_tableName, array('id = ?' => $id));
+        
         return (bool) $result;
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Backend_IBackend::update()
@@ -160,14 +159,14 @@
         if (! $model instanceof $this->_modelInterfaceName) {
             throw new InvalidArgumentException('$model must be instanace of ' . $this->_modelInterfaceName);
         }
-
+        
         $data = $this->_convertModelToArray($model);
-
-        $this->_db->update($this->_tablePrefix . $this->_tableName, $data, 
-            'id = ?' => $model->id, // @phpstan-ignore-line
-        );
-
-        return $this->get($model->id); // @phpstan-ignore-line
+        
+        $this->_db->update($this->_tablePrefix . $this->_tableName, $data, array(
+            'id = ?' => $model->id
+        ));
+        
+        return $this->get($model->id);
     }
 
     /**
@@ -179,7 +178,7 @@
      */
     public function userAccounts($device)
     {
-        return ;
+        return array();
     }
 
     /**
@@ -190,13 +189,13 @@
     protected function _fromCamelCase($string)
     {
         $string = lcfirst($string);
-
+        
         return preg_replace_callback('/(A-Z)/', function ($string) {return '_' . strtolower($string0);}, $string);
     }
-
+    
     /**
      * convert from camel_case to camelCase
-     *
+     * 
      * @param  string $string
      * @param  bool   $ucFirst
      * @return string
@@ -206,7 +205,7 @@
         if ($ucFirst === true) {
             $string = ucfirst($string);
         }
-
+        
         return preg_replace_callback('/_(a-z)/', function ($string) {return strtoupper($string1);}, $string);
     }
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Backend/Content.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Backend/Device.php Changed

@@ -18,15 +18,15 @@
 class Syncroton_Backend_Device extends Syncroton_Backend_ABackend implements Syncroton_Backend_IDevice
 {
     protected $_tableName = 'device';
-
+    
     protected $_modelClassName = 'Syncroton_Model_Device';
-
+    
     protected $_modelInterfaceName = 'Syncroton_Model_IDevice';
-
+    
     /**
      * return device for this user
-     *
-     * @param  string  $ownerId
+     * 
+     * @param  string  $userId
      * @param  string  $deviceId
      * @throws Syncroton_Exception_NotFound
      * @return Syncroton_Model_Device
@@ -37,10 +37,10 @@
             ->from($this->_tablePrefix . $this->_tableName)
             ->where('owner_id = ?', $ownerId)
             ->where('deviceid = ?', $deviceId);
-
+        
         $stmt = $this->_db->query($select);
         $data = $stmt->fetch();
-
+        
         if ($data === false) {
             throw new Syncroton_Exception_NotFound('id not found');
         }
@@ -49,9 +49,9 @@
             unset($data$key);
             $data$this->_toCamelCase($key, false) = $value;
         }
-
+        
         $model = new $this->_modelClassName($data);
-
+        
         return $model;
     }
 
@@ -64,7 +64,7 @@
      */
     public function userAccounts($device)
     {
-        return ;
+        return array();
     }
 
     /**
@@ -72,7 +72,7 @@
      *
      * @param array $request Oof/Get request data
      *
-     * @return Syncroton_Model_Oof|null Response object or NULL if OOF is not supported
+     * @return Syncroton_Model_Oof Response object or NULL if OOF is not supported
      * @throws Syncroton_Exception_Status
      */
     public function getOOF($request)

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Backend/Folder.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Backend/IBackend.php Changed

@@ -20,32 +20,32 @@
     /**
      * Create a new device
      *
-     * @param  Syncroton_Model_IEntry $model
-     * @return Syncroton_Model_IEntry
+     * @param  Syncroton_Model_IDevice $device
+     * @return Syncroton_Model_IDevice
      */
     public function create($model);
-
+    
     /**
      * Deletes one or more existing devices
      *
-     * @param string|Syncroton_Model_IEntry $id
-     * @return bool
+     * @param string|array $_id
+     * @return void
      */
     public function delete($id);
-
+    
     /**
      * Return a single device
      *
-     * @param string $id
-     * @return Syncroton_Model_IEntry
+     * @param string $_id
+     * @return Syncroton_Model_IDevice
      */
     public function get($id);
-
+    
     /**
      * Upates an existing persistent record
      *
-     * @param  Syncroton_Model_IEntry $model
-     * @return Syncroton_Model_IEntry
+     * @param  Syncroton_Model_IDevice $_device
+     * @return Syncroton_Model_IDevice
      */
     public function update($model);
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Backend/IContent.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Backend/IFolder.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Backend/ISyncState.php Changed

@@ -19,6 +19,14 @@
 interface Syncroton_Backend_ISyncState extends Syncroton_Backend_IBackend
 {
     /**
+     * create new sync state
+     * 
+     * @param  Syncroton_Model_IDevice  $model
+     * @param  boolean                  $keepPreviousSyncState
+     */
+    #public function create($model, $keepPreviousSyncState = true);
+
+    /**
      * always returns the latest syncstate
      *
      * @param  Syncroton_Model_IDevice|string  $deviceId
@@ -27,18 +35,15 @@
      */
     public function getSyncState($deviceId, $folderId);
 
-    public function haveNext($deviceId, $folderId, $syncKey);
-
-    public function resetState($deviceId, $type);
+    public function resetState($_deviceId, $_type);
 
     /**
      * get array of ids which got send to the client for a given class
      *
-     * @param Syncroton_Model_IDevice|string $deviceId
-     * @param Syncroton_Model_IFolder|string $folderId
-     * @param int                            $syncKey
+     * @param Syncroton_Model_Device $_deviceId
+     * @param string $_class
      *
      * @return Syncroton_Model_SyncState|false
      */
-    public function validate($deviceId, $folderId, $syncKey);
+    public function validate($_deviceId, $_syncKey, $_type);
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Backend/Policy.php Changed

@@ -15,57 +15,57 @@
  * @package     Syncroton
  * @subpackage  Backend
  */
-class Syncroton_Backend_Policy extends Syncroton_Backend_ABackend
+class Syncroton_Backend_Policy extends Syncroton_Backend_ABackend #implements Syncroton_Backend_IDevice
 {
     protected $_tableName = 'policy';
-
+    
     protected $_modelClassName = 'Syncroton_Model_Policy';
-
+    
     protected $_modelInterfaceName = 'Syncroton_Model_IPolicy';
-
+    
     /**
      * convert iteratable object to array
-     *
-     * @param Syncroton_Model_IXMLEntry  $model
+     * 
+     * @param  unknown   $model
      * @return array
      */
     protected function _convertModelToArray($model)
     {
         $policyValues = $model->getProperties('Provision');
-
-        $policy = ;
-
+        
+        $policy = array();
+        
         foreach ($policyValues as $policyName) {
-            if ($model->$policyName !== null) {
+            if ($model->$policyName !== NULL) { 
                 $policy$policyName = $model->$policyName;
             }
-
+            
             unset($model->$policyName);
         }
 
         $data = parent::_convertModelToArray($model);
-
+        
         $data'json_policy' = Zend_Json::encode($policy);
-
+        
         return $data;
     }
-
+    
     /**
      * convert array to object
-     *
+     * 
      * @param  array  $data
      * @return object
      */
     protected function _getObject($data)
     {
         $policy = Zend_Json::decode($data'json_policy');
-
+        
         foreach ($policy as $policyKey => $policyValue) {
             $data$policyKey = $policyValue;
         }
-
+        
         unset($data'json_policy');
-
+        
         return parent::_getObject($data);
     }
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Backend/SyncState.php Changed

@@ -7,7 +7,7 @@
  * @license     http://www.tine20.org/licenses/lgpl.html LGPL Version 3
  * @author      Lars Kneschke <l.kneschke@metaways.de>
  * @copyright   Copyright (c) 2009-2012 Metaways Infosystems GmbH (http://www.metaways.de)
- *
+ * 
  */
 
 /**
@@ -18,12 +18,12 @@
  */
 class Syncroton_Backend_SyncState extends Syncroton_Backend_ABackend implements Syncroton_Backend_ISyncState
 {
-    protected $_tableName = 'synckey';
-
-    protected $_modelClassName = 'Syncroton_Model_SyncState';
-
-    protected $_modelInterfaceName = 'Syncroton_Model_ISyncState';
+    protected $_tableName = 'synckey';
+    
+    protected $_modelClassName = 'Syncroton_Model_SyncState';
 
+    protected $_modelInterfaceName = 'Syncroton_Model_ISyncState';
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Backend_ISyncState::create()
@@ -31,15 +31,15 @@
     public function create($model, $keepPreviousSyncState = true)
     {
         $state = parent::create($model);
-
+        
         if ($keepPreviousSyncState !== true) {
             // remove all other synckeys
             $this->_deleteOtherStates($state);
         }
-
+        
         return $state;
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Backend_ABackend::_convertModelToArray()
@@ -47,46 +47,46 @@
     protected function _convertModelToArray($model)
     {
         $model = parent::_convertModelToArray($model);
-
+        
         $model'pendingdata' = isset($model'pendingdata') && is_array($model'pendingdata') ? Zend_Json::encode($model'pendingdata') : null;
-
+        
         return $model;
     }
-
+    
     /**
-     *
+     * 
      * @param Syncroton_Model_ISyncState $state
      */
     protected function _deleteOtherStates(Syncroton_Model_ISyncState $state)
     {
         // remove all other synckeys
-        $where = 
+        $where = array(
             'device_id = ?' => $state->deviceId,
             'type = ?'      => $state->type,
-            'counter != ?'  => $state->counter,
-        ;
-
+            'counter != ?'  => $state->counter
+        );
+    
         $this->_db->delete($this->_tablePrefix . $this->_tableName, $where);
-
+    
         return true;
-
+    
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Backend_ABackend::_getObject()
      */
-    protected function _getObject($data)
+    protected function _getObject($data)
     {
         $model = parent::_getObject($data);
-
-        if ($model->pendingdata !== null) {
-            $model->pendingdata = Zend_Json::decode($model->pendingdata);
+        
+        if ($model->pendingdata !== NULL) {
+            $model->pendingdata = Zend_Json::decode($model->pendingdata);
         }
-
-        return $model;
+        
+        return $model;
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Backend_ISyncState::getSyncState()
@@ -95,25 +95,25 @@
     {
         $deviceId = $deviceId instanceof Syncroton_Model_IDevice ? $deviceId->id : $deviceId;
         $folderId = $folderId instanceof Syncroton_Model_IFolder ? $folderId->id : $folderId;
-
+    
         $select = $this->_db->select()
             ->from($this->_tablePrefix . $this->_tableName)
             ->where($this->_db->quoteIdentifier('device_id') . ' = ?', $deviceId)
-            ->where($this->_db->quoteIdentifier('type') . ' = ?', $folderId)
+            ->where($this->_db->quoteIdentifier('type')      . ' = ?', $folderId)
             ->order('counter DESC')
             ->limit(1);
-
-        $stmt = $this->_db->query($select);
+        
+        $stmt = $this->_db->query($select);
         $data = $stmt->fetch();
-        $stmt = null; # see https://bugs.php.net/bug.php?id=44081
-
-        if ($data === false) {
-            throw new Syncroton_Exception_NotFound('id not found');
-        }
-
+        $stmt = null; # see https://bugs.php.net/bug.php?id=44081
+        
+        if ($data === false) {
+            throw new Syncroton_Exception_NotFound('id not found');
+        }
+        
         return $this->_getObject($data);
     }
-
+    
     /**
      * delete all stored synckeys for given type
      *
@@ -124,21 +124,20 @@
     {
         $deviceId = $deviceId instanceof Syncroton_Model_IDevice ? $deviceId->id : $deviceId;
         $folderId = $folderId instanceof Syncroton_Model_IFolder ? $folderId->id : $folderId;
-
-        $where = 
+         
+        $where = array(
             $this->_db->quoteInto($this->_db->quoteIdentifier('device_id') . ' = ?', $deviceId),
-            $this->_db->quoteInto($this->_db->quoteIdentifier('type') . ' = ?', $folderId),
-        ;
-
+            $this->_db->quoteInto($this->_db->quoteIdentifier('type') . ' = ?',      $folderId)
+        );
+    
         $this->_db->delete($this->_tablePrefix . $this->_tableName, $where);
     }
-
+    
     /**
      * get array of ids which got send to the client for a given class
      *
-     * @param Syncroton_Model_IDevice|string $deviceId
-     * @param Syncroton_Model_IFolder|string $folderId
-     * @param int                            $syncKey
+     * @param  Syncroton_Model_IDevice|string  $deviceId
+     * @param  Syncroton_Model_IFolder|string  $folderId
      *
      * @return Syncroton_Model_SyncState|false
      */
@@ -146,70 +145,65 @@
     {
         $deviceId = $deviceId instanceof Syncroton_Model_IDevice ? $deviceId->id : $deviceId;
         $folderId = $folderId instanceof Syncroton_Model_IFolder ? $folderId->id : $folderId;
-
+        
         $select = $this->_db->select()
             ->from($this->_tablePrefix . $this->_tableName)
             ->where($this->_db->quoteIdentifier('device_id') . ' = ?', $deviceId)
-            ->where($this->_db->quoteIdentifier('counter') . ' = ?', $syncKey)
-            ->where($this->_db->quoteIdentifier('type') . ' = ?', $folderId);
-
+            ->where($this->_db->quoteIdentifier('counter')   . ' = ?', $syncKey)
+            ->where($this->_db->quoteIdentifier('type')      . ' = ?', $folderId);
+        
         $stmt = $this->_db->query($select);
         $data = $stmt->fetch();
         $stmt = null; # see https://bugs.php.net/bug.php?id=44081
-
+        
         if ($data === false) {
             return false;
         }
 
         $state = $this->_getObject($data);
-
+        
         // check if this was the latest syncKey
         $select = $this->_db->select()
             ->from($this->_tablePrefix . $this->_tableName)
             ->where($this->_db->quoteIdentifier('device_id') . ' = ?', $deviceId)
-            ->where($this->_db->quoteIdentifier('counter') . ' = ?', $syncKey + 1)
-            ->where($this->_db->quoteIdentifier('type') . ' = ?', $folderId);
-
+            ->where($this->_db->quoteIdentifier('counter')   . ' = ?', $syncKey + 1)
+            ->where($this->_db->quoteIdentifier('type')      . ' = ?', $folderId);
+        
         $stmt = $this->_db->query($select);
         $moreRecentStateData = $stmt->fetch();
         $stmt = null; # see https://bugs.php.net/bug.php?id=44081
-
+        
         // found more recent synckey => the last sync repsone got not received by the client
         if ($moreRecentStateData !== false) {
             // undelete entries marked as deleted in Syncroton_content table
-            $this->_db->update($this->_tablePrefix . 'content', 
+            $this->_db->update($this->_tablePrefix . 'content', array(
                 'is_deleted'  => 0,
-            , 
+            ), array(
                 'device_id = ?'        => $deviceId,
                 'folder_id = ?'        => $folderId,
                 'creation_synckey = ?' => $state->counter,
-                'is_deleted = ?'       => 1,
-            );
-
+                'is_deleted = ?'       => 1
+            ));
+            
         } else {
-            // finally delete all entries marked for removal in Syncroton_content table
-            $this->_db->delete($this->_tablePrefix . 'content', 
+            // finally delete all entries marked for removal in Syncroton_content table    
+            $this->_db->delete($this->_tablePrefix . 'content', array(
                 'device_id = ?'  => $deviceId,
                 'folder_id = ?'  => $folderId,
-                'is_deleted = ?' => 1,
-            );
+                'is_deleted = ?' => 1
+            ));
         }
-
+        
         // remove all other synckeys
         $this->_deleteOtherStates($state);
-
+        
         // remove entries from Syncroton_content table with an creation_synckey bigger than current one
-        $this->_db->delete($this->_tablePrefix . 'content', 
+        $this->_db->delete($this->_tablePrefix . 'content', array(
             'device_id = ?'        => $deviceId,
             'folder_id = ?'        => $folderId,
             'creation_synckey > ?' => $state->counter,
-        );
-
+        ));
+        
         return $state;
     }
-
-    public function haveNext($deviceid, $folderid, $sync_key)
-    {
-        return false; // not implemented
-    }
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/AutoDiscover.php Changed

@@ -15,7 +15,7 @@
  * @package     Syncroton
  * @subpackage  Command
  */
-class Syncroton_Command_AutoDiscover extends Syncroton_Command_Wbxml
+class Syncroton_Command_AutoDiscover implements Syncroton_Command_ICommand
 {
     /**
      * the domDocucment containing the xml request from the client
@@ -23,105 +23,104 @@
      * @var DOMDocument
      */
     protected $requestBody;
-
+    
     protected $emailAddress;
-
-    public $mobileSyncUrl;
-
-    public $certEnrollUrl;
-
+    
+    public    $mobileSyncUrl;
+    
+    public    $certEnrollUrl;
+    
     /**
      * constructor of this class
-     *
-     * @param DOMDocument             $requestBody
-     * @param Syncroton_Model_IDevice $device
-     * @param array                   $requestParams
+     * 
+     * @param DOMDocument              $_requestBody
+     * @param Syncroton_Model_IDevice  $_device
+     * @param string                   $_policyKey
      */
-    // @phpstan-ignore-next-line
-    public function __construct($requestBody, Syncroton_Model_IDevice $device, $requestParams = )
+    public function __construct($requestBody, Syncroton_Model_IDevice $device = null, $policyKey = null)
     {
         $this->requestBody = $requestBody;
     }
-
+    
     /**
-     * process the incoming data
+     * process the incoming data 
      */
     public function handle()
     {
         $xpath = new DomXPath($this->requestBody);
         $xpath->registerNamespace('2006', 'http://schemas.microsoft.com/exchange/autodiscover/mobilesync/requestschema/2006');
-
+        
         $nodes = $xpath->query('//2006:Autodiscover/2006:Request/2006:EMailAddress');
         if ($nodes->length === 0) {
             throw new Syncroton_Exception();
         }
-
+        
         $this->emailAddress = $nodes->item(0)->nodeValue;
     }
-
+    
     /**
      * create the response
-     *
+     * 
      * @return DOMDocument
      */
     public function getResponse()
     {
         // Creates an instance of the DOMImplementation class
         $imp = new DOMImplementation();
-
+        
         // Creates a DOMDocument instance
         $document = $imp->createDocument("http://schemas.microsoft.com/exchange/autodiscover/mobilesync/requestschema/2006", 'Autodiscover');
         $document->xmlVersion   = '1.0';
         $document->encoding     = 'UTF-8';
         $document->formatOutput = false;
-
+        
         $response = $document->documentElement->appendChild($document->createElement('Response'));
-
+        
         $user = $response->appendChild($document->createElement('User'));
         $user->appendChild($document->createElement('EMailAddress', $this->emailAddress));
-
+        
         $settings = $document->createElement('Settings');
-
+        
         if (!empty($this->mobileSyncUrl)) {
             $server   = $document->createElement('Server');
-
+            
             $server->appendChild($document->createElement('Type', 'MobileSync'));
-
-            $server->appendChild($document->createElement('Url', $this->mobileSyncUrl));
+            
+            $server->appendChild($document->createElement('Url',  $this->mobileSyncUrl));
             $server->appendChild($document->createElement('Name', $this->mobileSyncUrl));
-
+            
             $settings->appendChild($server);
         }
-
+        
         if (!empty($this->certEnrollUrl)) {
             $server   = $document->createElement('Server');
-
+            
             $server->appendChild($document->createElement('Type', 'CertEnroll'));
-
-            $server->appendChild($document->createElement('Url', $this->certEnrollUrl));
+            
+            $server->appendChild($document->createElement('Url',  $this->certEnrollUrl));
             $server->appendChild($document->createElement('Name'));
             $server->appendChild($document->createElement('ServerData', 'CertEnrollTemplate'));
-
+            
             $settings->appendChild($server);
         }
-
+        
         if ($settings->hasChildNodes()) {
             $action   = $response->appendChild($document->createElement('Action'));
             $action->appendChild($settings);
         }
-
+        
         return $document;
     }
-
+    
     /**
      * return headers of command
-     *
+     * 
      * @return array list of headers
      */
     public function getHeaders()
     {
-        return 
-            'Content-Type'  => 'text/xml;charset=utf-8',
-        ;
+        return array(
+            'Content-Type'  => 'text/xml;charset=utf-8'
+        );
     }
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/FolderCreate.php Changed

@@ -19,9 +19,9 @@
 {
     protected $_defaultNameSpace    = 'uri:FolderHierarchy';
     protected $_documentElement     = 'FolderCreate';
-
+    
     /**
-     * @var Syncroton_Model_IFolder
+     * @var Syncroton_Model_Folder
      */
     protected $_folder;
 
@@ -29,49 +29,46 @@
      * @var int
      */
     protected $_status;
-
+    
     /**
      * parse FolderCreate request
      */
     public function handle()
     {
         $xml = simplexml_import_dom($this->_requestBody);
-
+        
         $syncKey = (int)$xml->SyncKey;
 
-        if ($this->_logger instanceof Zend_Log) {
+        if ($this->_logger instanceof Zend_Log) 
             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " synckey is $syncKey");
-        }
-
+        
         if (!($this->_syncState = $this->_syncStateBackend->validate($this->_device, 'FolderSync', $syncKey)) instanceof Syncroton_Model_SyncState) {
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log) 
                 $this->_logger->info(__METHOD__ . '::' . __LINE__ . " invalid synckey provided. FolderSync 0 needed.");
-            }
 
             $this->_status = Syncroton_Command_FolderSync::STATUS_INVALID_SYNC_KEY;
             return;
         }
-
+        
         $folder = new Syncroton_Model_Folder($xml);
-
-        if ($this->_logger instanceof Zend_Log) {
+        
+        if ($this->_logger instanceof Zend_Log)
             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " parentId: {$folder->parentId} displayName: {$folder->displayName}");
-        }
 
         if (!strlen($folder->displayName)) {
             $this->_status = Syncroton_Command_FolderSync::STATUS_MISFORMATTED;
             return;
         }
-
+        
         switch($folder->type) {
             case Syncroton_Command_FolderSync::FOLDERTYPE_CALENDAR_USER_CREATED:
                 $folder->class = Syncroton_Data_Factory::CLASS_CALENDAR;
                 break;
-
+                
             case Syncroton_Command_FolderSync::FOLDERTYPE_CONTACT_USER_CREATED:
                 $folder->class = Syncroton_Data_Factory::CLASS_CONTACTS;
                 break;
-
+                
             case Syncroton_Command_FolderSync::FOLDERTYPE_MAIL_USER_CREATED:
                 $folder->class = Syncroton_Data_Factory::CLASS_EMAIL;
                 break;
@@ -79,11 +76,11 @@
             case Syncroton_Command_FolderSync::FOLDERTYPE_NOTE_USER_CREATED:
                 $folder->class = Syncroton_Data_Factory::CLASS_NOTES;
                 break;
-
+                
             case Syncroton_Command_FolderSync::FOLDERTYPE_TASK_USER_CREATED:
                 $folder->class = Syncroton_Data_Factory::CLASS_TASKS;
                 break;
-
+                
             default:
                 // unsupported type
                 return;
@@ -98,66 +95,61 @@
                 $this->_status = Syncroton_Command_FolderSync::STATUS_UNKNOWN_ERROR;
             } else {
                 $this->_folder->class        = $folder->class;
-                $this->_folder->deviceId     = $this->_device->id;
+                $this->_folder->deviceId     = $this->_device;
                 $this->_folder->creationTime = $this->_syncTimeStamp;
-                $this->_folder->creationSynckey = $this->_syncState->counter;
 
                 // Check if the folder already exists to avoid a duplicate insert attempt in db
                 try {
                     $this->_folderBackend->getFolder($this->_device, $this->_folder->serverId);
 
-                    if ($this->_logger instanceof Zend_Log) {
+                    if ($this->_logger instanceof Zend_Log)
                         $this->_logger->info(__METHOD__ . '::' . __LINE__ . " Attempted to create a folder that already exists. parentId: {$folder->parentId} displayName: {$folder->displayName}");
-                    }
 
                     // The folder already exists
                     $this->_status = Syncroton_Command_FolderSync::STATUS_FOLDER_EXISTS;
                 } catch (Syncroton_Exception_NotFound $e) {
                     // This is the normal case
-                    if ($this->_logger instanceof Zend_Log) {
+                    if ($this->_logger instanceof Zend_Log)
                         $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " " . $e->getMessage());
-                    }
 
                     $this->_folderBackend->create($this->_folder);
                 }
             }
         } catch (Syncroton_Exception_Status $e) {
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log)
                 $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " " . $e->getMessage());
-            }
 
             $this->_status = $e->getCode();
         } catch (Exception $e) {
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log)
                 $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " " . $e->getMessage());
-            }
 
             $this->_status = Syncroton_Command_FolderSync::STATUS_UNKNOWN_ERROR;
         }
     }
-
+    
     /**
      * generate FolderCreate response
      */
     public function getResponse()
     {
         $folderCreate = $this->_outputDom->documentElement;
-
+        
         if ($this->_status) {
             $folderCreate->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Status', $this->_status));
         } else {
             $this->_syncState->counter++;
             $this->_syncState->lastsync = $this->_syncTimeStamp;
-
+            
             // store folder in state backend
             $this->_syncStateBackend->update($this->_syncState);
-
+            
             // create xml output
-            $folderCreate->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Status', Syncroton_Command_FolderSync::STATUS_SUCCESS));
-            $folderCreate->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'SyncKey', $this->_syncState->counter));
+            $folderCreate->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Status',   Syncroton_Command_FolderSync::STATUS_SUCCESS));
+            $folderCreate->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'SyncKey',  $this->_syncState->counter));
             $folderCreate->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'ServerId', $this->_folder->serverId));
         }
-
+        
         return $this->_outputDom;
     }
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/FolderDelete.php Changed

@@ -15,57 +15,55 @@
  * @package     Syncroton
  * @subpackage  Command
  */
-class Syncroton_Command_FolderDelete extends Syncroton_Command_Wbxml
-{
+class Syncroton_Command_FolderDelete extends Syncroton_Command_Wbxml 
+{        
     protected $_defaultNameSpace    = 'uri:FolderHierarchy';
     protected $_documentElement     = 'FolderDelete';
-
+    
     /**
-     * @var Syncroton_Model_IFolder
+     * @var Syncroton_Model_SyncState
      */
     protected $_folder;
-
+    
     /**
      * parse FolderDelete request
      */
     public function handle()
     {
         $xml = simplexml_import_dom($this->_requestBody);
-
+        
         // parse xml request
         $syncKey  = (int)$xml->SyncKey;
-        $serverId = (string)$xml->ServerId;
-
-        if ($this->_logger instanceof Zend_Log) {
+        $serverId = (string)$xml->ServerId;
+        
+        if ($this->_logger instanceof Zend_Log) 
             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " synckey is $syncKey");
-        }
-
+        
         if (!($this->_syncState = $this->_syncStateBackend->validate($this->_device, 'FolderSync', $syncKey)) instanceof Syncroton_Model_SyncState) {
-            return;
+            return;
         }
-
+        
         try {
             $folder = $this->_folderBackend->getFolder($this->_device, $serverId);
-
+            
             $dataController = Syncroton_Data_Factory::factory($folder->class, $this->_device, $this->_syncTimeStamp);
-
+            
             // delete folder in data backend
             $dataController->deleteFolder($folder);
-
+            
         } catch (Syncroton_Exception_NotFound $senf) {
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log)
                 $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " " . $senf->getMessage());
-            }
-
+            
             return;
         }
-
+        
         // delete folder in syncState backend
         $this->_folderBackend->delete($folder);
-
+        
         $this->_folder = $folder;
     }
-
+    
     /**
      * generate FolderDelete response
      *
@@ -74,28 +72,27 @@
     public function getResponse()
     {
         $folderDelete = $this->_outputDom->documentElement;
-
+        
         if (!$this->_syncState instanceof Syncroton_Model_SyncState) {
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log)
                 $this->_logger->info(__METHOD__ . '::' . __LINE__ . " invalid synckey provided. FolderSync 0 needed.");
-            }
             $folderDelete->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Status', Syncroton_Command_FolderSync::STATUS_INVALID_SYNC_KEY));
-
+            
         } elseif (!$this->_folder instanceof Syncroton_Model_IFolder) {
             $folderDelete->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Status', Syncroton_Command_FolderSync::STATUS_FOLDER_NOT_FOUND));
-
+            
         } else {
             $this->_syncState->counter++;
             $this->_syncState->lastsync = $this->_syncTimeStamp;
-
+            
             // store folder in state backend
             $this->_syncStateBackend->update($this->_syncState);
-
+            
             // create xml output
             $folderDelete->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Status', Syncroton_Command_FolderSync::STATUS_SUCCESS));
             $folderDelete->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'SyncKey', $this->_syncState->counter));
         }
-
+        
         return $this->_outputDom;
     }
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/FolderSync.php Changed

@@ -15,52 +15,52 @@
  * @package     Syncroton
  * @subpackage  Command
  */
-class Syncroton_Command_FolderSync extends Syncroton_Command_Wbxml
+class Syncroton_Command_FolderSync extends Syncroton_Command_Wbxml 
 {
-    public const STATUS_SUCCESS                = 1;
-    public const STATUS_FOLDER_EXISTS          = 2;
-    public const STATUS_IS_SPECIAL_FOLDER      = 3;
-    public const STATUS_FOLDER_NOT_FOUND       = 4;
-    public const STATUS_PARENT_FOLDER_NOT_FOUND = 5;
-    public const STATUS_SERVER_ERROR           = 6;
-    public const STATUS_ACCESS_DENIED          = 7;
-    public const STATUS_REQUEST_TIMED_OUT      = 8;
-    public const STATUS_INVALID_SYNC_KEY       = 9;
-    public const STATUS_MISFORMATTED           = 10;
-    public const STATUS_UNKNOWN_ERROR          = 11;
+    const STATUS_SUCCESS                = 1;
+    const STATUS_FOLDER_EXISTS          = 2;
+    const STATUS_IS_SPECIAL_FOLDER      = 3;
+    const STATUS_FOLDER_NOT_FOUND       = 4;
+    const STATUS_PARENT_FOLDER_NOT_FOUND = 5;
+    const STATUS_SERVER_ERROR           = 6;
+    const STATUS_ACCESS_DENIED          = 7;
+    const STATUS_REQUEST_TIMED_OUT      = 8;
+    const STATUS_INVALID_SYNC_KEY       = 9;
+    const STATUS_MISFORMATTED           = 10;
+    const STATUS_UNKNOWN_ERROR          = 11;
 
     /**
      * some usefull constants for working with the xml files
      */
-    public const FOLDERTYPE_GENERIC_USER_CREATED   = 1;
-    public const FOLDERTYPE_INBOX                  = 2;
-    public const FOLDERTYPE_DRAFTS                 = 3;
-    public const FOLDERTYPE_DELETEDITEMS           = 4;
-    public const FOLDERTYPE_SENTMAIL               = 5;
-    public const FOLDERTYPE_OUTBOX                 = 6;
-    public const FOLDERTYPE_TASK                   = 7;
-    public const FOLDERTYPE_CALENDAR               = 8;
-    public const FOLDERTYPE_CONTACT                = 9;
-    public const FOLDERTYPE_NOTE                   = 10;
-    public const FOLDERTYPE_JOURNAL                = 11;
-    public const FOLDERTYPE_MAIL_USER_CREATED      = 12;
-    public const FOLDERTYPE_CALENDAR_USER_CREATED  = 13;
-    public const FOLDERTYPE_CONTACT_USER_CREATED   = 14;
-    public const FOLDERTYPE_TASK_USER_CREATED      = 15;
-    public const FOLDERTYPE_JOURNAL_USER_CREATED   = 16;
-    public const FOLDERTYPE_NOTE_USER_CREATED      = 17;
-    public const FOLDERTYPE_UNKOWN                 = 18;
-
+    const FOLDERTYPE_GENERIC_USER_CREATED   = 1;
+    const FOLDERTYPE_INBOX                  = 2;
+    const FOLDERTYPE_DRAFTS                 = 3;
+    const FOLDERTYPE_DELETEDITEMS           = 4;
+    const FOLDERTYPE_SENTMAIL               = 5;
+    const FOLDERTYPE_OUTBOX                 = 6;
+    const FOLDERTYPE_TASK                   = 7;
+    const FOLDERTYPE_CALENDAR               = 8;
+    const FOLDERTYPE_CONTACT                = 9;
+    const FOLDERTYPE_NOTE                   = 10;
+    const FOLDERTYPE_JOURNAL                = 11;
+    const FOLDERTYPE_MAIL_USER_CREATED      = 12;
+    const FOLDERTYPE_CALENDAR_USER_CREATED  = 13;
+    const FOLDERTYPE_CONTACT_USER_CREATED   = 14;
+    const FOLDERTYPE_TASK_USER_CREATED      = 15;
+    const FOLDERTYPE_JOURNAL_USER_CREATED   = 16;
+    const FOLDERTYPE_NOTE_USER_CREATED      = 17;
+    const FOLDERTYPE_UNKOWN                 = 18;
+    
     protected $_defaultNameSpace    = 'uri:FolderHierarchy';
     protected $_documentElement     = 'FolderSync';
-
-    protected $_classes             = 
+    
+    protected $_classes             = array(
         Syncroton_Data_Factory::CLASS_CALENDAR,
         Syncroton_Data_Factory::CLASS_CONTACTS,
         Syncroton_Data_Factory::CLASS_EMAIL,
         Syncroton_Data_Factory::CLASS_NOTES,
-        Syncroton_Data_Factory::CLASS_TASKS,
-    ;
+        Syncroton_Data_Factory::CLASS_TASKS
+    );
 
     /**
      * @var string
@@ -74,47 +74,42 @@
     {
         $xml = simplexml_import_dom($this->_requestBody);
         $syncKey = (int)$xml->SyncKey;
-
-        if ($this->_logger instanceof Zend_Log) {
+        
+        if ($this->_logger instanceof Zend_Log) 
             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " synckey is $syncKey");
-        }
-
+        
         if ($syncKey === 0) {
-            $this->_syncState = new Syncroton_Model_SyncState(
+            $this->_syncState = new Syncroton_Model_SyncState(array(
                 'device_id' => $this->_device,
                 'counter'   => 0,
                 'type'      => 'FolderSync',
-                'lastsync'  => $this->_syncTimeStamp,
-            );
-
+                'lastsync'  => $this->_syncTimeStamp
+            ));
+            
             // reset state of foldersync
             $this->_syncStateBackend->resetState($this->_device, 'FolderSync');
-
+            
             return;
-        }
-
+        } 
+        
         if (!($this->_syncState = $this->_syncStateBackend->validate($this->_device, 'FolderSync', $syncKey)) instanceof Syncroton_Model_SyncState) {
-            if ($this->_logger instanceof Zend_Log) {
-                $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " invalidating sync state");
-            }
             $this->_syncStateBackend->resetState($this->_device, 'FolderSync');
         }
     }
-
+    
     /**
      * generate FolderSync response
-     *
+     * 
      * @todo changes are missing in response (folder got renamed for example)
      */
     public function getResponse()
     {
         $folderSync = $this->_outputDom->documentElement;
-
+        
         // invalid synckey provided
         if (!$this->_syncState instanceof Syncroton_Model_SyncState) {
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log) 
                 $this->_logger->info(__METHOD__ . '::' . __LINE__ . " invalid synckey provided. FolderSync 0 needed.");
-            }
             $folderSync->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Status', self::STATUS_INVALID_SYNC_KEY));
 
             return $this->_outputDom;
@@ -125,46 +120,43 @@
             $optionsCommand = new Syncroton_Command_Options();
             $this->_headers = array_merge($this->_headers, $optionsCommand->getHeaders());
         }
-
-        $adds    = ;
-        $updates = ;
-        $deletes = ;
+        
+        $adds    = array();
+        $updates = array();
+        $deletes = array();
 
         foreach($this->_classes as $class) {
             try {
                 $dataController = Syncroton_Data_Factory::factory($class, $this->_device, $this->_syncTimeStamp);
             } catch (Exception $e) {
                 // backend not defined
-                if ($this->_logger instanceof Zend_Log) {
+                if ($this->_logger instanceof Zend_Log)
                     $this->_logger->info(__METHOD__ . '::' . __LINE__ . " no data backend defined for class: " . $class);
-                }
                 continue;
             }
 
             try {
                 // retrieve all folders available in data backend
                 $serverFolders = $dataController->getAllFolders();
-
+                
                 // retrieve all folders sent to client
-                $clientFolders = $this->_folderBackend->getFolderState($this->_device, $class, $this->_syncState->counter);
-
+                $clientFolders = $this->_folderBackend->getFolderState($this->_device, $class);
+                
                 if ($this->_syncState->counter > 0) {
                     // retrieve all folders changed since last sync
                     $changedFolders = $dataController->getChangedFolders($this->_syncState->lastsync, $this->_syncTimeStamp);
                 } else {
-                    $changedFolders = ;
+                    $changedFolders = array();
                 }
-
+                
                 // only folders which were sent to the client already are allowed to be in $changedFolders
                 $changedFolders = array_intersect_key($changedFolders, $clientFolders);
-
+                
             } catch (Exception $e) {
-                if ($this->_logger instanceof Zend_Log) {
+                if ($this->_logger instanceof Zend_Log)
                     $this->_logger->crit(__METHOD__ . '::' . __LINE__ . " Syncing folder hierarchy failed: " . $e->getMessage());
-                }
-                if ($this->_logger instanceof Zend_Log) {
+                if ($this->_logger instanceof Zend_Log)
                     $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " Syncing folder hierarchy failed: " . $e->getTraceAsString());
-                }
 
                 // The Status element is global for all collections. If one collection fails,
                 // a failure status MUST be returned for all collections.
@@ -183,7 +175,7 @@
 
             // is this the first sync?
             if ($this->_syncState->counter == 0) {
-                $clientFoldersIds = ;
+                $clientFoldersIds = array();
             } else {
                 $clientFoldersIds = array_keys($clientFolders);
             }
@@ -197,8 +189,7 @@
                 } else {
                     $add = $serverFolders$serverFolderId;
                     $add->creationTime = $this->_syncTimeStamp;
-                    $add->creationSynckey = $this->_syncState->counter + 1;
-                    $add->deviceId     = $this->_device->id;
+                    $add->deviceId     = $this->_device;
                     unset($add->id);
                 }
                 $add->class = $class;
@@ -209,11 +200,11 @@
             // calculate changed entries
             foreach ($changedFolders as $changedFolder) {
                 $change = $clientFolders$changedFolder->serverId;
-
+                
                 $change->displayName = $changedFolder->displayName;
                 $change->parentId    = $changedFolder->parentId;
                 $change->type        = $changedFolder->type;
-
+                
                 $updates = $change;
             }
 
@@ -238,12 +229,6 @@
                 }
             }
 
-            // Handle folders set for forced re-sync, we'll send a delete action to the client,
-            // but because the folder is still existing and subscribed on the backend it should
-            // "immediately" be added again (and re-synced).
-            $forceDeleteIds = array_keys(array_filter($clientFolders, function ($f) { return !empty($f->resync); }));
-            $serverFoldersIds = array_diff($serverFoldersIds, $forceDeleteIds);
-
             // calculate deleted entries
             $serverDiff = array_diff($clientFoldersIds, $serverFoldersIds);
             foreach ($serverDiff as $serverFolderId) {
@@ -258,50 +243,45 @@
             $this->_syncState->counter++;
             $this->_syncState->lastsync = $this->_syncTimeStamp;
         }
-
+        
         // create xml output
         $folderSync->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'SyncKey', $this->_syncState->counter));
-
-        $changes = $folderSync->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Changes'));
+        
+        $changes = $folderSync->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Changes'));            
         $changes->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Count', $count));
-
+        
         foreach($adds as $folder) {
             $add = $changes->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Add'));
-
+            
             $folder->appendXML($add, $this->_device);
 
             // store folder in backend
             if (empty($folder->id)) {
-                try {
-                    $this->_folderBackend->create($folder);
-                } catch(Exception $zdse) {
-                    //This can happen if we rerun a previous sync-key
-                    $this->_folderBackend->update($folder);
-                }
+                $this->_folderBackend->create($folder);
             }
         }
-
+        
         foreach($updates as $folder) {
             $update = $changes->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Update'));
-
+            
             $folder->appendXML($update, $this->_device);
-
+            
             $this->_folderBackend->update($folder);
         }
-
+        
         foreach($deletes as $folder) {
             $delete = $changes->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Delete'));
             $delete->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'ServerId', $folder->serverId));
-
+            
             $this->_folderBackend->delete($folder);
         }
-
-        // Only create this syncstate if it isn't already existing (which happens if we a sync key is re-sent)
-        if (!$this->_syncStateBackend->haveNext($this->_device, 'FolderSync', $this->_syncState->counter - 1)) {
-            // Keep previous sync states in case a sync key is re-sent
-            $this->_syncStateBackend->create($this->_syncState, true);
+        
+        if (empty($this->_syncState->id)) {
+            $this->_syncStateBackend->create($this->_syncState);
+        } else {
+            $this->_syncStateBackend->update($this->_syncState);
         }
-
+        
         return $this->_outputDom;
-    }
+    }    
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/FolderUpdate.php Changed

@@ -15,22 +15,22 @@
  * @package     Syncroton
  * @subpackage  Command
  */
-class Syncroton_Command_FolderUpdate extends Syncroton_Command_Wbxml
-{
+class Syncroton_Command_FolderUpdate extends Syncroton_Command_Wbxml 
+{        
     protected $_defaultNameSpace    = 'uri:FolderHierarchy';
     protected $_documentElement     = 'FolderUpdate';
-
+    
     /**
-     * @var Syncroton_Model_IFolder
+     * @var Syncroton_Model_SyncState
      */
     protected $_folder;
-
+    
     /**
-     *
+     * 
      * @var Syncroton_Model_Folder
      */
     protected $_folderUpdate;
-
+    
     /**
      * parse FolderUpdate request
      *
@@ -38,76 +38,72 @@
     public function handle()
     {
         $xml = simplexml_import_dom($this->_requestBody);
-
+        
         $syncKey = (int)$xml->SyncKey;
-
-        if ($this->_logger instanceof Zend_Log) {
+        
+        if ($this->_logger instanceof Zend_Log) 
             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " synckey is $syncKey");
-        }
 
         if (!($this->_syncState = $this->_syncStateBackend->validate($this->_device, 'FolderSync', $syncKey)) instanceof Syncroton_Model_SyncState) {
             return;
         }
-
+        
         $updatedFolder = new Syncroton_Model_Folder($xml);
-
-        if ($this->_logger instanceof Zend_Log) {
-            $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " parentId: {$updatedFolder->parentId} displayName: {$updatedFolder->displayName}");
-        }
-
+        
+        if ($this->_logger instanceof Zend_Log)
+            $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " parentId: {$updatedFolder->parentId} displayName: {$updatedFolder->displayName}");
+        
         try {
             $folder = $this->_folderBackend->getFolder($this->_device, $updatedFolder->serverId);
-
+            
             $folder->displayName = $updatedFolder->displayName;
             $folder->parentId    = $updatedFolder->parentId;
-
+            
             $dataController = Syncroton_Data_Factory::factory($folder->class, $this->_device, $this->_syncTimeStamp);
-
+            
             // update folder in data backend
             $dataController->updateFolder($folder);
-
+            
         } catch (Syncroton_Exception_NotFound $senf) {
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log)
                 $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " " . $senf->getMessage());
-            }
-
+            
             return;
         }
-
+        
         // update folder status in Syncroton backend
-        $this->_folder = $this->_folderBackend->update($folder); // @phpstan-ignore-line
+        $this->_folder = $this->_folderBackend->update($folder);
     }
-
+    
     /**
      * generate FolderUpdate response
      *
      * @todo currently we support only the main folder which contains all contacts/tasks/events/notes per class
      */
-    public function getResponse($_keepSession = false)
+    public function getResponse($_keepSession = FALSE)
     {
         $folderUpdate = $this->_outputDom->documentElement;
-
+        
         if (!$this->_syncState instanceof Syncroton_Model_SyncState) {
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log) 
                 $this->_logger->info(__METHOD__ . '::' . __LINE__ . " invalid synckey provided. FolderSync 0 needed.");
-            }
-            $folderUpdate->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Status', Syncroton_Command_FolderSync::STATUS_INVALID_SYNC_KEY));
-
-        } elseif (!$this->_folder instanceof Syncroton_Model_IFolder) {
-            $folderUpdate->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Status', Syncroton_Command_FolderSync::STATUS_FOLDER_NOT_FOUND));
-
+            $folderUpdate->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Status',  Syncroton_Command_FolderSync::STATUS_INVALID_SYNC_KEY));
+            
+        } elseif (!$this->_folder instanceof Syncroton_Model_IFolder) {
+            $folderUpdate->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Status', Syncroton_Command_FolderSync::STATUS_FOLDER_NOT_FOUND));
+            
         } else {
             $this->_syncState->counter++;
             $this->_syncState->lastsync = $this->_syncTimeStamp;
-
+            
             // store folder in state backend
             $this->_syncStateBackend->update($this->_syncState);
-
+                        
             // create xml output
-            $folderUpdate->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Status', Syncroton_Command_FolderSync::STATUS_SUCCESS));
+            $folderUpdate->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'Status',  Syncroton_Command_FolderSync::STATUS_SUCCESS));
             $folderUpdate->appendChild($this->_outputDom->createElementNS('uri:FolderHierarchy', 'SyncKey', $this->_syncState->counter));
         }
-
+        
         return $this->_outputDom;
-    }
+    }    
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/GetAttachment.php Changed

@@ -22,42 +22,44 @@
      * @var string
      */
     protected $_attachmentName;
-
+    
     protected $_skipValidatePolicyKey = true;
-
+    
     /**
-     * process the XML file and add, change, delete or fetches data
+     * process the XML file and add, change, delete or fetches data 
+     *
+     * @return resource
      */
     public function handle()
     {
         $this->_attachmentName = $this->_requestParameters'attachmentName';
     }
-
+    
     /**
      * this function generates the response for the client
-     *
+     * 
      * @return void
      */
     public function getResponse()
     {
         $dataController = Syncroton_Data_Factory::factory(Syncroton_Data_Factory::CLASS_EMAIL, $this->_device, $this->_syncTimeStamp);
-
+        
         $attachment = $dataController->getFileReference($this->_attachmentName);
-
+        
         if (PHP_SAPI !== 'cli') {
-            // cache for 3600 seconds
+            // cache for 3600 seconds
             $maxAge = 3600;
-            $now = new DateTime('now', new DateTimeZone('UTC'));
-            header('Cache-Control: private, max-age=' . $maxAge);
-            header("Expires: " . gmdate('D, d M Y H:i:s', $now->modify("+{$maxAge} sec")->getTimestamp()) . " GMT");
-
-            // overwrite Pragma header from session
-            header("Pragma: cache");
-
-            #header('Content-Disposition: attachment; filename="' . $filename . '"');
-            header("Content-Type: " . $attachment->contentType);
+            $now = new DateTime('now', new DateTimeZone('UTC'));
+            header('Cache-Control: private, max-age=' . $maxAge);
+            header("Expires: " . gmdate('D, d M Y H:i:s', $now->modify("+{$maxAge} sec")->getTimestamp()) . " GMT");
+            
+            // overwrite Pragma header from session
+            header("Pragma: cache");
+            
+            #header('Content-Disposition: attachment; filename="' . $filename . '"');
+            header("Content-Type: " . $attachment->contentType);
         }
-
+        
         if (is_resource($attachment->data)) {
             fpassthru($attachment->data);
         } else {

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/GetItemEstimate.php Changed

@@ -15,75 +15,73 @@
  * @package     Syncroton
  * @subpackage  Command
  */
-class Syncroton_Command_GetItemEstimate extends Syncroton_Command_Wbxml
+class Syncroton_Command_GetItemEstimate extends Syncroton_Command_Wbxml 
 {
-    public const STATUS_SUCCESS                = 1;
-    public const STATUS_INVALID_COLLECTION     = 2;
-    public const STATUS_SYNC_STATE_NOT_PRIMED  = 3;
-    public const STATUS_INVALID_SYNC_KEY       = 4;
-
+    const STATUS_SUCCESS                = 1;
+    const STATUS_INVALID_COLLECTION     = 2;
+    const STATUS_SYNC_STATE_NOT_PRIMED  = 3;
+    const STATUS_INVALID_SYNC_KEY       = 4;
+    
     protected $_defaultNameSpace    = 'uri:ItemEstimate';
     protected $_documentElement     = 'GetItemEstimate';
-
+    
     /**
      * list of collections
      *
      * @var array
      */
-    protected $_collections = ;
-
+    protected $_collections = array();
+    
     /**
      */
     public function handle()
     {
         $xml = simplexml_import_dom($this->_requestBody);
-
+        
         foreach ($xml->Collections->Collection as $xmlCollection) {
-
+            
             // fetch values from a different namespace
             $airSyncValues  = $xmlCollection->children('uri:AirSync');
-
-            $collectionData = 
+            
+            $collectionData = array(
                 'syncKey'       => (int)$airSyncValues->SyncKey,
                 'collectionId'  => (string) $xmlCollection->CollectionId,
                 'class'         => isset($xmlCollection->Class) ? (string) $xmlCollection->Class : null,
-                'filterType'    => isset($airSyncValues->Options) && isset($airSyncValues->Options->FilterType) ? (int)$airSyncValues->Options->FilterType : 0,
-            ;
-
-            if ($this->_logger instanceof Zend_Log) {
+                'filterType'    => isset($airSyncValues->Options) && isset($airSyncValues->Options->FilterType) ? (int)$airSyncValues->Options->FilterType : 0
+            );
+            
+            if ($this->_logger instanceof Zend_Log) 
                 $this->_logger->info(__METHOD__ . '::' . __LINE__ . " synckey is {$collectionData'syncKey'} class: {$collectionData'class'} collectionid: {$collectionData'collectionId'} filtertype: {$collectionData'filterType'}");
-            }
-
+            
             try {
                 // does the folder exist?
                 $collectionData'folder' = $this->_folderBackend->getFolder($this->_device, $collectionData'collectionId');
                 $collectionData'folder'->lastfiltertype = $collectionData'filterType';
-
+                
                 if($collectionData'syncKey' === 0) {
-                    $collectionData'syncState' = new Syncroton_Model_SyncState(
+                    $collectionData'syncState' = new Syncroton_Model_SyncState(array(
                         'device_id' => $this->_device,
                         'counter'   => 0,
                         'type'      => $collectionData'folder',
-                        'lastsync'  => $this->_syncTimeStamp,
-                    );
-
+                        'lastsync'  => $this->_syncTimeStamp
+                    ));
+                    
                     // reset sync state for this folder
                     $this->_syncStateBackend->resetState($this->_device, $collectionData'folder');
                     $this->_contentStateBackend->resetState($this->_device, $collectionData'folder');
-
+                    
                 } else {
                     $collectionData'syncState' = $this->_syncStateBackend->validate($this->_device, $collectionData'folder', $collectionData'syncKey');
                 }
             } catch (Syncroton_Exception_NotFound $senf) {
-                if ($this->_logger instanceof Zend_Log) {
+                if ($this->_logger instanceof Zend_Log)
                     $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " " . $senf->getMessage());
-                }
             }
-
+            
             $this->_collections$collectionData'collectionId' = $collectionData;
         }
-    }
-
+    }    
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Command_Wbxml::getResponse()
@@ -91,43 +89,41 @@
     public function getResponse()
     {
         $itemEstimate = $this->_outputDom->documentElement;
-
+        
         foreach($this->_collections as $collectionData) {
             $response = $itemEstimate->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'Response'));
 
             // invalid collectionid provided
             if (empty($collectionData'folder')) {
-                if ($this->_logger instanceof Zend_Log) {
+                if ($this->_logger instanceof Zend_Log)
                     $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " folder does not exist");
-                }
-
+                
                 $response->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'Status', self::STATUS_INVALID_COLLECTION));
                 $collection = $response->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'Collection'));
                 $collection->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'CollectionId', $collectionData'collectionId'));
                 $collection->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'Estimate', 0));
-
+                
             } elseif (! ($collectionData'syncState' instanceof Syncroton_Model_ISyncState)) {
-                if ($this->_logger instanceof Zend_Log) {
+                if ($this->_logger instanceof Zend_Log)
                     $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " invalid synckey ${collectionData'syncKey'} provided");
-                }
                 /*
                  * Android phones (and maybe others) don't take care about status 4(INVALID_SYNC_KEY)
                  * To solve the problem we always return status 1(SUCCESS) even the sync key is invalid with Estimate set to 1.
                  * This way the phone gets forced to sync. Handling invalid synckeys during sync command works without any problems.
-                 *
+                 * 
                     $response->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'Status', self::STATUS_INVALID_SYNC_KEY));
                     $collection = $response->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'Collection'));
-                    $collection->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'CollectionId', $collectionData'collectionId'));
+                    $collection->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'CollectionId', $collectionData'collectionId'));  
                     $collection->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'Estimate', 0));
                  */
-
+                                                              
                 $response->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'Status', self::STATUS_SUCCESS));
                 $collection = $response->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'Collection'));
-                $collection->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'CollectionId', $collectionData'collectionId'));
-                $collection->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'Estimate', 1));
+                $collection->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'CollectionId', $collectionData'collectionId'));  
+                $collection->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'Estimate', 1));                                              
             } else {
                 $dataController = Syncroton_Data_Factory::factory($collectionData'folder'->class, $this->_device, $this->_syncTimeStamp);
-
+                
                 $response->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'Status', self::STATUS_SUCCESS));
                 $collection = $response->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'Collection'));
                 $collection->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'CollectionId', $collectionData'collectionId'));
@@ -139,13 +135,13 @@
                 }
                 $collection->appendChild($this->_outputDom->createElementNS('uri:ItemEstimate', 'Estimate', $count));
             }
-
+            
             // folderState can be NULL in case of not existing folder
             if (isset($collectionData'folder') && $collectionData'folder'->isDirty()) {
                 $this->_folderBackend->update($collectionData'folder');
             }
         }
-
+                
         return $this->_outputDom;
     }
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/ICommand.php Changed

@@ -15,19 +15,19 @@
  * @package     Syncroton
  * @subpackage  Command
  */
-interface Syncroton_Command_ICommand
+interface Syncroton_Command_ICommand 
 {
     /**
      * constructor of this class
-     *
+     * 
      * @param resource                 $_requestBody
      * @param Syncroton_Model_IDevice  $_device
-     * @param array                    $_requestParams
+     * @param string                   $_policyKey
      */
-    public function __construct($_requestBody, Syncroton_Model_IDevice $_device, $_requestParams = );
-
+    public function __construct($_requestBody, Syncroton_Model_IDevice $_device, $_policyKey);
+    
     /**
-     * process the incoming data
+     * process the incoming data 
      */
     public function handle();
 
@@ -35,10 +35,10 @@
      * create the response
      */
     public function getResponse();
-
+    
     /**
      * return headers of command
-     *
+     * 
      * @return array list of headers
      */
     public function getHeaders();

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/ItemOperations.php Changed

@@ -15,31 +15,31 @@
  * @package     Syncroton
  * @subpackage  Command
  */
-class Syncroton_Command_ItemOperations extends Syncroton_Command_Wbxml
-{
-    public const STATUS_SUCCESS        = 1;
-    public const STATUS_PROTOCOL_ERROR = 2;
-    public const STATUS_SERVER_ERROR   = 3;
-
-    public const STATUS_ITEM_FAILED_CONVERSION = 14;
-
+class Syncroton_Command_ItemOperations extends Syncroton_Command_Wbxml 
+{        
+    const STATUS_SUCCESS        = 1;
+    const STATUS_PROTOCOL_ERROR = 2;
+    const STATUS_SERVER_ERROR   = 3;
+    
+    const STATUS_ITEM_FAILED_CONVERSION = 14;
+    
     protected $_defaultNameSpace    = 'uri:ItemOperations';
     protected $_documentElement     = 'ItemOperations';
-
+    
     /**
      * list of items to move
-     *
+     * 
      * @var array
      */
-    protected $_fetches = ;
-
+    protected $_fetches = array();
+    
     /**
      * list of folder to empty
-     *
+     * 
      * @var array
      */
-    protected $_emptyFolderContents = ;
-
+    protected $_emptyFolderContents = array();
+    
     /**
      * parse MoveItems request
      *
@@ -47,112 +47,112 @@
     public function handle()
     {
         $xml = simplexml_import_dom($this->_requestBody);
-
+        
         if (isset($xml->Fetch)) {
             foreach ($xml->Fetch as $fetch) {
                 $this->_fetches = $this->_handleFetch($fetch);
             }
         }
-
+        
         if (isset($xml->EmptyFolderContents)) {
             foreach ($xml->EmptyFolderContents as $emptyFolderContents) {
                 $this->_emptyFolderContents = $this->_handleEmptyFolderContents($emptyFolderContents);
             }
         }
     }
-
+    
     /**
      * generate ItemOperations response
-     *
+     * 
      * @todo add multipart support to all types of fetches
      */
     public function getResponse()
     {
         // add aditional namespaces
-        $this->_outputDom->documentElement->setAttributeNS('http://www.w3.org/2000/xmlns/', 'xmlns:AirSyncBase', 'uri:AirSyncBase');
-        $this->_outputDom->documentElement->setAttributeNS('http://www.w3.org/2000/xmlns/', 'xmlns:AirSync', 'uri:AirSync');
-        $this->_outputDom->documentElement->setAttributeNS('http://www.w3.org/2000/xmlns/', 'xmlns:Search', 'uri:Search');
-
+        $this->_outputDom->documentElement->setAttributeNS('http://www.w3.org/2000/xmlns/', 'xmlns:AirSyncBase' , 'uri:AirSyncBase');
+        $this->_outputDom->documentElement->setAttributeNS('http://www.w3.org/2000/xmlns/', 'xmlns:AirSync'     , 'uri:AirSync');
+        $this->_outputDom->documentElement->setAttributeNS('http://www.w3.org/2000/xmlns/', 'xmlns:Search'      , 'uri:Search');
+        
         $itemOperations = $this->_outputDom->documentElement;
-
+        
         $itemOperations->appendChild($this->_outputDom->createElementNS('uri:ItemOperations', 'Status', Syncroton_Command_ItemOperations::STATUS_SUCCESS));
-
+        
         $response = $itemOperations->appendChild($this->_outputDom->createElementNS('uri:ItemOperations', 'Response'));
-
+        
         foreach ($this->_fetches as $fetch) {
             $fetchTag = $response->appendChild($this->_outputDom->createElementNS('uri:ItemOperations', 'Fetch'));
-
+            
             try {
                 $dataController = Syncroton_Data_Factory::factory($fetch'store', $this->_device, $this->_syncTimeStamp);
-
+                
                 if (isset($fetch'collectionId')) {
                     $fetchTag->appendChild($this->_outputDom->createElementNS('uri:ItemOperations', 'Status', Syncroton_Command_ItemOperations::STATUS_SUCCESS));
                     $fetchTag->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'CollectionId', $fetch'collectionId'));
-                    $fetchTag->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'ServerId', $fetch'serverId'));
-
+                    $fetchTag->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'ServerId',     $fetch'serverId'));
+                    
                     $properties = $this->_outputDom->createElementNS('uri:ItemOperations', 'Properties');
                     $dataController
-                        ->getEntry(new Syncroton_Model_SyncCollection('collectionId' => $fetch'collectionId', 'options' => $fetch'options'), $fetch'serverId')
+                        ->getEntry(new Syncroton_Model_SyncCollection(array('collectionId' => $fetch'collectionId', 'options' => $fetch'options')), $fetch'serverId')
                         ->appendXML($properties, $this->_device);
                     $fetchTag->appendChild($properties);
-
+                    
                 } elseif (isset($fetch'longId')) {
                     $fetchTag->appendChild($this->_outputDom->createElementNS('uri:ItemOperations', 'Status', Syncroton_Command_ItemOperations::STATUS_SUCCESS));
                     $fetchTag->appendChild($this->_outputDom->createElementNS('uri:Search', 'LongId', $fetch'longId'));
-
+                    
                     $properties = $this->_outputDom->createElementNS('uri:ItemOperations', 'Properties');
                     $dataController
-                        ->getEntry(new Syncroton_Model_SyncCollection('collectionId' => $fetch'longId', 'options' => $fetch'options'), $fetch'longId')
+                        ->getEntry(new Syncroton_Model_SyncCollection(array('collectionId' => $fetch'longId', 'options' => $fetch'options')), $fetch'longId')
                         ->appendXML($properties, $this->_device);
                     $fetchTag->appendChild($properties);
-
+                    
                 } elseif (isset($fetch'fileReference')) {
                     $fetchTag->appendChild($this->_outputDom->createElementNS('uri:ItemOperations', 'Status', Syncroton_Command_ItemOperations::STATUS_SUCCESS));
                     $fetchTag->appendChild($this->_outputDom->createElementNS('uri:AirSyncBase', 'FileReference', $fetch'fileReference'));
 
                     $properties = $this->_outputDom->createElementNS('uri:ItemOperations', 'Properties');
-
+                    
                     $fileReference = $dataController->getFileReference($fetch'fileReference');
-
+                    
                     // unset data field and move content to stream
                     if (!empty($this->_requestParameters'acceptMultipart')) {
                         $this->_headers'Content-Type' = 'application/vnd.ms-sync.multipart';
-
+                        
                         $partStream = fopen("php://temp", 'r+');
-
+                        
                         if (is_resource($fileReference->data)) {
                             stream_copy_to_stream($fileReference->data, $partStream);
                         } else {
                             fwrite($partStream, $fileReference->data);
                         }
-
+                        
                         unset($fileReference->data);
-
+                        
                         $this->_parts = $partStream;
-
+                        
                         $fileReference->part = count($this->_parts);
-                    }
-
+                    } 
+                    
                     /**
                      * the client requested a range. But we return the whole file.
-                     *
+                     * 
                      * That's not correct, but allowed. The server is allowed to overwrite the range.
-                     *
+                     * 
                      * @todo implement cutting $fileReference->data into pieces
                      */
                     if (isset($fetch'options''range')) {
                         $dataSize = $this->_getDataSize($fileReference->data);
-
+                        
                         $total = $this->_outputDom->createElementNS('uri:ItemOperations', 'Total', $dataSize);
                         $properties->appendChild($total);
-
-                        $rangeEnd = $dataSize > 0 ? $dataSize - 1 : 0;
+                        
+                        $rangeEnd = $dataSize > 0 ?  $dataSize - 1 : 0;
                         $range = $this->_outputDom->createElementNS('uri:ItemOperations', 'Range', '0-' . $rangeEnd);
                         $properties->appendChild($range);
                     }
-
+                    
                     $fileReference->appendXML($properties, $this->_device);
-
+                    
                     $fetchTag->appendChild($properties);
                 }
             } catch (Syncroton_Exception_NotFound $e) {
@@ -162,9 +162,9 @@
                 $response->appendChild($this->_outputDom->createElementNS('uri:ItemOperations', 'Status', Syncroton_Command_ItemOperations::STATUS_SERVER_ERROR));
             }
         }
-
+        
         foreach ($this->_emptyFolderContents as $emptyFolderContents) {
-
+            
             try {
                 $folder = $this->_folderBackend->getFolder($this->_device, $emptyFolderContents'collectionId');
 
@@ -172,74 +172,76 @@
                 $dataController->emptyFolderContents($emptyFolderContents'collectionId', $emptyFolderContents'options');
 
                 $status = Syncroton_Command_ItemOperations::STATUS_SUCCESS;
-            } catch (Syncroton_Exception_Status_ItemOperations $e) {
+            }
+            catch (Syncroton_Exception_Status_ItemOperations $e) {
                 $status = $e->getCode();
-            } catch (Exception $e) {
+            }
+            catch (Exception $e) {
                 $status = Syncroton_Exception_Status_ItemOperations::ITEM_SERVER_ERROR;
             }
 
             $emptyFolderContentsTag = $this->_outputDom->createElementNS('uri:ItemOperations', 'EmptyFolderContents');
-
+            
             $emptyFolderContentsTag->appendChild($this->_outputDom->createElementNS('uri:ItemOperations', 'Status', $status));
             $emptyFolderContentsTag->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'CollectionId', $emptyFolderContents'collectionId'));
-
+            
             $response->appendChild($emptyFolderContentsTag);
         }
-
+        
         return $this->_outputDom;
     }
-
+    
     /**
      * parse fetch request
-     *
+     * 
      * @param SimpleXMLElement $fetch
      * @return array
      */
     protected function _handleFetch(SimpleXMLElement $fetch)
     {
-        $fetchArray = 
+        $fetchArray = array(
             'store'   => (string)$fetch->Store,
-            'options' => ,
-        ;
-
+            'options' => array()
+        );
+        
         // try to fetch element from namespace AirSync
         $airSync = $fetch->children('uri:AirSync');
-
+        
         if (isset($airSync->CollectionId)) {
             $fetchArray'collectionId' = (string)$airSync->CollectionId;
             $fetchArray'serverId'     = (string)$airSync->ServerId;
         }
-
+        
         // try to fetch element from namespace Search
         $search = $fetch->children('uri:Search');
-
+        
         if (isset($search->LongId)) {
             $fetchArray'longId' = (string)$search->LongId;
         }
-
+        
         // try to fetch element from namespace AirSyncBase
         $airSyncBase = $fetch->children('uri:AirSyncBase');
-
+        
         if (isset($airSyncBase->FileReference)) {
             $fetchArray'fileReference' = (string)$airSyncBase->FileReference;
         }
-
+        
         if (isset($fetch->Options)) {
             // try to fetch element from namespace AirSyncBase
             $airSyncBase = $fetch->Options->children('uri:AirSyncBase');
-
+            
             if (isset($airSyncBase->BodyPreference)) {
                 foreach ($airSyncBase->BodyPreference as $bodyPreference) {
                     $type = (int) $bodyPreference->Type;
-                    $fetchArray'options''bodyPreferences'$type = 
-                        'type' => $type,
-                    ;
-
+                    $fetchArray'options''bodyPreferences'$type = array(
+                        'type' => $type
+                    );
+                    
                     // optional
                     if (isset($bodyPreference->TruncationSize)) {
                         $fetchArray'options''bodyPreferences'$type'truncationSize' = (int) $bodyPreference->TruncationSize;
                     }
-
+                    
                     // optional
                     if (isset($bodyPreference->AllOrNone)) {
                         $fetchArray'options''bodyPreferences'$type'allOrNone' = (int) $bodyPreference->AllOrNone;
@@ -251,43 +253,43 @@
             if (isset($airSync->MIMESupport)) {
                 $fetchArray'options''mimeSupport' = (int) $airSync->MIMESupport;
             }
-
+ 
             if (isset($fetch->Options->Range)) {
                 $fetchArray'options''range' = (string) $fetch->Options->Range;
             }
         }
-
+        
         return $fetchArray;
     }
-
+    
     /**
      * handle empty folder request
-     *
+     * 
      * @param SimpleXMLElement $emptyFolderContent
      * @return array
      */
     protected function _handleEmptyFolderContents(SimpleXMLElement $emptyFolderContent)
     {
-        $folderArray = 
+        $folderArray = array(
             'collectiondId' => null,
-            'options'       => 'deleteSubFolders' => false,
-        ;
-
+            'options'       => array('deleteSubFolders' => FALSE)
+        );
+        
         // try to fetch element from namespace AirSync
         $airSync = $emptyFolderContent->children('uri:AirSync');
-
+        
         $folderArray'collectionId' = (string)$airSync->CollectionId;
-
+        
         if (isset($emptyFolderContent->Options)) {
-            $folderArray'options''deleteSubFolders' = isset($emptyFolderContent->Options->DeleteSubFolders);
+            $folderArray'options''deleteSubFolders' = isset($emptyFolderContent->Options->DeleteSubFolders); 
         }
-
+        
         return $folderArray;
     }
 
     /**
      * return length of data
-     *
+     * 
      * @param string|resource $data
      * @return number
      */

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/MeetingResponse.php Changed

@@ -17,10 +17,9 @@
  */
 class Syncroton_Command_MeetingResponse extends Syncroton_Command_Wbxml
 {
-    protected $_results = ;
-
+    protected $_results = array();
+    
     protected $_defaultNameSpace = 'uri:MeetingResponse';
-
     protected $_documentElement  = 'MeetingResponse';
 
     /**
@@ -28,28 +27,27 @@
      */
     public function handle()
     {
-        /** @var Syncroton_Data_IDataCalendar $dataController */
         $dataController = Syncroton_Data_Factory::factory(Syncroton_Data_Factory::CLASS_CALENDAR, $this->_device, $this->_syncTimeStamp);
-
+        
         $xml = simplexml_import_dom($this->_requestBody);
 
         foreach ($xml as $meetingResponse) {
             $request = new Syncroton_Model_MeetingResponse($meetingResponse);
-
+            
             try {
                 $calendarId = $dataController->setAttendeeStatus($request);
-
-                $this->_results = 
+                
+                $this->_results = array(
                     'calendarId' => $calendarId,
                     'request'    => $request,
-                    'status'     => 1,
-                ;
-
+                    'status'     => 1
+                );
+                
             } catch (Syncroton_Exception_Status_MeetingResponse $sesmr) {
-                $this->_results = 
+                $this->_results = array(
                     'request' => $request,
-                    'status'  => $sesmr->getCode(),
-                ;
+                    'status'  => $sesmr->getCode()
+                );
             }
         }
     }
@@ -60,27 +58,27 @@
     public function getResponse()
     {
         $this->_outputDom->documentElement->setAttributeNS('http://www.w3.org/2000/xmlns/', 'xmlns:Search', 'uri:Search');
-
+        
         $meetingResponse = $this->_outputDom->documentElement;
 
         foreach ($this->_results as $result) {
             $resultElement = $this->_outputDom->createElementNS('uri:MeetingResponse', 'Result');
-
+            
             if (isset($result'request'->requestId)) {
                 $resultElement->appendChild($this->_outputDom->createElementNS('uri:MeetingResponse', 'RequestId', $result'request'->requestId));
             } elseif (isset($result'request'->longId)) {
                 $resultElement->appendChild($this->_outputDom->createElementNS('uri:Search', 'LongId', $result'request'->longId));
             }
-
+            
             $resultElement->appendChild($this->_outputDom->createElementNS('uri:MeetingResponse', 'Status', $result'status'));
-
+            
             if (isset($result'calendarId')) {
                 $resultElement->appendChild($this->_outputDom->createElementNS('uri:MeetingResponse', 'CalendarId', $result'calendarId'));
             }
-
+            
             $meetingResponse->appendChild($resultElement);
-        }
-
+        } 
+        
         return $this->_outputDom;
     }
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/MoveItems.php Changed

@@ -20,7 +20,7 @@
  */
 class Syncroton_Command_MoveItems extends Syncroton_Command_Wbxml
 {
-    public const STATUS_SUCCESS                = 3;
+    const STATUS_SUCCESS                = 3;
 
     protected $_defaultNameSpace    = 'uri:Move';
     protected $_documentElement     = 'MoveItems';
@@ -30,7 +30,7 @@
      *
      * @var array
      */
-    protected $_moves = ;
+    protected $_moves = array();
 
     /**
      * parse MoveItems request
@@ -40,11 +40,11 @@
         $xml = simplexml_import_dom($this->_requestBody);
 
         foreach ($xml->Move as $move) {
-            $this->_moves = 
+            $this->_moves = array(
                 'srcMsgId' => (string)$move->SrcMsgId,
                 'srcFldId' => (string)$move->SrcFldId,
-                'dstFldId' => (string)$move->DstFldId,
-            ;
+                'dstFldId' => (string)$move->DstFldId
+            );
         }
     }
 
@@ -59,11 +59,11 @@
             $response = $moves->appendChild($this->_outputDom->createElementNS('uri:Move', 'Response'));
             $response->appendChild($this->_outputDom->createElementNS('uri:Move', 'SrcMsgId', $move'srcMsgId'));
 
-            if ($this->_logger instanceof Zend_Log) {
-                $this->_logger->info(__METHOD__ . '::' . __LINE__ . " Moving from " . $move'srcFldId' . " to " . $move'dstFldId');
-            }
-
             try {
+                if ($move'srcFldId' === $move'dstFldId') {
+                    throw new Syncroton_Exception_Status_MoveItems(Syncroton_Exception_Status_MoveItems::SAME_FOLDER);
+                }
+
                 try {
                     $sourceFolder = $this->_folderBackend->getFolder($this->_device, $move'srcFldId');
                 } catch (Syncroton_Exception_NotFound $e) {
@@ -76,30 +76,19 @@
                     throw new Syncroton_Exception_Status_MoveItems(Syncroton_Exception_Status_MoveItems::INVALID_DESTINATION);
                 }
 
-                if ($move'srcFldId' === $move'dstFldId') {
-                    throw new Syncroton_Exception_Status_MoveItems(Syncroton_Exception_Status_MoveItems::SAME_FOLDER);
-                }
-
                 $dataController = Syncroton_Data_Factory::factory($sourceFolder->class, $this->_device, $this->_syncTimeStamp);
                 $newId          = $dataController->moveItem($move'srcFldId', $move'srcMsgId', $move'dstFldId');
+
                 if (!$newId) {
-                    // We don't actually know what the reason was that this failed, but from the resolution description this error seems to make the most sense,
-                    // and we rule out most other reasons before.
                     throw new Syncroton_Exception_Status_MoveItems(Syncroton_Exception_Status_MoveItems::INVALID_SOURCE);
                 }
 
                 $response->appendChild($this->_outputDom->createElementNS('uri:Move', 'Status', Syncroton_Command_MoveItems::STATUS_SUCCESS));
                 $response->appendChild($this->_outputDom->createElementNS('uri:Move', 'DstMsgId', $newId));
-            } catch (Syncroton_Exception_Status_MoveItems $e) {
-                if ($this->_logger instanceof Zend_Log) {
-                    $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " Move failed: " . $e->getMessage());
-                }
+            } catch (Syncroton_Exception_Status $e) {
                 $response->appendChild($this->_outputDom->createElementNS('uri:Move', 'Status', $e->getCode()));
             } catch (Exception $e) {
-                if ($this->_logger instanceof Zend_Log) {
-                    $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " Move failed: " . $e->getMessage());
-                }
-                $response->appendChild($this->_outputDom->createElementNS('uri:Move', 'Status', Syncroton_Exception_Status_MoveItems::FOLDER_LOCKED));
+                $response->appendChild($this->_outputDom->createElementNS('uri:Move', 'Status', Syncroton_Exception_Status::SERVER_ERROR));
             }
         }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/Options.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/Ping.php Changed

@@ -15,38 +15,45 @@
  * @package     Syncroton
  * @subpackage  Command
  */
-class Syncroton_Command_Ping extends Syncroton_Command_Wbxml
+class Syncroton_Command_Ping extends Syncroton_Command_Wbxml 
 {
-    public const STATUS_NO_CHANGES_FOUND           = 1;
-    public const STATUS_CHANGES_FOUND              = 2;
-    public const STATUS_MISSING_PARAMETERS         = 3;
-    public const STATUS_REQUEST_FORMAT_ERROR       = 4;
-    public const STATUS_INTERVAL_TO_GREAT_OR_SMALL = 5;
-    public const STATUS_TOO_MANY_FOLDERS           = 6;
-    public const STATUS_FOLDER_NOT_FOUND           = 7;
-    public const STATUS_GENERAL_ERROR              = 8;
-
-    public const MAX_PING_INTERVAL                 = 3540; // 59 minutes limit defined in Activesync protocol spec.
-
-    protected $_defaultNameSpace = 'uri:Ping';
-
-    protected $_documentElement = 'Ping';
-
+    const STATUS_NO_CHANGES_FOUND           = 1;
+    const STATUS_CHANGES_FOUND              = 2;
+    const STATUS_MISSING_PARAMETERS         = 3;
+    const STATUS_REQUEST_FORMAT_ERROR       = 4;
+    const STATUS_INTERVAL_TO_GREAT_OR_SMALL = 5;
+    const STATUS_TOO_MANY_FOLDERS           = 6;
+    const STATUS_FOLDER_NOT_FOUND           = 7;
+    const STATUS_GENERAL_ERROR              = 8;
+    
+    const MAX_PING_INTERVAL                 = 3540; // 59 minutes limit defined in Activesync protocol spec. 
+    
     protected $_skipValidatePolicyKey = true;
+    
     protected $_changesDetected = false;
-    protected $_foldersWithChanges = ;
+    
+    /**
+     * @var Syncroton_Backend_StandAlone_Abstract
+     */
+    protected $_dataBackend;
 
+    protected $_defaultNameSpace = 'uri:Ping';
+    protected $_documentElement  = 'Ping';
+    
+    protected $_foldersWithChanges = array();
+    
     /**
-     * process the XML file and add, change, delete or fetches data
+     * process the XML file and add, change, delete or fetches data 
      *
      * @todo can we get rid of LIBXML_NOWARNING
      * @todo we need to stored the initial data for folders and lifetime as the phone is sending them only when they change
+     * @return resource
      */
     public function handle()
     {
         $intervalStart = time();
         $status = self::STATUS_NO_CHANGES_FOUND;
-
+        
         // the client does not send a wbxml document, if the Ping parameters did not change compared with the last request
         if ($this->_requestBody instanceof DOMDocument) {
             $xml = simplexml_import_dom($this->_requestBody);
@@ -55,7 +62,7 @@
             if(isset($xml->HeartbeatInterval)) {
                 $this->_device->pinglifetime = (int)$xml->HeartbeatInterval;
             }
-
+            
             if (isset($xml->Folders->Folder)) {
                 $maxCollections = Syncroton_Registry::getMaxCollections();
                 if ($maxCollections && count($xml->Folders->Folder) > $maxCollections) {
@@ -65,21 +72,16 @@
                     return;
                 }
 
-                $folders = ;
+                $folders = array();
                 foreach ($xml->Folders->Folder as $folderXml) {
                     try {
-                        if (empty((string)$folderXml->Id)) {
-                            // Ignore empty folder ids
-                            continue;
-                        }
                         // does the folder exist?
                         $folder = $this->_folderBackend->getFolder($this->_device, (string)$folderXml->Id);
-
+                        
                         $folders$folder->id = $folder;
                     } catch (Syncroton_Exception_NotFound $senf) {
-                        if ($this->_logger instanceof Zend_Log) {
+                        if ($this->_logger instanceof Zend_Log) 
                             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " " . $senf->getMessage());
-                        }
                         $status = self::STATUS_FOLDER_NOT_FOUND;
                         break;
                     }
@@ -87,13 +89,13 @@
                 $this->_device->pingfolder = serialize(array_keys($folders));
             }
         }
-
+        
         $this->_device->lastping = new DateTime('now', new DateTimeZone('UTC'));
 
         if ($status == self::STATUS_NO_CHANGES_FOUND) {
-            $this->_device = $this->_deviceBackend->update($this->_device); // @phpstan-ignore-line
+            $this->_device = $this->_deviceBackend->update($this->_device);
         }
-
+        
         $lifeTime    = $this->_device->pinglifetime;
         $maxInterval = Syncroton_Registry::getPingInterval();
 
@@ -107,20 +109,19 @@
             $ping->appendChild($this->_outputDom->createElementNS('uri:Ping', 'HeartbeatInterval', $maxInterval));
             return;
         }
-
+        
         $intervalEnd = $intervalStart + $lifeTime;
         $secondsLeft = $intervalEnd;
-
-        $folders = $this->_device->pingfolder ? unserialize($this->_device->pingfolder) : ;
-
+        
+        $folders = $this->_device->pingfolder ? unserialize($this->_device->pingfolder) : array();
+        
         if ($status === self::STATUS_NO_CHANGES_FOUND && (!is_array($folders) || count($folders) == 0)) {
             $status = self::STATUS_MISSING_PARAMETERS;
         }
-
-        if ($this->_logger instanceof Zend_Log) {
+        
+        if ($this->_logger instanceof Zend_Log) 
             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " Folders to monitor($lifeTime / $intervalStart / $intervalEnd / $status): " . print_r($folders, true));
-        }
-
+        
         if ($status === self::STATUS_NO_CHANGES_FOUND) {
             $sleepCallback  = Syncroton_Registry::getSleepCallback();
             $wakeupCallback = Syncroton_Registry::getWakeupCallback();
@@ -128,13 +129,12 @@
             do {
                 // take a break to save battery lifetime
                 call_user_func($sleepCallback);
-                sleep(min(Syncroton_Registry::getPingTimeout(), $lifeTime));
+                sleep(Syncroton_Registry::getPingTimeout());
 
                 // make sure the connection is still alive, abort otherwise
                 if (connection_aborted()) {
-                    if ($this->_logger instanceof Zend_Log) {
+                    if ($this->_logger instanceof Zend_Log)
                         $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " Exiting on aborted connection");
-                    }
                     exit;
                 }
 
@@ -146,151 +146,132 @@
                 $secondsLeft = $intervalEnd - time();
 
                 try {
-                    /** @var Syncroton_Model_Device $device */
                     $device = $this->_deviceBackend->get($this->_device->id);
                 } catch (Syncroton_Exception_NotFound $e) {
-                    if ($this->_logger instanceof Zend_Log) {
+                    if ($this->_logger instanceof Zend_Log)
                         $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " " . $e->getMessage());
-                    }
 
                     $status = self::STATUS_FOLDER_NOT_FOUND;
                     break;
                 } catch (Exception $e) {
-                    if ($this->_logger instanceof Zend_Log) {
+                    if ($this->_logger instanceof Zend_Log)
                         $this->_logger->err(__METHOD__ . '::' . __LINE__ . " " . $e->getMessage());
-                    }
 
                     // do nothing, maybe temporal issue, should we stop?
                     continue;
                 }
 
                 // if another Ping command updated lastping property, we can stop processing this Ping command request
-                if ((isset($device->lastping) &&
-                    $device->lastping instanceof DateTime) &&
+                if ((isset($device->lastping) && $device->lastping instanceof DateTime) &&
                     $device->pingfolder === $this->_device->pingfolder &&
-                    $device->lastping->getTimestamp() > $this->_device->lastping->getTimestamp()
-                ) {
+                    $device->lastping->getTimestamp() > $this->_device->lastping->getTimestamp() ) {
                     break;
                 }
 
                 // If folders hierarchy changed, break the loop and ask the client for FolderSync
                 try {
                     if ($this->_folderBackend->hasHierarchyChanges($this->_device)) {
-                        if ($this->_logger instanceof Zend_Log) {
+                        if ($this->_logger instanceof Zend_Log)
                             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . ' Detected changes in folders hierarchy');
-                        }
 
                         $status = self::STATUS_FOLDER_NOT_FOUND;
                         break;
                     }
                 } catch (Exception $e) {
-                    if ($this->_logger instanceof Zend_Log) {
+                    if ($this->_logger instanceof Zend_Log)
                         $this->_logger->err(__METHOD__ . '::' . __LINE__ . " " . $e->getMessage());
-                    }
 
                     // do nothing, maybe temporal issue, should we stop?
                     continue;
                 }
 
                 $now = new DateTime('now', new DateTimeZone('UTC'));
-
+                
                 foreach ($folders as $folderId) {
-                    if (empty($folderId)) {
-                        // Ignore empty folder ids
-                        continue;
-                    }
                     try {
-                        /** @var Syncroton_Model_Folder $folder */
                         $folder         = $this->_folderBackend->get($folderId);
                         $dataController = Syncroton_Data_Factory::factory($folder->class, $this->_device, $this->_syncTimeStamp);
-
+                        
                     } catch (Syncroton_Exception_NotFound $e) {
-                        if ($this->_logger instanceof Zend_Log) {
+                        if ($this->_logger instanceof Zend_Log)
                             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " " . $e->getMessage());
-                        }
                         $status = self::STATUS_FOLDER_NOT_FOUND;
-
+                        
                         break;
-
+                        
                     } catch (Exception $e) {
-                        if ($this->_logger instanceof Zend_Log) {
+                        if ($this->_logger instanceof Zend_Log)
                             $this->_logger->err(__METHOD__ . '::' . __LINE__ . " " . $e->getMessage());
-                        }
-
+                        
                         // do nothing, maybe temporal issue, should we stop?
                         continue;
                     }
 
                     try {
                         $syncState = $this->_syncStateBackend->getSyncState($this->_device, $folder);
-
+                        
                         // another process synchronized data of this folder already. let's skip it
                         if ($syncState->lastsync > $this->_syncTimeStamp) {
                             continue;
                         }
-
+                        
                         // safe battery time by skipping folders which got synchronied less than Syncroton_Registry::getQuietTime() seconds ago
                         if (($now->getTimestamp() - $syncState->lastsync->getTimestamp()) < Syncroton_Registry::getQuietTime()) {
                             continue;
                         }
-
+                        
                         $foundChanges = $dataController->hasChanges($this->_contentStateBackend, $folder, $syncState);
-
+                        
                     } catch (Syncroton_Exception_NotFound $e) {
                         // folder got never synchronized to client
-                        if ($this->_logger instanceof Zend_Log) {
+                        if ($this->_logger instanceof Zend_Log) 
                             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " " . $e->getMessage());
-                        }
-                        if ($this->_logger instanceof Zend_Log) {
+                        if ($this->_logger instanceof Zend_Log) 
                             $this->_logger->info(__METHOD__ . '::' . __LINE__ . ' syncstate not found. enforce sync for folder: ' . $folder->serverId);
-                        }
-
+                        
                         $foundChanges = true;
                     }
-
+                    
                     if ($foundChanges == true) {
                         $this->_foldersWithChanges = $folder;
                         $status = self::STATUS_CHANGES_FOUND;
                     }
                 }
-
+                
                 if ($status != self::STATUS_NO_CHANGES_FOUND) {
                     break;
                 }
 
                 // Update secondsLeft (again)
                 $secondsLeft = $intervalEnd - time();
-
-                if ($this->_logger instanceof Zend_Log) {
+                
+                if ($this->_logger instanceof Zend_Log)
                     $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " DeviceId: " . $this->_device->deviceid . " seconds left: " . $secondsLeft);
-                }
-
-                // See: http://www.tine20.org/forum/viewtopic.php?f=12&t=12146
-                //
-                // break if there are less than PingTimeout + 10 seconds left for the next loop
-                // otherwise the response will be returned after the client has finished his Ping
-                // request already maybe
+            
+            // See: http://www.tine20.org/forum/viewtopic.php?f=12&t=12146
+            //
+            // break if there are less than PingTimeout + 10 seconds left for the next loop
+            // otherwise the response will be returned after the client has finished his Ping
+            // request already maybe
             } while (Syncroton_Server::validateSession() && $secondsLeft > (Syncroton_Registry::getPingTimeout() + 10));
         }
-
-        if ($this->_logger instanceof Zend_Log) {
+        
+        if ($this->_logger instanceof Zend_Log) 
             $this->_logger->info(__METHOD__ . '::' . __LINE__ . " DeviceId: " . $this->_device->deviceid . " Lifetime: $lifeTime SecondsLeft: $secondsLeft Status: $status)");
-        }
-
+        
         $ping = $this->_outputDom->documentElement;
         $ping->appendChild($this->_outputDom->createElementNS('uri:Ping', 'Status', $status));
         if($status === self::STATUS_CHANGES_FOUND) {
             $folders = $ping->appendChild($this->_outputDom->createElementNS('uri:Ping', 'Folders'));
-
+            
             foreach($this->_foldersWithChanges as $changedFolder) {
                 $folder = $folders->appendChild($this->_outputDom->createElementNS('uri:Ping', 'Folder', $changedFolder->serverId));
-                if ($this->_logger instanceof Zend_Log) {
+                if ($this->_logger instanceof Zend_Log) 
                     $this->_logger->info(__METHOD__ . '::' . __LINE__ . " DeviceId: " . $this->_device->deviceid . " changes in folder: " . $changedFolder->serverId);
-                }
             }
         }
     }
-
+        
     /**
      * generate ping command response
      *

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/Provision.php Changed

@@ -19,65 +19,67 @@
 {
     protected $_defaultNameSpace = 'uri:Provision';
     protected $_documentElement  = 'Provision';
-
-    public const POLICYTYPE_WBXML = 'MS-EAS-Provisioning-WBXML';
-
-    public const STATUS_SUCCESS                   = 1;
-    public const STATUS_PROTOCOL_ERROR            = 2;
-    public const STATUS_GENERAL_SERVER_ERROR      = 3;
-    public const STATUS_DEVICE_MANAGED_EXTERNALLY = 4;
-
-    public const STATUS_POLICY_SUCCESS        = 1;
-    public const STATUS_POLICY_NOPOLICY       = 2;
-    public const STATUS_POLICY_UNKNOWNTYPE    = 3;
-    public const STATUS_POLICY_CORRUPTED      = 4;
-    public const STATUS_POLICY_WRONGPOLICYKEY = 5;
-
-    public const REMOTEWIPE_REQUESTED = 1;
-    public const REMOTEWIPE_CONFIRMED = 2;
-
+    
+    const POLICYTYPE_WBXML = 'MS-EAS-Provisioning-WBXML';
+    
+    const STATUS_SUCCESS                   = 1;
+    const STATUS_PROTOCOL_ERROR            = 2;
+    const STATUS_GENERAL_SERVER_ERROR      = 3;
+    const STATUS_DEVICE_MANAGED_EXTERNALLY = 4;
+    
+    const STATUS_POLICY_SUCCESS        = 1;
+    const STATUS_POLICY_NOPOLICY       = 2;
+    const STATUS_POLICY_UNKNOWNTYPE    = 3;
+    const STATUS_POLICY_CORRUPTED      = 4;
+    const STATUS_POLICY_WRONGPOLICYKEY = 5;
+    
+    const REMOTEWIPE_REQUESTED = 1;
+    const REMOTEWIPE_CONFIRMED = 2;
+    
     protected $_skipValidatePolicyKey = true;
-
+    
     protected $_policyType;
     protected $_sendPolicyKey;
-
+    
     /**
      * @var Syncroton_Model_DeviceInformation
      */
     protected $_deviceInformation;
-
+    
     /**
-     * process the XML file and add, change, delete or fetches data
+     * process the XML file and add, change, delete or fetches data 
+     *
+     * @return resource
      */
     public function handle()
     {
         $xml = simplexml_import_dom($this->_requestBody);
-
+        
         $this->_policyType     = isset($xml->Policies->Policy->PolicyType) ? (string) $xml->Policies->Policy->PolicyType : null;
-        $this->_sendPolicyKey  = isset($xml->Policies->Policy->PolicyKey) ? (int) $xml->Policies->Policy->PolicyKey : null;
-
+        $this->_sendPolicyKey  = isset($xml->Policies->Policy->PolicyKey)  ? (int) $xml->Policies->Policy->PolicyKey     : null;
+        
         if ($this->_device->remotewipe == self::REMOTEWIPE_REQUESTED && isset($xml->RemoteWipe->Status) && (int)$xml->RemoteWipe->Status == self::STATUS_SUCCESS) {
             $this->_device->remotewipe = self::REMOTEWIPE_CONFIRMED;
         }
-
-        // try to fetch element from Settings namespace
+        
+        // try to fetch element from Settings namespace
         $settings = $xml->children('uri:Settings');
         if (isset($settings->DeviceInformation) && isset($settings->DeviceInformation->Set)) {
             $this->_deviceInformation = new Syncroton_Model_DeviceInformation($settings->DeviceInformation->Set);
-
-            $this->_device->model           = $this->_deviceInformation->model;
-            $this->_device->imei            = $this->_deviceInformation->iMEI;
-            $this->_device->friendlyname    = $this->_deviceInformation->friendlyName;
-            $this->_device->os              = $this->_deviceInformation->oS;
-            $this->_device->oslanguage      = $this->_deviceInformation->oSLanguage;
-            $this->_device->phonenumber     = $this->_deviceInformation->phoneNumber;
+            
+            $this->_device->model           = $this->_deviceInformation->model;
+            $this->_device->imei            = $this->_deviceInformation->iMEI;
+            $this->_device->friendlyname    = $this->_deviceInformation->friendlyName;
+            $this->_device->os              = $this->_deviceInformation->oS;
+            $this->_device->oslanguage      = $this->_deviceInformation->oSLanguage;
+            $this->_device->phonenumber     = $this->_deviceInformation->phoneNumber;
         }
 
         if ($this->_device->isDirty()) {
-            $this->_device = $this->_deviceBackend->update($this->_device); // @phpstan-ignore-line
+            $this->_device = $this->_deviceBackend->update($this->_device);
         }
     }
-
+    
     /**
      * generate search command response
      *
@@ -85,28 +87,27 @@
     public function getResponse()
     {
         $this->_outputDom->documentElement->setAttributeNS('http://www.w3.org/2000/xmlns/', 'xmlns:Settings', 'uri:Settings');
-
+        
         // should we wipe the device
         if ($this->_device->remotewipe >= self::REMOTEWIPE_REQUESTED) {
             $this->_sendRemoteWipe();
         } else {
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log) 
                 $this->_logger->debug(__METHOD__ . '::' . __LINE__ . ' PolicyType: ' . $this->_policyType . ' PolicyKey: ' . $this->_sendPolicyKey);
-            }
-
+            
             if (!$this->_sendPolicyKey) {
                 $this->_sendPolicy();
             } elseif ($this->_sendPolicyKey == $this->_device->policykey) {
                 $this->_acknowledgePolicy();
-            }
-        }
-
+            }       
+        } 
+            
         return $this->_outputDom;
     }
-
+    
     /**
      * function the send policy to client
-     *
+     * 
      * 4131 (Enforce password on device) 0: enabled 1: disabled
      * 4133 (Unlock from computer) 0: disabled 1: enabled
      * AEFrequencyType 0: no inactivity time 1: inactivity time is set
@@ -119,10 +120,9 @@
      */
     protected function _sendPolicy()
     {
-        if ($this->_logger instanceof Zend_Log) {
+        if ($this->_logger instanceof Zend_Log) 
             $this->_logger->info(__METHOD__ . '::' . __LINE__ . ' send policy to device');
-        }
-
+        
         $provision = $sync = $this->_outputDom->documentElement;
         $provision->appendChild($this->_outputDom->createElementNS('uri:Provision', 'Status', 1));
 
@@ -131,65 +131,61 @@
             $deviceInformation = $provision->appendChild($this->_outputDom->createElementNS('uri:Settings', 'DeviceInformation'));
             $deviceInformation->appendChild($this->_outputDom->createElementNS('uri:Settings', 'Status', 1));
         }
-
+        
         // policies
         $policies = $provision->appendChild($this->_outputDom->createElementNS('uri:Provision', 'Policies'));
         $policy = $policies->appendChild($this->_outputDom->createElementNS('uri:Provision', 'Policy'));
         $policy->appendChild($this->_outputDom->createElementNS('uri:Provision', 'PolicyType', $this->_policyType));
-
+        
         if ($this->_policyType != self::POLICYTYPE_WBXML) {
             $policy->appendChild($this->_outputDom->createElementNS('uri:Provision', 'Status', self::STATUS_POLICY_UNKNOWNTYPE));
         } elseif (empty($this->_device->policyId)) {
             $policy->appendChild($this->_outputDom->createElementNS('uri:Provision', 'Status', self::STATUS_POLICY_NOPOLICY));
         } else {
             $this->_device->policykey = $this->generatePolicyKey();
-
+            
             $policy->appendChild($this->_outputDom->createElementNS('uri:Provision', 'Status', self::STATUS_POLICY_SUCCESS));
             $policy->appendChild($this->_outputDom->createElementNS('uri:Provision', 'PolicyKey', $this->_device->policykey));
-
+            
             $data = $policy->appendChild($this->_outputDom->createElementNS('uri:Provision', 'Data'));
             $easProvisionDoc = $data->appendChild($this->_outputDom->createElementNS('uri:Provision', 'EASProvisionDoc'));
-
-            /** @var Syncroton_Model_Policy $_policy */
-            $_policy = $this->_policyBackend->get($this->_device->policyId);
-            $_policy->appendXML($easProvisionDoc, $this->_device);
-
+            $this->_policyBackend
+                ->get($this->_device->policyId)
+                ->appendXML($easProvisionDoc, $this->_device);
+            
             $this->_deviceBackend->update($this->_device);
         }
     }
-
+    
     /**
      * function the send remote wipe command
      */
     protected function _sendRemoteWipe()
     {
-        if ($this->_logger instanceof Zend_Log) {
+        if ($this->_logger instanceof Zend_Log) 
             $this->_logger->warn(__METHOD__ . '::' . __LINE__ . ' send remote wipe to device');
-        }
-
+        
         $provision = $sync = $this->_outputDom->documentElement;
         $provision->appendChild($this->_outputDom->createElementNS('uri:Provision', 'Status', 1));
         $provision->appendChild($this->_outputDom->createElementNS('uri:Provision', 'RemoteWipe'));
     }
-
+    
     protected function _acknowledgePolicy()
     {
-        if ($this->_logger instanceof Zend_Log) {
+        if ($this->_logger instanceof Zend_Log) 
             $this->_logger->info(__METHOD__ . '::' . __LINE__ . ' acknowledge policy');
-        }
-
-        /** @var Syncroton_Model_Policy $_policy */
-        $_policy = $this->_policyBackend->get($this->_device->policyId);
-
+        
+        $policykey = $this->_policyBackend->get($this->_device->policyId)->policyKey;
+        
         $provision = $sync = $this->_outputDom->documentElement;
         $provision->appendChild($this->_outputDom->createElementNS('uri:Provision', 'Status', 1));
         $policies = $provision->appendChild($this->_outputDom->createElementNS('uri:Provision', 'Policies'));
         $policy = $policies->appendChild($this->_outputDom->createElementNS('uri:Provision', 'Policy'));
         $policy->appendChild($this->_outputDom->createElementNS('uri:Provision', 'PolicyType', $this->_policyType));
         $policy->appendChild($this->_outputDom->createElementNS('uri:Provision', 'Status', 1));
-        $policy->appendChild($this->_outputDom->createElementNS('uri:Provision', 'PolicyKey', $_policy->policyKey));
+        $policy->appendChild($this->_outputDom->createElementNS('uri:Provision', 'PolicyKey', $policykey));
 
-        $this->_device->policykey = $_policy->policyKey;
+        $this->_device->policykey = $policykey;
         $this->_deviceBackend->update($this->_device);
     }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/Search.php Changed

@@ -17,8 +17,8 @@
  */
 class Syncroton_Command_Search extends Syncroton_Command_Wbxml
 {
-    public const STATUS_SUCCESS      = 1;
-    public const STATUS_SERVER_ERROR = 3;
+    const STATUS_SUCCESS      = 1;
+    const STATUS_SERVER_ERROR = 3;
 
     protected $_defaultNameSpace    = 'uri:Search';
     protected $_documentElement     = 'Search';
@@ -39,8 +39,7 @@
     {
         if (! $this->_requestBody instanceof DOMDocument) {
             throw new Syncroton_Exception_UnexpectedValue(
-                'request body is no DOMDocument. got: ' . print_r($this->_requestBody, true)
-            );
+                'request body is no DOMDocument. got: ' . print_r($this->_requestBody, true));
         }
 
         $xml = simplexml_import_dom($this->_requestBody);
@@ -55,26 +54,24 @@
     public function getResponse()
     {
         $dataController = Syncroton_Data_Factory::factory($this->_store->name, $this->_device, new DateTime());
-
-        if (! $dataController instanceof Syncroton_Data_IDataSearch) {
-            throw new RuntimeException('class must be instanceof Syncroton_Data_IDataSearch');
+        
+        if (! $dataController instanceof Syncroton_Data_IDataSearch) {
+            throw new RuntimeException('class must be instanceof Syncroton_Data_IDataSearch');
         }
-
+        
         try {
             // Search
             $storeResponse = $dataController->search($this->_store);
             $storeResponse->status = self::STATUS_SUCCESS;
         } catch (Exception $e) {
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log)
                 $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " search exception: " . $e->getMessage());
-            }
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log)
                 $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " saerch exception trace : " . $e->getTraceAsString());
-            }
-
-            $storeResponse = new Syncroton_Model_StoreResponse(
-               'status' => self::STATUS_SERVER_ERROR,
-            );
+            
+            $storeResponse = new Syncroton_Model_StoreResponse(array(
+               'status' => self::STATUS_SERVER_ERROR
+            ));
         }
 
         $search = $this->_outputDom->documentElement;

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/SendMail.php Changed

@@ -38,36 +38,35 @@
             $this->_saveInSent    = $this->_requestParameters'saveInSent';
             $this->_replaceMime   = false;
 
-            $this->_source = 
+            $this->_source = array(
                 'collectionId' => $this->_requestParameters'collectionId',
                 'itemId'       => $this->_requestParameters'itemId',
-                'instanceId'   => null,
-            ;
+                'instanceId'   => null
+            );
 
-        } elseif ($this->_requestBody) {
+        } else if ($this->_requestBody) {
             $xml = simplexml_import_dom($this->_requestBody);
 
             $this->_mime          = (string) $xml->Mime;
             $this->_saveInSent    = isset($xml->SaveInSentItems);
             $this->_replaceMime   = isset($xml->ReplaceMime);
 
-            if (isset($xml->Source)) {
+            if (isset ($xml->Source)) {
                 if ($xml->Source->LongId) {
                     $this->_source = (string)$xml->Source->LongId;
                 } else {
-                    $this->_source = 
+                    $this->_source = array(
                         'collectionId' => (string)$xml->Source->FolderId,
                         'itemId'       => (string)$xml->Source->ItemId,
-                        'instanceId'   => isset($xml->Source->InstanceId) ? (string)$xml->Source->InstanceId : null,
-                    ;
+                        'instanceId'   => isset($xml->Source->InstanceId) ? (string)$xml->Source->InstanceId : null
+                    );
                 }
             }
         }
 
         if (empty($this->_mime)) {
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log)
                 $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " Sending email failed: Empty input");
-            }
 
 
             if (version_compare($this->_device->acsversion, '14.0', '<')) {
@@ -76,9 +75,9 @@
             }
 
             $response_type = 'Syncroton_Model_' . $this->_documentElement;
-            $response      = new $response_type(
+            $response      = new $response_type(array(
                 'status' => Syncroton_Exception_Status::INVALID_CONTENT,
-            );
+            ));
 
             $response->appendXML($this->_outputDom->documentElement, $this->_device);
 
@@ -86,9 +85,8 @@
         }
 
 
-        if ($this->_logger instanceof Zend_Log) {
+        if ($this->_logger instanceof Zend_Log)
             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " saveInSent: " . (int)$this->_saveInSent);
-        }
     }
 
     /**
@@ -103,14 +101,13 @@
         try {
             $this->sendMail($dataController);
         } catch (Syncroton_Exception_Status $ses) {
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log)
                 $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " Sending email failed: " . $ses->getMessage());
-            }
 
             $response_type = 'Syncroton_Model_' . $this->_documentElement;
-            $response      = new $response_type(
+            $response      = new $response_type(array(
                 'status' => $ses->getCode(),
-            );
+            ));
 
             $response->appendXML($this->_outputDom->documentElement, $this->_device);

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/Settings.php Changed

@@ -15,13 +15,13 @@
  * @package     Syncroton
  * @subpackage  Command
  */
-class Syncroton_Command_Settings extends Syncroton_Command_Wbxml
+class Syncroton_Command_Settings extends Syncroton_Command_Wbxml 
 {
-    public const STATUS_SUCCESS = 1;
-
+    const STATUS_SUCCESS = 1;
+    
     protected $_defaultNameSpace = 'uri:Settings';
     protected $_documentElement  = 'Settings';
-
+    
     /**
      * @var Syncroton_Model_DeviceInformation
      */
@@ -30,45 +30,44 @@
     protected $_userInformationRequested = false;
     protected $_OofGet;
     protected $_OofSet;
-
-
+    
+    
     /**
-     * process the XML file and add, change, delete or fetches data
+     * process the XML file and add, change, delete or fetches data 
      *
      */
     public function handle()
     {
         $xml = simplexml_import_dom($this->_requestBody);
-
-        if (isset($xml->DeviceInformation->Set)) {
-            $this->_deviceInformation = new Syncroton_Model_DeviceInformation($xml->DeviceInformation->Set);
-
-            $this->_device->model           = $this->_deviceInformation->model;
-            $this->_device->imei            = $this->_deviceInformation->iMEI;
-            $this->_device->friendlyname    = $this->_deviceInformation->friendlyName;
-            $this->_device->os              = $this->_deviceInformation->oS;
-            $this->_device->oslanguage      = $this->_deviceInformation->oSLanguage;
-            $this->_device->phonenumber     = $this->_deviceInformation->phoneNumber;
+        
+        if(isset($xml->DeviceInformation->Set)) {
+            $this->_deviceInformation = new Syncroton_Model_DeviceInformation($xml->DeviceInformation->Set);
+            
+            $this->_device->model           = $this->_deviceInformation->model;
+            $this->_device->imei            = $this->_deviceInformation->iMEI;
+            $this->_device->friendlyname    = $this->_deviceInformation->friendlyName;
+            $this->_device->os              = $this->_deviceInformation->oS;
+            $this->_device->oslanguage      = $this->_deviceInformation->oSLanguage;
+            $this->_device->phonenumber     = $this->_deviceInformation->phoneNumber;
 
             if ($this->_device->isDirty()) {
-                // @phpstan-ignore-next-line
                 $this->_device = $this->_deviceBackend->update($this->_device);
             }
         }
-
-        if (isset($xml->UserInformation->Get)) {
+        
+        if(isset($xml->UserInformation->Get)) {
             $this->_userInformationRequested = true;
         }
 
         if (isset($xml->Oof)) {
             if (isset($xml->Oof->Get)) {
-                $this->_OofGet = 'bodyType' => $xml->Oof->Get->BodyType;
-            } elseif (isset($xml->Oof->Set)) {
+                $this->_OofGet = array('bodyType' => $xml->Oof->Get->BodyType);
+            } else if (isset($xml->Oof->Set)) {
                 $this->_OofSet = new Syncroton_Model_Oof($xml->Oof->Set);
             }
         }
     }
-
+    
     /**
      * this function generates the response for the client
      *
@@ -76,29 +75,29 @@
     public function getResponse()
     {
         $settings = $this->_outputDom->documentElement;
-
+        
         $settings->appendChild($this->_outputDom->createElementNS('uri:Settings', 'Status', self::STATUS_SUCCESS));
-
+        
         if ($this->_deviceInformation instanceof Syncroton_Model_DeviceInformation) {
             $deviceInformation = $settings->appendChild($this->_outputDom->createElementNS('uri:Settings', 'DeviceInformation'));
             $set = $deviceInformation->appendChild($this->_outputDom->createElementNS('uri:Settings', 'Set'));
             $set->appendChild($this->_outputDom->createElementNS('uri:Settings', 'Status', self::STATUS_SUCCESS));
         }
-
+        
         if ($this->_userInformationRequested === true) {
             $userInformation = $settings->appendChild($this->_outputDom->createElementNS('uri:Settings', 'UserInformation'));
             $userInformation->appendChild($this->_outputDom->createElementNS('uri:Settings', 'Status', self::STATUS_SUCCESS));
 
             $get = $userInformation->appendChild($this->_outputDom->createElementNS('uri:Settings', 'Get'));
-            /*
-                        $smtpAddresses = array();
-                        if (!empty($smtpAddresses)) {
-                            $emailAddresses = $get->appendChild($this->_outputDom->createElementNS('uri:Settings', 'EmailAddresses'));
-                            foreach($smtpAddresses as $smtpAddress) {
-                                $emailAddresses->appendChild($this->_outputDom->createElementNS('uri:Settings', 'SMTPAddress', $smtpAddress));
-                            }
-                        }
-            */
+/*
+            $smtpAddresses = array();
+            if (!empty($smtpAddresses)) {
+                $emailAddresses = $get->appendChild($this->_outputDom->createElementNS('uri:Settings', 'EmailAddresses'));
+                foreach($smtpAddresses as $smtpAddress) {
+                    $emailAddresses->appendChild($this->_outputDom->createElementNS('uri:Settings', 'SMTPAddress', $smtpAddress));
+                }
+            }
+*/
             $userAccounts = $this->_deviceBackend->userAccounts($this->_device);
             if (!empty($userAccounts)) {
                 $accounts = $get->appendChild($this->_outputDom->createElementNS('uri:Settings', 'Accounts'));
@@ -134,7 +133,7 @@
                 $Get = $Oof->appendChild($this->_outputDom->createElementNS('uri:Settings', 'Get'));
                 $OofGet->appendXML($Get, $this->_device);
             }
-        } elseif (!empty($this->_OofSet)) {
+        } else if (!empty($this->_OofSet)) {
             try {
                 $this->_deviceBackend->setOOF($this->_OofSet);
                 $OofStatus = self::STATUS_SUCCESS;

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/Sync.php Changed

@@ -15,82 +15,82 @@
  * @package     Syncroton
  * @subpackage  Command
  */
-class Syncroton_Command_Sync extends Syncroton_Command_Wbxml
+class Syncroton_Command_Sync extends Syncroton_Command_Wbxml 
 {
-    public const STATUS_SUCCESS                                = 1;
-    public const STATUS_PROTOCOL_VERSION_MISMATCH              = 2;
-    public const STATUS_INVALID_SYNC_KEY                       = 3;
-    public const STATUS_PROTOCOL_ERROR                         = 4;
-    public const STATUS_SERVER_ERROR                           = 5;
-    public const STATUS_ERROR_IN_CLIENT_SERVER_CONVERSION      = 6;
-    public const STATUS_CONFLICT_MATCHING_THE_CLIENT_AND_SERVER_OBJECT = 7;
-    public const STATUS_OBJECT_NOT_FOUND                       = 8;
-    public const STATUS_USER_ACCOUNT_MAYBE_OUT_OF_DISK_SPACE   = 9;
-    public const STATUS_ERROR_SETTING_NOTIFICATION_GUID        = 10;
-    public const STATUS_DEVICE_NOT_PROVISIONED_FOR_NOTIFICATIONS = 11;
-    public const STATUS_FOLDER_HIERARCHY_HAS_CHANGED           = 12;
-    public const STATUS_RESEND_FULL_XML                        = 13;
-    public const STATUS_WAIT_INTERVAL_OUT_OF_RANGE             = 14;
-    public const STATUS_TOO_MANY_COLLECTIONS                   = 15;
-
-    public const CONFLICT_OVERWRITE_SERVER                     = 0;
-    public const CONFLICT_OVERWRITE_PIM                        = 1;
-
-    public const MIMESUPPORT_DONT_SEND_MIME                    = 0;
-    public const MIMESUPPORT_SMIME_ONLY                        = 1;
-    public const MIMESUPPORT_SEND_MIME                         = 2;
-
-    public const BODY_TYPE_PLAIN_TEXT                          = 1;
-    public const BODY_TYPE_HTML                                = 2;
-    public const BODY_TYPE_RTF                                 = 3;
-    public const BODY_TYPE_MIME                                = 4;
-
+    const STATUS_SUCCESS                                = 1;
+    const STATUS_PROTOCOL_VERSION_MISMATCH              = 2;
+    const STATUS_INVALID_SYNC_KEY                       = 3;
+    const STATUS_PROTOCOL_ERROR                         = 4;
+    const STATUS_SERVER_ERROR                           = 5;
+    const STATUS_ERROR_IN_CLIENT_SERVER_CONVERSION      = 6;
+    const STATUS_CONFLICT_MATCHING_THE_CLIENT_AND_SERVER_OBJECT = 7;
+    const STATUS_OBJECT_NOT_FOUND                       = 8;
+    const STATUS_USER_ACCOUNT_MAYBE_OUT_OF_DISK_SPACE   = 9;
+    const STATUS_ERROR_SETTING_NOTIFICATION_GUID        = 10;
+    const STATUS_DEVICE_NOT_PROVISIONED_FOR_NOTIFICATIONS = 11;
+    const STATUS_FOLDER_HIERARCHY_HAS_CHANGED           = 12;
+    const STATUS_RESEND_FULL_XML                        = 13;
+    const STATUS_WAIT_INTERVAL_OUT_OF_RANGE             = 14;
+    const STATUS_TOO_MANY_COLLECTIONS                   = 15;
+    
+    const CONFLICT_OVERWRITE_SERVER                     = 0;
+    const CONFLICT_OVERWRITE_PIM                        = 1;
+    
+    const MIMESUPPORT_DONT_SEND_MIME                    = 0;
+    const MIMESUPPORT_SMIME_ONLY                        = 1;
+    const MIMESUPPORT_SEND_MIME                         = 2;
+    
+    const BODY_TYPE_PLAIN_TEXT                          = 1;
+    const BODY_TYPE_HTML                                = 2;
+    const BODY_TYPE_RTF                                 = 3;
+    const BODY_TYPE_MIME                                = 4;
+    
     /**
      * truncate types
      */
-    public const TRUNCATE_ALL                                  = 0;
-    public const TRUNCATE_4096                                 = 1;
-    public const TRUNCATE_5120                                 = 2;
-    public const TRUNCATE_7168                                 = 3;
-    public const TRUNCATE_10240                                = 4;
-    public const TRUNCATE_20480                                = 5;
-    public const TRUNCATE_51200                                = 6;
-    public const TRUNCATE_102400                               = 7;
-    public const TRUNCATE_NOTHING                              = 8;
-
+    const TRUNCATE_ALL                                  = 0;
+    const TRUNCATE_4096                                 = 1;
+    const TRUNCATE_5120                                 = 2;
+    const TRUNCATE_7168                                 = 3;
+    const TRUNCATE_10240                                = 4;
+    const TRUNCATE_20480                                = 5;
+    const TRUNCATE_51200                                = 6;
+    const TRUNCATE_102400                               = 7;
+    const TRUNCATE_NOTHING                              = 8;
+    
     /**
      * filter types
      */
-    public const FILTER_NOTHING        = 0;
-    public const FILTER_1_DAY_BACK     = 1;
-    public const FILTER_3_DAYS_BACK    = 2;
-    public const FILTER_1_WEEK_BACK    = 3;
-    public const FILTER_2_WEEKS_BACK   = 4;
-    public const FILTER_1_MONTH_BACK   = 5;
-    public const FILTER_3_MONTHS_BACK  = 6;
-    public const FILTER_6_MONTHS_BACK  = 7;
-    public const FILTER_INCOMPLETE     = 8;
-
-
+    const FILTER_NOTHING        = 0;
+    const FILTER_1_DAY_BACK     = 1;
+    const FILTER_3_DAYS_BACK    = 2;
+    const FILTER_1_WEEK_BACK    = 3;
+    const FILTER_2_WEEKS_BACK   = 4;
+    const FILTER_1_MONTH_BACK   = 5;
+    const FILTER_3_MONTHS_BACK  = 6;
+    const FILTER_6_MONTHS_BACK  = 7;
+    const FILTER_INCOMPLETE     = 8;
+    
+    
     protected $_defaultNameSpace    = 'uri:AirSync';
     protected $_documentElement     = 'Sync';
-
+    
     /**
      * list of collections
      *
-     * @var array<string,Syncroton_Model_SyncCollection>
+     * @var array
      */
-    protected $_collections = ;
-
-    protected $_modifications = ;
-
+    protected $_collections = array();
+    
+    protected $_modifications = array();
+    
     /**
      * the global WindowSize
      *
      * @var integer
      */
     protected $_globalWindowSize;
-
+    
     /**
      * there are more entries than WindowSize available
      * the MoreAvailable tag hot added to the xml output
@@ -98,65 +98,64 @@
      * @var boolean
      */
     protected $_moreAvailable = false;
-
+    
     protected $_maxWindowSize = 100;
-
+    
     protected $_heartbeatInterval = null;
-
+    
     /**
-     * process the XML file and add, change, delete or fetches data
+     * process the XML file and add, change, delete or fetches data 
      */
     public function handle()
     {
         // input xml
         $requestXML = simplexml_import_dom($this->_mergeSyncRequest($this->_requestBody, $this->_device));
-
+        
         if (! isset($requestXML->Collections)) {
             $this->_outputDom->documentElement->appendChild(
                 $this->_outputDom->createElementNS('uri:AirSync', 'Status', self::STATUS_RESEND_FULL_XML)
             );
-
+            
             return $this->_outputDom;
         }
-
-        $intervalDiv = 1;
+        
         if (isset($requestXML->HeartbeatInterval)) {
             $intervalDiv = 1;
             $this->_heartbeatInterval = (int)$requestXML->HeartbeatInterval;
-        } elseif (isset($requestXML->Wait)) {
+        } else if (isset($requestXML->Wait)) {
             $intervalDiv = 60;
             $this->_heartbeatInterval = (int)$requestXML->Wait * $intervalDiv;
         }
-
+        
         $maxInterval = Syncroton_Registry::getPingInterval();
         if ($maxInterval <= 0 || $maxInterval > Syncroton_Server::MAX_HEARTBEAT_INTERVAL) {
             $maxInterval = Syncroton_Server::MAX_HEARTBEAT_INTERVAL;
         }
-
+        
         if ($this->_heartbeatInterval && $this->_heartbeatInterval > $maxInterval) {
             $sync = $this->_outputDom->documentElement;
             $sync->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'Status', self::STATUS_WAIT_INTERVAL_OUT_OF_RANGE));
-            $sync->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'Limit', floor($maxInterval / $intervalDiv)));
+            $sync->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'Limit', floor($maxInterval/$intervalDiv)));
             $this->_heartbeatInterval = null;
             return;
         }
-
+        
         $this->_globalWindowSize = isset($requestXML->WindowSize) ? (int)$requestXML->WindowSize : 100;
 
         if (!$this->_globalWindowSize || $this->_globalWindowSize > 512) {
             $this->_globalWindowSize = 512;
         }
-
+        
         if ($this->_globalWindowSize > $this->_maxWindowSize) {
             $this->_globalWindowSize = $this->_maxWindowSize;
         }
-
+        
         // load options from lastsynccollection
-        $lastSyncCollection = 'options' => ;
+        $lastSyncCollection = array('options' => array());
         if (!empty($this->_device->lastsynccollection)) {
             $lastSyncCollection = Zend_Json::decode($this->_device->lastsynccollection);
             if (!array_key_exists('options', $lastSyncCollection) || !is_array($lastSyncCollection'options')) {
-                $lastSyncCollection'options' = ;
+                $lastSyncCollection'options' = array();
             }
         }
 
@@ -168,117 +167,111 @@
             return;
         }
 
-        $collections = ;
-
+        $collections = array();
+        
         foreach ($requestXML->Collections->Collection as $xmlCollection) {
             $collectionId = (string)$xmlCollection->CollectionId;
-
+            
             $collections$collectionId = new Syncroton_Model_SyncCollection($xmlCollection);
-
+            
             // do we have to reuse the options from the previous request?
             if (!isset($xmlCollection->Options) && array_key_exists($collectionId, $lastSyncCollection'options')) {
                 $collections$collectionId->options = $lastSyncCollection'options'$collectionId;
-                if ($this->_logger instanceof Zend_Log) {
-                    $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " restored options to " . print_r($collections$collectionId->options, true));
-                }
+                if ($this->_logger instanceof Zend_Log)
+                    $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " restored options to " . print_r($collections$collectionId->options, TRUE));
             }
-
+            
             // store current options for next Sync command request (sticky options)
             $lastSyncCollection'options'$collectionId = $collections$collectionId->options;
         }
-
+        
         $this->_device->lastsynccollection = Zend_Json::encode($lastSyncCollection);
-
+        
         if ($this->_device->isDirty()) {
             Syncroton_Registry::getDeviceBackend()->update($this->_device);
         }
-
+        
         foreach ($collections as $collectionData) {
             // has the folder been synchronised to the device already
             try {
                 $collectionData->folder = $this->_folderBackend->getFolder($this->_device, $collectionData->collectionId);
-
+                
             } catch (Syncroton_Exception_NotFound $senf) {
-                if ($this->_logger instanceof Zend_Log) {
+                if ($this->_logger instanceof Zend_Log) 
                     $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " folder {$collectionData->collectionId} not found");
-                }
-
+                
                 // trigger INVALID_SYNCKEY instead of OBJECT_NOTFOUND when synckey is higher than 0
                 // to avoid a syncloop for the iPhone
                 if ($collectionData->syncKey > 0) {
-                    $collectionData->folder    = new Syncroton_Model_Folder(
+                    $collectionData->folder    = new Syncroton_Model_Folder(array(
                         'deviceId' => $this->_device,
-                        'serverId' => $collectionData->collectionId,
-                    );
+                        'serverId' => $collectionData->collectionId
+                    ));
                 }
-
+                
                 $this->_collections$collectionData->collectionId = $collectionData;
-
+                
                 continue;
             }
-
-            if ($this->_logger instanceof Zend_Log) {
+            
+            if ($this->_logger instanceof Zend_Log) 
                 $this->_logger->info(__METHOD__ . '::' . __LINE__ . " SyncKey is {$collectionData->syncKey} Class: {$collectionData->folder->class} CollectionId: {$collectionData->collectionId}");
-            }
-
+            
             // initial synckey
             if($collectionData->syncKey === 0) {
-                if ($this->_logger instanceof Zend_Log) {
+                if ($this->_logger instanceof Zend_Log) 
                     $this->_logger->info(__METHOD__ . '::' . __LINE__ . " initial client synckey 0 provided");
-                }
-
+                
                 // reset sync state for this folder
                 $this->_syncStateBackend->resetState($this->_device, $collectionData->folder);
                 $this->_contentStateBackend->resetState($this->_device, $collectionData->folder);
-
-                $collectionData->syncState    = new Syncroton_Model_SyncState(
+            
+                $collectionData->syncState    = new Syncroton_Model_SyncState(array(
                     'device_id' => $this->_device,
                     'counter'   => 0,
                     'type'      => $collectionData->folder,
-                    'lastsync'  => $this->_syncTimeStamp,
-                );
-
+                    'lastsync'  => $this->_syncTimeStamp
+                ));
+                
                 $this->_collections$collectionData->collectionId = $collectionData;
-
+                
                 continue;
             }
-
+            
             $syncKeyReused = $this->_syncStateBackend->haveNext($this->_device, $collectionData->folder, $collectionData->syncKey);
             if ($syncKeyReused) {
-                if ($this->_logger instanceof Zend_Log) {
+                if ($this->_logger instanceof Zend_Log) 
                     $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " already known synckey {$collectionData->syncKey} provided");
-                }
             }
             // check for invalid synckey
             if(($collectionData->syncState = $this->_syncStateBackend->validate($this->_device, $collectionData->folder, $collectionData->syncKey)) === false) {
-                if ($this->_logger instanceof Zend_Log) {
+                if ($this->_logger instanceof Zend_Log) 
                     $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " invalid synckey {$collectionData->syncKey} provided");
-                }
-
+                
                 // reset sync state for this folder
                 $this->_syncStateBackend->resetState($this->_device, $collectionData->folder);
                 $this->_contentStateBackend->resetState($this->_device, $collectionData->folder);
-
+                
                 $this->_collections$collectionData->collectionId = $collectionData;
-
+                
                 continue;
             }
-
+            
             $dataController = Syncroton_Data_Factory::factory($collectionData->folder->class, $this->_device, $this->_syncTimeStamp);
-
+            
             switch($collectionData->folder->class) {
                 case Syncroton_Data_Factory::CLASS_CALENDAR:
                     $dataClass = 'Syncroton_Model_Event';
                     break;
-
+                    
                 case Syncroton_Data_Factory::CLASS_CONTACTS:
                     $dataClass = 'Syncroton_Model_Contact';
                     break;
-
+                    
                 case Syncroton_Data_Factory::CLASS_EMAIL:
                     $dataClass = 'Syncroton_Model_Email';
                     break;
-
+                    
                 case Syncroton_Data_Factory::CLASS_NOTES:
                     $dataClass = 'Syncroton_Model_Note';
                     break;
@@ -286,43 +279,41 @@
                 case Syncroton_Data_Factory::CLASS_TASKS:
                     $dataClass = 'Syncroton_Model_Task';
                     break;
-
+                    
                 default:
                     throw new Syncroton_Exception_UnexpectedValue('invalid class provided');
+                    break;
             }
-
-            $clientModifications = 
-                'added'            => ,
-                'changed'          => ,
-                'deleted'          => ,
-                'forceAdd'         => ,
-                'forceChange'      => ,
-                'toBeFetched'      => ,
-            ;
-
+            
+            $clientModifications = array(
+                'added'            => array(),
+                'changed'          => array(),
+                'deleted'          => array(),
+                'forceAdd'         => array(),
+                'forceChange'      => array(),
+                'toBeFetched'      => array(),
+            );
+            
             // handle incoming data
             if($collectionData->hasClientAdds()) {
                 $adds = $collectionData->getClientAdds();
-
-                if ($this->_logger instanceof Zend_Log) {
+                
+                if ($this->_logger instanceof Zend_Log) 
                     $this->_logger->info(__METHOD__ . '::' . __LINE__ . " found " . count($adds) . " entries to be added to server");
-                }
-
+                
                 $clientIdMap = ;
                 if ($syncKeyReused && $collectionData->syncState->clientIdMap) {
                     $clientIdMap = Zend_Json::decode($collectionData->syncState->clientIdMap);
                 }
 
                 foreach ($adds as $add) {
-                    if ($this->_logger instanceof Zend_Log) {
+                    if ($this->_logger instanceof Zend_Log) 
                         $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " add entry with clientId " . (string) $add->ClientId);
-                    }
 
                     try {
-                        if ($this->_logger instanceof Zend_Log) {
+                        if ($this->_logger instanceof Zend_Log) 
                             $this->_logger->info(__METHOD__ . '::' . __LINE__ . " adding entry as new");
-                        }
-
+                        
                         $clientId = (string)$add->ClientId;
                         // If the sync key was reused, but we don't have a $clientId mapping,
                         // this means the client sent a new item with the same sync_key.
@@ -331,229 +322,134 @@
                             // we have to look-up the corresponding serverId using a cached clientId => serverId mapping,
                             // otherwise we would duplicate all added items on resend.
                             $serverId = $clientIdMap$clientId;
-                            $clientModifications'added'$serverId = 
+                            $clientModifications'added'$serverId = array(
                                 'clientId'     => (string)$add->ClientId,
                                 'serverId'     => $serverId,
                                 'status'       => self::STATUS_SUCCESS,
-                                'contentState' => null,
-                            ;
+                                'contentState' => null
+                            );
                         } else {
                             $serverId = $dataController->createEntry($collectionData->collectionId, new $dataClass($add->ApplicationData));
-                            $clientModifications'added'$serverId = 
+                            $clientModifications'added'$serverId = array(
                                 'clientId'     => (string)$add->ClientId,
                                 'serverId'     => $serverId,
                                 'status'       => self::STATUS_SUCCESS,
-                                'contentState' => $this->_contentStateBackend->create(new Syncroton_Model_Content(
+                                'contentState' => $this->_contentStateBackend->create(new Syncroton_Model_Content(array(
                                     'device_id'        => $this->_device,
                                     'folder_id'        => $collectionData->folder,
                                     'contentid'        => $serverId,
                                     'creation_time'    => $this->_syncTimeStamp,
-                                    'creation_synckey' => $collectionData->syncKey + 1,
-                                )),
-                            ;
+                                    'creation_synckey' => $collectionData->syncKey + 1
+                                )))
+                            );
                         }
-
+                        
                     } catch (Exception $e) {
-                        if ($this->_logger instanceof Zend_Log) {
+                        if ($this->_logger instanceof Zend_Log) 
                             $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " failed to add entry " . $e->getMessage());
-                        }
-                        $clientModifications'added' = 
+                        $clientModifications'added' = array(
                             'clientId' => (string)$add->ClientId,
-                            'status'   => self::STATUS_SERVER_ERROR,
-                        ;
+                            'status'   => self::STATUS_SERVER_ERROR
+                        );
                     }
                 }
             }
-
+            
             // handle changes, but only if not first sync
             if(!$syncKeyReused && $collectionData->syncKey > 1 && $collectionData->hasClientChanges()) {
                 $changes = $collectionData->getClientChanges();
-
-                if ($this->_logger instanceof Zend_Log) {
+                
+                if ($this->_logger instanceof Zend_Log) 
                     $this->_logger->info(__METHOD__ . '::' . __LINE__ . " found " . count($changes) . " entries to be updated on server");
-                }
-
+                
                 foreach ($changes as $change) {
                     $serverId = (string)$change->ServerId;
-
+                    
                     try {
                         $dataController->updateEntry($collectionData->collectionId, $serverId, new $dataClass($change->ApplicationData));
                         $clientModifications'changed'$serverId = self::STATUS_SUCCESS;
-
+                        
                     } catch (Syncroton_Exception_AccessDenied $e) {
                         $clientModifications'changed'$serverId = self::STATUS_CONFLICT_MATCHING_THE_CLIENT_AND_SERVER_OBJECT;
                         $clientModifications'forceChange'$serverId = $serverId;
-
+                        
                     } catch (Syncroton_Exception_NotFound $e) {
                         // entry does not exist anymore, will get deleted automaticaly
                         $clientModifications'changed'$serverId = self::STATUS_OBJECT_NOT_FOUND;
-
+                        
                     } catch (Exception $e) {
-                        if ($this->_logger instanceof Zend_Log) {
+                        if ($this->_logger instanceof Zend_Log) 
                             $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " failed to update entry " . $e);
-                        }
                         // something went wrong while trying to update the entry
                         $clientModifications'changed'$serverId = self::STATUS_SERVER_ERROR;
                     }
                 }
             }
-
+            
             // handle deletes, but only if not first sync
             if(!$syncKeyReused && $collectionData->hasClientDeletes()) {
                 $deletes = $collectionData->getClientDeletes();
-                if ($this->_logger instanceof Zend_Log) {
+                if ($this->_logger instanceof Zend_Log) 
                     $this->_logger->info(__METHOD__ . '::' . __LINE__ . " found " . count($deletes) . " entries to be deleted on server");
-                }
-
+                
                 foreach ($deletes as $delete) {
                     $serverId = (string)$delete->ServerId;
-
+                    
                     try {
                         // check if we have sent this entry to the phone
                         $state = $this->_contentStateBackend->getContentState($this->_device, $collectionData->folder, $serverId);
-
+                        
                         try {
                             $dataController->deleteEntry($collectionData->collectionId, $serverId, $collectionData);
-
+                            
                         } catch(Syncroton_Exception_NotFound $e) {
-                            if ($this->_logger instanceof Zend_Log) {
+                            if ($this->_logger instanceof Zend_Log) 
                                 $this->_logger->crit(__METHOD__ . '::' . __LINE__ . ' tried to delete entry ' . $serverId . ' but entry was not found');
-                            }
-
+                            
                         } catch (Syncroton_Exception $e) {
-                            if ($this->_logger instanceof Zend_Log) {
+                            if ($this->_logger instanceof Zend_Log) 
                                 $this->_logger->info(__METHOD__ . '::' . __LINE__ . ' tried to delete entry ' . $serverId . ' but a error occured: ' . $e->getMessage());
-                            }
                             $clientModifications'forceAdd'$serverId = $serverId;
                         }
                         $this->_contentStateBackend->delete($state);
-
+                        
                     } catch (Syncroton_Exception_NotFound $senf) {
-                        if ($this->_logger instanceof Zend_Log) {
+                        if ($this->_logger instanceof Zend_Log) 
                             $this->_logger->info(__METHOD__ . '::' . __LINE__ . ' ' . $serverId . ' should have been removed from client already');
-                        }
                         // should we send a special status???
                         //$collectionData->deleted$serverId = self::STATUS_SUCCESS;
                     }
-
+                    
                     $clientModifications'deleted'$serverId = self::STATUS_SUCCESS;
                 }
             }
-
+            
             // handle fetches, but only if not first sync
             if($collectionData->syncKey > 1 && $collectionData->hasClientFetches()) {
                 // the default value for GetChanges is 1. If the phone don't want the changes it must set GetChanges to 0
                 // some prevoius versions of iOS did not set GetChanges to 0 for fetches. Let's enforce getChanges to false here.
                 $collectionData->getChanges = false;
-
+                
                 $fetches = $collectionData->getClientFetches();
-                if ($this->_logger instanceof Zend_Log) {
+                if ($this->_logger instanceof Zend_Log) 
                     $this->_logger->info(__METHOD__ . '::' . __LINE__ . " found " . count($fetches) . " entries to be fetched from server");
-                }
-
-                $toBeFetched = ;
-
+                
+                $toBeFetched = array();
+                
                 foreach ($fetches as $fetch) {
                     $serverId = (string)$fetch->ServerId;
-
+                    
                     $toBeFetched$serverId = $serverId;
                 }
-
+                
                 $collectionData->toBeFetched = $toBeFetched;
             }
-
+            
             $this->_collections$collectionData->collectionId = $collectionData;
             $this->_modifications$collectionData->collectionId = $clientModifications;
         }
     }
-
-    private function getServerModifications($dataController, $collectionData, $clientModifications)
-    {
-        $serverModifications = 
-            'added'   => ,
-            'changed' => ,
-            'deleted' => ,
-        ;
-
-        // We first use hasChanges because it has a fast path for when there are no changes by fetching the count of messages only.
-        // However, in all other cases we will end up fetching the same entries as below, which is less than ideal.
-        // TODO: We should create a new method, which checks if there are no changes, and otherwise just let the code below figure out
-        // if there are any changes to process.
-        if (!$dataController->hasChanges($this->_contentStateBackend, $collectionData->folder, $collectionData->syncState)) {
-            return $serverModifications;
-        }
-
-        // update _syncTimeStamp as $dataController->hasChanges might have spent some time
-        $this->_syncTimeStamp = new DateTime('now', new DateTimeZone('UTC'));
-
-        // fetch entries added since last sync
-        $allClientEntries = $this->_contentStateBackend->getFolderState(
-            $this->_device,
-            $collectionData->folder,
-            $collectionData->syncState->counter
-        );
-
-        // fetch entries changed since last sync
-        $allChangedEntries = $dataController->getChangedEntries(
-            $collectionData->collectionId,
-            $collectionData->syncState,
-            $collectionData->options'filterType'
-        );
-
-        // fetch all entries
-        $allServerEntries = $dataController->getServerEntries(
-            $collectionData->collectionId,
-            $collectionData->options'filterType'
-        );
-
-        // add entries
-        $serverDiff = array_diff($allServerEntries, $allClientEntries);
-        // add entries which produced problems during delete from client
-        $serverModifications'added' = $clientModifications'forceAdd';
-        // add entries not yet sent to client
-        $serverModifications'added' = array_unique(array_merge($serverModifications'added', $serverDiff));
-
-        // @todo still needed?
-        foreach($serverModifications'added' as $id => $serverId) {
-            // skip entries added by client during this sync session
-            if(isset($clientModifications'added'$serverId) && !isset($clientModifications'forceAdd'$serverId)) {
-                if ($this->_logger instanceof Zend_Log) {
-                    $this->_logger->info(__METHOD__ . '::' . __LINE__ . " skipped added entry: " . $serverId);
-                }
-                unset($serverModifications'added'$id);
-            }
-        }
-
-        // entries to be deleted
-        $serverModifications'deleted' = array_diff($allClientEntries, $allServerEntries);
-
-        // entries changed since last sync
-        $serverModifications'changed' = array_merge($allChangedEntries, $clientModifications'forceChange');
-
-        foreach($serverModifications'changed' as $id => $serverId) {
-            // skip entry, if it got changed by client during current sync
-            if(isset($clientModifications'changed'$serverId) && !isset($clientModifications'forceChange'$serverId)) {
-                if ($this->_logger instanceof Zend_Log) {
-                    $this->_logger->info(__METHOD__ . '::' . __LINE__ . " skipped changed entry: " . $serverId);
-                }
-                unset($serverModifications'changed'$id);
-            }
-            // skip entry, make sure we don't sent entries already added by client in this request
-            elseif (isset($clientModifications'added'$serverId) && !isset($clientModifications'forceAdd'$serverId)) {
-                if ($this->_logger instanceof Zend_Log) {
-                    $this->_logger->info(__METHOD__ . '::' . __LINE__ . " skipped change for added entry: " . $serverId);
-                }
-                unset($serverModifications'changed'$id);
-            }
-        }
-
-        // entries comeing in scope are already in $serverModifications'added' and do not need to
-        // be send with $serverCanges
-        $serverModifications'changed' = array_diff($serverModifications'changed', $serverModifications'added');
-
-        return $serverModifications;
-    }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Command_Wbxml::getResponse()
@@ -561,20 +457,20 @@
     public function getResponse()
     {
         $sync = $this->_outputDom->documentElement;
-
+        
         $collections = $this->_outputDom->createElementNS('uri:AirSync', 'Collections');
 
         $totalChanges = 0;
 
         // Detect devices that do not support empty Sync reponse
         $emptySyncSupported = !preg_match('/(meego|nokian800)/i', $this->_device->useragent);
-
+        
         // continue only if there are changes or no time is left
         if ($this->_heartbeatInterval > 0) {
             $intervalStart  = time();
             $sleepCallback  = Syncroton_Registry::getSleepCallback();
             $wakeupCallback = Syncroton_Registry::getWakeupCallback();
-
+            
             do {
                 // take a break to save battery lifetime
                 $sleepCallback();
@@ -582,94 +478,90 @@
 
                 // make sure the connection is still alive, abort otherwise
                 if (connection_aborted()) {
-                    if ($this->_logger instanceof Zend_Log) {
+                    if ($this->_logger instanceof Zend_Log)
                         $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " Exiting on aborted connection");
-                    }
                     exit;
                 }
 
                 $wakeupCallback();
-
+                
                 $now = new DateTime('now', new DateTimeZone('UTC'));
 
                 foreach($this->_collections as $collectionData) {
-                    // continue immediately if folder does not exist
+                    // continue immediately if folder does not exist 
                     if (! ($collectionData->folder instanceof Syncroton_Model_IFolder)) {
                         break 2;
-
-                        // countinue immediately if syncstate is invalid
+                        
+                    // countinue immediately if syncstate is invalid
                     } elseif (! ($collectionData->syncState instanceof Syncroton_Model_ISyncState)) {
                         break 2;
-
+                        
                     } else {
                         if ($collectionData->getChanges !== true) {
                             continue;
                         }
-
+                        
                         try {
                             // just check if the folder still exists
                             $this->_folderBackend->get($collectionData->folder);
                         } catch (Syncroton_Exception_NotFound $senf) {
-                            if ($this->_logger instanceof Zend_Log) {
+                            if ($this->_logger instanceof Zend_Log)
                                 $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " collection does not exist anymore: " . $collectionData->collectionId);
-                            }
-
+                            
                             $collectionData->getChanges = false;
-
+                            
                             // make sure this is the last while loop
                             // no break 2 here, as we like to check the other folders too
                             $intervalStart -= $this->_heartbeatInterval;
                         }
-
+                        
                         // check that the syncstate still exists and is still valid
                         try {
                             $syncState = $this->_syncStateBackend->getSyncState($this->_device, $collectionData->folder);
-
+                            
                             // another process synchronized data of this folder already. let's skip it
                             if ($syncState->id !== $collectionData->syncState->id) {
-                                if ($this->_logger instanceof Zend_Log) {
+                                if ($this->_logger instanceof Zend_Log)
                                     $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " syncstate changed during heartbeat interval for collection: " . $collectionData->folder->serverId);
-                                }
-
+                                
                                 $collectionData->getChanges = false;
-
+                                
                                 // make sure this is the last while loop
                                 // no break 2 here, as we like to check the other folders too
                                 $intervalStart -= $this->_heartbeatInterval;
                             }
                         } catch (Syncroton_Exception_NotFound $senf) {
-                            if ($this->_logger instanceof Zend_Log) {
+                            if ($this->_logger instanceof Zend_Log)
                                 $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " no syncstate found anymore for collection: " . $collectionData->folder->serverId);
-                            }
-
+                            
                             $collectionData->syncState = null;
-
+                            
                             // make sure this is the last while loop
                             // no break 2 here, as we like to check the other folders too
                             $intervalStart -= $this->_heartbeatInterval;
                         }
-
-
+                        
+                        
                         // safe battery time by skipping folders which got synchronied less than Syncroton_Command_Ping::$quietTime seconds ago
-                        if (! $collectionData->syncState instanceof Syncroton_Model_SyncState ||
+                        if ( ! $collectionData->syncState instanceof Syncroton_Model_SyncState ||
                              ($now->getTimestamp() - $collectionData->syncState->lastsync->getTimestamp()) < Syncroton_Registry::getQuietTime()) {
                             continue;
                         }
-
-                        $dataController = Syncroton_Data_Factory::factory($collectionData->folder->class, $this->_device, $this->_syncTimeStamp);
-
+                        
+                        $dataController = Syncroton_Data_Factory::factory($collectionData->folder->class , $this->_device, $this->_syncTimeStamp);
+                        
                         // countinue immediately if there are any changes available
                         if($dataController->hasChanges($this->_contentStateBackend, $collectionData->folder, $collectionData->syncState)) {
                             break 2;
                         }
                     }
                 }
-
-                // See: http://www.tine20.org/forum/viewtopic.php?f=12&t=12146
-                //
-                // break if there are less than PingTimeout + 10 seconds left for the next loop
-                // otherwise the response will be returned after the client has finished his Ping
-                // request already maybe
+                
+            // See: http://www.tine20.org/forum/viewtopic.php?f=12&t=12146
+            //
+            // break if there are less than PingTimeout + 10 seconds left for the next loop
+            // otherwise the response will be returned after the client has finished his Ping
+            // request already maybe
             } while (Syncroton_Server::validateSession() && time() - $intervalStart < $this->_heartbeatInterval - (Syncroton_Registry::getPingTimeout() + 10));
         }
 
@@ -677,47 +569,27 @@
         foreach ($this->_collections as $collectionData) {
             if (! ($collectionData->folder instanceof Syncroton_Model_IFolder)) {
 
-                if ($this->_logger instanceof Zend_Log) {
+                if ($this->_logger instanceof Zend_Log)
                     $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " Detected a folder hierarchy change on {$collectionData->collectionId}.");
-                }
 
                 $sync->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'Status', self::STATUS_FOLDER_HIERARCHY_HAS_CHANGED));
                 return $this->_outputDom;
             }
         }
 
-        // Handle Calendar folders first.
-        // Outlook can't match MeetingRequest with an event that wasn't synced yet, which
-        // leads to duplicated events in Outlook's calendar.
-        uasort(
-            $this->_collections,
-            function ($a, $b) {
-                $ac = $a->folder && $a->folder->class == Syncroton_Data_Factory::CLASS_CALENDAR;
-                $bc = $b->folder && $b->folder->class == Syncroton_Data_Factory::CLASS_CALENDAR;
-                if ($ac) {
-                    return $bc ? 0 : -1;
-                }
-                return $bc ? 1 : 0;
-            }
-        );
-
-        foreach ($this->_collections as $collectionData) {
-            if ($this->_logger instanceof Zend_Log) {
-                $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " Processing {$collectionData->collectionId}...");
-            }
-
+        foreach($this->_collections as $collectionData) {
             $collectionChanges = 0;
-
+            
             /**
              * keep track of entries added on server side
              */
-            $newContentStates = ;
-
+            $newContentStates = array();
+            
             /**
              * keep track of entries deleted on server side
              */
-            $deletedContentStates = ;
-
+            $deletedContentStates = array();
+            
             // invalid synckey provided
             if (! ($collectionData->syncState instanceof Syncroton_Model_ISyncState)) {
                 // set synckey to 0
@@ -725,8 +597,8 @@
                 $collection->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'SyncKey', 0));
                 $collection->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'CollectionId', $collectionData->collectionId));
                 $collection->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'Status', self::STATUS_INVALID_SYNC_KEY));
-
-                // initial sync
+                
+            // initial sync
             } elseif ($collectionData->syncState->counter === 0) {
                 $collectionData->syncState->counter++;
 
@@ -739,51 +611,126 @@
                 $collection->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'SyncKey', $collectionData->syncState->counter));
                 $collection->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'CollectionId', $collectionData->collectionId));
                 $collection->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'Status', self::STATUS_SUCCESS));
+                
             } else {
-                $dataController = Syncroton_Data_Factory::factory($collectionData->folder->class, $this->_device, $this->_syncTimeStamp);
 
+                $dataController = Syncroton_Data_Factory::factory($collectionData->folder->class , $this->_device, $this->_syncTimeStamp);
+                
                 $clientModifications = $this->_modifications$collectionData->collectionId;
-                $serverModifications = 
-                    'added'   => ,
-                    'changed' => ,
-                    'deleted' => ,
-                ;
+                $serverModifications = array(
+                    'added'   => array(),
+                    'changed' => array(),
+                    'deleted' => array(),
+                );
 
                 $status = self::STATUS_SUCCESS;
+                $hasChanges = 0;
 
-                if ($collectionData->getChanges === true) {
+                if($collectionData->getChanges === true) {
                     // continue sync session?
                     if(is_array($collectionData->syncState->pendingdata)) {
+                        if ($this->_logger instanceof Zend_Log)
+                            $this->_logger->info(__METHOD__ . '::' . __LINE__ . " restored from sync state ");
+
                         $serverModifications = $collectionData->syncState->pendingdata;
-                        if ($this->_logger instanceof Zend_Log) {
-                            $this->_logger->info(__METHOD__ . '::' . __LINE__ . " restored from sync state.");
-                        }
                     } else {
                         try {
-                            $serverModifications = $this->getServerModifications($dataController, $collectionData, $clientModifications);
+                            $hasChanges = $dataController->hasChanges($this->_contentStateBackend, $collectionData->folder, $collectionData->syncState);
                         } catch (Syncroton_Exception_NotFound $e) {
-                            if ($this->_logger instanceof Zend_Log) {
+                            if ($this->_logger instanceof Zend_Log)
                                 $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " Folder changes checking failed (not found): " . $e->getTraceAsString());
-                            }
 
                             $status = self::STATUS_FOLDER_HIERARCHY_HAS_CHANGED;
                         } catch (Exception $e) {
-                            if ($this->_logger instanceof Zend_Log) {
+                            if ($this->_logger instanceof Zend_Log)
                                 $this->_logger->crit(__METHOD__ . '::' . __LINE__ . " Folder changes checking failed: " . $e->getMessage());
+
+                            // Prevent from removing client entries when getServerEntries() fails
+                            // @todo: should we break the loop here?
+                            $status = self::STATUS_SERVER_ERROR;
+                        }
+                    }
+
+                    if ($hasChanges) {
+                        // update _syncTimeStamp as $dataController->hasChanges might have spent some time
+                        $this->_syncTimeStamp = new DateTime('now', new DateTimeZone('UTC'));
+
+                        try {
+                            // fetch entries added since last sync
+                            $allClientEntries = $this->_contentStateBackend->getFolderState(
+                                $this->_device,
+                                $collectionData->folder,
+                                $collectionData->syncState->counter
+                            );
+
+                            // fetch entries changed since last sync
+                            $allChangedEntries = $dataController->getChangedEntries(
+                                $collectionData->collectionId,
+                                $collectionData->syncState->lastsync,
+                                $this->_syncTimeStamp,
+                                $collectionData->options'filterType'
+                            );
+
+                            // fetch all entries
+                            $allServerEntries = $dataController->getServerEntries(
+                                $collectionData->collectionId,
+                                $collectionData->options'filterType'
+                            );
+
+                            // add entries
+                            $serverDiff = array_diff($allServerEntries, $allClientEntries);
+                            // add entries which produced problems during delete from client
+                            $serverModifications'added' = $clientModifications'forceAdd';
+                            // add entries not yet sent to client
+                            $serverModifications'added' = array_unique(array_merge($serverModifications'added', $serverDiff));
+
+                            // @todo still needed?
+                            foreach($serverModifications'added' as $id => $serverId) {
+                                // skip entries added by client during this sync session
+                                if(isset($clientModifications'added'$serverId) && !isset($clientModifications'forceAdd'$serverId)) {
+                                    if ($this->_logger instanceof Zend_Log)
+                                        $this->_logger->info(__METHOD__ . '::' . __LINE__ . " skipped added entry: " . $serverId);
+                                    unset($serverModifications'added'$id);
+                                }
                             }
 
-                            if ($this->_logger instanceof Zend_Log) {
-                                $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " Folder state checking failed: " . $e->getTraceAsString());
+                            // entries to be deleted
+                            $serverModifications'deleted' = array_diff($allClientEntries, $allServerEntries);
+
+                            // entries changed since last sync
+                            $serverModifications'changed' = array_merge($allChangedEntries, $clientModifications'forceChange');
+
+                            foreach($serverModifications'changed' as $id => $serverId) {
+                                // skip entry, if it got changed by client during current sync
+                                if(isset($clientModifications'changed'$serverId) && !isset($clientModifications'forceChange'$serverId)) {
+                                     if ($this->_logger instanceof Zend_Log)
+                                         $this->_logger->info(__METHOD__ . '::' . __LINE__ . " skipped changed entry: " . $serverId);
+                                    unset($serverModifications'changed'$id);
+                                }
+                                // skip entry, make sure we don't sent entries already added by client in this request
+                                else if (isset($clientModifications'added'$serverId) && !isset($clientModifications'forceAdd'$serverId)) {
+                                    if ($this->_logger instanceof Zend_Log)
+                                        $this->_logger->info(__METHOD__ . '::' . __LINE__ . " skipped change for added entry: " . $serverId);
+                                    unset($serverModifications'changed'$id);
+                                }
                             }
 
+                            // entries comeing in scope are already in $serverModifications'added' and do not need to
+                            // be send with $serverCanges
+                            $serverModifications'changed' = array_diff($serverModifications'changed', $serverModifications'added');
+                        } catch (Exception $e) {
+                            if ($this->_logger instanceof Zend_Log)
+                                $this->_logger->crit(__METHOD__ . '::' . __LINE__ . " Folder state checking failed: " . $e->getMessage());
+                            if ($this->_logger instanceof Zend_Log)
+                                $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " Folder state checking failed: " . $e->getTraceAsString());
+
                             // Prevent from removing client entries when getServerEntries() fails
                             // @todo: should we break the loop here?
                             $status = self::STATUS_SERVER_ERROR;
                         }
-                    }
 
-                    if ($this->_logger instanceof Zend_Log) {
-                        $this->_logger->info(__METHOD__ . '::' . __LINE__ . " found (added/changed/deleted) " . count($serverModifications'added') . '/' . count($serverModifications'changed') . '/' . count($serverModifications'deleted') . ' entries for sync from server to client');
+                        if ($this->_logger instanceof Zend_Log)
+                            $this->_logger->info(__METHOD__ . '::' . __LINE__ . " found (added/changed/deleted) " . count($serverModifications'added') . '/' . count($serverModifications'changed') . '/' . count($serverModifications'deleted')  . ' entries for sync from server to client');
                     }
                 }
 
@@ -792,18 +739,14 @@
                 if (!empty($collectionData->folder->class)) {
                     $collection->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'Class', $collectionData->folder->class));
                 }
-
+                
                 $syncKeyElement = $collection->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'SyncKey'));
-
+                
                 $collection->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'CollectionId', $collectionData->collectionId));
                 $collection->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'Status', $status));
-
+                
                 $responses = $this->_outputDom->createElementNS('uri:AirSync', 'Responses');
-
-                if ($this->_logger instanceof Zend_Log) {
-                    $this->_logger->info(__METHOD__ . '::' . __LINE__ . " Processing collection " . $collectionData->collectionId);
-                }
-
+                
                 // send reponse for newly added entries
                 if(!empty($clientModifications'added')) {
                     foreach($clientModifications'added' as $entryData) {
@@ -816,7 +759,7 @@
                         $add->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'Status', $entryData'status'));
                     }
                 }
-
+                
                 // send reponse for changed entries
                 if(!empty($clientModifications'changed')) {
                     foreach($clientModifications'changed' as $serverId => $status) {
@@ -827,12 +770,12 @@
                         }
                     }
                 }
-
+                
                 // send response for to be fetched entries
                 if(!empty($collectionData->toBeFetched)) {
                     // unset all truncation settings as entries are not allowed to be truncated during fetch
                     $fetchCollectionData = clone $collectionData;
-
+                    
                     // unset truncationSize
                     if (isset($fetchCollectionData->options'bodyPreferences') && is_array($fetchCollectionData->options'bodyPreferences')) {
                         foreach($fetchCollectionData->options'bodyPreferences' as $key => $bodyPreference) {
@@ -840,86 +783,101 @@
                         }
                     }
                     $fetchCollectionData->options'mimeTruncation' = Syncroton_Command_Sync::TRUNCATE_NOTHING;
-
+                    
                     foreach($collectionData->toBeFetched as $serverId) {
                         $fetch = $responses->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'Fetch'));
                         $fetch->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'ServerId', $serverId));
-
+                        
                         try {
                             $applicationData = $this->_outputDom->createElementNS('uri:AirSync', 'ApplicationData');
-
+                            
                             $dataController
                                 ->getEntry($fetchCollectionData, $serverId)
                                 ->appendXML($applicationData, $this->_device);
-
+                            
                             $fetch->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'Status', self::STATUS_SUCCESS));
-
+                            
                             $fetch->appendChild($applicationData);
                         } catch (Exception $e) {
-                            if ($this->_logger instanceof Zend_Log) {
+                            if ($this->_logger instanceof Zend_Log) 
                                 $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " unable to convert entry to xml: " . $e->getMessage());
-                            }
-                            if ($this->_logger instanceof Zend_Log) {
+                            if ($this->_logger instanceof Zend_Log) 
                                 $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " unable to convert entry to xml: " . $e->getTraceAsString());
-                            }
                             $fetch->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'Status', self::STATUS_OBJECT_NOT_FOUND));
                         }
                     }
                 }
-
+                
                 if ($responses->hasChildNodes() === true) {
                     $collection->appendChild($responses);
                 }
-
+                
                 $commands = $this->_outputDom->createElementNS('uri:AirSync', 'Commands');
-
+                
                 foreach($serverModifications'added' as $id => $serverId) {
                     if($collectionChanges == $collectionData->windowSize || $totalChanges + $collectionChanges >= $this->_globalWindowSize) {
                         break;
                     }
-
+                    
+                    #/**
+                    # * somewhere is a problem in the logic for handling moreAvailable
+                    # * 
+                    # * it can happen, that we have a contentstate (which means we sent the entry to the client
+                    # * and that this entry is yet in $collectionData->syncState->pendingdata'serverAdds'
+                    # * I have no idea how this can happen, but the next lines of code work around this problem
+                    # */
+                    #try {
+                    #    $this->_contentStateBackend->getContentState($this->_device, $collectionData->folder, $serverId);
+                    # 
+                    #    if ($this->_logger instanceof Zend_Log) 
+                    #        $this->_logger->info(__METHOD__ . '::' . __LINE__ . " skipped an entry($serverId) which is already on the client");
+                    #    
+                    #    unset($serverModifications'added'$id);
+                    #    continue;
+                    #    
+                    #} catch (Syncroton_Exception_NotFound $senf) {
+                    #    // do nothing => content state should not exist yet
+                    #}
+                    
                     try {
                         $add = $this->_outputDom->createElementNS('uri:AirSync', 'Add');
                         $add->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'ServerId', $serverId));
-
+                        
                         $applicationData = $add->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'ApplicationData'));
-
-                        $dataController
-                            ->getEntry($collectionData, $serverId)
-                            ->appendXML($applicationData, $this->_device);
-
+                        
+                        $dataController
+                            ->getEntry($collectionData, $serverId)
+                            ->appendXML($applicationData, $this->_device);
+                        
                         $commands->appendChild($add);
-
-                        $newContentStates = new Syncroton_Model_Content(
+                        
+                        $newContentStates = new Syncroton_Model_Content(array(
                             'device_id'        => $this->_device,
                             'folder_id'        => $collectionData->folder,
                             'contentid'        => $serverId,
                             'creation_time'    => $this->_syncTimeStamp,
-                            'creation_synckey' => $collectionData->syncState->counter + 1,
-                        );
+                            'creation_synckey' => $collectionData->syncState->counter + 1
+                        ));
 
                         $collectionChanges++;
                     } catch (Syncroton_Exception_MemoryExhausted $seme) {
                         // continue to next entry, as there is not enough memory left for the current entry
                         // this will lead to MoreAvailable at the end and the entry will be synced during the next Sync command
-                        if ($this->_logger instanceof Zend_Log) {
-                            $this->_logger->info(__METHOD__ . '::' . __LINE__ . " memory exhausted for entry: " . $serverId);
-                        }
-
+                        if ($this->_logger instanceof Zend_Log)
+                            $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " memory exhausted for entry: " . $serverId);
+                        
                         break;
-
+                        
                     } catch (Exception $e) {
-                        if ($this->_logger instanceof Zend_Log) {
+                        if ($this->_logger instanceof Zend_Log)
                             $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " unable to convert entry to xml: " . $e->getMessage());
-                        }
-                        if ($this->_logger instanceof Zend_Log) {
+                        if ($this->_logger instanceof Zend_Log)
                             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " unable to convert entry to xml: " . $e->getTraceAsString());
-                        }
                         // We bump collectionChanges anyways to make sure the windowSize still applies.
                         $collectionChanges++;
                     }
-
-                    // mark as sent to the client, even the conversion to xml might have failed
+                    
+                    // mark as sent to the client, even the conversion to xml might have failed 
                     unset($serverModifications'added'$id);
                 }
 
@@ -930,146 +888,135 @@
                     if($collectionChanges == $collectionData->windowSize || $totalChanges + $collectionChanges >= $this->_globalWindowSize) {
                         break;
                     }
-
+                    
                     try {
                         $change = $this->_outputDom->createElementNS('uri:AirSync', 'Change');
                         $change->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'ServerId', $serverId));
-
+                        
                         $applicationData = $change->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'ApplicationData'));
-
-                        $collectionData->options'_changesOnly' = true;
-
-                        $dataController
-                            ->getEntry($collectionData, $serverId)
-                            ->appendXML($applicationData, $this->_device);
-
+                        
+                        $dataController
+                            ->getEntry($collectionData, $serverId)
+                            ->appendXML($applicationData, $this->_device);
+                        
 
                         $commands->appendChild($change);
-
+                        
                         $collectionChanges++;
                     } catch (Syncroton_Exception_MemoryExhausted $seme) {
                         // continue to next entry, as there is not enough memory left for the current entry
                         // this will lead to MoreAvailable at the end and the entry will be synced during the next Sync command
-                        if ($this->_logger instanceof Zend_Log) {
-                            $this->_logger->info(__METHOD__ . '::' . __LINE__ . " memory exhausted for entry: " . $serverId);
-                        }
-
+                        if ($this->_logger instanceof Zend_Log)
+                            $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " memory exhausted for entry: " . $serverId);
+                        
                         break;
-
+                        
                     } catch (Exception $e) {
-                        if ($this->_logger instanceof Zend_Log) {
+                        if ($this->_logger instanceof Zend_Log) 
                             $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " unable to convert entry to xml: " . $e->getMessage());
-                        }
                         // We bump collectionChanges anyways to make sure the windowSize still applies.
                         $collectionChanges++;
                     }
 
-                    unset($serverModifications'changed'$id);
+                    unset($serverModifications'changed'$id);    
                 }
 
                 foreach($serverModifications'deleted' as $id => $serverId) {
                     if($collectionChanges == $collectionData->windowSize || $totalChanges + $collectionChanges >= $this->_globalWindowSize) {
                         break;
                     }
-
+                    
                     try {
                         // check if we have sent this entry to the phone
                         $state = $this->_contentStateBackend->getContentState($this->_device, $collectionData->folder, $serverId);
-
+                        
                         $delete = $this->_outputDom->createElementNS('uri:AirSync', 'Delete');
                         $delete->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'ServerId', $serverId));
-
+                        
                         $deletedContentStates = $state;
-
+                        
                         $commands->appendChild($delete);
-
+                        
                         $collectionChanges++;
                     } catch (Exception $e) {
-                        if ($this->_logger instanceof Zend_Log) {
+                        if ($this->_logger instanceof Zend_Log) 
                             $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " unable to convert entry to xml: " . $e->getMessage());
-                        }
                         // We bump collectionChanges anyways to make sure the windowSize still applies.
                         $collectionChanges++;
                     }
-
+                    
                     unset($serverModifications'deleted'$id);
                 }
-
-                $countOfPendingChanges = (count($serverModifications'added') + count($serverModifications'changed') + count($serverModifications'deleted'));
+                
+                $countOfPendingChanges = (count($serverModifications'added') + count($serverModifications'changed') + count($serverModifications'deleted')); 
                 if ($countOfPendingChanges > 0) {
-                    if ($this->_logger instanceof Zend_Log) {
-                        $this->_logger->info(__METHOD__ . '::' . __LINE__ . " there are  " . $countOfPendingChanges . " more items available");
-                    }
+                    if ($this->_logger instanceof Zend_Log) 
+                        $this->_logger->info(__METHOD__ . '::' . __LINE__ . " there are  ". $countOfPendingChanges . " more items available");
                     $collection->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'MoreAvailable'));
                 } else {
-                    if ($this->_logger instanceof Zend_Log) {
+                    if ($this->_logger instanceof Zend_Log) 
                         $this->_logger->info(__METHOD__ . '::' . __LINE__ . " there are no more items available");
-                    }
                     $serverModifications = null;
                 }
-
+                    
                 if ($commands->hasChildNodes() === true) {
                     $collection->appendChild($commands);
                 }
-
+                
                 $totalChanges += $collectionChanges;
 
                 // If the client resent an old sync-key, we should still respond with the latest sync key
                 if (isset($collectionData->syncState->counterNext)) {
-                    //TODO we're not resending the changes in between, but I'm not sure we have to.
+                    //TODO we're not resending the changes in between, but I'm not sure we have to. 
                     $collectionData->syncState->counter = $collectionData->syncState->counterNext;
                 }
-
+                
                 // increase SyncKey if needed
                 if ((
-                    // sent the clients updates... ?
-                    !empty($clientModifications'added') ||
-                    !empty($clientModifications'changed') ||
-                    !empty($clientModifications'deleted')
-                ) || (
-                    // is the server sending updates to the client... ?
-                    $commands->hasChildNodes() === true
-                ) || (
-                    // changed the pending data... ?
-                    $collectionData->syncState->pendingdata != $serverModifications
-                )
+                        // sent the clients updates... ?
+                        !empty($clientModifications'added') ||
+                        !empty($clientModifications'changed') ||
+                        !empty($clientModifications'deleted')
+                    ) || (
+                        // is the server sending updates to the client... ?
+                        $commands->hasChildNodes() === true
+                    ) || (
+                        // changed the pending data... ?
+                        $collectionData->syncState->pendingdata != $serverModifications
+                    )
                 ) {
-                    // ...then increase SyncKey
-                    $collectionData->syncState->counter++;
-                }
+                    // ...then increase SyncKey
+                    $collectionData->syncState->counter++;
+                }
                 $syncKeyElement->appendChild($this->_outputDom->createTextNode($collectionData->syncState->counter));
-
-                if ($this->_logger instanceof Zend_Log) {
-                    $this->_logger->info(__METHOD__ . '::' . __LINE__ . " current synckey is " . $collectionData->syncState->counter);
-                }
-
+                
+                if ($this->_logger instanceof Zend_Log)
+                    $this->_logger->info(__METHOD__ . '::' . __LINE__ . " current synckey is ". $collectionData->syncState->counter);
+                
                 if (!$emptySyncSupported || $collection->childNodes->length > 4 || $collectionData->syncState->counter != $collectionData->syncKey) {
-                    $collections->appendChild($collection);
+                     $collections->appendChild($collection);
                 }
-
-                //Store next
-                $collectionData->syncState->extraData = $dataController->getExtraData($collectionData->folder);
             }
-
-            if (isset($collectionData->syncState) &&
+            
+            if (isset($collectionData->syncState) && 
                 $collectionData->syncState instanceof Syncroton_Model_ISyncState &&
-                $collectionData->syncState->counter != $collectionData->syncKey
+                $collectionData->syncState->counter != $collectionData->syncKey 
             ) {
-                if ($this->_logger instanceof Zend_Log) {
+                
+                if ($this->_logger instanceof Zend_Log)
                     $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " update syncState for collection: " . $collectionData->collectionId);
-                }
-
+                
                 // store pending data in sync state when needed
-                if (isset($countOfPendingChanges) && $countOfPendingChanges > 0) {
-                    $collectionData->syncState->pendingdata = 
-                        'added'   => $serverModifications'added' ?? ,
-                        'changed' => $serverModifications'changed' ?? ,
-                        'deleted' => $serverModifications'deleted' ?? ,
-                    ;
+                if(isset($countOfPendingChanges) && $countOfPendingChanges > 0) {
+                    $collectionData->syncState->pendingdata = array(
+                        'added'   => (array)$serverModifications'added',
+                        'changed' => (array)$serverModifications'changed',
+                        'deleted' => (array)$serverModifications'deleted'
+                    );
                 } else {
                     $collectionData->syncState->pendingdata = null;
                 }
-
+                
                 $collectionData->syncState->lastsync = clone $this->_syncTimeStamp;
                 // increment sync timestamp by 1 second
                 $collectionData->syncState->lastsync->modify('+1 sec');
@@ -1084,15 +1031,15 @@
                     }
                     $collectionData->syncState->clientIdMap = Zend_Json::encode($newClientIdMap);
                 }
-
+                
                 //Retry in case of deadlock
                 $retryCounter = 0;
-                while (true) {
+                while (True) {
                     try {
                         $transactionId = Syncroton_Registry::getTransactionManager()->startTransaction(Syncroton_Registry::getDatabase());
                         // store new synckey
-                        $this->_syncStateBackend->create($collectionData->syncState, true); // @phpstan-ignore-line
-
+                        $this->_syncStateBackend->create($collectionData->syncState, true);
+                        
                         // store contentstates for new entries added to client
                         foreach($newContentStates as $state) {
                             try {
@@ -1103,7 +1050,7 @@
                                 $this->_contentStateBackend->create($state);
                             }
                         }
-
+                        
                         // remove contentstates for entries to be deleted on client
                         foreach($deletedContentStates as $state) {
                             $this->_contentStateBackend->delete($state);
@@ -1114,55 +1061,51 @@
                     } catch (Syncroton_Exception_DeadlockDetected $zdse) {
                         $retryCounter++;
                         if ($retryCounter > 60) {
-                            if ($this->_logger instanceof Zend_Log) {
+                            if ($this->_logger instanceof Zend_Log) 
                                 $this->_logger->warn(__METHOD__ . '::' . __LINE__ . ' exception while storing new synckey. Aborting after 5 retries.');
-                            }
 
                             // something went wrong
                             // maybe another parallel request added a new synckey
                             // we must remove data added from client
-                            if (!empty($clientModifications'added') && isset($dataController)) {
+                            if (!empty($clientModifications'added')) {
                                 foreach ($clientModifications'added' as $added) {
                                     $this->_contentStateBackend->delete($added'contentState');
                                     $dataController->deleteEntry($collectionData->collectionId, $added'serverId');
                                 }
                             }
-
+                            
                             Syncroton_Registry::getTransactionManager()->rollBack();
-
+                            
                             throw $zdse;
                         }
 
                         Syncroton_Registry::getTransactionManager()->rollBack();
                         // Give the other transactions some time before we try again
                         sleep(1);
-                        if ($this->_logger instanceof Zend_Log) {
+                        if ($this->_logger instanceof Zend_Log) 
                             $this->_logger->warn(__METHOD__ . '::' . __LINE__ . ' error during transaction, trying again.');
-                        }
                     } catch (Exception $zdse) {
-                        if ($this->_logger instanceof Zend_Log) {
+                        if ($this->_logger instanceof Zend_Log) 
                             $this->_logger->warn(__METHOD__ . '::' . __LINE__ . ' exception while storing new synckey.');
-                        }
                         // something went wrong
                         // maybe another parallel request added a new synckey
                         // we must remove data added from client
-                        if (!empty($clientModifications'added') && isset($dataController)) {
+                        if (!empty($clientModifications'added')) {
                             foreach ($clientModifications'added' as $added) {
                                 $this->_contentStateBackend->delete($added'contentState');
                                 $dataController->deleteEntry($collectionData->collectionId, $added'serverId');
                             }
                         }
-
+                        
                         Syncroton_Registry::getTransactionManager()->rollBack();
-
+                        
                         throw $zdse;
                     }
                 }
             }
-
+            
             // store current filter type
             try {
-                /** @var Syncroton_Model_Folder $folderState */
                 $folderState = $this->_folderBackend->get($collectionData->folder);
                 $folderState->lastfiltertype = $collectionData->options'filterType';
                 if ($folderState->isDirty()) {
@@ -1170,63 +1113,61 @@
                 }
             } catch (Syncroton_Exception_NotFound $senf) {
                 // failed to get folderstate => should not happen but is also no problem in this state
-                if ($this->_logger instanceof Zend_Log) {
+                if ($this->_logger instanceof Zend_Log) 
                     $this->_logger->warn(__METHOD__ . '::' . __LINE__ . ' failed to get folder state for: ' . $collectionData->collectionId);
-                }
             }
         }
-
+        
         if ($collections->hasChildNodes() === true) {
             $sync->appendChild($collections);
         }
-
+        
         if ($sync->hasChildNodes()) {
             return $this->_outputDom;
         }
-
+        
         return null;
     }
-
+    
     /**
      * remove Commands and Supported from collections XML tree
-     *
+     * 
      * @param  DOMDocument $document
      * @return DOMDocument
      */
     protected function _cleanUpXML(DOMDocument $document)
     {
         $cleanedDocument = clone $document;
-
+        
         $xpath = new DomXPath($cleanedDocument);
         $xpath->registerNamespace('AirSync', 'uri:AirSync');
-
+        
         $collections = $xpath->query("//AirSync:Sync/AirSync:Collections/AirSync:Collection");
-
+        
         // remove Commands and Supported elements
         foreach ($collections as $collection) {
-            foreach ('Commands', 'Supported' as $element) {
-                /** @var DOMElement $collection */
+            foreach (array('Commands', 'Supported') as $element) {
                 $childrenToRemove = $collection->getElementsByTagName($element);
-
+                
                 foreach ($childrenToRemove as $childToRemove) {
                     $collection->removeChild($childToRemove);
                 }
             }
         }
-
+        
         return $cleanedDocument;
     }
-
+    
     /**
      * merge a partial XML document with the XML document from the previous request
-     *
+     * 
      * @param  DOMDocument|null  $requestBody
-     * @return DOMDocument
+     * @return SimpleXMLElement
      */
     protected function _mergeSyncRequest($requestBody, Syncroton_Model_Device $device)
     {
-        $lastSyncCollection = ;
-
+        $lastSyncCollection = array();
+        
         if (!empty($device->lastsynccollection)) {
             $lastSyncCollection = Zend_Json::decode($device->lastsynccollection);
             if (!empty($lastSyncCollection'lastXML')) {
@@ -1234,75 +1175,71 @@
                 $lastXML->loadXML($lastSyncCollection'lastXML');
             }
         }
-
-        if (! $requestBody instanceof DOMDocument) {
-            if (!empty($lastXML)) {
-                $requestBody = $lastXML;
-            } else {
-                throw new Syncroton_Exception_UnexpectedValue('no xml body found');
-            }
+        
+        if (! $requestBody instanceof DOMDocument && isset($lastXML) && $lastXML instanceof DOMDocument) {
+            $requestBody = $lastXML;
+        } elseif (! $requestBody instanceof DOMDocument) {
+            throw new Syncroton_Exception_UnexpectedValue('no xml body found');
         }
-
+        
         if ($requestBody->getElementsByTagName('Partial')->length > 0) {
             $partialBody = clone $requestBody;
-            $requestBody = $lastXML ?? (new DOMDocument());
-
+            $requestBody = $lastXML;
+            
             $xpath = new DomXPath($requestBody);
             $xpath->registerNamespace('AirSync', 'uri:AirSync');
-
+            
             foreach ($partialBody->documentElement->childNodes as $child) {
                 if (! $child instanceof DOMElement) {
                     continue;
                 }
-
-                /** @var DOMElement $child */
+                
                 if ($child->tagName == 'Partial') {
                     continue;
                 }
-
+                
                 if ($child->tagName == 'Collections') {
                     foreach ($child->getElementsByTagName('Collection') as $updatedCollection) {
                         $collectionId = $updatedCollection->getElementsByTagName('CollectionId')->item(0)->nodeValue;
-
+                        
                         $existingCollections = $xpath->query("//AirSync:Sync/AirSync:Collections/AirSync:CollectionAirSync:CollectionId='$collectionId'");
-
+                        
                         if ($existingCollections->length > 0) {
-                            /** @var DOMElement $existingCollection */
                             $existingCollection = $existingCollections->item(0);
                             foreach ($updatedCollection->childNodes as $updatedCollectionChild) {
                                 if (! $updatedCollectionChild instanceof DOMElement) {
                                     continue;
                                 }
-
+                                
                                 $duplicateChild = $existingCollection->getElementsByTagName($updatedCollectionChild->tagName);
-
+                                
                                 if ($duplicateChild->length > 0) {
-                                    $existingCollection->replaceChild($requestBody->importNode($updatedCollectionChild, true), $duplicateChild->item(0));
+                                    $existingCollection->replaceChild($requestBody->importNode($updatedCollectionChild, TRUE), $duplicateChild->item(0));
                                 } else {
-                                    $existingCollection->appendChild($requestBody->importNode($updatedCollectionChild, true));
+                                    $existingCollection->appendChild($requestBody->importNode($updatedCollectionChild, TRUE));
                                 }
                             }
                         } else {
-                            $importedCollection = $requestBody->importNode($updatedCollection, true);
+                            $importedCollection = $requestBody->importNode($updatedCollection, TRUE);
                         }
                     }
-
+                    
                 } else {
                     $duplicateChild = $xpath->query("//AirSync:Sync/AirSync:{$child->tagName}");
-
+                    
                     if ($duplicateChild->length > 0) {
-                        $requestBody->documentElement->replaceChild($requestBody->importNode($child, true), $duplicateChild->item(0));
+                        $requestBody->documentElement->replaceChild($requestBody->importNode($child, TRUE), $duplicateChild->item(0));
                     } else {
-                        $requestBody->documentElement->appendChild($requestBody->importNode($child, true));
+                        $requestBody->documentElement->appendChild($requestBody->importNode($child, TRUE));
                     }
                 }
             }
         }
-
+        
         $lastSyncCollection'lastXML' = $this->_cleanUpXML($requestBody)->saveXML();
-
+        
         $device->lastsynccollection = Zend_Json::encode($lastSyncCollection);
-
+        
         return $requestBody;
     }
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/Wbxml.php Changed

@@ -15,121 +15,122 @@
  * @package     Syncroton
  * @subpackage  Command
  */
-
+ 
 abstract class Syncroton_Command_Wbxml implements Syncroton_Command_ICommand
 {
     /**
      * informations about the currently device
      *
-     * @var Syncroton_Model_IDevice
+     * @var Syncroton_Model_Device
      */
     protected $_device;
-
+    
     /**
      * informations about the currently device
      *
      * @var Syncroton_Backend_IDevice
      */
     protected $_deviceBackend;
-
+    
     /**
      * informations about the currently device
      *
      * @var Syncroton_Backend_IFolder
      */
     protected $_folderBackend;
-
+    
     /**
      * @var Syncroton_Backend_ISyncState
      */
     protected $_syncStateBackend;
-
+    
     /**
      * @var Syncroton_Backend_IContent
      */
     protected $_contentStateBackend;
-
+    
     /**
-     * @var Syncroton_Backend_Policy
+     * 
+     * @var Syncroton_Backend_IPolicy
      */
     protected $_policyBackend;
-
+    
     /**
      * the domDocument containing the xml response from the server
      *
      * @var DOMDocument
      */
     protected $_outputDom;
-
+    
     /**
      * the domDocucment containing the xml request from the client
      *
      * @var DOMDocument
      */
     protected $_requestBody;
-
+    
     /**
      * the default namespace
      *
-     * @var ?string
+     * @var string
      */
     protected $_defaultNameSpace;
-
+    
     /**
      * the main xml tag
      *
-     * @var ?string
+     * @var string
      */
     protected $_documentElement;
-
+    
     /**
      * @var array
      */
     protected $_requestParameters;
-
+    
     /**
      * @var Syncroton_Model_SyncState
      */
     protected $_syncState;
-
+    
     protected $_skipValidatePolicyKey = false;
-
+    
     /**
      * timestamp to use for all sync requests
      *
      * @var DateTime
      */
     protected $_syncTimeStamp;
-
+    
     /**
      * @var string
      */
     protected $_transactionId;
-
+    
     /**
      * @var string
      */
     protected $_policyKey;
-
+    
     /**
      * @var Zend_Log
      */
     protected $_logger;
-
+    
     /**
      * list of part streams
-     *
+     * 
      * @var array
      */
-    protected $_parts = ;
-
+    protected $_parts = array();
+    
     /**
      * list of headers
-     *
+     * 
      * @var array
      */
-    protected $_headers = ;
-
+    protected $_headers = array();
+    
     /**
      * the constructor
      *
@@ -137,12 +138,12 @@
      * @param  Syncroton_Model_Device  $device
      * @param  array                   $requestParameters
      */
-    public function __construct($requestBody, Syncroton_Model_IDevice $device, $requestParameters = )
+    public function __construct($requestBody, Syncroton_Model_IDevice $device, $requestParameters)
     {
         $this->_requestBody       = $requestBody;
         $this->_device            = $device;
         $this->_requestParameters = $requestParameters;
-        $this->_policyKey         = $requestParameters'policyKey' ?? null;
+        $this->_policyKey         = isset($requestParameters'policyKey') ? $requestParameters'policyKey' : null;
 
         $this->_deviceBackend       = Syncroton_Registry::getDeviceBackend();
         $this->_folderBackend       = Syncroton_Registry::getFolderBackend();
@@ -152,57 +153,55 @@
         if (Syncroton_Registry::isRegistered('loggerBackend')) {
             $this->_logger          = Syncroton_Registry::get('loggerBackend');
         }
-
+        
         $this->_syncTimeStamp = new DateTime('now', new DateTimeZone('UTC'));
-
+        
         // set default content type
         $this->_headers'Content-Type' = 'application/vnd.ms-sync.wbxml';
-
-        if ($this->_logger instanceof Zend_Log) {
+        
+        if ($this->_logger instanceof Zend_Log) 
             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " sync timestamp: " . $this->_syncTimeStamp->format('Y-m-d H:i:s'));
-        }
-
+        
         if (isset($this->_defaultNameSpace) && isset($this->_documentElement)) {
             // Creates an instance of the DOMImplementation class
             $imp = new DOMImplementation();
-
+            
             // Creates a DOMDocumentType instance
             $dtd = $imp->createDocumentType('AirSync', "-//AIRSYNC//DTD AirSync//EN", "http://www.microsoft.com/");
-
+            
             // Creates a DOMDocument instance
             $this->_outputDom = $imp->createDocument($this->_defaultNameSpace, $this->_documentElement, $dtd);
             $this->_outputDom->documentElement->setAttributeNS('http://www.w3.org/2000/xmlns/', 'xmlns:Syncroton', 'uri:Syncroton');
             $this->_outputDom->formatOutput = false;
             $this->_outputDom->encoding     = 'utf-8';
         }
-
+        
         if ($this->_skipValidatePolicyKey != true) {
             if (!empty($this->_device->policyId)) {
-                /** @var Syncroton_Model_Policy $policy */
                 $policy = $this->_policyBackend->get($this->_device->policyId);
-
-                if ((int) $policy->policyKey != (int) $this->_policyKey) {
+                
+                if((int)$policy->policyKey != (int)$this->_policyKey) {
                     $this->_outputDom->documentElement->appendChild($this->_outputDom->createElementNS($this->_defaultNameSpace, 'Status', 142));
-
+                    
                     $sepn = new Syncroton_Exception_ProvisioningNeeded();
                     $sepn->domDocument = $this->_outputDom;
-
+                    
                     throw $sepn;
                 }
-
+                
                 // should we wipe the mobile phone?
                 if ($this->_device->remotewipe >= Syncroton_Command_Provision::REMOTEWIPE_REQUESTED) {
                     $this->_outputDom->documentElement->appendChild($this->_outputDom->createElementNS($this->_defaultNameSpace, 'Status', 140));
-
+                    
                     $sepn = new Syncroton_Exception_ProvisioningNeeded();
                     $sepn->domDocument = $this->_outputDom;
-
+                    
                     throw $sepn;
                 }
             }
         }
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Command_ICommand::getHeaders()
@@ -213,7 +212,7 @@
     }
     /**
      * return array of part streams
-     *
+     * 
      * @return array
      */
     public function getParts()

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Data/AData.php Changed

@@ -17,30 +17,16 @@
  */
 abstract class Syncroton_Data_AData implements Syncroton_Data_IData
 {
-    public const LONGID_DELIMITER = "\xe2\x87\x94"; // UTF-8 character ⇔
-
-    /** @var DateTime */
+    const LONGID_DELIMITER = "\xe2\x87\x94"; # UTF-8 character ⇔
+    
+    /**
+     * @var DateTime
+     */
     protected $_timeStamp;
-
-    /** @var Syncroton_Model_IDevice */
-    protected $_device;
-
-    /** @var Zend_Db_Adapter_Abstract */
-    protected $_db;
-
-    /** @var string */
-    protected $_tablePrefix;
-
-    /** @var string */
-    protected $_ownerId;
-
-    /** @var array */
-    protected $_supportedFolderTypes = ;
-
-
+    
     /**
      * the constructor
-     *
+     * 
      * @param Syncroton_Model_IDevice $_device
      * @param DateTime $_timeStamp
      */
@@ -52,10 +38,10 @@
         $this->_tablePrefix = 'Syncroton_';
         $this->_ownerId     = '1234';
     }
-
+    
     /**
      * return one folder identified by id
-     *
+     * 
      * @param  string  $id
      * @throws Syncroton_Exception_NotFound
      * @return Syncroton_Model_Folder
@@ -66,23 +52,23 @@
             ->from($this->_tablePrefix . 'data_folder')
             ->where('owner_id = ?', $this->_ownerId)
             ->where('id = ?', $id);
-
+        
         $stmt   = $this->_db->query($select);
         $folder = $stmt->fetch();
         $stmt = null; # see https://bugs.php.net/bug.php?id=44081
-
+        
         if ($folder === false) {
             throw new Syncroton_Exception_NotFound("folder $id not found");
         }
-
-        return new Syncroton_Model_Folder(
+        
+        return new Syncroton_Model_Folder(array(
             'serverId'    => $folder'id',
             'displayName' => $folder'name',
             'type'        => $folder'type',
-            'parentId'    => !empty($folder'parent_id') ? $folder'parent_id' : null,
-        );
+            'parentId'    => !empty($folder'parent_id') ? $folder'parent_id' : null
+        ));
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_IData::createFolder()
@@ -92,53 +78,53 @@
         if (!in_array($folder->type, $this->_supportedFolderTypes)) {
             throw new Syncroton_Exception_UnexpectedValue();
         }
-
-        $id = !empty($folder->serverId) ? $folder->serverId : sha1(mt_rand() . microtime());
-
-        $this->_db->insert($this->_tablePrefix . 'data_folder', 
+        
+        $id = !empty($folder->serverId) ? $folder->serverId : sha1(mt_rand(). microtime());
+        
+        $this->_db->insert($this->_tablePrefix . 'data_folder', array(
             'id'            => $id,
             'type'          => $folder->type,
             'name'          => $folder->displayName,
             'owner_id'      => $this->_ownerId,
             'parent_id'     => $folder->parentId,
-            'creation_time' => $this->_timeStamp->format("Y-m-d H:i:s"),
-        );
-
+            'creation_time' => $this->_timeStamp->format("Y-m-d H:i:s")
+        ));
+        
         return $this->getFolder($id);
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_IData::createEntry()
      */
-    public function createEntry($_folderId, Syncroton_Model_IEntry $_entry)
-    {
-        $id = sha1(mt_rand() . microtime());
-
-        $this->_db->insert($this->_tablePrefix . 'data', 
-            'id'            => $id,
+    public function createEntry($_folderId, Syncroton_Model_IEntry $_entry)
+    {
+        $id = sha1(mt_rand(). microtime());
+    
+        $this->_db->insert($this->_tablePrefix . 'data', array(
+            'id'            => $id,
             'class'         => get_class($_entry),
             'folder_id'     => $_folderId,
             'creation_time' => $this->_timeStamp->format("Y-m-d H:i:s"),
-            'data'          => serialize($_entry),
-        );
-
-        return $id;
-    }
-
+            'data'          => serialize($_entry)
+        ));
+    
+        return $id;
+    }
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_IData::deleteEntry()
      */
-    public function deleteEntry($_folderId, $_serverId, $_collectionData = null)
+    public function deleteEntry($_folderId, $_serverId, $_collectionData)
     {
         $folderId = $_folderId instanceof Syncroton_Model_IFolder ? $_folderId->serverId : $_folderId;
-
-        $result = $this->_db->delete($this->_tablePrefix . 'data', 'id = ?' => $_serverId);
-
+        
+        $result = $this->_db->delete($this->_tablePrefix . 'data', array('id = ?' => $_serverId));
+        
         return (bool) $result;
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_IData::deleteFolder()
@@ -146,13 +132,13 @@
     public function deleteFolder($_folderId)
     {
         $folderId = $_folderId instanceof Syncroton_Model_IFolder ? $_folderId->serverId : $_folderId;
-
-        $result = $this->_db->delete($this->_tablePrefix . 'data', 'folder_id = ?' => $folderId);
-        $result = $this->_db->delete($this->_tablePrefix . 'data_folder', 'id = ?' => $folderId);
-
+        
+        $result = $this->_db->delete($this->_tablePrefix . 'data', array('folder_id = ?' => $folderId));
+        $result = $this->_db->delete($this->_tablePrefix . 'data_folder', array('id = ?' => $folderId));
+        
         return (bool) $result;
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_IData::emptyFolderContents()
@@ -161,7 +147,7 @@
     {
         return true;
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_IData::getAllFolders()
@@ -172,52 +158,55 @@
             ->from($this->_tablePrefix . 'data_folder')
             ->where('type IN (?)', $this->_supportedFolderTypes)
             ->where('owner_id = ?', $this->_ownerId);
-
+        
         $stmt    = $this->_db->query($select);
         $folders = $stmt->fetchAll();
         $stmt = null; # see https://bugs.php.net/bug.php?id=44081
-
-        $result = ;
-
+        
+        $result = array();
+        
         foreach ((array) $folders as $folder) {
-            $result$folder'id' =  new Syncroton_Model_Folder(
+            $result$folder'id' =  new Syncroton_Model_Folder(array(
                 'serverId'    => $folder'id',
                 'displayName' => $folder'name',
                 'type'        => $folder'type',
-                'parentId'    => $folder'parent_id',
-            );
+                'parentId'    => $folder'parent_id'
+            ));
         }
-
+        
         return $result;
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_IData::getChangedEntries()
      */
-    public function getChangedEntries($_folderId, Syncroton_Model_ISyncState $syncState, $filterType = null)
+    public function getChangedEntries($_folderId, DateTime $_startTimeStamp, DateTime $_endTimeStamp = NULL, $filterType = NULL)
     {
-        $_startTimeStamp = $syncState->lastsync;
         $folderId = $_folderId instanceof Syncroton_Model_IFolder ? $_folderId->id : $_folderId;
-
+    
         $select = $this->_db->select()
-            ->from($this->_tablePrefix . 'data', 'id')
+            ->from($this->_tablePrefix . 'data', array('id'))
             ->where('folder_id = ?', $_folderId)
             ->where('last_modified_time > ?', $_startTimeStamp->format("Y-m-d H:i:s"));
-
-        $ids = ;
-
+        
+        if ($_endTimeStamp instanceof DateTime) {
+            $select->where('last_modified_time < ?', $_endTimeStamp->format("Y-m-d H:i:s"));
+        }
+        
+        $ids = array();
+        
         $stmt = $this->_db->query($select);
         while ($id = $stmt->fetchColumn()) {
             $ids = $id;
         }
-
+        
         return $ids;
     }
-
+    
     /**
      * retrieve folders which were modified since last sync
-     *
+     * 
      * @param  DateTime  $startTimeStamp
      * @param  DateTime  $endTimeStamp
      * @return array list of Syncroton_Model_Folder
@@ -230,25 +219,25 @@
             ->where('owner_id = ?', $this->_ownerId)
             ->where('last_modified_time > ?', $startTimeStamp->format('Y-m-d H:i:s'))
             ->where('last_modified_time <= ?', $endTimeStamp->format('Y-m-d H:i:s'));
-
+        
         $stmt    = $this->_db->query($select);
         $folders = $stmt->fetchAll();
         $stmt = null; # see https://bugs.php.net/bug.php?id=44081
-
-        $result = ;
-
+        
+        $result = array();
+        
         foreach ((array) $folders as $folder) {
-            $result$folder'id' =  new Syncroton_Model_Folder(
+            $result$folder'id' =  new Syncroton_Model_Folder(array(
                 'serverId'    => $folder'id',
                 'displayName' => $folder'name',
                 'type'        => $folder'type',
-                'parentId'    => $folder'parent_id',
-            );
+                'parentId'    => $folder'parent_id'
+            ));
         }
-
+        
         return $result;
     }
-
+    
     /**
      * @param  Syncroton_Model_IFolder|string  $_folderId
      * @param  string                          $_filter
@@ -257,21 +246,21 @@
     public function getServerEntries($_folderId, $_filter)
     {
         $folderId = $_folderId instanceof Syncroton_Model_IFolder ? $_folderId->id : $_folderId;
-
-        $select = $this->_db->select()
-            ->from($this->_tablePrefix . 'data', 'id')
-            ->where('folder_id = ?', $_folderId);
-
-        $ids = ;
-
-        $stmt = $this->_db->query($select);
+    
+        $select = $this->_db->select()
+            ->from($this->_tablePrefix . 'data', array('id'))
+            ->where('folder_id = ?', $_folderId);
+        
+        $ids = array();
+        
+        $stmt = $this->_db->query($select);
         while ($id = $stmt->fetchColumn()) {
             $ids = $id;
-        }
-
-        return $ids;
+        }
+        
+        return $ids;
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_IData::getCountOfChanges()
@@ -280,42 +269,42 @@
     {
         $allClientEntries = $contentBackend->getFolderState($this->_device, $folder);
         $allServerEntries = $this->getServerEntries($folder->serverId, $folder->lastfiltertype);
-
+        
         $addedEntries       = array_diff($allServerEntries, $allClientEntries);
         $deletedEntries     = array_diff($allClientEntries, $allServerEntries);
-        $changedEntries     = $this->getChangedEntries($folder->serverId, $syncState, $folder->lastfiltertype);
-
+        $changedEntries     = $this->getChangedEntries($folder->serverId, $syncState->lastsync, null, $folder->lastfiltertype);
+        
         return count($addedEntries) + count($deletedEntries) + count($changedEntries);
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_IData::getFileReference()
      */
-    public function getFileReference($fileReference)
-    {
-        throw new Syncroton_Exception_NotFound('filereference not found');
-    }
-
+    public function getFileReference($fileReference)
+    {
+        throw new Syncroton_Exception_NotFound('filereference not found');
+    }
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_IData::getEntry()
      */
-    public function getEntry(Syncroton_Model_SyncCollection $collection, $serverId)
-    {
+    public function getEntry(Syncroton_Model_SyncCollection $collection, $serverId)
+    {
         $select = $this->_db->select()
-            ->from($this->_tablePrefix . 'data', 'data')
+            ->from($this->_tablePrefix . 'data', array('data'))
             ->where('id = ?', $serverId);
-
+        
         $stmt  = $this->_db->query($select);
         $entry = $stmt->fetchColumn();
 
         if ($entry === false) {
             throw new Syncroton_Exception_NotFound("entry $serverId not found in folder {$collection->collectionId}");
         }
-
+        
         return unserialize($entry);
-    }
+    }
 
     /**
      * (non-PHPdoc)
@@ -325,59 +314,53 @@
     {
         return !!$this->getCountOfChanges($contentBackend, $folder, $syncState);
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_IData::moveItem()
      */
     public function moveItem($_srcFolderId, $_serverId, $_dstFolderId)
     {
-        $this->_db->update($this->_tablePrefix . 'data', 
-            'folder_id' => $_dstFolderId,
-        , 
-            'id = ?' => $_serverId,
-        );
-
+        $this->_db->update($this->_tablePrefix . 'data', array(
+            'folder_id' => $_dstFolderId,
+        ), array(
+            'id = ?' => $_serverId
+        ));
+        
         return $_serverId;
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_IData::updateEntry()
      */
-    public function updateEntry($_folderId, $_serverId, Syncroton_Model_IEntry $_entry)
+    public function updateEntry($_folderId, $_serverId, Syncroton_Model_IEntry $_entry)
     {
-        $this->_db->update($this->_tablePrefix . 'data', 
+        $this->_db->update($this->_tablePrefix . 'data', array(
             'folder_id'          => $_folderId,
             'last_modified_time' => $this->_timeStamp->format("Y-m-d H:i:s"),
-            'data'               => serialize($_entry),
-        , 
-            'id = ?' => $_serverId,
-        );
-
-        return $_serverId;
+            'data'               => serialize($_entry)
+        ), array(
+            'id = ?' => $_serverId
+        ));
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_IData::updateFolder()
-     */
-    public function updateFolder(Syncroton_Model_IFolder $folder)
-    {
-        $this->_db->update($this->_tablePrefix . 'data_folder', 
+     */
+    public function updateFolder(Syncroton_Model_IFolder $folder)
+    {
+        $this->_db->update($this->_tablePrefix . 'data_folder', array(
             'name'               => $folder->displayName,
             'parent_id'          => $folder->parentId,
             'last_modified_time' => $this->_timeStamp->format("Y-m-d H:i:s"),
-        , 
+        ), array(
             'id = ?'       => $folder->serverId,
-            'owner_id = ?' => $this->_ownerId,
-        );
-
+            'owner_id = ?' => $this->_ownerId
+        ));
+        
         return $this->getFolder($folder->serverId);
-    }
-
-    public function getExtraData(Syncroton_Model_IFolder $folder)
-    {
-        return null;
-    }
+    }
 }
+

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Data/Calendar.php Changed

@@ -17,20 +17,20 @@
  */
 class Syncroton_Data_Calendar extends Syncroton_Data_AData implements Syncroton_Data_IDataCalendar
 {
-    protected $_supportedFolderTypes = 
+    protected $_supportedFolderTypes = array(
         Syncroton_Command_FolderSync::FOLDERTYPE_CALENDAR,
-        Syncroton_Command_FolderSync::FOLDERTYPE_CALENDAR_USER_CREATED,
-    ;
-
+        Syncroton_Command_FolderSync::FOLDERTYPE_CALENDAR_USER_CREATED
+    );
+    
     /**
      * set attendee status for meeting
-     *
-     * @param Syncroton_Model_MeetingResponse $response The meeting response
-     *
-     * @return string ID of new calendar entry
+     * 
+     * @param  Syncroton_Model_MeetingResponse  $request  the meeting response
+     * @return  string  id of new calendar entry
      */
-    public function setAttendeeStatus(Syncroton_Model_MeetingResponse $response)
+    public function setAttendeeStatus(Syncroton_Model_MeetingResponse $reponse)
     {
-        return $response->requestId;
+        return $reponse->requestId;
     }
 }
+

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Data/Contacts.php Changed

@@ -15,31 +15,31 @@
  * @package     Syncroton
  * @subpackage  Data
  */
+
 class Syncroton_Data_Contacts extends Syncroton_Data_AData implements Syncroton_Data_IDataSearch
 {
-    protected $_supportedFolderTypes = 
+    protected $_supportedFolderTypes = array(
         Syncroton_Command_FolderSync::FOLDERTYPE_CONTACT,
-        Syncroton_Command_FolderSync::FOLDERTYPE_CONTACT_USER_CREATED,
-    ;
-
+        Syncroton_Command_FolderSync::FOLDERTYPE_CONTACT_USER_CREATED
+    );
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_IDataSearch::getSearchEntry()
      */
     public function getSearchEntry($longId, $options)
     {
-        $collectionId, $serverId = explode(Syncroton_Data_AData::LONGID_DELIMITER, $longId, 2);
-
-        /** @var Syncroton_Model_Contact $contact */
-        $contact = $this->getEntry(new Syncroton_Model_SyncCollection('collectionId' => $collectionId), $serverId);
-
-        return new Syncroton_Model_GAL(
+        list($collectionId, $serverId) = explode(Syncroton_Data_AData::LONGID_DELIMITER, $longId, 2);
+        
+        $contact = $this->getEntry(new Syncroton_Model_SyncCollection(array('collectionId' => $collectionId)), $serverId);
+        
+        return new Syncroton_Model_GAL(array(
             'firstName' => $contact->firstName,
             'lastName'  => $contact->lastName,
-            'picture'   => new Syncroton_Model_GALPicture('status' => 1, 'data' => 'abc'),
-        );
+            'picture'   => new Syncroton_Model_GALPicture(array('status' => 1, 'data' => 'abc'))
+        ));
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_IDataSearch::search()
@@ -47,37 +47,37 @@
     public function search(Syncroton_Model_StoreRequest $store)
     {
         $storeResponse = new Syncroton_Model_StoreResponse();
-
+        
         $serverIds = $this->getServerEntries('addressbookFolderId', Syncroton_Command_Sync::FILTER_NOTHING);
-
+        
         $total = 0;
-        $found = ;
-
+        $found = array();
+        
         foreach ($serverIds as $serverId) {
-            /** @var Syncroton_Model_Contact $contact */
-            $contact = $this->getEntry(new Syncroton_Model_SyncCollection('collectionId' => 'addressbookFolderId'), $serverId);
-
+            $contact = $this->getEntry(new Syncroton_Model_SyncCollection(array('collectionId' => 'addressbookFolderId')), $serverId);
+            
             if ($contact->firstName == $store->query) {
                 $total++;
-
-                if (count($found) == $store->options'range'1 + 1) {
+                
+                if (count($found) == $store->options'range'1+1) {
                     continue;
                 }
-                $found = new Syncroton_Model_StoreResponseResult(
-                    'longId' => 'addressbookFolderId' . Syncroton_Data_AData::LONGID_DELIMITER . $serverId,
-                    'properties' => $this->getSearchEntry('addressbookFolderId' . Syncroton_Data_AData::LONGID_DELIMITER . $serverId, $store->options),
-                );
+                $found = new Syncroton_Model_StoreResponseResult(array(
+                    'longId' => 'addressbookFolderId' . Syncroton_Data_AData::LONGID_DELIMITER .  $serverId,
+                    'properties' => $this->getSearchEntry('addressbookFolderId' . Syncroton_Data_AData::LONGID_DELIMITER .  $serverId, $store->options)
+                ));
             }
         }
-
+        
         if (count($found) > 0) {
             $storeResponse->result = $found;
-            $storeResponse->range = 0, count($found) - 1;
+            $storeResponse->range = array(0, count($found) - 1);
             $storeResponse->total = $total;
         } else {
-            $storeResponse->total = $total;
+            $storeResponse->total = $total;
         }
-
+        
         return $storeResponse;
     }
 }
+

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Data/Email.php Changed

@@ -17,52 +17,52 @@
  */
 class Syncroton_Data_Email extends Syncroton_Data_AData implements Syncroton_Data_IDataEmail
 {
-    protected $_supportedFolderTypes = 
+    protected $_supportedFolderTypes = array(
         Syncroton_Command_FolderSync::FOLDERTYPE_DELETEDITEMS,
         Syncroton_Command_FolderSync::FOLDERTYPE_DRAFTS,
         Syncroton_Command_FolderSync::FOLDERTYPE_INBOX,
         Syncroton_Command_FolderSync::FOLDERTYPE_MAIL_USER_CREATED,
         Syncroton_Command_FolderSync::FOLDERTYPE_OUTBOX,
-        Syncroton_Command_FolderSync::FOLDERTYPE_SENTMAIL,
-    ;
-
+        Syncroton_Command_FolderSync::FOLDERTYPE_SENTMAIL
+    );
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_IDataEmail::forwardEmail()
      */
     public function forwardEmail($source, $inputStream, $saveInSent, $replaceMime)
     {
-        if ($inputStream == 'triggerException') {
-            throw new Syncroton_Exception_Status(Syncroton_Exception_Status::MAILBOX_SERVER_OFFLINE);
-        }
-
+        if ($inputStream == 'triggerException') {
+            throw new Syncroton_Exception_Status(Syncroton_Exception_Status::MAILBOX_SERVER_OFFLINE);
+        }
+        
         // forward email
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_AData::getFileReference()
      */
-    public function getFileReference($fileReference)
-    {
-        $messageId, $partId = explode(Syncroton_Data_AData::LONGID_DELIMITER, $fileReference, 2);
-
-        // example code
-        return new Syncroton_Model_FileReference(
-            'contentType' => 'text/plain',
-            'data'        => 'Lars',
-        );
+    public function getFileReference($fileReference)
+    {
+        list($messageId, $partId) = explode(Syncroton_Data_AData::LONGID_DELIMITER, $fileReference, 2);
+    
+        // example code
+        return new Syncroton_Model_FileReference(array(
+            'contentType' => 'text/plain',
+            'data'        => 'Lars'
+        ));
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_IDataEmail::replyEmail()
-     */
-    public function replyEmail($source, $inputStream, $saveInSent, $replaceMime)
-    {
-        // forward email
-    }
-
+     */
+    public function replyEmail($source, $inputStream, $saveInSent, $replaceMime)
+    {
+        // forward email
+    }
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_AData::updateEntry()
@@ -70,9 +70,8 @@
     public function updateEntry($_folderId, $_serverId, Syncroton_Model_IEntry $_entry)
     {
         // not used by email
-        return '';
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Data_IDataEmail::sendEmail()
@@ -85,3 +84,4 @@
         // send email
     }
 }
+

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Data/Factory.php Changed

@@ -18,40 +18,39 @@
 
 class Syncroton_Data_Factory
 {
-    public const CLASS_CALENDAR = 'Calendar';
-    public const CLASS_CONTACTS = 'Contacts';
-    public const CLASS_EMAIL    = 'Email';
-    public const CLASS_NOTES    = 'Notes';
-    public const CLASS_TASKS    = 'Tasks';
-    public const STORE_EMAIL    = 'Mailbox';
-    public const STORE_GAL      = 'GAL';
-
-    protected static $_classMap = ;
-
+    const CLASS_CALENDAR = 'Calendar';
+    const CLASS_CONTACTS = 'Contacts';
+    const CLASS_EMAIL    = 'Email';
+    const CLASS_NOTES    = 'Notes';
+    const CLASS_TASKS    = 'Tasks';
+    const STORE_EMAIL    = 'Mailbox';
+    const STORE_GAL      = 'GAL';
+    
+    protected static $_classMap = array();
+    
     /**
-     * @param string                  $_classFactory
+     * @param unknown_type $_class
      * @param Syncroton_Model_IDevice $_device
-     * @param DateTime                $_timeStamp
-     *
+     * @param DateTime $_timeStamp
      * @throws InvalidArgumentException
      * @return Syncroton_Data_IData
      */
     public static function factory($_classFactory, Syncroton_Model_IDevice $_device, DateTime $_timeStamp)
     {
-        switch ($_classFactory) {
+        switch($_classFactory) {
             case self::CLASS_CALENDAR:
                 $className = Syncroton_Registry::get(Syncroton_Registry::CALENDAR_DATA_CLASS);
                 break;
-
+                
             case self::CLASS_CONTACTS:
                 $className = Syncroton_Registry::get(Syncroton_Registry::CONTACTS_DATA_CLASS);
                 break;
-
+                
             case self::STORE_EMAIL:
             case self::CLASS_EMAIL:
                 $className = Syncroton_Registry::get(Syncroton_Registry::EMAIL_DATA_CLASS);
                 break;
-
+                
             case self::CLASS_NOTES:
                 $className = Syncroton_Registry::get(Syncroton_Registry::NOTES_DATA_CLASS);
                 break;
@@ -66,14 +65,16 @@
 
             default:
                 throw new Syncroton_Exception_UnexpectedValue('invalid class type provided');
+                breeak;
         }
-
+        
         $class = new $className($_device, $_timeStamp);
-
+        
         if (! $class instanceof Syncroton_Data_IData) {
             throw new RuntimeException('class must be instanceof Syncroton_Data_IData');
         }
-
+                    
         return $class;
     }
 }
+

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Data/IData.php Changed

@@ -19,37 +19,37 @@
 {
     /**
      * create new entry
-     *
+     * 
      * @param string                  $folderId
      * @param Syncroton_Model_IEntry  $entry
      * @return string  id of created entry
      */
     public function createEntry($folderId, Syncroton_Model_IEntry $entry);
-
+    
     /**
      * create a new folder in backend
-     *
+     * 
      * @param Syncroton_Model_IFolder $folder
      * @return Syncroton_Model_IFolder
      */
     public function createFolder(Syncroton_Model_IFolder $folder);
-
+    
     /**
      * delete entry in backend
-     *
+     * 
      * @param string                          $_folderId
      * @param string                          $_serverId
      * @param ?Syncroton_Model_SyncCollection $_collectionData
      */
     public function deleteEntry($_folderId, $_serverId, $_collectionData = null);
-
+    
     /**
      * delete folder
-     *
+     * 
      * @param string $folderId
      */
     public function deleteFolder($folderId);
-
+    
     /**
      * empty folder
      *
@@ -57,77 +57,71 @@
      * @param array  $options
      */
     public function emptyFolderContents($folderId, $options);
-
+    
     /**
      * return list off all folders
      * @return array  of Syncroton_Model_IFolder
      */
     public function getAllFolders();
-
-    public function getChangedEntries($folderId, Syncroton_Model_ISyncState $syncState, $filterType = null);
-
-    /**
-     * Retrieve extra data that is stored with the sync key
-     * @return string|null
-     **/
-    public function getExtraData(Syncroton_Model_IFolder $folder);
-
-
+    
+    public function getChangedEntries($folderId, DateTime $startTimeStamp, DateTime $endTimeStamp = NULL, $filterType = NULL);
+    
     /**
      * retrieve folders which were modified since last sync
-     *
+     * 
      * @param DateTime $startTimeStamp
      * @param DateTime $endTimeStamp
      */
     public function getChangedFolders(DateTime $startTimeStamp, DateTime $endTimeStamp);
-
+    
     public function getCountOfChanges(Syncroton_Backend_IContent $contentBackend, Syncroton_Model_IFolder $folder, Syncroton_Model_ISyncState $syncState);
-
+    
     /**
-     *
+     * 
      * @param Syncroton_Model_SyncCollection $collection
      * @param string $serverId
-     * @return Syncroton_Model_IXMLEntry
+     * @return Syncroton_Model_IEntry
      */
     public function getEntry(Syncroton_Model_SyncCollection $collection, $serverId);
-
+    
     /**
-     *
+     * 
      * @param string $fileReference
      * @return Syncroton_Model_FileReference
      */
     public function getFileReference($fileReference);
-
+    
     /**
-     * return array of all id's stored in folder
-     *
-     * @param  Syncroton_Model_IFolder|string  $folderId
-     * @param  string                          $filter
-     * @return array
-     */
+     * return array of all id's stored in folder 
+     * 
+     * @param  Syncroton_Model_IFolder|string  $folderId
+     * @param  string                          $filter
+     * @return array
+     */
     public function getServerEntries($folderId, $filter);
 
     /**
      * return true if any data got modified in the backend
-     *
+     * 
      * @param  Syncroton_Backend_IContent  $contentBackend
      * @param  Syncroton_Model_IFolder     $folder
      * @param  Syncroton_Model_ISyncState  $syncState
      * @return bool
      */
     public function hasChanges(Syncroton_Backend_IContent $contentBackend, Syncroton_Model_IFolder $folder, Syncroton_Model_ISyncState $syncState);
-
+    
     public function moveItem($srcFolderId, $serverId, $dstFolderId);
-
+    
     /**
      * update existing entry
-     *
+     * 
      * @param  string                  $folderId
      * @param  string                  $serverId
      * @param  Syncroton_Model_IEntry  $entry
      * @return string  id of updated entry
      */
     public function updateEntry($folderId, $serverId, Syncroton_Model_IEntry $entry);
-
+    
     public function updateFolder(Syncroton_Model_IFolder $folder);
 }
+

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Data/IDataCalendar.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Data/IDataEmail.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Data/Notes.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Data/Tasks.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Exception/Status.php Changed

@@ -20,87 +20,87 @@
 class Syncroton_Exception_Status extends Syncroton_Exception
 {
     // http://msdn.microsoft.com/en-us/library/ee218647%28v=exchg.80%29
-    public const INVALID_CONTENT                    = 101;
-    public const INVALID_WBXML                      = 102;
-    public const INVALID_XML                        = 103;
-    public const INVALID_DATE_TIME                  = 104;
-    public const INVALID_COMBINATION_OF_IDS         = 105;
-    public const INVALID_IDS                        = 106;
-    public const INVALID_MIME                       = 107;
-    public const DEVICE_MISSING_OR_INVALID          = 108;
-    public const DEVICE_TYPE_MISSING_OR_INVALID     = 109;
-    public const SERVER_ERROR                       = 110;
-    public const SERVER_ERROR_RETRY_LATER           = 111;
-    public const ACTIVE_DIRECTORY_ACCESS_DENIED     = 112;
-    public const MAILBOX_QUOTA_EXCEEDED             = 113;
-    public const MAILBOX_SERVER_OFFLINE             = 114;
-    public const SEND_QUOTA_EXCEEDED                = 115;
-    public const MESSAGE_RECIPIENT_UNRESOLVED       = 116;
-    public const MESSAGE_REPLY_NOT_ALLOWED          = 117;
-    public const MESSAGE_PREVIOUSLY_SENT            = 118;
-    public const MESSAGE_HAS_NO_RECIPIENT           = 119;
-    public const MAIL_SUBMISSION_FAILED             = 120;
-    public const MESSAGE_REPLY_FAILED               = 121;
-    public const ATTACHMENT_IS_TOO_LARGE            = 122;
-    public const USER_HAS_NO_MAILBOX                = 123;
-    public const USER_CANNOT_BE_ANONYMOUS           = 124;
-    public const USER_PRINCIPAL_COULD_NOT_BE_FOUND  = 125;
-    public const USER_DISABLED_FOR_SYNC             = 126;
-    public const USER_ON_NEW_MAILBOX_CANNOT_SYNC    = 127;
-    public const USER_ON_LEGACY_MAILBOX_CANNOT_SYNC = 128;
-    public const DEVICE_IS_BLOCKED_FOR_THIS_USER    = 129;
-    public const ACCESS_DENIED                      = 130;
-    public const ACCOUNT_DISABLED                   = 131;
-    public const SYNC_STATE_NOT_FOUND               = 132;
-    public const SYNC_STATE_LOCKED                  = 133;
-    public const SYNC_STATE_CORRUPT                 = 134;
-    public const SYNC_STATE_ALREADY_EXISTS          = 135;
-    public const SYNC_STATE_VERSION_INVALID         = 136;
-    public const COMMAND_NOT_SUPPORTED              = 137;
-    public const VERSION_NOT_SUPPORTED              = 138;
-    public const DEVICE_NOT_FULLY_PROVISIONABLE     = 139;
-    public const REMOTE_WIPE_REQUESTED              = 140;
-    public const LEGACY_DEVICE_ON_STRICT_POLICY     = 141;
-    public const DEVICE_NOT_PROVISIONED             = 142;
-    public const POLICY_REFRESH                     = 143;
-    public const INVALID_POLICY_KEY                 = 144;
-    public const EXTERNALLY_MANAGED_DEVICES_NOT_ALLOWED = 145;
-    public const NO_RECURRENCE_IN_CALENDAR          = 146;
-    public const UNEXPECTED_ITEM_CLASS              = 147;
-    public const REMOTE_SERVER_HAS_NO_SSL           = 148;
-    public const INVALID_STORED_REQUEST             = 149;
-    public const ITEM_NOT_FOUND                     = 150;
-    public const TOO_MANY_FOLDERS                   = 151;
-    public const NO_FOLDERS_FOUND                   = 152;
-    public const ITEMS_LOST_AFTER_MOVE              = 153;
-    public const FAILURE_IN_MOVE_OPERATION          = 154;
-    public const MOVE_COMMAND_DISALLOWED            = 155;
-    public const MOVE_COMMAND_INVALID_DESTINATION   = 156;
-    public const AVAILABILITY_TO_MANY_RECIPIENTS    = 160;
-    public const AVAILABILITY_DL_LIMIT_REACHED      = 161;
-    public const AVAILABILITY_TRANSIENT_FAILURE     = 162;
-    public const AVAILABILITY_FAILURE               = 163;
-    public const BODY_PART_PREFERENCE_TYPE_NOT_SUPPORTED = 164;
-    public const DEVICE_INFORMATION_REQUIRED        = 165;
-    public const INVALID_ACCOUNT_ID                 = 166;
-    public const ACCOUNT_SEND_DISABLED              = 167;
-    public const IRM_FEATURE_DISABLED               = 168;
-    public const IRM_TRANSIENT_ERROR                = 169;
-    public const IRM_PERMANENT_ERROR                = 170;
-    public const IRM_INVALID_TEMPLATE_ID            = 171;
-    public const IRM_OPERATION_NOT_PERMITTED        = 172;
-    public const NO_PICTURE                         = 173;
-    public const PICTURE_TO_LARGE                   = 174;
-    public const PICTURE_LIMIT_REACHED              = 175;
-    public const BODY_PART_CONVERSATION_TOO_LARGE   = 176;
-    public const MAXIMUM_DEVICES_REACHED            = 177;
+    const INVALID_CONTENT                    = 101;
+    const INVALID_WBXML                      = 102;
+    const INVALID_XML                        = 103;
+    const INVALID_DATE_TIME                  = 104;
+    const INVALID_COMBINATION_OF_IDS         = 105;
+    const INVALID_IDS                        = 106;
+    const INVALID_MIME                       = 107;
+    const DEVICE_MISSING_OR_INVALID          = 108;
+    const DEVICE_TYPE_MISSING_OR_INVALID     = 109;
+    const SERVER_ERROR                       = 110;
+    const SERVER_ERROR_RETRY_LATER           = 111;
+    const ACTIVE_DIRECTORY_ACCESS_DENIED     = 112;
+    const MAILBOX_QUOTA_EXCEEDED             = 113;
+    const MAILBOX_SERVER_OFFLINE             = 114;
+    const SEND_QUOTA_EXCEEDED                = 115;
+    const MESSAGE_RECIPIENT_UNRESOLVED       = 116;
+    const MESSAGE_REPLY_NOT_ALLOWED          = 117;
+    const MESSAGE_PREVIOUSLY_SENT            = 118;
+    const MESSAGE_HAS_NO_RECIPIENT           = 119;
+    const MAIL_SUBMISSION_FAILED             = 120;
+    const MESSAGE_REPLY_FAILED               = 121;
+    const ATTACHMENT_IS_TOO_LARGE            = 122;
+    const USER_HAS_NO_MAILBOX                = 123;
+    const USER_CANNOT_BE_ANONYMOUS           = 124;
+    const USER_PRINCIPAL_COULD_NOT_BE_FOUND  = 125;
+    const USER_DISABLED_FOR_SYNC             = 126;
+    const USER_ON_NEW_MAILBOX_CANNOT_SYNC    = 127;
+    const USER_ON_LEGACY_MAILBOX_CANNOT_SYNC = 128;
+    const DEVICE_IS_BLOCKED_FOR_THIS_USER    = 129;
+    const ACCESS_DENIED                      = 130;
+    const ACCOUNT_DISABLED                   = 131;
+    const SYNC_STATE_NOT_FOUND               = 132;
+    const SYNC_STATE_LOCKED                  = 133;
+    const SYNC_STATE_CORRUPT                 = 134;
+    const SYNC_STATE_ALREADY_EXISTS          = 135;
+    const SYNC_STATE_VERSION_INVALID         = 136;
+    const COMMAND_NOT_SUPPORTED              = 137;
+    const VERSION_NOT_SUPPORTED              = 138;
+    const DEVICE_NOT_FULLY_PROVISIONABLE     = 139;
+    const REMOTE_WIPE_REQUESTED              = 140;
+    const LEGACY_DEVICE_ON_STRICT_POLICY     = 141;
+    const DEVICE_NOT_PROVISIONED             = 142;
+    const POLICY_REFRESH                     = 143;
+    const INVALID_POLICY_KEY                 = 144;
+    const EXTERNALLY_MANAGED_DEVICES_NOT_ALLOWED = 145;
+    const NO_RECURRENCE_IN_CALENDAR          = 146;
+    const UNEXPECTED_ITEM_CLASS              = 147;
+    const REMOTE_SERVER_HAS_NO_SSL           = 148;
+    const INVALID_STORED_REQUEST             = 149;
+    const ITEM_NOT_FOUND                     = 150;
+    const TOO_MANY_FOLDERS                   = 151;
+    const NO_FOLDERS_FOUND                   = 152;
+    const ITEMS_LOST_AFTER_MOVE              = 153;
+    const FAILURE_IN_MOVE_OPERATION          = 154;
+    const MOVE_COMMAND_DISALLOWED            = 155;
+    const MOVE_COMMAND_INVALID_DESTINATION   = 156;
+    const AVAILABILITY_TO_MANY_RECIPIENTS    = 160;
+    const AVAILABILITY_DL_LIMIT_REACHED      = 161;
+    const AVAILABILITY_TRANSIENT_FAILURE     = 162;
+    const AVAILABILITY_FAILURE               = 163;
+    const BODY_PART_PREFERENCE_TYPE_NOT_SUPPORTED = 164;
+    const DEVICE_INFORMATION_REQUIRED        = 165;
+    const INVALID_ACCOUNT_ID                 = 166;
+    const ACCOUNT_SEND_DISABLED              = 167;
+    CONST IRM_FEATURE_DISABLED               = 168;
+    const IRM_TRANSIENT_ERROR                = 169;
+    const IRM_PERMANENT_ERROR                = 170;
+    const IRM_INVALID_TEMPLATE_ID            = 171;
+    const IRM_OPERATION_NOT_PERMITTED        = 172;
+    const NO_PICTURE                         = 173;
+    const PICTURE_TO_LARGE                   = 174;
+    const PICTURE_LIMIT_REACHED              = 175;
+    const BODY_PART_CONVERSATION_TOO_LARGE   = 176;
+    const MAXIMUM_DEVICES_REACHED            = 177;
 
     /**
      * Common error messages assigned to error codes
      *
      * @var array
      */
-    protected $_commonMessages = 
+    protected $_commonMessages = array(
         self::INVALID_CONTENT                    => "Invalid request body",
         self::INVALID_WBXML                      => "Invalid WBXML request",
         self::INVALID_XML                        => "Invalid XML request",
@@ -175,20 +175,20 @@
         self::PICTURE_LIMIT_REACHED              => "The number of contact photos returned exceeds the size limit set by the MaxPictures element",
         self::BODY_PART_CONVERSATION_TOO_LARGE   => "The conversation is too large to compute the body parts",
         self::MAXIMUM_DEVICES_REACHED            => "The user's account has too many device partnerships",
-    ;
+    );
 
     /**
      * Error messages assigned to class-specific error codes
      *
      * @var array
      */
-    protected $_errorMessages = ;
+    protected $_errorMessages = array();
 
 
     /**
      * Constructor
      */
-    public function __construct()
+    function __construct()
     {
         $args = func_get_args();
 
@@ -202,7 +202,7 @@
             $message = $args0;
         }
 
-        if (empty($code)) {
+        if (!$code) {
             $code = self::SERVER_ERROR;
         }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Exception/Status/Autodiscover.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Exception/Status/FolderCreate.php Changed

@@ -19,21 +19,21 @@
  */
 class Syncroton_Exception_Status_FolderCreate extends Syncroton_Exception_Status
 {
-    public const FOLDER_EXISTS       = 2;
-    public const SPECIAL_FOLDER      = 3;
-    public const PARENT_NOT_FOUND    = 5;
-    public const FOLDER_SERVER_ERROR = 6;
-    public const INVALID_SYNCKEY     = 9;
-    public const INVALID_REQUEST     = 10;
-    public const UNKNOWN_ERROR       = 11;
-    public const UNKNOWN_CODE        = 12;
+    const FOLDER_EXISTS       = 2;
+    const SPECIAL_FOLDER      = 3;
+    const PARENT_NOT_FOUND    = 5;
+    const FOLDER_SERVER_ERROR = 6;
+    const INVALID_SYNCKEY     = 9;
+    const INVALID_REQUEST     = 10;
+    const UNKNOWN_ERROR       = 11;
+    const UNKNOWN_CODE        = 12;
 
     /**
      * Error messages assigned to error codes
      *
      * @var array
      */
-    protected $_errorMessages = 
+    protected $_errorMessages = array(
         self::FOLDER_EXISTS       => "A folder that has this name already exists",
         self::SPECIAL_FOLDER      => "The specified folder is a special system folder",
         self::PARENT_NOT_FOUND    => "The specified parent folder was not found",
@@ -42,5 +42,5 @@
         self::INVALID_REQUEST     => "Malformed request",
         self::UNKNOWN_ERROR       => "An unknown error occurred",
         self::UNKNOWN_CODE        => "Unusual back-end issue",
-    ;
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Exception/Status/FolderDelete.php Changed

@@ -19,24 +19,24 @@
  */
 class Syncroton_Exception_Status_FolderDelete extends Syncroton_Exception_Status
 {
-    public const SPECIAL_FOLDER      = 3;
-    public const FOLDER_NOT_FOUND    = 4;
-    public const FOLDER_SERVER_ERROR = 6;
-    public const INVALID_SYNCKEY     = 9;
-    public const INVALID_REQUEST     = 10;
-    public const UNKNOWN_ERROR       = 11;
+    const SPECIAL_FOLDER      = 3;
+    const FOLDER_NOT_FOUND    = 4;
+    const FOLDER_SERVER_ERROR = 6;
+    const INVALID_SYNCKEY     = 9;
+    const INVALID_REQUEST     = 10;
+    const UNKNOWN_ERROR       = 11;
 
     /**
      * Error messages assigned to error codes
      *
      * @var array
      */
-    protected $_errorMessages = 
+    protected $_errorMessages = array(
         self::SPECIAL_FOLDER      => "The specified folder is a special system folder",
         self::FOLDER_NOT_FOUND    => "The specified folder doesn't exist",
         self::FOLDER_SERVER_ERROR => "An error occurred on the server",
         self::INVALID_SYNCKEY     => "Synchronization key mismatch or invalid synchronization key",
         self::INVALID_REQUEST     => "Malformed request",
         self::UNKNOWN_ERROR       => "An unknown error occurred",
-    ;
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Exception/Status/FolderSync.php Changed

@@ -19,22 +19,22 @@
  */
 class Syncroton_Exception_Status_FolderSync extends Syncroton_Exception_Status
 {
-    public const FOLDER_SERVER_ERROR = 6;
-    public const INVALID_SYNCKEY     = 9;
-    public const INVALID_REQUEST     = 10;
-    public const UNKNOWN_ERROR       = 11;
-    public const UNKNOWN_CODE        = 12;
+    const FOLDER_SERVER_ERROR = 6;
+    const INVALID_SYNCKEY     = 9;
+    const INVALID_REQUEST     = 10;
+    const UNKNOWN_ERROR       = 11;
+    const UNKNOWN_CODE        = 12;
 
     /**
      * Error messages assigned to error codes
      *
      * @var array
      */
-    protected $_errorMessages = 
+    protected $_errorMessages = array(
         self::FOLDER_SERVER_ERROR => "An error occurred on the server",
         self::INVALID_SYNCKEY     => "Synchronization key mismatch or invalid synchronization key",
         self::INVALID_REQUEST     => "Malformed request",
         self::UNKNOWN_ERROR       => "An unknown error occurred",
         self::UNKNOWN_CODE        => "Unusual back-end issue",
-    ;
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Exception/Status/FolderUpdate.php Changed

@@ -19,21 +19,21 @@
  */
 class Syncroton_Exception_Status_FolderUpdate extends Syncroton_Exception_Status
 {
-    public const FOLDER_EXISTS       = 2;
-    public const SPECIAL_FOLDER      = 3;
-    public const FOLDER_NOT_FOUND    = 4;
-    public const PARENT_NOT_FOUND    = 5;
-    public const FOLDER_SERVER_ERROR = 6;
-    public const INVALID_SYNCKEY     = 9;
-    public const INVALID_REQUEST     = 10;
-    public const UNKNOWN_ERROR       = 11;
+    const FOLDER_EXISTS       = 2;
+    const SPECIAL_FOLDER      = 3;
+    const FOLDER_NOT_FOUND    = 4;
+    const PARENT_NOT_FOUND    = 5;
+    const FOLDER_SERVER_ERROR = 6;
+    const INVALID_SYNCKEY     = 9;
+    const INVALID_REQUEST     = 10;
+    const UNKNOWN_ERROR       = 11;
 
     /**
      * Error messages assigned to error codes
      *
      * @var array
      */
-    protected $_errorMessages = 
+    protected $_errorMessages = array(
         self::FOLDER_EXISTS       => "A folder that has this name already exists or is a special folder",
         self::SPECIAL_FOLDER      => "The specified folder is the Recipient information folder which cannot be updated",
         self::FOLDER_NOT_FOUND    => "The specified folder doesn't exist",
@@ -42,5 +42,5 @@
         self::INVALID_SYNCKEY     => "Synchronization key mismatch or invalid synchronization key",
         self::INVALID_REQUEST     => "Malformed request",
         self::UNKNOWN_ERROR       => "An unknown error occurred",
-    ;
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Exception/Status/GetItemEstimate.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Exception/Status/ItemOperations.php Changed

@@ -19,29 +19,29 @@
  */
 class Syncroton_Exception_Status_ItemOperations extends Syncroton_Exception_Status
 {
-    public const PROTOCOL_ERROR         = 2;
-    public const ITEM_SERVER_ERROR      = 3;
-    public const DOCLIB_INVALID_URI     = 4;
-    public const DOCLIB_ACCESS_DENIED   = 5;
-    public const DOCLIB_NOT_FOUND       = 6;
-    public const DOCLIB_CONN_FAILED     = 7;
-    public const INVALID_BYTE_RANGE     = 8;
-    public const UNKNOWN_STORE          = 9;
-    public const FILE_EMPTY             = 10;
-    public const DATA_TOO_LARGE         = 11;
-    public const FILE_IO_ERROR          = 12;
-    public const CONVERSION_ERROR       = 14;
-    public const INVALID_ATTACHMENT     = 15;
-    public const RESOURCE_ACCESS_DENIED = 16;
-    public const PARTIAL_SUCCESS        = 17;
-    public const CREDENTIALS_REQUIRED   = 18;
+    const PROTOCOL_ERROR         = 2;
+    const ITEM_SERVER_ERROR      = 3;
+    const DOCLIB_INVALID_URI     = 4;
+    const DOCLIB_ACCESS_DENIED   = 5;
+    const DOCLIB_NOT_FOUND       = 6;
+    const DOCLIB_CONN_FAILED     = 7;
+    const INVALID_BYTE_RANGE     = 8;
+    const UNKNOWN_STORE          = 9;
+    const FILE_EMPTY             = 10;
+    const DATA_TOO_LARGE         = 11;
+    const FILE_IO_ERROR          = 12;
+    const CONVERSION_ERROR       = 14;
+    const INVALID_ATTACHMENT     = 15;
+    const RESOURCE_ACCESS_DENIED = 16;
+    const PARTIAL_SUCCESS        = 17;
+    const CREDENTIALS_REQUIRED   = 18;
 
     /**
      * Error messages assigned to error codes
      *
      * @var array
      */
-    protected $_errorMessages = 
+    protected $_errorMessages = array(
         self::PROTOCOL_ERROR         => "Protocol error - protocol violation/XML validation error",
         self::ITEM_SERVER_ERROR      => "Server error",
         self::DOCLIB_INVALID_URI     => "Document library access - The specified URI is bad",
@@ -58,5 +58,5 @@
         self::RESOURCE_ACCESS_DENIED => "Access to the resource is denied",
         self::PARTIAL_SUCCESS        => "Partial success; the command completed partially",
         self::CREDENTIALS_REQUIRED   => "Credentials required",
-    ;
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Exception/Status/MeetingResponse.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Exception/Status/MoveItems.php Changed

@@ -19,22 +19,22 @@
  */
 class Syncroton_Exception_Status_MoveItems extends Syncroton_Exception_Status
 {
-    public const INVALID_SOURCE          = 1;
-    public const INVALID_DESTINATION     = 2;
-    public const SAME_FOLDER             = 4;
-    public const ITEM_EXISTS_OR_LOCKED   = 5;
-    public const FOLDER_LOCKED           = 7;
+    const INVALID_SOURCE          = 1;
+    const INVALID_DESTINATION     = 2;
+    const SAME_FOLDER             = 4;
+    const ITEM_EXISTS_OR_LOCKED   = 5;
+    const FOLDER_LOCKED           = 7;
 
     /**
      * Error messages assigned to error codes
      *
      * @var array
      */
-    protected $_errorMessages = 
+    protected $_errorMessages = array(
         self::INVALID_SOURCE          => "Invalid source collection ID or item ID",
         self::INVALID_DESTINATION     => "Invalid destination collection ID",
         self::SAME_FOLDER             => "Source and destination collection IDs are the same",
         self::ITEM_EXISTS_OR_LOCKED   => "The item cannot be moved to more than one item at a time, or the source or destination item was locked",
         self::FOLDER_LOCKED           => "Source or destination item was locked",
-    ;
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Exception/Status/Settings.php Changed

@@ -19,24 +19,24 @@
  */
 class Syncroton_Exception_Status_Settings extends Syncroton_Exception_Status
 {
-    public const PROTOCOL_ERROR         = 2;
-    public const ACCESS_DENIED          = 3;
-    public const SERVICE_UNAVAILABLE    = 4;
-    public const INVALID_ARGUMENTS      = 5;
-    public const CONFLICTING_ARGUMENTS  = 6;
-    public const DENIED_BY_POLICY       = 7;
+    const PROTOCOL_ERROR         = 2;
+    const ACCESS_DENIED          = 3;
+    const SERVICE_UNAVAILABLE    = 4;
+    const INVALID_ARGUMENTS      = 5;
+    const CONFLICTING_ARGUMENTS  = 6;
+    const DENIED_BY_POLICY       = 7;
 
     /**
      * Error messages assigned to error codes
      *
      * @var array
      */
-    protected $_errorMessages = 
+    protected $_errorMessages = array(
         self::PROTOCOL_ERROR        => "Protocol error",
         self::ACCESS_DENIED         => "Access denied",
         self::SERVICE_UNAVAILABLE   => "Server unavailable",
         self::INVALID_ARGUMENTS     => "Invalid arguments",
         self::CONFLICTING_ARGUMENTS => "Conflicting arguments",
         self::DENIED_BY_POLICY      => "Denied by policy. Disabled by administrator",
-    ;
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Exception/Status/Sync.php Changed

@@ -19,25 +19,25 @@
  */
 class Syncroton_Exception_Status_Sync extends Syncroton_Exception_Status
 {
-    public const INVALID_SYNCKEY     = 3;
-    public const PROTOCOL_ERROR      = 4;
-    public const SYNC_SERVER_ERROR   = 5;
-    public const INVALID_ITEM        = 6;
-    public const OBJECT_CONFLICT     = 7;
-    public const OBJECT_NOT_FOUND    = 8;
-    public const SYNC_ERROR          = 9;
-    public const HIERARCHY_CHANGED   = 12;
-    public const INCOMPLETE_REQUEST  = 13;
-    public const INVALID_INTERVAL    = 14;
-    public const INVALID_REQUEST     = 15;
-    public const SYNC_RETRY          = 16;
+    const INVALID_SYNCKEY     = 3;
+    const PROTOCOL_ERROR      = 4;
+    const SYNC_SERVER_ERROR   = 5;
+    const INVALID_ITEM        = 6;
+    const OBJECT_CONFLICT     = 7;
+    const OBJECT_NOT_FOUND    = 8;
+    const SYNC_ERROR          = 9;
+    const HIERARCHY_CHANGED   = 12;
+    const INCOMPLETE_REQUEST  = 13;
+    const INVALID_INTERVAL    = 14;
+    const INVALID_REQUEST     = 15;
+    const SYNC_RETRY          = 16;
 
     /**
      * Error messages assigned to error codes
      *
      * @var array
      */
-    protected $_errorMessages = 
+    protected $_errorMessages = array(
         self::INVALID_SYNCKEY     => "Invalid synchronization key",
         self::PROTOCOL_ERROR      => "Protocol error",
         self::SYNC_SERVER_ERROR   => "Server error",
@@ -50,5 +50,5 @@
         self::INVALID_INTERVAL    => "Invalid Wait or HeartbeatInterval value",
         self::INVALID_REQUEST     => "Too many collections are included in the Sync request",
         self::SYNC_RETRY          => "Something on the server caused a retriable error",
-    ;
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/AEntry.php Changed

@@ -15,12 +15,13 @@
  * @package     Syncroton
  * @subpackage  Model
  */
+
 abstract class Syncroton_Model_AEntry implements Syncroton_Model_IEntry, IteratorAggregate, Countable
 {
-    protected $_elements = ;
-
+    protected $_elements = array();
+    
     protected $_isDirty;
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Model_IEntry::__construct()
@@ -30,31 +31,31 @@
         if (is_array($properties)) {
             $this->setFromArray($properties);
         }
-
+        
         $this->_isDirty = false;
     }
-
-
+    
+    
     /**
      * (non-PHPdoc)
      * @see Countable::count()
-     */
+     */    
     #\ReturnTypeWillChange
     public function count()
     {
         return count($this->_elements);
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see IteratorAggregate::getIterator()
      */
     #\ReturnTypeWillChange
-    public function getIterator()
-    {
-        return new ArrayIterator($this->_elements);
+    public function getIterator() 
+    {
+        return new ArrayIterator($this->_elements);
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Model_IEntry::isDirty()
@@ -63,7 +64,7 @@
     {
         return $this->_isDirty;
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Model_IEntry::setFromArray()
@@ -79,28 +80,28 @@
             }
         }
     }
-
-    public function &__get($name)
-    {
-        return $this->_elements$name;
-    }
-
-    public function __set($name, $value)
+        
+    public function &__get($name)
+    {
+        return $this->_elements$name;
+    }
+    
+    public function __set($name, $value)
     {
         if (!array_key_exists($name, $this->_elements) || $this->_elements$name != $value) {
             $this->_elements$name = $value;
-
+            
             $this->_isDirty = true;
-        }
-    }
-
-    public function __isset($name)
-    {
-        return isset($this->_elements$name);
-    }
-
-    public function __unset($name)
-    {
-        unset($this->_elements$name);
+        }
+    }
+    
+    public function __isset($name)
+    {
+        return isset($this->_elements$name);
+    }
+    
+    public function __unset($name)
+    {
+        unset($this->_elements$name);
     }
-}
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/AXMLEntry.php Changed

@@ -19,11 +19,11 @@
 abstract class Syncroton_Model_AXMLEntry extends Syncroton_Model_AEntry implements Syncroton_Model_IXMLEntry
 {
     protected $_xmlBaseElement;
-
-    protected $_properties = ;
-
+    
+    protected $_properties = array();
+    
     protected $_dateTimeFormat = "Y-m-d\TH:i:s.000\Z";
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Model_IEntry::__construct()
@@ -35,10 +35,10 @@
         } elseif (is_array($properties)) {
             $this->setFromArray($properties);
         }
-
+        
         $this->_isDirty = false;
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Model_IEntry::appendXML()
@@ -46,27 +46,27 @@
     public function appendXML(DOMElement $domParrent, Syncroton_Model_IDevice $device)
     {
         $this->_addXMLNamespaces($domParrent);
-
+        
         foreach($this->_elements as $elementName => $value) {
             // skip empty values
             if($value === null || $value === '' || (is_array($value) && empty($value))) {
                 continue;
             }
-
-            $nameSpace, $elementProperties = $this->_getElementProperties($elementName);
-
-            if ($nameSpace == 'Internal') {
-                continue;
-            }
-
-            $elementVersion = $elementProperties'supportedSince' ?? '12.0';
-
+            
+            list ($nameSpace, $elementProperties) = $this->_getElementProperties($elementName);
+            
+            if ($nameSpace == 'Internal') {
+                continue;
+            }
+            
+            $elementVersion = isset($elementProperties'supportedSince') ? $elementProperties'supportedSince' : '12.0';
+            
             if (version_compare($device->acsversion, $elementVersion, '<')) {
                 continue;
             }
-
+            
             $nameSpace = 'uri:' . $nameSpace;
-
+            
             if (isset($elementProperties'childElement')) {
                 $element = $domParrent->ownerDocument->createElementNS($nameSpace, ucfirst($elementName));
                 foreach($value as $subValue) {
@@ -75,13 +75,13 @@
                     $element->appendChild($subElement);
                 }
                 $domParrent->appendChild($element);
-            } elseif ($elementProperties'type' == 'container' && !empty($elementProperties'multiple')) {
+            } else if ($elementProperties'type' == 'container' && !empty($elementProperties'multiple')) {
                 foreach ($value as $element) {
                     $container = $domParrent->ownerDocument->createElementNS($nameSpace, ucfirst($elementName));
                     $element->appendXML($container, $device);
                     $domParrent->appendChild($container);
                 }
-            } elseif ($elementProperties'type' == 'none') {
+            } else if ($elementProperties'type' == 'none') {
                 if ($value) {
                     $element = $domParrent->ownerDocument->createElementNS($nameSpace, ucfirst($elementName));
                     $domParrent->appendChild($element);
@@ -93,80 +93,80 @@
             }
         }
     }
-
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Model_IEntry::getProperties()
      */
     public function getProperties($selectedNamespace = null)
     {
-        $properties = ;
-
+        $properties = array();
+        
         foreach($this->_properties as $namespace => $namespaceProperties) {
             if ($selectedNamespace !== null && $namespace != $selectedNamespace) {
                 continue;
             }
-            $properties = array_merge($properties, array_keys($namespaceProperties));
+            $properties = array_merge($properties, array_keys($namespaceProperties));
         }
-
+        
         return $properties;
-
+        
     }
-
-    /**
-     * set properties from SimpleXMLElement object
-     *
-     * @param SimpleXMLElement $properties
-     * @throws InvalidArgumentException
-     */
-    public function setFromSimpleXMLElement(SimpleXMLElement $properties)
-    {
+    
+    /**
+     * set properties from SimpleXMLElement object
+     *
+     * @param SimpleXMLElement $xmlCollection
+     * @throws InvalidArgumentException
+     */
+    public function setFromSimpleXMLElement(SimpleXMLElement $properties)
+    {
         if (!in_array($properties->getName(), (array) $this->_xmlBaseElement)) {
-            throw new InvalidArgumentException('Unexpected element name: ' . $properties->getName());
-        }
-
+            throw new InvalidArgumentException('Unexpected element name: ' . $properties->getName());
+        }
+    
         foreach (array_keys($this->_properties) as $namespace) {
             if ($namespace == 'Internal') {
                 continue;
             }
-
-            $this->_parseNamespace($namespace, $properties);
-        }
-
-        return;
+            
+            $this->_parseNamespace($namespace, $properties);
+        }
+    
+        return;
     }
-
+    
     /**
      * add needed xml namespaces to DomDocument
-     *
-     * @param DOMElement $domParent
+     * 
+     * @param unknown_type $domParrent
      */
-    protected function _addXMLNamespaces(DOMElement $domParent)
+    protected function _addXMLNamespaces(DOMElement $domParrent)
     {
-        foreach ($this->_properties as $namespace => $namespaceProperties) {
+        foreach($this->_properties as $namespace => $namespaceProperties) {
             // don't add default namespace again
-            if ($domParent->ownerDocument->documentElement->namespaceURI != 'uri:' . $namespace) {
-                $domParent->ownerDocument->documentElement->setAttributeNS('http://www.w3.org/2000/xmlns/', 'xmlns:' . $namespace, 'uri:' . $namespace);
-            }
+            if($domParrent->ownerDocument->documentElement->namespaceURI != 'uri:'.$namespace) {
+                $domParrent->ownerDocument->documentElement->setAttributeNS('http://www.w3.org/2000/xmlns/', 'xmlns:'.$namespace, 'uri:'.$namespace);
+            }
         }
-    }
-
+    }
+    
     protected function _appendXMLElement(Syncroton_Model_IDevice $device, DOMElement $element, $elementProperties, $value)
     {
-        if ($value instanceof Syncroton_Model_IEntry) {
-            $value->appendXML($element, $device); // @phpstan-ignore-line
-        } else {
-            if ($value instanceof DateTime) {
+        if ($value instanceof Syncroton_Model_IEntry) {
+            $value->appendXML($element, $device);
+        } else {
+            if ($value instanceof DateTime) {
                 $value = $value->format($this->_dateTimeFormat);
-
-            } elseif (isset($elementProperties'encoding') && $elementProperties'encoding' == 'base64') {
-                if (is_resource($value)) {
+                
+            } elseif (isset($elementProperties'encoding') && $elementProperties'encoding' == 'base64') {
+                if (is_resource($value)) {
                     rewind($value);
-                    $value = stream_get_contents($value);
-                }
-                $value = base64_encode($value);
-            }
-
+                    $value = stream_get_contents($value);
+                }
+                $value = base64_encode($value);
+            }
+            
             if ($elementProperties'type' == 'byteArray') {
                 $element->setAttributeNS('uri:Syncroton', 'Syncroton:encoding', 'opaque');
                 // encode to base64; the wbxml encoder will base64_decode it again
@@ -177,12 +177,12 @@
                 if (!ctype_print((string)$value)) {
                     $value = $this->_removeControlChars($value);
                 }
-
+                
                 $element->appendChild($element->ownerDocument->createTextNode($this->_enforceUTF8($value)));
-            }
-        }
+            }
+        }
     }
-
+    
     /**
      * remove control chars from a string which are not allowed in XML values
      *
@@ -193,15 +193,15 @@
     {
         // Replace non-character UTF-8 sequences that cause XML Parser to fail
         // https://git.kolab.org/T1311
-        $dirty = str_replace("\xEF\xBF\xBE", "\xEF\xBF\xBF", '', $dirty);
+        $dirty = str_replace(array("\xEF\xBF\xBE", "\xEF\xBF\xBF"), '', $dirty);
 
         // Replace ASCII control-characters
         return preg_replace('/\x00-\x08\x0B\x0C\x0E-\x1F/', '', $dirty);
     }
-
+    
     /**
      * enforce >valid< utf-8 encoding
-     *
+     * 
      * @param  string  $dirty  the string with maybe invalid utf-8 data
      * @return string  string with valid utf-8
      */
@@ -212,87 +212,62 @@
                 return $clean;
             }
         }
-
+        
         if (function_exists('mb_convert_encoding')) {
             if (($clean = mb_convert_encoding($dirty, 'UTF-8', 'UTF-8')) !== false) {
                 return $clean;
             }
         }
-
+    
         return $dirty;
     }
-
-    /**
-     * Fix date-time string input
-     *
-     * @param string $date Date time string
-     *
-     * @return string
-     */
-    protected function _fixDateTimeString($date)
-    {
-        // Note: Some clients send date-time in local charset instead of ascii
-        // It is not supported by PHP DateTime constructor
-
-        $from = 
-            '١','٢','٣','٤','٥','٦','٧','٨','٩','٠', // arabic
-            '۱','۲','۳','۴','۵','۶','۷','۸','۹','۰', // persian
-        ;
-
-        $to = 
-            '1','2','3','4','5','6','7','8','9','0',
-            '1','2','3','4','5','6','7','8','9','0',
-        ;
-
-        return str_replace($from, $to, $date);
-    }
-
+    
     /**
-     *
-     * @param string $element
+     * 
+     * @param unknown_type $element
      * @throws InvalidArgumentException
-     * @return array
+     * @return multitype:unknown
      */
-    protected function _getElementProperties($element)
+    protected function _getElementProperties($element)
     {
         foreach($this->_properties as $namespace => $namespaceProperties) {
-            if (array_key_exists($element, $namespaceProperties)) {
-                return $namespace, $namespaceProperties$element;
-            }
-        }
-
-        throw new InvalidArgumentException("$element is no valid property of " . get_class($this));
+            if (array_key_exists($element, $namespaceProperties)) {
+                return array($namespace, $namespaceProperties$element);
+            }
+        }
+        
+        throw new InvalidArgumentException("$element is no valid property of " . get_class($this));
     }
-
+    
     protected function _parseNamespace($nameSpace, SimpleXMLElement $properties)
     {
-        // fetch data from Contacts namespace
-        $children = $properties->children("uri:$nameSpace");
-
+        // fetch data from Contacts namespace
+        $children = $properties->children("uri:$nameSpace");
+        
         foreach ($children as $elementName => $xmlElement) {
             $elementName = lcfirst($elementName);
-
+            
             if (!isset($this->_properties$nameSpace$elementName)) {
                 continue;
             }
-
-            , $elementProperties = $this->_getElementProperties($elementName);
-
+            
+            list (, $elementProperties) = $this->_getElementProperties($elementName);
+            
             switch ($elementProperties'type') {
                 case 'container':
                     if (!empty($elementProperties'multiple')) {
                         $property = (array) $this->$elementName;
-
+                        
                         if (isset($elementProperties'class')) {
                             $property = new $elementProperties'class'($xmlElement);
                         } else {
                             $property = (string) $xmlElement;
                         }
-                    } elseif (isset($elementProperties'childElement')) {
-                        $property = ;
-
+                    } else if (isset($elementProperties'childElement')) {
+                        $property = array();
+                        
                         $childElement = ucfirst($elementProperties'childElement');
-
+                        
                         foreach ($xmlElement->$childElement as $subXmlElement) {
                             if (isset($elementProperties'class')) {
                                 $property = new $elementProperties'class'($subXmlElement);
@@ -301,15 +276,15 @@
                             }
                         }
                     } else {
-                        $subClassName = $elementProperties'class' ?? get_class($this) . ucfirst($elementName);
-
-                        $property = new $subClassName($xmlElement);
+                        $subClassName = isset($elementProperties'class') ? $elementProperties'class' : get_class($this) . ucfirst($elementName);
+                        
+                        $property = new $subClassName($xmlElement);
                     }
-
+                    
                     break;
-
+                    
                 case 'datetime':
-                    $property = new DateTime($this->_fixDateTimeString((string) $xmlElement), new DateTimeZone('UTC'));
+                    $property = new DateTime((string) $xmlElement, new DateTimeZone('UTC'));
                     break;
 
                 case 'number':
@@ -324,30 +299,30 @@
             if (isset($elementProperties'encoding') && $elementProperties'encoding' == 'base64') {
                 $property = base64_decode($property);
             }
-
+            
             $this->$elementName = $property;
-        }
+        }
     }
-
-    public function &__get($name)
-    {
-        $this->_getElementProperties($name);
-
-        return $this->_elements$name;
-    }
-
-    public function __set($name, $value)
-    {
-        $nameSpace, $properties = $this->_getElementProperties($name);
-
-        if ($properties'type' == 'datetime' && !$value instanceof DateTime) {
-            throw new InvalidArgumentException("value for $name must be an instance of DateTime");
-        }
-
-        if (!array_key_exists($name, $this->_elements) || $this->_elements$name != $value) {
+    
+    public function &__get($name)
+    {
+        $this->_getElementProperties($name);
+    
+        return $this->_elements$name;
+    }
+    
+    public function __set($name, $value)
+    {
+        list ($nameSpace, $properties) = $this->_getElementProperties($name);
+        
+        if ($properties'type' == 'datetime' && !$value instanceof DateTime) {
+            throw new InvalidArgumentException("value for $name must be an instance of DateTime");
+        }
+        
+        if (!array_key_exists($name, $this->_elements) || $this->_elements$name != $value) {
             $this->_elements$name = $value;
-
+            
             $this->_isDirty = true;
-        }
-    }
-}
+        }
+    }
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/Account.php Changed

@@ -14,30 +14,30 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property    string  $accountId
- * @property    string  $accountName
- * @property    string  $userDisplayName
- * @property    bool    $sendDisabled
- * @property    string  $primaryAddress
- * @property    array   $addresses
+ * @property    string  accountId
+ * @property    string  accountName
+ * @property    string  userDisplayName
+ * @property    bool    sendDisabled
+ * @property    string  primaryAddress
+ * @property    array   addresses
  */
 class Syncroton_Model_Account extends Syncroton_Model_AXMLEntry
 {
     protected $_xmlBaseElement = 'Account';
 
-    protected $_properties = 
-        'Settings' => 
-            'accountId'       => 'type' => 'string',
-            'accountName'     => 'type' => 'string',
-            'userDisplayName' => 'type' => 'string',
-            'sendDisabled'    => 'type' => 'number',
+    protected $_properties = array(
+        'Settings' => array(
+            'accountId'       => array('type' => 'string'),
+            'accountName'     => array('type' => 'string'),
+            'userDisplayName' => array('type' => 'string'),
+            'sendDisabled'    => array('type' => 'number'),
 //            'emailAddresses'  => array('type' => 'container'),
-        ,
-        'Internal' => 
-            'primaryAddress' => 'type' => 'string',
-            'addresses'      => 'type' => 'array',
-        ,
-    ;
+        ),
+        'Internal' => array(
+            'primaryAddress' => array('type' => 'string'),
+            'addresses'      => array('type' => 'array'),
+        ),
+    );
 
     /**
      * (non-PHPdoc)

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/Contact.php Changed

@@ -14,91 +14,90 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property    string                      $alias
- * @property    DateTime                    $anniversary
- * @property    string                      $assistantName
- * @property    string                      $assistantPhoneNumber
- * @property    DateTime                    $birthday
- * @property    string                      $business2PhoneNumber
- * @property    string                      $businessAddressCity
- * @property    Syncroton_Model_EmailBody   $body
- * @property    string                      $firstName
- * @property    string                      $lastName
+ * @property    string    Alias
+ * @property    DateTime  Anniversary
+ * @property    string    AssistantName
+ * @property    string    AssistantPhoneNumber
+ * @property    DateTime  Birthday
+ * @property    string    Business2PhoneNumber
+ * @property    string    BusinessAddressCity
+ * @property    Syncroton_Model_EmailBody  Body
  */
+
 class Syncroton_Model_Contact extends Syncroton_Model_AXMLEntry
 {
     protected $_xmlBaseElement = 'ApplicationData';
-
-    protected $_properties = 
-        'AirSyncBase' => 
-            'body'                   => 'type' => 'container', 'class' => 'Syncroton_Model_EmailBody',
-        ,
-        'Contacts' => 
-            'alias'                  => 'type' => 'string', 'supportedSince' => '14.0',
-            'anniversary'            => 'type' => 'datetime',
-            'assistantName'          => 'type' => 'string',
-            'assistantPhoneNumber'   => 'type' => 'string',
-            'birthday'               => 'type' => 'datetime',
-            'business2PhoneNumber'   => 'type' => 'string',
-            'businessAddressCity'    => 'type' => 'string',
-            'businessAddressCountry' => 'type' => 'string',
-            'businessAddressPostalCode' => 'type' => 'string',
-            'businessAddressState'   => 'type' => 'string',
-            'businessAddressStreet'  => 'type' => 'string',
-            'businessFaxNumber'      => 'type' => 'string',
-            'businessPhoneNumber'    => 'type' => 'string',
-            'carPhoneNumber'         => 'type' => 'string',
-            'categories'             => 'type' => 'container', 'childElement' => 'category',
-            'children'               => 'type' => 'container', 'childElement' => 'child',
-            'companyName'            => 'type' => 'string',
-            'department'             => 'type' => 'string',
-            'email1Address'          => 'type' => 'string',
-            'email2Address'          => 'type' => 'string',
-            'email3Address'          => 'type' => 'string',
-            'fileAs'                 => 'type' => 'string',
-            'firstName'              => 'type' => 'string',
-            'home2PhoneNumber'       => 'type' => 'string',
-            'homeAddressCity'        => 'type' => 'string',
-            'homeAddressCountry'     => 'type' => 'string',
-            'homeAddressPostalCode'  => 'type' => 'string',
-            'homeAddressState'       => 'type' => 'string',
-            'homeAddressStreet'      => 'type' => 'string',
-            'homeFaxNumber'          => 'type' => 'string',
-            'homePhoneNumber'        => 'type' => 'string',
-            'jobTitle'               => 'type' => 'string',
-            'lastName'               => 'type' => 'string',
-            'middleName'             => 'type' => 'string',
-            'mobilePhoneNumber'      => 'type' => 'string',
-            'officeLocation'         => 'type' => 'string',
-            'otherAddressCity'       => 'type' => 'string',
-            'otherAddressCountry'    => 'type' => 'string',
-            'otherAddressPostalCode' => 'type' => 'string',
-            'otherAddressState'      => 'type' => 'string',
-            'otherAddressStreet'     => 'type' => 'string',
-            'pagerNumber'            => 'type' => 'string',
-            'picture'                => 'type' => 'string', 'encoding' => 'base64',
-            'padioPhoneNumber'       => 'type' => 'string',
-            'rtf'                    => 'type' => 'string',
-            'spouse'                 => 'type' => 'string',
-            'suffix'                 => 'type' => 'string',
-            'title'                  => 'type' => 'string',
-            'webPage'                => 'type' => 'string',
-            'weightedRank'           => 'type' => 'string', 'supportedSince' => '14.0',
-            'yomiCompanyName'        => 'type' => 'string',
-            'yomiFirstName'          => 'type' => 'string',
-            'yomiLastName'           => 'type' => 'string',
-        ,
-        'Contacts2' => 
-            'accountName'            => 'type' => 'string',
-            'companyMainPhone'       => 'type' => 'string',
-            'customerId'             => 'type' => 'string',
-            'governmentId'           => 'type' => 'string',
-            'iMAddress'              => 'type' => 'string',
-            'iMAddress2'             => 'type' => 'string',
-            'iMAddress3'             => 'type' => 'string',
-            'managerName'            => 'type' => 'string',
-            'mMS'                    => 'type' => 'string',
-            'nickName'               => 'type' => 'string',
-        ,
-    ;
-}
+    
+    protected $_properties = array(
+        'AirSyncBase' => array(
+            'body'                   => array('type' => 'container', 'class' => 'Syncroton_Model_EmailBody')
+        ),
+        'Contacts' => array(
+            'alias'                  => array('type' => 'string', 'supportedSince' => '14.0'),
+            'anniversary'            => array('type' => 'datetime'),
+            'assistantName'          => array('type' => 'string'),
+            'assistantPhoneNumber'   => array('type' => 'string'),
+            'birthday'               => array('type' => 'datetime'),
+            'business2PhoneNumber'   => array('type' => 'string'),
+            'businessAddressCity'    => array('type' => 'string'),
+            'businessAddressCountry' => array('type' => 'string'),
+            'businessAddressPostalCode' => array('type' => 'string'),
+            'businessAddressState'   => array('type' => 'string'),
+            'businessAddressStreet'  => array('type' => 'string'),
+            'businessFaxNumber'      => array('type' => 'string'),
+            'businessPhoneNumber'    => array('type' => 'string'),
+            'carPhoneNumber'         => array('type' => 'string'),
+            'categories'             => array('type' => 'container', 'childElement' => 'category'),
+            'children'               => array('type' => 'container', 'childElement' => 'child'),
+            'companyName'            => array('type' => 'string'),
+            'department'             => array('type' => 'string'),
+            'email1Address'          => array('type' => 'string'),
+            'email2Address'          => array('type' => 'string'),
+            'email3Address'          => array('type' => 'string'),
+            'fileAs'                 => array('type' => 'string'),
+            'firstName'              => array('type' => 'string'),
+            'home2PhoneNumber'       => array('type' => 'string'),
+            'homeAddressCity'        => array('type' => 'string'),
+            'homeAddressCountry'     => array('type' => 'string'),
+            'homeAddressPostalCode'  => array('type' => 'string'),
+            'homeAddressState'       => array('type' => 'string'),
+            'homeAddressStreet'      => array('type' => 'string'),
+            'homeFaxNumber'          => array('type' => 'string'),
+            'homePhoneNumber'        => array('type' => 'string'),
+            'jobTitle'               => array('type' => 'string'),
+            'lastName'               => array('type' => 'string'),
+            'middleName'             => array('type' => 'string'),
+            'mobilePhoneNumber'      => array('type' => 'string'),
+            'officeLocation'         => array('type' => 'string'),
+            'otherAddressCity'       => array('type' => 'string'),
+            'otherAddressCountry'    => array('type' => 'string'),
+            'otherAddressPostalCode' => array('type' => 'string'),
+            'otherAddressState'      => array('type' => 'string'),
+            'otherAddressStreet'     => array('type' => 'string'),
+            'pagerNumber'            => array('type' => 'string'),
+            'picture'                => array('type' => 'string', 'encoding' => 'base64'),
+            'padioPhoneNumber'       => array('type' => 'string'),
+            'rtf'                    => array('type' => 'string'),
+            'spouse'                 => array('type' => 'string'),
+            'suffix'                 => array('type' => 'string'),
+            'title'                  => array('type' => 'string'),
+            'webPage'                => array('type' => 'string'),
+            'weightedRank'           => array('type' => 'string', 'supportedSince' => '14.0'),
+            'yomiCompanyName'        => array('type' => 'string'),
+            'yomiFirstName'          => array('type' => 'string'),
+            'yomiLastName'           => array('type' => 'string'),
+        ),
+        'Contacts2' => array(
+            'accountName'            => array('type' => 'string'),
+            'companyMainPhone'       => array('type' => 'string'),
+            'customerId'             => array('type' => 'string'),
+            'governmentId'           => array('type' => 'string'),
+            'iMAddress'              => array('type' => 'string'),
+            'iMAddress2'             => array('type' => 'string'),
+            'iMAddress3'             => array('type' => 'string'),
+            'managerName'            => array('type' => 'string'),
+            'mMS'                    => array('type' => 'string'),
+            'nickName'               => array('type' => 'string'),
+        )
+    );
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/Content.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/Device.php Changed

@@ -17,36 +17,37 @@
  */
 class Syncroton_Model_Device extends Syncroton_Model_AEntry implements Syncroton_Model_IDevice
 {
-    public const TYPE_IPHONE          = 'iphone';
-    public const TYPE_WEBOS           = 'webos';
-    public const TYPE_ANDROID         = 'android';
-    public const TYPE_ANDROID_40      = 'android40';
-    public const TYPE_SMASUNGGALAXYS2 = 'samsunggti9100'; // Samsung Galaxy S-3
-    public const TYPE_BLACKBERRY      = 'blackberry';
-
+    const TYPE_IPHONE          = 'iphone';
+    const TYPE_WEBOS           = 'webos';
+    const TYPE_ANDROID         = 'android';
+    const TYPE_ANDROID_40      = 'android40';
+    const TYPE_SMASUNGGALAXYS2 = 'samsunggti9100'; // Samsung Galaxy S-3
+    const TYPE_BLACKBERRY      = 'blackberry';
+    
     /**
      * Returns major firmware version of this device
-     *
-     * @return int|string
+     * 
+     * @return int/string
      */
     public function getMajorVersion()
     {
         switch (strtolower($this->devicetype)) {
             case Syncroton_Model_Device::TYPE_BLACKBERRY:
                 if (preg_match('/(.+)\/(.+)/', $this->useragent, $matches)) {
-                    , $name, $version = $matches;
+                    list(, $name, $version) = $matches;
                     return $version;
                 }
                 break;
-
+                
             case Syncroton_Model_Device::TYPE_IPHONE:
                 if (preg_match('/(.+)\/(\d+)\.(\d+)/', $this->useragent, $matches)) {
-                    , $name, $majorVersion, $minorVersion = $matches;
+                    list(, $name, $majorVersion, $minorVersion) = $matches;
                     return $majorVersion;
                 }
                 break;
         }
-
+        
         return 0;
     }
 }
+

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/DeviceInformation.php Changed

@@ -14,29 +14,29 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property    string  $friendlyName
- * @property    string  $iMEI
- * @property    string  $mobileOperator
- * @property    string  $model
- * @property    string  $oS
- * @property    string  $oSLanguage
- * @property    string  $phoneNumber
+ * @property    string  friendlyName
+ * @property    string  iMEI
+ * @property    string  mobileOperator
+ * @property    string  model
+ * @property    string  oS
+ * @property    string  oSLanguage
+ * @property    string  phoneNumber
  */
 
 class Syncroton_Model_DeviceInformation extends Syncroton_Model_AXMLEntry
 {
     protected $_xmlBaseElement = 'Set';
-
-    protected $_properties = 
-        'Settings' => 
-            'enableOutboundSMS' => 'type' => 'number',
-            'friendlyName'      => 'type' => 'string',
-            'iMEI'              => 'type' => 'string',
-            'mobileOperator'    => 'type' => 'string',
-            'model'             => 'type' => 'string',
-            'oS'                => 'type' => 'string',
-            'oSLanguage'        => 'type' => 'string',
-            'phoneNumber'       => 'type' => 'string',
-        ,
-    ;
-}
+    
+    protected $_properties = array(
+        'Settings' => array(
+            'enableOutboundSMS' => array('type' => 'number'),
+            'friendlyName'      => array('type' => 'string'),
+            'iMEI'              => array('type' => 'string'),
+            'mobileOperator'    => array('type' => 'string'),
+            'model'             => array('type' => 'string'),
+            'oS'                => array('type' => 'string'),
+            'oSLanguage'        => array('type' => 'string'),
+            'phoneNumber'       => array('type' => 'string')
+        ),
+    );
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/Email.php Changed

@@ -14,77 +14,77 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property    array                       $attachments
- * @property    string                      $contentType
- * @property    array                       $flag
- * @property    Syncroton_Model_EmailBody   $body
- * @property    array                       $cc
- * @property    array                       $to
- * @property    int                         $lastVerbExecuted
- * @property    DateTime                    $lastVerbExecutionTime
- * @property    int                         $read
+ * @property    array     attachments
+ * @property    string    contentType
+ * @property    array     flag
+ * @property    Syncroton_Model_EmailBody    body
+ * @property    array     cc
+ * @property    array     to
+ * @property    int       lastVerbExecuted
+ * @property    DateTime  lastVerbExecutionTime
+ * @property    int       read
  */
 class Syncroton_Model_Email extends Syncroton_Model_AXMLEntry
 {
-    public const LASTVERB_UNKNOWN       = 0;
-    public const LASTVERB_REPLYTOSENDER = 1;
-    public const LASTVERB_REPLYTOALL    = 2;
-    public const LASTVERB_FORWARD       = 3;
-
+    const LASTVERB_UNKNOWN       = 0;
+    const LASTVERB_REPLYTOSENDER = 1;
+    const LASTVERB_REPLYTOALL    = 2;
+    const LASTVERB_FORWARD       = 3;
+    
     protected $_xmlBaseElement = 'ApplicationData';
-
-    protected $_properties = 
-        'AirSyncBase' => 
-            'attachments'             => 'type' => 'container', 'childElement' => 'attachment', 'class' => 'Syncroton_Model_EmailAttachment',
-            'contentType'             => 'type' => 'string',
-            'body'                    => 'type' => 'container', 'class' => 'Syncroton_Model_EmailBody',
-            'nativeBodyType'          => 'type' => 'number',
-        ,
-        'Email' => 
-            'busyStatus'              => 'type' => 'number',
-            'categories'              => 'type' => 'container', 'childElement' => 'category', 'supportedSince' => '14.0',
-            'cc'                      => 'type' => 'string',
-            'completeTime'            => 'type' => 'datetime',
-            'contentClass'            => 'type' => 'string',
-            'dateReceived'            => 'type' => 'datetime',
-            'disallowNewTimeProposal' => 'type' => 'number',
-            'displayTo'               => 'type' => 'string',
-            'dTStamp'                 => 'type' => 'datetime',
-            'endTime'                 => 'type' => 'datetime',
-            'flag'                    => 'type' => 'container', 'class' => 'Syncroton_Model_EmailFlag',
-            'from'                    => 'type' => 'string',
-            'globalObjId'             => 'type' => 'string',
-            'importance'              => 'type' => 'number',
-            'instanceType'            => 'type' => 'number',
-            'internetCPID'            => 'type' => 'string',
-            'location'                => 'type' => 'string',
-            'meetingRequest'          => 'type' => 'container', 'class' => 'Syncroton_Model_EmailMeetingRequest',
-            'messageClass'            => 'type' => 'string',
-            'organizer'               => 'type' => 'string',
-            'read'                    => 'type' => 'number',
-            'recurrences'             => 'type' => 'container',
-            'reminder'                => 'type' => 'number',
-            'replyTo'                 => 'type' => 'string',
-            'responseRequested'       => 'type' => 'number',
-            'sensitivity'             => 'type' => 'number',
-            'startTime'               => 'type' => 'datetime',
-            'status'                  => 'type' => 'number',
-            'subject'                 => 'type' => 'string',
-            'threadTopic'             => 'type' => 'string',
-            'timeZone'                => 'type' => 'timezone',
-            'to'                      => 'type' => 'string',
-        ,
-        'Email2' => 
-            'accountId'             => 'type' => 'string', 'supportedSince' => '14.1',
-            'conversationId'        => 'type' => 'byteArray', 'supportedSince' => '14.0',
-            'conversationIndex'     => 'type' => 'byteArray', 'supportedSince' => '14.0',
-            'lastVerbExecuted'      => 'type' => 'number', 'supportedSince' => '14.0',
-            'lastVerbExecutionTime' => 'type' => 'datetime', 'supportedSince' => '14.0',
-            'meetingMessageType'    => 'type' => 'number', 'supportedSince' => '14.1',
-            'receivedAsBcc'         => 'type' => 'number', 'supportedSince' => '14.0',
-            'sender'                => 'type' => 'string', 'supportedSince' => '14.0',
-            'umCallerID'            => 'type' => 'string', 'supportedSince' => '14.0',
-            'umUserNotes'           => 'type' => 'string', 'supportedSince' => '14.0',
-        ,
-    ;
+    
+    protected $_properties = array(
+        'AirSyncBase' => array(
+            'attachments'             => array('type' => 'container', 'childElement' => 'attachment', 'class' => 'Syncroton_Model_EmailAttachment'),
+            'contentType'             => array('type' => 'string'),
+            'body'                    => array('type' => 'container', 'class' => 'Syncroton_Model_EmailBody'),
+            'nativeBodyType'          => array('type' => 'number'),
+        ),
+        'Email' => array(
+            'busyStatus'              => array('type' => 'number'),
+            'categories'              => array('type' => 'container', 'childElement' => 'category', 'supportedSince' => '14.0'),
+            'cc'                      => array('type' => 'string'),
+            'completeTime'            => array('type' => 'datetime'),
+            'contentClass'            => array('type' => 'string'),
+            'dateReceived'            => array('type' => 'datetime'),
+            'disallowNewTimeProposal' => array('type' => 'number'),
+            'displayTo'               => array('type' => 'string'),
+            'dTStamp'                 => array('type' => 'datetime'),
+            'endTime'                 => array('type' => 'datetime'),
+            'flag'                    => array('type' => 'container', 'class' => 'Syncroton_Model_EmailFlag'),
+            'from'                    => array('type' => 'string'),
+            'globalObjId'             => array('type' => 'string'),
+            'importance'              => array('type' => 'number'),
+            'instanceType'            => array('type' => 'number'),
+            'internetCPID'            => array('type' => 'string'),
+            'location'                => array('type' => 'string'),
+            'meetingRequest'          => array('type' => 'container', 'class' => 'Syncroton_Model_EmailMeetingRequest'),
+            'messageClass'            => array('type' => 'string'),
+            'organizer'               => array('type' => 'string'),
+            'read'                    => array('type' => 'number'),
+            'recurrences'             => array('type' => 'container'),
+            'reminder'                => array('type' => 'number'),
+            'replyTo'                 => array('type' => 'string'),
+            'responseRequested'       => array('type' => 'number'),
+            'sensitivity'             => array('type' => 'number'),
+            'startTime'               => array('type' => 'datetime'),
+            'status'                  => array('type' => 'number'),
+            'subject'                 => array('type' => 'string'),
+            'threadTopic'             => array('type' => 'string'),
+            'timeZone'                => array('type' => 'timezone'),
+            'to'                      => array('type' => 'string'),
+        ),
+        'Email2' => array(
+            'accountId'             => array('type' => 'string', 'supportedSince' => '14.1'),
+            'conversationId'        => array('type' => 'byteArray', 'supportedSince' => '14.0'),
+            'conversationIndex'     => array('type' => 'byteArray', 'supportedSince' => '14.0'),
+            'lastVerbExecuted'      => array('type' => 'number', 'supportedSince' => '14.0'),
+            'lastVerbExecutionTime' => array('type' => 'datetime', 'supportedSince' => '14.0'),
+            'meetingMessageType'    => array('type' => 'number', 'supportedSince' => '14.1'),
+            'receivedAsBcc'         => array('type' => 'number', 'supportedSince' => '14.0'),
+            'sender'                => array('type' => 'string', 'supportedSince' => '14.0'),
+            'umCallerID'            => array('type' => 'string', 'supportedSince' => '14.0'),
+            'umUserNotes'           => array('type' => 'string', 'supportedSince' => '14.0'),
+        ),
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/EmailAttachment.php Changed

@@ -14,30 +14,30 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property    string  $class
- * @property    string  $collectionId
- * @property    bool    $deletesAsMoves
- * @property    bool    $getChanges
- * @property    string  $syncKey
- * @property    int     $windowSize
+ * @property    string  class
+ * @property    string  collectionId
+ * @property    bool    deletesAsMoves
+ * @property    bool    getChanges
+ * @property    string  syncKey
+ * @property    int     windowSize
  */
 class Syncroton_Model_EmailAttachment extends Syncroton_Model_AXMLEntry
 {
     protected $_xmlBaseElement = 'Attachment';
-
-    protected $_properties = 
-        'AirSyncBase' => 
-            'contentId'               => 'type' => 'string',
-            'contentLocation'         => 'type' => 'string',
-            'displayName'             => 'type' => 'string',
-            'estimatedDataSize'       => 'type' => 'string',
-            'fileReference'           => 'type' => 'string',
-            'isInline'                => 'type' => 'number',
-            'method'                  => 'type' => 'string',
-        ,
-        'Email2' => 
-            'umAttDuration'         => 'type' => 'number', 'supportedSince' => '14.0',
-            'umAttOrder'            => 'type' => 'number', 'supportedSince' => '14.0',
-        ,
-    ;
-}
+    
+    protected $_properties = array(
+        'AirSyncBase' => array(
+            'contentId'               => array('type' => 'string'),
+            'contentLocation'         => array('type' => 'string'),
+            'displayName'             => array('type' => 'string'),
+            'estimatedDataSize'       => array('type' => 'string'),
+            'fileReference'           => array('type' => 'string'),
+            'isInline'                => array('type' => 'number'),
+            'method'                  => array('type' => 'string'),
+        ),
+        'Email2' => array(
+            'umAttDuration'         => array('type' => 'number', 'supportedSince' => '14.0'),
+            'umAttOrder'            => array('type' => 'number', 'supportedSince' => '14.0'),
+        ),
+    );
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/EmailBody.php Changed

@@ -14,31 +14,31 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property   int     $estimatedDataSize
- * @property   string  $data
- * @property   string  $part
- * @property   string  $preview
- * @property   bool    $truncated
- * @property   string  $type
+ * @property   int     EstimatedDataSize
+ * @property   string  Data
+ * @property   string  Part
+ * @property   string  Preview
+ * @property   bool    Truncated
+ * @property   string  Type
  */
 
 class Syncroton_Model_EmailBody extends Syncroton_Model_AXMLEntry
 {
-    public const TYPE_PLAINTEXT = 1;
-    public const TYPE_HTML      = 2;
-    public const TYPE_RTF       = 3;
-    public const TYPE_MIME      = 4;
-
+    const TYPE_PLAINTEXT = 1;
+    const TYPE_HTML      = 2;
+    const TYPE_RTF       = 3;
+    const TYPE_MIME      = 4;
+    
     protected $_xmlBaseElement = 'Body';
-
-    protected $_properties = 
-        'AirSyncBase' => 
-            'type'              => 'type' => 'string',
-            'estimatedDataSize' => 'type' => 'string',
-            'data'              => 'type' => 'string',
-            'truncated'         => 'type' => 'number',
-            'part'              => 'type' => 'number',
-            'preview'           => 'type' => 'string', 'supportedSince' => '14.0',
-        ,
-    ;
-}
+    
+    protected $_properties = array(
+        'AirSyncBase' => array(
+            'type'              => array('type' => 'string'),
+            'estimatedDataSize' => array('type' => 'string'),
+            'data'              => array('type' => 'string'),
+            'truncated'         => array('type' => 'number'),
+            'part'              => array('type' => 'number'),
+            'preview'           => array('type' => 'string', 'supportedSince' => '14.0'),
+        ),
+    );
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/EmailFlag.php Changed

@@ -16,45 +16,45 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property    DateTime  $completeTime
- * @property    DateTime  $dateCompleted
- * @property    DateTime  $dueDate
- * @property    string    $flagType
- * @property    DateTime  $ordinalDate
- * @property    int       $reminderSet
- * @property    DateTime  $reminderTime
- * @property    DateTime  $startDate
- * @property    string    $status
- * @property    string    $subject
- * @property    string    $subOrdinalDate
- * @property    DateTime  $utcDueDate
- * @property    DateTime  $utcStartDate
+ * @property    DateTime  CompleteTime
+ * @property    DateTime  DateCompleted
+ * @property    DateTime  DueDate
+ * @property    string    FlagType
+ * @property    DateTime  OrdinalDate
+ * @property    int       ReminderSet
+ * @property    DateTime  ReminderTime
+ * @property    DateTime  StartDate
+ * @property    string    Status
+ * @property    string    Subject
+ * @property    string    SubOrdinalDate
+ * @property    DateTime  UtcDueDate
+ * @property    DateTime  UtcStartDate
  */
 class Syncroton_Model_EmailFlag extends Syncroton_Model_AXMLEntry
 {
-    public const STATUS_CLEARED  = 0;
-    public const STATUS_COMPLETE = 1;
-    public const STATUS_ACTIVE   = 2;
+    const STATUS_CLEARED  = 0;
+    const STATUS_COMPLETE = 1;
+    const STATUS_ACTIVE   = 2;
 
     protected $_xmlBaseElement = 'Flag';
 
-    protected $_properties = 
-        'Email' => 
-            'completeTime'       => 'type' => 'datetime',
-            'flagType'           => 'type' => 'string',
-            'status'             => 'type' => 'number',
-        ,
-        'Tasks' => 
-            'dateCompleted'      => 'type' => 'datetime',
-            'dueDate'            => 'type' => 'datetime',
-            'ordinalDate'        => 'type' => 'datetime',
-            'reminderSet'        => 'type' => 'number',
-            'reminderTime'       => 'type' => 'datetime',
-            'startDate'          => 'type' => 'datetime',
-            'subject'            => 'type' => 'string',
-            'subOrdinalDate'     => 'type' => 'string',
-            'utcStartDate'       => 'type' => 'datetime',
-            'utcDueDate'         => 'type' => 'datetime',
-        ,
-    ;
+    protected $_properties = array(
+        'Email' => array(
+            'completeTime'       => array('type' => 'datetime'),
+            'flagType'           => array('type' => 'string'),
+            'status'             => array('type' => 'number'),
+        ),
+        'Tasks' => array(
+            'dateCompleted'      => array('type' => 'datetime'),
+            'dueDate'            => array('type' => 'datetime'),
+            'ordinalDate'        => array('type' => 'datetime'),
+            'reminderSet'        => array('type' => 'number'),
+            'reminderTime'       => array('type' => 'datetime'),
+            'startDate'          => array('type' => 'datetime'),
+            'subject'            => array('type' => 'string'),
+            'subOrdinalDate'     => array('type' => 'string'),
+            'utcStartDate'       => array('type' => 'datetime'),
+            'utcDueDate'         => array('type' => 'datetime'),
+        ),
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/EmailMeetingRequest.php Changed

@@ -14,83 +14,83 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property    bool     $allDayEvent
- * @property    int      $busyStatus
- * @property    int      $disallowNewTimeProposal
- * @property    DateTime $dtStamp
- * @property    DateTime $endTime
- * @property    string   $globalObjId
- * @property    int      $instanceType
- * @property    int      $meetingMessageType
- * @property    string   $organizer
- * @property    string   $recurrenceId
- * @property    array    $recurrences
- * @property    int      $reminder
- * @property    int      $responseRequested
- * @property    int      $sensitivity
- * @property    DateTime $startTime
- * @property    string   $timezone
+ * @property    bool     AllDayEvent
+ * @property    int      BusyStatus
+ * @property    int      DisallowNewTimeProposal
+ * @property    DateTime DtStamp
+ * @property    DateTime EndTime
+ * @property    string   GlobalObjId
+ * @property    int      InstanceType
+ * @property    int      MeetingMessageType
+ * @property    string   Organizer
+ * @property    string   RecurrenceId
+ * @property    array    Recurrences
+ * @property    int      Reminder
+ * @property    int      ResponseRequested
+ * @property    int      Sensitivity
+ * @property    DateTime StartTime
+ * @property    string   Timezone
  */
 class Syncroton_Model_EmailMeetingRequest extends Syncroton_Model_AXMLEntry
 {
     /**
      * busy status constants
      */
-    public const BUSY_STATUS_FREE      = 0;
-    public const BUSY_STATUS_TENATTIVE = 1;
-    public const BUSY_STATUS_BUSY      = 2;
-    public const BUSY_STATUS_OUT       = 3;
+    const BUSY_STATUS_FREE      = 0;
+    const BUSY_STATUS_TENATTIVE = 1;
+    const BUSY_STATUS_BUSY      = 2;
+    const BUSY_STATUS_OUT       = 3;
 
     /**
      * sensitivity constants
      */
-    public const SENSITIVITY_NORMAL       = 0;
-    public const SENSITIVITY_PERSONAL     = 1;
-    public const SENSITIVITY_PRIVATE      = 2;
-    public const SENSITIVITY_CONFIDENTIAL = 3;
+    const SENSITIVITY_NORMAL       = 0;
+    const SENSITIVITY_PERSONAL     = 1;
+    const SENSITIVITY_PRIVATE      = 2;
+    const SENSITIVITY_CONFIDENTIAL = 3;
 
     /**
      * instanceType constants
      */
-    public const TYPE_NORMAL              = 0;
-    public const TYPE_RECURRING_MASTER    = 1;
-    public const TYPE_RECURRING_SINGLE    = 2;
-    public const TYPE_RECURRING_EXCEPTION = 3;
+    const TYPE_NORMAL              = 0;
+    const TYPE_RECURRING_MASTER    = 1;
+    const TYPE_RECURRING_SINGLE    = 2;
+    const TYPE_RECURRING_EXCEPTION = 3;
 
     /**
      * messageType constants
      */
-    public const MESSAGE_TYPE_NORMAL      = 0;
-    public const MESSAGE_TYPE_REQUEST     = 1;
-    public const MESSAGE_TYPE_FULL_UPDATE = 2;
-    public const MESSAGE_TYPE_INFO_UPDATE = 3;
-    public const MESSAGE_TYPE_OUTDATED    = 4;
-    public const MESSAGE_TYPE_COPY        = 5;
-    public const MESSAGE_TYPE_DELEGATED   = 6;
+    const MESSAGE_TYPE_NORMAL      = 0;
+    const MESSAGE_TYPE_REQUEST     = 1;
+    const MESSAGE_TYPE_FULL_UPDATE = 2;
+    const MESSAGE_TYPE_INFO_UPDATE = 3;
+    const MESSAGE_TYPE_OUTDATED    = 4;
+    const MESSAGE_TYPE_COPY        = 5;
+    const MESSAGE_TYPE_DELEGATED   = 6;
 
     protected $_xmlBaseElement = 'MeetingRequest';
 
-    protected $_properties = 
-        'Email' => 
-            'allDayEvent'               => 'type' => 'number',
-            'busyStatus'                => 'type' => 'number',
-            'disallowNewTimeProposal'   => 'type' => 'number',
-            'dtStamp'                   => 'type' => 'datetime',
-            'endTime'                   => 'type' => 'datetime',
-            'globalObjId'               => 'type' => 'string',
-            'instanceType'              => 'type' => 'number',
-            'location'                  => 'type' => 'string',
-            'organizer'                 => 'type' => 'string', //e-mail address
-            'recurrenceId'              => 'type' => 'datetime',
-            'recurrences'               => 'type' => 'container',
-            'reminder'                  => 'type' => 'number',
-            'responseRequested'         => 'type' => 'number',
-            'sensitivity'               => 'type' => 'number',
-            'startTime'                 => 'type' => 'datetime',
-            'timeZone'                  => 'type' => 'timezone',
-        ,
-        'Email2' => 
-            'meetingMessageType'        => 'type' => 'number',
-        ,
-    ;
+    protected $_properties = array(
+        'Email' => array(
+            'allDayEvent'               => array('type' => 'number'),
+            'busyStatus'                => array('type' => 'number'),
+            'disallowNewTimeProposal'   => array('type' => 'number'),
+            'dtStamp'                   => array('type' => 'datetime'),
+            'endTime'                   => array('type' => 'datetime'),
+            'globalObjId'               => array('type' => 'string'),
+            'instanceType'              => array('type' => 'number'),
+            'location'                  => array('type' => 'string'),
+            'organizer'                 => array('type' => 'string'), //e-mail address
+            'recurrenceId'              => array('type' => 'datetime'),
+            'recurrences'               => array('type' => 'container'),
+            'reminder'                  => array('type' => 'number'),
+            'responseRequested'         => array('type' => 'number'),
+            'sensitivity'               => array('type' => 'number'),
+            'startTime'                 => array('type' => 'datetime'),
+            'timeZone'                  => array('type' => 'timezone'),
+        ),
+        'Email2' => array(
+            'meetingMessageType'        => array('type' => 'number'),
+        ),
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/EmailRecurrence.php Changed

@@ -14,18 +14,19 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property    int       $calendarType
- * @property    int       $dayOfMonth
- * @property    int       $dayOfWeek
- * @property    int       $firstDayOfWeek
- * @property    int       $interval
- * @property    int       $isLeapMonth
- * @property    int       $monthOfYear
- * @property    int       $occurrences
- * @property    int       $type
- * @property    DateTime  $until
- * @property    int       $weekOfMonth
+ * @property    int       CalendarType
+ * @property    int       DayOfMonth
+ * @property    int       DayOfWeek
+ * @property    int       FirstDayOfWeek
+ * @property    int       Interval
+ * @property    int       IsLeapMonth
+ * @property    int       MonthOfYear
+ * @property    int       Occurrences
+ * @property    int       Type
+ * @property    DateTime  Until
+ * @property    int       WeekOfMonth
  */
+
 class Syncroton_Model_EmailRecurrence extends Syncroton_Model_AXMLEntry
 {
     protected $_xmlBaseElement = 'Recurrence';
@@ -33,41 +34,41 @@
     /**
      * recur types
      */
-    public const TYPE_DAILY          = 0;     // Recurs daily
-    public const TYPE_WEEKLY         = 1;     // Recurs weekly
-    public const TYPE_MONTHLY        = 3;     // Recurs monthly
-    public const TYPE_MONTHLY_DAYN   = 2;     // Recurs monthly on the nth day
-    public const TYPE_YEARLY         = 5;     // Recurs yearly on the nth day of the nth month each year
-    public const TYPE_YEARLY_DAYN    = 6;     // Recurs yearly on the nth day of the week of the nth month
+    const TYPE_DAILY          = 0;     // Recurs daily
+    const TYPE_WEEKLY         = 1;     // Recurs weekly
+    const TYPE_MONTHLY        = 3;     // Recurs monthly
+    const TYPE_MONTHLY_DAYN   = 2;     // Recurs monthly on the nth day
+    const TYPE_YEARLY         = 5;     // Recurs yearly on the nth day of the nth month each year
+    const TYPE_YEARLY_DAYN    = 6;     // Recurs yearly on the nth day of the week of the nth month
 
     /**
      * day of week constants
      */
-    public const RECUR_DOW_SUNDAY      = 1;
-    public const RECUR_DOW_MONDAY      = 2;
-    public const RECUR_DOW_TUESDAY     = 4;
-    public const RECUR_DOW_WEDNESDAY   = 8;
-    public const RECUR_DOW_THURSDAY    = 16;
-    public const RECUR_DOW_FRIDAY      = 32;
-    public const RECUR_DOW_SATURDAY    = 64;
+    const RECUR_DOW_SUNDAY      = 1;
+    const RECUR_DOW_MONDAY      = 2;
+    const RECUR_DOW_TUESDAY     = 4;
+    const RECUR_DOW_WEDNESDAY   = 8;
+    const RECUR_DOW_THURSDAY    = 16;
+    const RECUR_DOW_FRIDAY      = 32;
+    const RECUR_DOW_SATURDAY    = 64;
 
     protected $_dateTimeFormat = "Ymd\THis\Z";
 
-    protected $_properties = 
-        'Email' => 
-            'dayOfMonth'     => 'type' => 'number',
-            'dayOfWeek'      => 'type' => 'number',
-            'interval'       => 'type' => 'number', // 1 or 2
-            'monthOfYear'    => 'type' => 'number',
-            'occurrences'    => 'type' => 'number',
-            'type'           => 'type' => 'number',
-            'until'          => 'type' => 'datetime',
-            'weekOfMonth'    => 'type' => 'number',
-        ,
-        'Email2' => 
-            'calendarType'   => 'type' => 'number',
-            'firstDayOfWeek' => 'type' => 'number',
-            'isLeapMonth'    => 'type' => 'number',
-        ,
-    ;
+    protected $_properties = array(
+        'Email' => array(
+            'dayOfMonth'     => array('type' => 'number'),
+            'dayOfWeek'      => array('type' => 'number'),
+            'interval'       => array('type' => 'number'), // 1 or 2
+            'monthOfYear'    => array('type' => 'number'),
+            'occurrences'    => array('type' => 'number'),
+            'type'           => array('type' => 'number'),
+            'until'          => array('type' => 'datetime'),
+            'weekOfMonth'    => array('type' => 'number'),
+        ),
+        'Email2' => array(
+            'calendarType'   => array('type' => 'number'),
+            'firstDayOfWeek' => array('type' => 'number'),
+            'isLeapMonth'    => array('type' => 'number'),
+        )
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/Event.php Changed

@@ -14,62 +14,59 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- *
- * @property  bool     $allDayEvent
- * @property  string   $class
- * @property  string   $collectionId
- * @property  bool     $deletesAsMoves
- * @property  DateTime $endTime
- * @property  bool     $getChanges
- * @property  DateTime $startTime
- * @property  string   $syncKey
- * @property  int      $windowSize
+ * @property    string  class
+ * @property    string  collectionId
+ * @property    bool    deletesAsMoves
+ * @property    bool    getChanges
+ * @property    string  syncKey
+ * @property    int     windowSize
  */
+
 class Syncroton_Model_Event extends Syncroton_Model_AXMLEntry
 {
-    /**
-     * busy status constants
-     */
-    public const BUSY_STATUS_FREE      = 0;
-    public const BUSY_STATUS_TENATTIVE = 1;
-    public const BUSY_STATUS_BUSY      = 2;
-
-    protected $_dateTimeFormat = "Ymd\THis\Z";
-
+    /**
+     * busy status constants
+     */
+    const BUSY_STATUS_FREE      = 0;
+    const BUSY_STATUS_TENATTIVE = 1;
+    const BUSY_STATUS_BUSY      = 2;
+    
+    protected $_dateTimeFormat = "Ymd\THis\Z";
+    
     protected $_xmlBaseElement = 'ApplicationData';
-
-    protected $_properties = 
-        'AirSyncBase' => 
-            'body'                      => 'type' => 'container', 'class' => 'Syncroton_Model_EmailBody',
-        ,
-        'Calendar' => 
-            'allDayEvent'               => 'type' => 'number',
-            'appointmentReplyTime'      => 'type' => 'datetime',
-            'attendees'                 => 'type' => 'container', 'childElement' => 'attendee', 'class' => 'Syncroton_Model_EventAttendee',
-            'busyStatus'                => 'type' => 'number',
-            'categories'                => 'type' => 'container', 'childElement' => 'category',
-            'disallowNewTimeProposal'   => 'type' => 'number',
-            'dtStamp'                   => 'type' => 'datetime',
-            'endTime'                   => 'type' => 'datetime',
-            'exceptions'                => 'type' => 'container', 'childElement' => 'exception', 'class' => 'Syncroton_Model_EventException',
-            'location'                  => 'type' => 'string',
-            'meetingStatus'             => 'type' => 'number',
-            'onlineMeetingConfLink'     => 'type' => 'string',
-            'onlineMeetingExternalLink' => 'type' => 'string',
-            'organizerEmail'            => 'type' => 'string',
-            'organizerName'             => 'type' => 'string',
-            'recurrence'                => 'type' => 'container',
-            'reminder'                  => 'type' => 'number',
-            'responseRequested'         => 'type' => 'number',
-            'responseType'              => 'type' => 'number',
-            'sensitivity'               => 'type' => 'number',
-            'startTime'                 => 'type' => 'datetime',
-            'subject'                   => 'type' => 'string',
-            'timezone'                  => 'type' => 'timezone',
-            'uID'                       => 'type' => 'string',
-        ,
-    ;
-
+    
+    protected $_properties = array(
+        'AirSyncBase' => array(
+            'body'                      => array('type' => 'container', 'class' => 'Syncroton_Model_EmailBody')
+        ),
+        'Calendar' => array(
+            'allDayEvent'               => array('type' => 'number'),
+            'appointmentReplyTime'      => array('type' => 'datetime'),
+            'attendees'                 => array('type' => 'container', 'childElement' => 'attendee', 'class' => 'Syncroton_Model_EventAttendee'),
+            'busyStatus'                => array('type' => 'number'),
+            'categories'                => array('type' => 'container', 'childElement' => 'category'),
+            'disallowNewTimeProposal'   => array('type' => 'number'),
+            'dtStamp'                   => array('type' => 'datetime'),
+            'endTime'                   => array('type' => 'datetime'),
+            'exceptions'                => array('type' => 'container', 'childElement' => 'exception', 'class' => 'Syncroton_Model_EventException'),
+            'location'                  => array('type' => 'string'),
+            'meetingStatus'             => array('type' => 'number'),
+            'onlineMeetingConfLink'     => array('type' => 'string'),
+            'onlineMeetingExternalLink' => array('type' => 'string'),
+            'organizerEmail'            => array('type' => 'string'),
+            'organizerName'             => array('type' => 'string'),
+            'recurrence'                => array('type' => 'container'),
+            'reminder'                  => array('type' => 'number'),
+            'responseRequested'         => array('type' => 'number'),
+            'responseType'              => array('type' => 'number'),
+            'sensitivity'               => array('type' => 'number'),
+            'startTime'                 => array('type' => 'datetime'),
+            'subject'                   => array('type' => 'string'),
+            'timezone'                  => array('type' => 'timezone'),
+            'uID'                       => array('type' => 'string'),
+        )
+    );
+    
     /**
      * (non-PHPdoc)
      * @see Syncroton_Model_IEntry::appendXML()
@@ -80,7 +77,7 @@
         parent::appendXML($domParrent, $device);
 
         $exceptionElements = $domParrent->getElementsByTagName('Exception');
-        $parentFields      = 'AllDayEvent'/*, 'Attendees'*/, 'Body', 'BusyStatus'/*, 'Categories'*/, 'DtStamp', 'EndTime', 'Location', 'MeetingStatus', 'Reminder', 'ResponseType', 'Sensitivity', 'StartTime', 'Subject';
+        $parentFields      = array('AllDayEvent'/*, 'Attendees'*/, 'Body', 'BusyStatus'/*, 'Categories'*/, 'DtStamp', 'EndTime', 'Location', 'MeetingStatus', 'Reminder', 'ResponseType', 'Sensitivity', 'StartTime', 'Subject');
 
         if ($exceptionElements->length > 0) {
             $mainEventElement = $exceptionElements->item(0)->parentNode->parentNode;
@@ -100,31 +97,31 @@
             }
         }
     }
-
+    
     /**
-     * some elements of an exception can be left out, if they have the same value
+     * some elements of an exception can be left out, if they have the same value 
      * like the main event
-     *
+     * 
      * this function copies these elements to the exception for backends which need
      * this elements in the exceptions too. Tine 2.0 needs this for example.
      */
     public function copyFieldsFromParent()
     {
-        if (isset($this->_elements'exceptions') && is_array($this->_elements'exceptions')) {
-            foreach ($this->_elements'exceptions' as $exception) {
-                // no need to update deleted exceptions
-                if ($exception->deleted == 1) {
-                    continue;
-                }
-
-                $parentFields = 'allDayEvent', 'attendees', 'body', 'busyStatus', 'categories', 'dtStamp', 'endTime', 'location', 'meetingStatus', 'reminder', 'responseType', 'sensitivity', 'startTime', 'subject';
-
-                foreach ($parentFields as $field) {
-                    if (!isset($exception->$field) && isset($this->_elements$field)) {
-                        $exception->$field = $this->_elements$field;
-                    }
-                }
-            }
-        }
+        if (isset($this->_elements'exceptions') && is_array($this->_elements'exceptions')) {
+            foreach ($this->_elements'exceptions' as $exception) {
+                // no need to update deleted exceptions
+                if ($exception->deleted == 1) {
+                    continue;
+                }
+        
+                $parentFields = array('allDayEvent', 'attendees', 'body', 'busyStatus', 'categories', 'dtStamp', 'endTime', 'location', 'meetingStatus', 'reminder', 'responseType', 'sensitivity', 'startTime', 'subject');
+        
+                foreach ($parentFields as $field) {
+                    if (!isset($exception->$field) && isset($this->_elements$field)) {
+                        $exception->$field = $this->_elements$field;
+                    }
+                }
+            }
+        }
     }
-}
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/EventAttendee.php Changed

@@ -14,39 +14,40 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property    string  $class
- * @property    string  $collectionId
- * @property    bool    $deletesAsMoves
- * @property    bool    $getChanges
- * @property    string  $syncKey
- * @property    int     $windowSize
+ * @property    string  class
+ * @property    string  collectionId
+ * @property    bool    deletesAsMoves
+ * @property    bool    getChanges
+ * @property    string  syncKey
+ * @property    int     windowSize
  */
+
 class Syncroton_Model_EventAttendee extends Syncroton_Model_AXMLEntry
 {
     protected $_xmlBaseElement = 'Attendee';
-
-    /**
-     * attendee status
-     */
-    public const ATTENDEE_STATUS_UNKNOWN       = 0;
-    public const ATTENDEE_STATUS_TENTATIVE     = 2;
-    public const ATTENDEE_STATUS_ACCEPTED      = 3;
-    public const ATTENDEE_STATUS_DECLINED      = 4;
-    public const ATTENDEE_STATUS_NOTRESPONDED  = 5;
-
-    /**
-     * attendee types
-     */
-    public const ATTENDEE_TYPE_REQUIRED = 1;
-    public const ATTENDEE_TYPE_OPTIONAL = 2;
-    public const ATTENDEE_TYPE_RESOURCE = 3;
-
-    protected $_properties = 
-        'Calendar' => 
-            'attendeeStatus'          => 'type' => 'number',
-            'attendeeType'            => 'type' => 'number',
-            'email'                   => 'type' => 'string',
-            'name'                    => 'type' => 'string',
-        ,
-    ;
-}
+    
+    /**
+     * attendee status
+     */
+    const ATTENDEE_STATUS_UNKNOWN       = 0;
+    const ATTENDEE_STATUS_TENTATIVE     = 2;
+    const ATTENDEE_STATUS_ACCEPTED      = 3;
+    const ATTENDEE_STATUS_DECLINED      = 4;
+    const ATTENDEE_STATUS_NOTRESPONDED  = 5;
+    
+    /**
+     * attendee types
+     */
+    const ATTENDEE_TYPE_REQUIRED = 1;
+    const ATTENDEE_TYPE_OPTIONAL = 2;
+    const ATTENDEE_TYPE_RESOURCE = 3;
+    
+    protected $_properties = array(
+        'Calendar' => array(
+            'attendeeStatus'          => array('type' => 'number'),
+            'attendeeType'            => array('type' => 'number'),
+            'email'                   => array('type' => 'string'),
+            'name'                    => array('type' => 'string'),
+        )
+    );
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/EventException.php Changed

@@ -14,44 +14,41 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- *
- * @property bool     $allDayEvent
- * @property string   $class
- * @property string   $collectionId
- * @property bool     $deletesAsMoves
- * @property DateTime $endTime
- * @property bool     $getChanges
- * @property DateTime $startTime
- * @property string   $syncKey
- * @property int      $windowSize
+ * @property    string  class
+ * @property    string  collectionId
+ * @property    bool    deletesAsMoves
+ * @property    bool    getChanges
+ * @property    string  syncKey
+ * @property    int     windowSize
  */
+
 class Syncroton_Model_EventException extends Syncroton_Model_AXMLEntry
-{
+{    
     protected $_xmlBaseElement = 'Exception';
-
+    
     protected $_dateTimeFormat = "Ymd\THis\Z";
-
-    protected $_properties = 
-        'AirSyncBase' => 
-            'body'                    => 'type' => 'container', 'class' => 'Syncroton_Model_EmailBody',
-        ,
-        'Calendar' => 
-            'allDayEvent'             => 'type' => 'number',
-            'appointmentReplyTime'    => 'type' => 'datetime',
-            'attendees'               => 'type' => 'container', 'childElement' => 'attendee', 'class' => 'Syncroton_Model_EventAttendee',
-            'busyStatus'              => 'type' => 'number',
-            'categories'              => 'type' => 'container', 'childElement' => 'category',
-            'deleted'                 => 'type' => 'number',
-            'dtStamp'                 => 'type' => 'datetime',
-            'endTime'                 => 'type' => 'datetime',
-            'exceptionStartTime'      => 'type' => 'datetime',
-            'location'                => 'type' => 'string',
-            'meetingStatus'           => 'type' => 'number',
-            'reminder'                => 'type' => 'number',
-            'responseType'            => 'type' => 'number',
-            'sensitivity'             => 'type' => 'number',
-            'startTime'               => 'type' => 'datetime',
-            'subject'                 => 'type' => 'string',
-        ,
-    ;
-}
+    
+    protected $_properties = array(
+        'AirSyncBase' => array(
+            'body'                    => array('type' => 'container', 'class' => 'Syncroton_Model_EmailBody')
+        ),
+        'Calendar' => array(
+            'allDayEvent'             => array('type' => 'number'),
+            'appointmentReplyTime'    => array('type' => 'datetime'),
+            'attendees'               => array('type' => 'container', 'childElement' => 'attendee', 'class' => 'Syncroton_Model_EventAttendee'),
+            'busyStatus'              => array('type' => 'number'),
+            'categories'              => array('type' => 'container', 'childElement' => 'category'),
+            'deleted'                 => array('type' => 'number'),
+            'dtStamp'                 => array('type' => 'datetime'),
+            'endTime'                 => array('type' => 'datetime'),
+            'exceptionStartTime'      => array('type' => 'datetime'),
+            'location'                => array('type' => 'string'),
+            'meetingStatus'           => array('type' => 'number'),
+            'reminder'                => array('type' => 'number'),
+            'responseType'            => array('type' => 'number'),
+            'sensitivity'             => array('type' => 'number'),
+            'startTime'               => array('type' => 'datetime'),
+            'subject'                 => array('type' => 'string'),
+        )
+    );    
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/EventRecurrence.php Changed

@@ -14,58 +14,59 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property    int       $calendarType
- * @property    int       $dayOfMonth
- * @property    int       $dayOfWeek
- * @property    int       $firstDayOfWeek
- * @property    int       $interval
- * @property    int       $isLeapMonth
- * @property    int       $monthOfYear
- * @property    int       $occurrences
- * @property    int       $type
- * @property    DateTime  $until
- * @property    int       $weekOfMonth
+ * @property    int       CalendarType
+ * @property    int       DayOfMonth
+ * @property    int       DayOfWeek
+ * @property    int       FirstDayOfWeek
+ * @property    int       Interval
+ * @property    int       IsLeapMonth
+ * @property    int       MonthOfYear
+ * @property    int       Occurrences
+ * @property    int       Type
+ * @property    DateTime  Until
+ * @property    int       WeekOfMonth
  */
+
 class Syncroton_Model_EventRecurrence extends Syncroton_Model_AXMLEntry
 {
     protected $_xmlBaseElement = 'Recurrence';
-
-    /**
-     * recur types
-     */
-    public const TYPE_DAILY          = 0;     // Recurs daily.
-    public const TYPE_WEEKLY         = 1;     // Recurs weekly
-    public const TYPE_MONTHLY        = 2;     // Recurs monthly
-    public const TYPE_MONTHLY_DAYN   = 3;     // Recurs monthly on the nth day
-    public const TYPE_YEARLY         = 5;     // Recurs yearly
-    public const TYPE_YEARLY_DAYN    = 6;     // Recurs yearly on the nth day
-
-    /**
-     * day of week constants
-     */
-    public const RECUR_DOW_SUNDAY      = 1;
-    public const RECUR_DOW_MONDAY      = 2;
-    public const RECUR_DOW_TUESDAY     = 4;
-    public const RECUR_DOW_WEDNESDAY   = 8;
-    public const RECUR_DOW_THURSDAY    = 16;
-    public const RECUR_DOW_FRIDAY      = 32;
-    public const RECUR_DOW_SATURDAY    = 64;
-
+    
+    /**
+     * recur types
+     */
+    const TYPE_DAILY          = 0;     // Recurs daily.
+    const TYPE_WEEKLY         = 1;     // Recurs weekly
+    const TYPE_MONTHLY        = 2;     // Recurs monthly
+    const TYPE_MONTHLY_DAYN   = 3;     // Recurs monthly on the nth day
+    const TYPE_YEARLY         = 5;     // Recurs yearly
+    const TYPE_YEARLY_DAYN    = 6;     // Recurs yearly on the nth day
+    
+    /**
+     * day of week constants
+     */
+    const RECUR_DOW_SUNDAY      = 1;
+    const RECUR_DOW_MONDAY      = 2;
+    const RECUR_DOW_TUESDAY     = 4;
+    const RECUR_DOW_WEDNESDAY   = 8;
+    const RECUR_DOW_THURSDAY    = 16;
+    const RECUR_DOW_FRIDAY      = 32;
+    const RECUR_DOW_SATURDAY    = 64;
+    
     protected $_dateTimeFormat = "Ymd\THis\Z";
-
-    protected $_properties = 
-        'Calendar' => 
-            'calendarType'            => 'type' => 'number',
-            'dayOfMonth'              => 'type' => 'number',
-            'dayOfWeek'               => 'type' => 'number',
-            'firstDayOfWeek'          => 'type' => 'number',
-            'interval'                => 'type' => 'number',
-            'isLeapMonth'             => 'type' => 'number',
-            'monthOfYear'             => 'type' => 'number',
-            'occurrences'             => 'type' => 'number',
-            'type'                    => 'type' => 'number',
-            'until'                   => 'type' => 'datetime',
-            'weekOfMonth'             => 'type' => 'number',
-        ,
-    ;
-}
+    
+    protected $_properties = array(
+        'Calendar' => array(
+            'calendarType'            => array('type' => 'number'),
+            'dayOfMonth'              => array('type' => 'number'),
+            'dayOfWeek'               => array('type' => 'number'),
+            'firstDayOfWeek'          => array('type' => 'number'),
+            'interval'                => array('type' => 'number'),
+            'isLeapMonth'             => array('type' => 'number'),
+            'monthOfYear'             => array('type' => 'number'),
+            'occurrences'             => array('type' => 'number'),
+            'type'                    => array('type' => 'number'),
+            'until'                   => array('type' => 'datetime'),
+            'weekOfMonth'             => array('type' => 'number'),
+        )
+    );
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/FileReference.php Changed

@@ -14,32 +14,33 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property    string   $contentType
- * @property    string   $data
- * @property    int      $part
+ * @property    string  ContentType
+ * @property    string  Data
  */
+
 class Syncroton_Model_FileReference extends Syncroton_Model_AXMLEntry
 {
     protected $_xmlBaseElement = 'ApplicationData';
-
-    protected $_properties = 
-        'AirSyncBase' => 
-            'contentType' => 'type' => 'string',
-        ,
-        'ItemOperations' => 
-            'data'        => 'type' => 'string', 'encoding' => 'base64',
-            'part'        => 'type' => 'number',
-        ,
-    ;
-
+    
+    protected $_properties = array(
+        'AirSyncBase' => array(
+            'contentType' => array('type' => 'string'),
+        ),
+        'ItemOperations' => array(
+            'data'        => array('type' => 'string', 'encoding' => 'base64'),
+            'part'        => array('type' => 'number')
+        )
+    );
+        
     /**
-     *
-     * @param SimpleXMLElement $properties
+     * 
+     * @param SimpleXMLElement $xmlCollection
      * @throws InvalidArgumentException
      */
     public function setFromSimpleXMLElement(SimpleXMLElement $properties)
     {
-        // do nothing
+        //do nothing
+                
         return;
     }
-}
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/Folder.php Changed

@@ -18,24 +18,22 @@
  */
 class Syncroton_Model_Folder extends Syncroton_Model_AXMLEntry implements Syncroton_Model_IFolder
 {
-    protected $_xmlBaseElement = 'FolderUpdate', 'FolderCreate';
-
-    protected $_properties = 
-        'FolderHierarchy' => 
-            'parentId'     => 'type' => 'string',
-            'serverId'     => 'type' => 'string',
-            'displayName'  => 'type' => 'string',
-            'type'         => 'type' => 'number',
-        ,
-        'Internal' => 
-            'id'             => 'type' => 'string',
-            'deviceId'       => 'type' => 'string',
-            'ownerId'        => 'type' => 'string',
-            'class'          => 'type' => 'string',
-            'creationTime'   => 'type' => 'datetime',
-            'creationSynckey' => 'type' => 'number',
-            'lastfiltertype' => 'type' => 'number',
-            'resync'         => 'type' => 'number',
-        ,
-    ;
+    protected $_xmlBaseElement = array('FolderUpdate', 'FolderCreate');
+    
+    protected $_properties = array(
+        'FolderHierarchy' => array(
+            'parentId'     => array('type' => 'string'),
+            'serverId'     => array('type' => 'string'),
+            'displayName'  => array('type' => 'string'),
+            'type'         => array('type' => 'number')
+        ),
+        'Internal' => array(
+            'id'             => array('type' => 'string'),
+            'deviceId'       => array('type' => 'string'),
+            'ownerId'        => array('type' => 'string'),
+            'class'          => array('type' => 'string'),
+            'creationTime'   => array('type' => 'datetime'),
+            'lastfiltertype' => array('type' => 'number')
+        ),
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/GAL.php Changed

@@ -17,35 +17,35 @@
  * @package     Syncroton
  * @subpackage  Model
  *
- * @property    string    $alias
- * @property    string    $company
- * @property    string    $displayName
- * @property    string    $emailAddress
- * @property    string    $firstName
- * @property    string    $lastName
- * @property    string    $mobilePhone
- * @property    string    $office
- * @property    string    $phone
- * @property    string    $picture
- * @property    string    $title
+ * @property    string    Alias
+ * @property    string    Company
+ * @property    string    DisplayName
+ * @property    string    EmailAddress
+ * @property    string    FirstName
+ * @property    string    LastName
+ * @property    string    MobilePhone
+ * @property    string    Office
+ * @property    string    Phone
+ * @property    string    Picture
+ * @property    string    Title
  */
 class Syncroton_Model_GAL extends Syncroton_Model_AXMLEntry
 {
     protected $_xmlBaseElement = 'ApplicationData';
 
-    protected $_properties = 
-        'GAL' => 
-            'alias'         => 'type' => 'string', 'supportedSince' => '2.5',
-            'company'       => 'type' => 'string', 'supportedSince' => '2.5',
-            'displayName'   => 'type' => 'string', 'supportedSince' => '2.5',
-            'emailAddress'  => 'type' => 'string', 'supportedSince' => '2.5',
-            'firstName'     => 'type' => 'string', 'supportedSince' => '2.5',
-            'lastName'      => 'type' => 'string', 'supportedSince' => '2.5',
-            'mobilePhone'   => 'type' => 'string', 'supportedSince' => '2.5',
-            'office'        => 'type' => 'string', 'supportedSince' => '2.5',
-            'phone'         => 'type' => 'string', 'supportedSince' => '2.5',
-            'picture'       => 'type' => 'container', 'supportedSince' => '14.0',
-            'title'         => 'type' => 'string', 'supportedSince' => '2.5',
-        ,
-    ;
+    protected $_properties = array(
+        'GAL' => array(
+            'alias'         => array('type' => 'string', 'supportedSince' => '2.5'),
+            'company'       => array('type' => 'string', 'supportedSince' => '2.5'),
+            'displayName'   => array('type' => 'string', 'supportedSince' => '2.5'),
+            'emailAddress'  => array('type' => 'string', 'supportedSince' => '2.5'),
+            'firstName'     => array('type' => 'string', 'supportedSince' => '2.5'),
+            'lastName'      => array('type' => 'string', 'supportedSince' => '2.5'),
+            'mobilePhone'   => array('type' => 'string', 'supportedSince' => '2.5'),
+            'office'        => array('type' => 'string', 'supportedSince' => '2.5'),
+            'phone'         => array('type' => 'string', 'supportedSince' => '2.5'),
+            'picture'       => array('type' => 'container', 'supportedSince' => '14.0'),
+            'title'         => array('type' => 'string', 'supportedSince' => '2.5'),
+        )
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/GALPicture.php Changed

@@ -17,24 +17,24 @@
  * @package     Syncroton
  * @subpackage  Model
  *
- * @property    string    $status
- * @property    string    $data
+ * @property    string    Status
+ * @property    string    Data
  */
 class Syncroton_Model_GALPicture extends Syncroton_Model_AXMLEntry
 {
-    public const STATUS_SUCCESS   = 1;
-    public const STATUS_NOPHOTO   = 173;
-    public const STATUS_TOOLARGE  = 174;
-    public const STATUS_OVERLIMIT = 175;
+    const STATUS_SUCCESS   = 1;
+    const STATUS_NOPHOTO   = 173;
+    const STATUS_TOOLARGE  = 174;
+    const STATUS_OVERLIMIT = 175;
 
     protected $_xmlBaseElement = 'ApplicationData';
 
-    protected $_properties = 
-        'AirSync' => 
-            'status'       => 'type' => 'number',
-        ,
-        'GAL' => 
-            'data'         => 'type' => 'byteArray',
-        ,
-    ;
+    protected $_properties = array(
+        'AirSync' => array(
+            'status'       => array('type' => 'number'),
+        ),
+        'GAL' => array(
+            'data'         => array('type' => 'byteArray'),
+        ),
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/IContent.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/IDevice.php Changed

@@ -1,13 +1,12 @@
 <?php
-
 /**
  * Syncroton
  *
  * @package     Syncroton
  * @subpackage  Model
  * @license     http://www.tine20.org/licenses/lgpl.html LGPL Version 3
- * @copyright   Copyright (c) 2012-2014 Kolab Systems AG
- * @author      Aleksander Machniak <machniak@kolabsys.com>
+ * @copyright   Copyright (c) 2009-2012 Metaways Infosystems GmbH (http://www.metaways.de)
+ * @author      Lars Kneschke <l.kneschke@metaways.de>
  */
 
 /**
@@ -15,29 +14,31 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property    string   $acsversion
- * @property    string   $deviceid
- * @property    string   $devicetype
- * @property    string   $friendlyname
- * @property    string   $id
- * @property    string   $imei
- * @property    string   $model
- * @property    string   $os
- * @property    string   $oslanguage
- * @property    string   $ownerId
- * @property    string   $phonenumber
- * @property    string   $pingfolder
- * @property    int      $pinglifetime
- * @property    string   $policykey
- * @property    string   $policyId
- * @property    int      $remotewipe
- * @property    string   $useragent
- * @property    string   $contactsfilter_id
- * @property    string   $calendarfilter_id
- * @property    string   $tasksfilter_id
- * @property    string   $emailfilter_id
- * @property    string   $lastsynccollection
- * @property    DateTime $lastping
+ * @property    string   id
+ * @property    string   deviceid
+ * @property    string   devicetype
+ * @property    string   policykey
+ * @property    string   policyId
+ * @property    string   ownerId
+ * @property    string   acsversion
+ * @property    string   pingfolder
+ * @property    string   pinglifetime
+ * @property    string   remotewipe
+ * @property    string   useragent
+ * @property    string   imei
+ * @property    string   model
+ * @property    string   friendlyname
+ * @property    string   os
+ * @property    string   oslanguage
+ * @property    string   phonenumber
+ * @property    string   pinglifetime
+ * @property    string   pingfolder
+ * @property    string   contactsfilter_id
+ * @property    string   calendarfilter_id
+ * @property    string   tasksfilter_id
+ * @property    string   emailfilter_id
+ * @property    string   lastsynccollection
+ * @property    DateTime lastping
  */
 interface Syncroton_Model_IDevice extends Syncroton_Model_IEntry
 {
@@ -48,3 +49,4 @@
      */
     public function getMajorVersion();
 }
+

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/IEntry.php Changed

@@ -1,5 +1,5 @@
 <?php
-/*
+/**
  * Syncroton
  *
  * @package     Syncroton
@@ -10,33 +10,33 @@
  */
 
 /**
- * class to handle ActiveSync entry
+ * class to handle ActiveSync contact
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property    string  $class
- * @property    string  $collectionId
- * @property    bool    $deletesAsMoves
- * @property    bool    $getChanges
- * @property    string  $syncKey
- * @property    int     $windowSize
+ * @property    string  class
+ * @property    string  collectionId
+ * @property    bool    deletesAsMoves
+ * @property    bool    getChanges
+ * @property    string  syncKey
+ * @property    int     windowSize
  */
 interface Syncroton_Model_IEntry
 {
     /**
-     *
-     * @param SimpleXMLElement|array|null $properties
+     * 
+     * @param unknown_type $properties
      */
     public function __construct($properties = null);
-
+    
     /**
      * return true if data have got changed after initial data got loaded via constructor
      */
     public function isDirty();
-
+    
     /**
-     *
+     * 
      * @param array $properties
-     */
-    public function setFromArray(array $properties);
-}
+     */
+    public function setFromArray(array $properties);    
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/IFolder.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/IPolicy.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/ISyncState.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/IXMLEntry.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/MeetingResponse.php Changed

@@ -14,34 +14,34 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property    int     $userResponse
- * @property    string  $collectionId
- * @property    string  $calendarId
- * @property    string  $requestId
- * @property    string  $instanceId
- * @property    string  $longId
+ * @property    int     userResponse
+ * @property    string  collectionId
+ * @property    string  calendarId
+ * @property    string  requestId
+ * @property    string  instanceId
+ * @property    string  longId
  */
 class Syncroton_Model_MeetingResponse extends Syncroton_Model_AXMLEntry
 {
     protected $_xmlBaseElement = 'Request';
-
-    /**
-     * attendee status
-     */
-    public const RESPONSE_ACCEPTED  = 1;
-    public const RESPONSE_TENTATIVE = 2;
-    public const RESPONSE_DECLINED  = 3;
-
-    protected $_properties = 
-        'MeetingResponse' => 
-            'userResponse'  => 'type' => 'number',
-            'collectionId'  => 'type' => 'string',
-            'calendarId'    => 'type' => 'string',
-            'requestId'     => 'type' => 'string',
-            'instanceId'    => 'type' => 'datetime',
-        ,
-        'Search' => 
-            'longId'        => 'type' => 'string',
-        ,
-    ;
-}
+    
+    /**
+     * attendee status
+     */
+    const RESPONSE_ACCEPTED  = 1;
+    const RESPONSE_TENTATIVE = 2;
+    const RESPONSE_DECLINED  = 3;
+    
+    protected $_properties = array(
+        'MeetingResponse' => array(
+            'userResponse'  => array('type' => 'number'),
+            'collectionId'  => array('type' => 'string'),
+            'calendarId'    => array('type' => 'string'),
+            'requestId'     => array('type' => 'string'),
+            'instanceId'    => array('type' => 'datetime'),
+        ),
+        'Search' => array(
+            'longId'        => array('type' => 'string')
+        )
+    );
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/Note.php Changed

@@ -14,25 +14,25 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property    Syncroton_Model_EmailBody $body
- * @property    array                     $categories
- * @property    DateTime                  $lastModifiedDate
- * @property    string                    $messageClass
- * @property    string                    $subject
+ * @property    Syncroton_Model_EmailBody body
+ * @property    array                     categories
+ * @property    DateTime                  lastModifiedDate
+ * @property    string                    messageClass
+ * @property    string                    subject
  */
 class Syncroton_Model_Note extends Syncroton_Model_AXMLEntry
 {
     protected $_xmlBaseElement = 'ApplicationData';
 
-    protected $_properties = 
-        'AirSyncBase' => 
-            'body'             => 'type' => 'container', 'class' => 'Syncroton_Model_EmailBody',
-        ,
-        'Notes' => 
-            'categories'       => 'type' => 'container', 'childElement' => 'category',
-            'lastModifiedDate' => 'type' => 'datetime',
-            'messageClass'     => 'type' => 'string',
-            'subject'          => 'type' => 'string',
-        ,
-    ;
-}
+    protected $_properties = array(
+        'AirSyncBase' => array(
+            'body'             => array('type' => 'container', 'class' => 'Syncroton_Model_EmailBody')
+        ),
+        'Notes' => array(
+            'categories'       => array('type' => 'container', 'childElement' => 'category'),
+            'lastModifiedDate' => array('type' => 'datetime'),
+            'messageClass'     => array('type' => 'string'),
+            'subject'          => array('type' => 'string'),
+        )
+    );
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/Oof.php Changed

@@ -15,26 +15,21 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- *
- * @property DateTime                   $endTime
- * @property Syncroton_Model_OofMessage $oofMessage
- * @property int                        $oofState
- * @property DateTime                   $startTime
  */
 class Syncroton_Model_Oof extends Syncroton_Model_AXMLEntry
 {
-    public const STATUS_DISABLED   = 0;
-    public const STATUS_GLOBAL     = 1;
-    public const STATUS_TIME_BASED = 2;
+    const STATUS_DISABLED   = 0;
+    const STATUS_GLOBAL     = 1;
+    const STATUS_TIME_BASED = 2;
 
-    protected $_xmlBaseElement = 'Get', 'Set';
+    protected $_xmlBaseElement = array('Get', 'Set');
 
-    protected $_properties = 
-        'Settings' => 
-            'endTime'    => 'type' => 'datetime',
-            'oofMessage' => 'type' => 'container', 'multiple' => true, 'class' => 'Syncroton_Model_OofMessage',
-            'oofState'   => 'type' => 'number',
-            'startTime'  => 'type' => 'datetime',
-        ,
-    ;
+    protected $_properties = array(
+        'Settings' => array(
+            'endTime'    => array('type' => 'datetime'),
+            'oofMessage' => array('type' => 'container', 'multiple' => true, 'class' => 'Syncroton_Model_OofMessage'),
+            'oofState'   => array('type' => 'number'),
+            'startTime'  => array('type' => 'datetime'),
+        )
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/OofMessage.php Changed

@@ -18,16 +18,16 @@
  */
 class Syncroton_Model_OofMessage extends Syncroton_Model_AXMLEntry
 {
-    protected $_xmlBaseElement = 'OofMessage';
+    protected $_xmlBaseElement = array('OofMessage');
 
-    protected $_properties = 
-        'Settings' => 
-            'appliesToInternal'        => 'type' => 'none',
-            'appliesToExternalKnown'   => 'type' => 'none',
-            'appliesToExternalUnknown' => 'type' => 'none',
-            'bodyType'                 => 'type' => 'string',
-            'enabled'                  => 'type' => 'string',
-            'replyMessage'             => 'type' => 'string',
-        ,
-    ;
+    protected $_properties = array(
+        'Settings' => array(
+            'appliesToInternal'        => array('type' => 'none'),
+            'appliesToExternalKnown'   => array('type' => 'none'),
+            'appliesToExternalUnknown' => array('type' => 'none'),
+            'bodyType'                 => array('type' => 'string'),
+            'enabled'                  => array('type' => 'string'),
+            'replyMessage'             => array('type' => 'string'),
+        )
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/Policy.php Changed

@@ -18,57 +18,59 @@
 class Syncroton_Model_Policy extends Syncroton_Model_AXMLEntry implements Syncroton_Model_IPolicy
 {
     protected $_xmlBaseElement = 'EASProvisionDoc';
-
-    protected $_properties = 
-        'Internal' => 
-            'id'                                   => 'type' => 'string',
-            'description'                          => 'type' => 'string',
-            'name'                                 => 'type' => 'string',
-            'policyKey'                            => 'type' => 'string',
-        ,
-        'Provision' => 
-            'allowBluetooth'                       => 'type' => 'number',
-            'allowBrowser'                         => 'type' => 'number',
-            'allowCamera'                          => 'type' => 'number',
-            'allowConsumerEmail'                   => 'type' => 'number',
-            'allowDesktopSync'                     => 'type' => 'number',
-            'allowHTMLEmail'                       => 'type' => 'number',
-            'allowInternetSharing'                 => 'type' => 'number',
-            'allowIrDA'                            => 'type' => 'number',
-            'allowPOPIMAPEmail'                    => 'type' => 'number',
-            'allowRemoteDesktop'                   => 'type' => 'number',
-            'allowSimpleDevicePassword'            => 'type' => 'number',
-            'allowSMIMEEncryptionAlgorithmNegotiation' => 'type' => 'number',
-            'allowSMIMESoftCerts'                  => 'type' => 'number',
-            'allowStorageCard'                     => 'type' => 'number',
-            'allowTextMessaging'                   => 'type' => 'number',
-            'allowUnsignedApplications'            => 'type' => 'number',
-            'allowUnsignedInstallationPackages'    => 'type' => 'number',
-            'allowWifi'                            => 'type' => 'number',
-            'alphanumericDevicePasswordRequired'   => 'type' => 'number',
-            'approvedApplicationList'              => 'type' => 'container', 'childName' => 'Hash',
-            'attachmentsEnabled'                   => 'type' => 'number',
-            'devicePasswordEnabled'                => 'type' => 'number',
-            'devicePasswordExpiration'             => 'type' => 'number',
-            'devicePasswordHistory'                => 'type' => 'number',
-            'maxAttachmentSize'                    => 'type' => 'number',
-            'maxCalendarAgeFilter'                 => 'type' => 'number',
-            'maxDevicePasswordFailedAttempts'      => 'type' => 'number',
-            'maxEmailAgeFilter'                    => 'type' => 'number',
-            'maxEmailBodyTruncationSize'           => 'type' => 'number',
-            'maxEmailHTMLBodyTruncationSize'       => 'type' => 'number',
-            'maxInactivityTimeDeviceLock'          => 'type' => 'number',
-            'minDevicePasswordComplexCharacters'   => 'type' => 'number',
-            'minDevicePasswordLength'              => 'type' => 'number',
-            'passwordRecoveryEnabled'              => 'type' => 'number',
-            'requireDeviceEncryption'              => 'type' => 'number',
-            'requireEncryptedSMIMEMessages'        => 'type' => 'number',
-            'requireEncryptionSMIMEAlgorithm'      => 'type' => 'number',
-            'requireManualSyncWhenRoaming'         => 'type' => 'number',
-            'requireSignedSMIMEAlgorithm'          => 'type' => 'number',
-            'requireSignedSMIMEMessages'           => 'type' => 'number',
-            'requireStorageCardEncryption'         => 'type' => 'number',
-            'unapprovedInROMApplicationList'       => 'type' => 'container', 'childName' => 'ApplicationName',
-        ,
-    ;
+    
+    protected $_properties = array(
+        'Internal' => array(
+            'id'                                   => array('type' => 'string'),
+            'description'                          => array('type' => 'string'),
+            'name'                                 => array('type' => 'string'),
+            'policyKey'                            => array('type' => 'string'),
+        ),
+        'Provision' => array(
+            'allowBluetooth'                       => array('type' => 'number'),
+            'allowSMIMEEncryptionAlgorithmNegotiation' => array('type' => 'number'),
+            'allowBrowser'                         => array('type' => 'number'),
+            'allowCamera'                          => array('type' => 'number'),
+            'allowConsumerEmail'                   => array('type' => 'number'),
+            'allowDesktopSync'                     => array('type' => 'number'),
+            'allowHTMLEmail'                       => array('type' => 'number'),
+            'allowInternetSharing'                 => array('type' => 'number'),
+            'allowIrDA'                            => array('type' => 'number'),
+            'allowPOPIMAPEmail'                    => array('type' => 'number'),
+            'allowRemoteDesktop'                   => array('type' => 'number'),
+            'allowSimpleDevicePassword'            => array('type' => 'number'),
+            'allowSMIMEEncryptionAlgorithmNegotiation' => array('type' => 'number'),
+            'allowSMIMESoftCerts'                  => array('type' => 'number'),
+            'allowStorageCard'                     => array('type' => 'number'),
+            'allowTextMessaging'                   => array('type' => 'number'),
+            'allowUnsignedApplications'            => array('type' => 'number'),
+            'allowUnsignedInstallationPackages'    => array('type' => 'number'),
+            'allowWifi'                            => array('type' => 'number'),
+            'alphanumericDevicePasswordRequired'   => array('type' => 'number'),
+            'approvedApplicationList'              => array('type' => 'container', 'childName' => 'Hash'),
+            'attachmentsEnabled'                   => array('type' => 'number'),
+            'devicePasswordEnabled'                => array('type' => 'number'),
+            'devicePasswordExpiration'             => array('type' => 'number'),
+            'devicePasswordHistory'                => array('type' => 'number'),
+            'maxAttachmentSize'                    => array('type' => 'number'),
+            'maxCalendarAgeFilter'                 => array('type' => 'number'),
+            'maxDevicePasswordFailedAttempts'      => array('type' => 'number'),
+            'maxEmailAgeFilter'                    => array('type' => 'number'),
+            'maxEmailBodyTruncationSize'           => array('type' => 'number'),
+            'maxEmailHTMLBodyTruncationSize'       => array('type' => 'number'),
+            'maxInactivityTimeDeviceLock'          => array('type' => 'number'),
+            'minDevicePasswordComplexCharacters'   => array('type' => 'number'),
+            'minDevicePasswordLength'              => array('type' => 'number'),
+            'passwordRecoveryEnabled'              => array('type' => 'number'),
+            'requireDeviceEncryption'              => array('type' => 'number'),
+            'requireEncryptedSMIMEMessages'        => array('type' => 'number'),
+            'requireEncryptionSMIMEAlgorithm'      => array('type' => 'number'),
+            'requireManualSyncWhenRoaming'         => array('type' => 'number'),
+            'requireSignedSMIMEAlgorithm'          => array('type' => 'number'),
+            'requireSignedSMIMEMessages'           => array('type' => 'number'),
+            'requireStorageCardEncryption'         => array('type' => 'number'),
+            'unapprovedInROMApplicationList'       => array('type' => 'container', 'childName' => 'ApplicationName')
+        )
+    );
 }
+

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/SendMail.php Changed

@@ -19,16 +19,16 @@
  */
 class Syncroton_Model_SendMail extends Syncroton_Model_AXMLEntry
 {
-    protected $_properties = 
-        'ComposeMail' => 
-            'accountId'       => 'type' => 'string',
-            'clientId'        => 'type' => 'string',
-            'mime'            => 'type' => 'byteArray',
-            'saveInSentItems' => 'type' => 'string',
-            'status'          => 'type' => 'number',
-        ,
-        'RightsManagement' => 
-            'templateID'      => 'type' => 'string',
-        ,
-    ;
+    protected $_properties = array(
+        'ComposeMail' => array(
+            'accountId'       => array('type' => 'string'),
+            'clientId'        => array('type' => 'string'),
+            'mime'            => array('type' => 'byteArray'),
+            'saveInSentItems' => array('type' => 'string'),
+            'status'          => array('type' => 'number'),
+        ),
+        'RightsManagement' => array(
+            'templateID'      => array('type' => 'string'),
+        )
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/SmartForward.php Changed

@@ -19,18 +19,18 @@
  */
 class Syncroton_Model_SmartForward extends Syncroton_Model_AXMLEntry
 {
-    protected $_properties = 
-        'ComposeMail' => 
-            'accountId'       => 'type' => 'string',
-            'clientId'        => 'type' => 'string',
-            'mime'            => 'type' => 'byteArray',
-            'replaceMime'     => 'type' => 'string',
-            'saveInSentItems' => 'type' => 'string',
-            'source'          => 'type' => 'container', // or string
-            'status'          => 'type' => 'number',
-        ,
-        'RightsManagement' => 
-            'templateID'      => 'type' => 'string',
-        ,
-    ;
+    protected $_properties = array(
+        'ComposeMail' => array(
+            'accountId'       => array('type' => 'string'),
+            'clientId'        => array('type' => 'string'),
+            'mime'            => array('type' => 'byteArray'),
+            'replaceMime'     => array('type' => 'string'),
+            'saveInSentItems' => array('type' => 'string'),
+            'source'          => array('type' => 'container'), // or string
+            'status'          => array('type' => 'number'),
+        ),
+        'RightsManagement' => array(
+            'templateID'      => array('type' => 'string'),
+        )
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/SmartReply.php Changed

@@ -19,18 +19,18 @@
  */
 class Syncroton_Model_SmartReply extends Syncroton_Model_AXMLEntry
 {
-    protected $_properties = 
-        'ComposeMail' => 
-            'accountId'       => 'type' => 'string',
-            'clientId'        => 'type' => 'string',
-            'mime'            => 'type' => 'byteArray',
-            'replaceMime'     => 'type' => 'string',
-            'saveInSentItems' => 'type' => 'string',
-            'source'          => 'type' => 'container', // or string
-            'status'          => 'type' => 'number',
-        ,
-        'RightsManagement' => 
-            'templateID'      => 'type' => 'string',
-        ,
-    ;
+    protected $_properties = array(
+        'ComposeMail' => array(
+            'accountId'       => array('type' => 'string'),
+            'clientId'        => array('type' => 'string'),
+            'mime'            => array('type' => 'byteArray'),
+            'replaceMime'     => array('type' => 'string'),
+            'saveInSentItems' => array('type' => 'string'),
+            'source'          => array('type' => 'container'), // or string
+            'status'          => array('type' => 'number'),
+        ),
+        'RightsManagement' => array(
+            'templateID'      => array('type' => 'string'),
+        )
+    );
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/StoreRequest.php Changed

@@ -16,13 +16,13 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property    string  $name
- * @property    array   $options
- * @property    array   $query
+ * @property    string  name
+ * @property    array   options
+ * @property    array   query
  */
 class Syncroton_Model_StoreRequest
 {
-    protected $_store = ;
+    protected $_store = array();
 
     protected $_xmlStore;
 
@@ -37,12 +37,12 @@
 
     public function setFromArray(array $properties)
     {
-        $this->_store = 
-            'options' => 
+        $this->_store = array(
+            'options' => array(
                 'mimeSupport'     => Syncroton_Command_Sync::MIMESUPPORT_DONT_SEND_MIME,
-                'bodyPreferences' => ,
-            ,
-        ;
+                'bodyPreferences' => array()
+            ),
+        );
 
         foreach ($properties as $key => $value) {
             try {
@@ -67,13 +67,13 @@
 
         $this->_xmlStore = $xmlStore;
 
-        $this->_store = 
+        $this->_store = array(
             'name'             => (string) $xmlStore->Name,
-            'options'          => 
+            'options'          => array(
                 'mimeSupport'     => Syncroton_Command_Sync::MIMESUPPORT_DONT_SEND_MIME,
-                'bodyPreferences' => ,
-            ,
-        ;
+                'bodyPreferences' => array(),
+            ),
+        );
 
         // Process Query
         if ($this->_store'name' == 'GAL') {
@@ -176,15 +176,15 @@
                 $this->_store'options''range' = (string) $xmlStore->Options->Range;
             } else {
                 switch ($this->_store'name') {
-                    case 'DocumentLibrary':
-                    case 'Document Library': //?
-                        $this->_store'options''range' = '0-999';
-                        break;
-                    case 'Mailbox':
-                    case 'GAL':
-                    default:
-                        $this->_store'options''range' = '0-99';
-                        break;
+                case 'DocumentLibrary':
+                case 'Document Library': //?
+                    $this->_store'options''range' = '0-999';
+                    break;
+                case 'Mailbox':
+                case 'GAL':
+                default:
+                    $this->_store'options''range' = '0-99';
+                    break;
                 }
             }
 
@@ -193,20 +193,20 @@
             if (isset($xmlStore->Options->MIMESupport)) {
                 $this->_store'options''mimeSupport' = (int) $xmlStore->Options->MIMESupport;
             }
-            /*
-                        if (isset($xmlStore->Options->MIMETruncation)) {
-                            $this->_store'options''mimeTruncation' = (int)$xmlStore->Options->MIMETruncation;
-                        }
-            */
+/*
+            if (isset($xmlStore->Options->MIMETruncation)) {
+                $this->_store'options''mimeTruncation' = (int)$xmlStore->Options->MIMETruncation;
+            }
+*/
             // try to fetch element from AirSyncBase:BodyPreference
             $airSyncBase = $xmlStore->Options->children('uri:AirSyncBase');
 
             if (isset($airSyncBase->BodyPreference)) {
                 foreach ($airSyncBase->BodyPreference as $bodyPreference) {
                     $type = (int) $bodyPreference->Type;
-                    $this->_store'options''bodyPreferences'$type = 
-                        'type' => $type,
-                    ;
+                    $this->_store'options''bodyPreferences'$type = array(
+                        'type' => $type
+                    );
 
                     // optional
                     if (isset($bodyPreference->TruncationSize)) {
@@ -244,4 +244,4 @@
     {
         unset($this->_store$name);
     }
-}
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/StoreResponse.php Changed

@@ -1,13 +1,12 @@
 <?php
-
 /**
  * Syncroton
  *
  * @package     Syncroton
  * @subpackage  Model
  * @license     http://www.tine20.org/licenses/lgpl.html LGPL Version 3
- * @copyright   Copyright (c) 2012-2014 Kolab Systems AG
- * @author      Aleksander Machniak <machniak@kolabsys.com>
+ * @copyright   Copyright (c) 2012-2012 Metaways Infosystems GmbH (http://www.metaways.de)
+ * @author      Lars Kneschke <l.kneschke@metaways.de>
  */
 
 /**
@@ -15,41 +14,40 @@
  *
  * @package    Syncroton
  * @subpackage Model
- *
- * @property  int     $status
- * @property  array   $result
- * @property  array   $range
- * @property  int     $total
+ * @property  string  status
+ * @property  array   result
+ * @property  array   range
+ * @property  int     total
  */
 class Syncroton_Model_StoreResponse extends Syncroton_Model_AXMLEntry
 {
     /**
      * status constants
      */
-    public const STATUS_SUCCESS            = 1;
-    public const STATUS_INVALIDREQUEST     = 2;
-    public const STATUS_SERVERERROR        = 3;
-    public const STATUS_BADLINK            = 4;
-    public const STATUS_ACCESSDENIED       = 5;
-    public const STATUS_NOTFOUND           = 6;
-    public const STATUS_CONNECTIONFAILED   = 7;
-    public const STATUS_TOOCOMPLEX         = 8;
-    public const STATUS_TIMEDOUT           = 10;
-    public const STATUS_FOLDERSYNCREQUIRED = 11;
-    public const STATUS_ENDOFRANGE         = 12;
-    public const STATUS_ACCESSBLOCKED      = 13;
-    public const STATUS_CREDENTIALSREQUIRED = 14;
+    const STATUS_SUCCESS            = 1;
+    const STATUS_INVALIDREQUEST     = 2;
+    const STATUS_SERVERERROR        = 3;
+    const STATUS_BADLINK            = 4;
+    const STATUS_ACCESSDENIED       = 5;
+    const STATUS_NOTFOUND           = 6;
+    const STATUS_CONNECTIONFAILED   = 7;
+    const STATUS_TOOCOMPLEX         = 8;
+    const STATUS_TIMEDOUT           = 10;
+    const STATUS_FOLDERSYNCREQUIRED = 11;
+    const STATUS_ENDOFRANGE         = 12;
+    const STATUS_ACCESSBLOCKED      = 13;
+    const STATUS_CREDENTIALSREQUIRED = 14;
 
     protected $_xmlBaseElement = 'Store';
 
-    protected $_properties = 
-        'Search' => 
-            'status'    => 'type' => 'number',
-            'result'    => 'type' => 'container', 'multiple' => true,
-            'range'     => 'type' => 'string',
-            'total'     => 'type' => 'number',
-        ,
-    ;
+    protected $_properties = array(
+        'Search' => array(
+            'status'    => array('type' => 'number'),
+            'result'    => array('type' => 'container', 'multiple' => true),
+            'range'     => array('type' => 'string'),
+            'total'     => array('type' => 'number'),
+        )
+    );
 
     /**
      * (non-PHPdoc)
@@ -65,7 +63,7 @@
                 continue;
             }
 
-            $nameSpace, $elementProperties = $this->_getElementProperties($elementName);
+            list ($nameSpace, $elementProperties) = $this->_getElementProperties($elementName);
 
             $nameSpace = 'uri:' . $nameSpace;
 
@@ -83,7 +81,6 @@
                         $value = implode('-', $value);
                     }
 
-                    // no break
                 default:
                     $element = $_domParrent->ownerDocument->createElementNS($nameSpace, ucfirst($elementName));
                     $element->appendChild($_domParrent->ownerDocument->createTextNode($value));

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/StoreResponseResult.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/SyncCollection.php Changed

@@ -14,39 +14,35 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- *
- * @property string                      $class
- * @property string                      $collectionId
- * @property bool                        $deletesAsMoves
- * @property Syncroton_Model_IFolder     $folder
- * @property bool                        $getChanges
- * @property array                       $options
- * @property int                         $syncKey
- * @property ?Syncroton_Model_ISyncState $syncState
- * @property array                       $toBeFetched
- * @property int                         $windowSize
+ * @property    string  class
+ * @property    string  collectionId
+ * @property    bool    deletesAsMoves
+ * @property    bool    getChanges
+ * @property    string  syncKey
+ * @property    int     windowSize
  */
+
 class Syncroton_Model_SyncCollection extends Syncroton_Model_AXMLEntry
 {
-    protected $_elements = 
+    protected $_elements = array(
         'syncState' => null,
-        'folder'    => null,
-    ;
-
+        'folder'    => null
+    );
+    
     protected $_xmlCollection;
-
+    
     protected $_xmlBaseElement = 'Collection';
-
-    public function __construct($properties = null)
-    {
-        if ($properties instanceof SimpleXMLElement) {
-            $this->setFromSimpleXMLElement($properties);
-        } elseif (is_array($properties)) {
-            $this->setFromArray($properties);
+    
+    public function __construct($properties = null)
+    {
+        if ($properties instanceof SimpleXMLElement) {
+            $this->setFromSimpleXMLElement($properties);
+        } elseif (is_array($properties)) {
+            $this->setFromArray($properties);
         }
-
+        
         if (!isset($this->_elements'options')) {
-            $this->_elements'options' = ;
+            $this->_elements'options' = array();
         }
         if (!isset($this->_elements'options''filterType')) {
             $this->_elements'options''filterType' = Syncroton_Command_Sync::FILTER_NOTHING;
@@ -57,14 +53,14 @@
         if (!isset($this->_elements'options''mimeTruncation')) {
             $this->_elements'options''mimeTruncation' = Syncroton_Command_Sync::TRUNCATE_NOTHING;
         }
-        if (!isset($this->_elements'options''bodyPreferences')) {
-            $this->_elements'options''bodyPreferences' = ;
+            if (!isset($this->_elements'options''bodyPreferences')) {
+            $this->_elements'options''bodyPreferences' = array();
         }
-    }
-
+    }
+    
     /**
      * return XML element which holds all client Add commands
-     *
+     * 
      * @return SimpleXMLElement
      */
     public function getClientAdds()
@@ -72,13 +68,13 @@
         if (! $this->_xmlCollection instanceof SimpleXMLElement) {
             throw new InvalidArgumentException('no collection xml element set');
         }
-
+        
         return $this->_xmlCollection->Commands->Add;
     }
-
+    
     /**
      * return XML element which holds all client Change commands
-     *
+     * 
      * @return SimpleXMLElement
      */
     public function getClientChanges()
@@ -86,13 +82,13 @@
         if (! $this->_xmlCollection instanceof SimpleXMLElement) {
             throw new InvalidArgumentException('no collection xml element set');
         }
-
+        
         return $this->_xmlCollection->Commands->Change;
     }
-
+    
     /**
      * return XML element which holds all client Delete commands
-     *
+     * 
      * @return SimpleXMLElement
      */
     public function getClientDeletes()
@@ -100,13 +96,13 @@
         if (! $this->_xmlCollection instanceof SimpleXMLElement) {
             throw new InvalidArgumentException('no collection xml element set');
         }
-
+        
         return $this->_xmlCollection->Commands->Delete;
     }
-
+    
     /**
      * return XML element which holds all client Fetch commands
-     *
+     * 
      * @return SimpleXMLElement
      */
     public function getClientFetches()
@@ -114,13 +110,13 @@
         if (! $this->_xmlCollection instanceof SimpleXMLElement) {
             throw new InvalidArgumentException('no collection xml element set');
         }
-
+        
         return $this->_xmlCollection->Commands->Fetch;
     }
-
+    
     /**
      * check if client sent a Add command
-     *
+     * 
      * @throws InvalidArgumentException
      * @return bool
      */
@@ -129,13 +125,13 @@
         if (! $this->_xmlCollection instanceof SimpleXMLElement) {
             return false;
         }
-
+        
         return isset($this->_xmlCollection->Commands->Add);
     }
-
+    
     /**
      * check if client sent a Change command
-     *
+     * 
      * @throws InvalidArgumentException
      * @return bool
      */
@@ -144,13 +140,13 @@
         if (! $this->_xmlCollection instanceof SimpleXMLElement) {
             return false;
         }
-
+        
         return isset($this->_xmlCollection->Commands->Change);
     }
-
+    
     /**
      * check if client sent a Delete command
-     *
+     * 
      * @throws InvalidArgumentException
      * @return bool
      */
@@ -159,13 +155,13 @@
         if (! $this->_xmlCollection instanceof SimpleXMLElement) {
             return false;
         }
-
+        
         return isset($this->_xmlCollection->Commands->Delete);
     }
-
+    
     /**
      * check if client sent a Fetch command
-     *
+     * 
      * @throws InvalidArgumentException
      * @return bool
      */
@@ -174,14 +170,14 @@
         if (! $this->_xmlCollection instanceof SimpleXMLElement) {
             return false;
         }
-
+        
         return isset($this->_xmlCollection->Commands->Fetch);
     }
-
+    
     /**
      * this functions does not only set from SimpleXMLElement but also does merge from SimpleXMLElement
      * to support partial sync requests
-     *
+     * 
      * @param SimpleXMLElement $properties
      * @throws InvalidArgumentException
      */
@@ -190,29 +186,29 @@
         if (!in_array($properties->getName(), (array) $this->_xmlBaseElement)) {
             throw new InvalidArgumentException('Unexpected element name: ' . $properties->getName());
         }
-
+        
         $this->_xmlCollection = $properties;
-
+        
         if (isset($properties->CollectionId)) {
             $this->_elements'collectionId' = (string)$properties->CollectionId;
         }
-
+        
         if (isset($properties->SyncKey)) {
             $this->_elements'syncKey' = (int)$properties->SyncKey;
         }
-
+        
         if (isset($properties->Class)) {
             $this->_elements'class' = (string)$properties->Class;
         } elseif (!array_key_exists('class', $this->_elements)) {
             $this->_elements'class' = null;
         }
-
+        
         if (isset($properties->WindowSize)) {
             $this->_elements'windowSize' = (string)$properties->WindowSize;
         } elseif (!array_key_exists('windowSize', $this->_elements)) {
             $this->_elements'windowSize' = 100;
         }
-
+        
         if (isset($properties->DeletesAsMoves)) {
             if ((string)$properties->DeletesAsMoves === '0') {
                 $this->_elements'deletesAsMoves' = false;
@@ -222,7 +218,7 @@
         } elseif (!array_key_exists('deletesAsMoves', $this->_elements)) {
             $this->_elements'deletesAsMoves' = true;
         }
-
+        
         if (isset($properties->ConversationMode)) {
             if ((string)$properties->ConversationMode === '0') {
                 $this->_elements'conversationMode' = false;
@@ -232,7 +228,7 @@
         } elseif (!array_key_exists('conversationMode', $this->_elements)) {
             $this->_elements'conversationMode' = true;
         }
-
+        
         if (isset($properties->GetChanges)) {
             if ((string)$properties->GetChanges === '0') {
                 $this->_elements'getChanges' = false;
@@ -242,82 +238,82 @@
         } elseif (!array_key_exists('getChanges', $this->_elements)) {
             $this->_elements'getChanges' = true;
         }
-
+        
         if (isset($properties->Supported)) {
             // @todo collect supported elements
         }
-
-        // process options
+        
+        // process options
         if (isset($properties->Options)) {
-            $this->_elements'options' = ;
-
-            // optional parameters
-            if (isset($properties->Options->FilterType)) {
-                $this->_elements'options''filterType' = (int)$properties->Options->FilterType;
-            }
-            if (isset($properties->Options->MIMESupport)) {
-                $this->_elements'options''mimeSupport' = (int)$properties->Options->MIMESupport;
-            }
-            if (isset($properties->Options->MIMETruncation)) {
-                $this->_elements'options''mimeTruncation' = (int)$properties->Options->MIMETruncation;
-            }
-            if (isset($properties->Options->Class)) {
-                $this->_elements'options''class' = (string)$properties->Options->Class;
+            $this->_elements'options' = array();
+            
+            // optional parameters
+            if (isset($properties->Options->FilterType)) {
+                $this->_elements'options''filterType' = (int)$properties->Options->FilterType;
+            }
+            if (isset($properties->Options->MIMESupport)) {
+                $this->_elements'options''mimeSupport' = (int)$properties->Options->MIMESupport;
+            }
+            if (isset($properties->Options->MIMETruncation)) {
+                $this->_elements'options''mimeTruncation' = (int)$properties->Options->MIMETruncation;
             }
-
-            // try to fetch element from AirSyncBase:BodyPreference
-            $airSyncBase = $properties->Options->children('uri:AirSyncBase');
-
-            if (isset($airSyncBase->BodyPreference)) {
-
-                foreach ($airSyncBase->BodyPreference as $bodyPreference) {
-                    $type = (int) $bodyPreference->Type;
-                    $this->_elements'options''bodyPreferences'$type = 
-                        'type' => $type,
-                    ;
-
-                    // optional
-                    if (isset($bodyPreference->TruncationSize)) {
-                        $this->_elements'options''bodyPreferences'$type'truncationSize' = (int) $bodyPreference->TruncationSize;
-                    }
-
-                    // optional
-                    if (isset($bodyPreference->Preview)) {
-                        $this->_elements'options''bodyPreferences'$type'preview' = (int) $bodyPreference->Preview;
+            if (isset($properties->Options->Class)) {
+                $this->_elements'options''class' = (string)$properties->Options->Class;
+            }
+            
+            // try to fetch element from AirSyncBase:BodyPreference
+            $airSyncBase = $properties->Options->children('uri:AirSyncBase');
+            
+            if (isset($airSyncBase->BodyPreference)) {
+                
+                foreach ($airSyncBase->BodyPreference as $bodyPreference) {
+                    $type = (int) $bodyPreference->Type;
+                    $this->_elements'options''bodyPreferences'$type = array(
+                        'type' => $type
+                    );
+                    
+                    // optional
+                    if (isset($bodyPreference->TruncationSize)) {
+                        $this->_elements'options''bodyPreferences'$type'truncationSize' = (int) $bodyPreference->TruncationSize;
                     }
+                    
+                    // optional
+                    if (isset($bodyPreference->Preview)) {
+                        $this->_elements'options''bodyPreferences'$type'preview' = (int) $bodyPreference->Preview;
+                    }
                 }
             }
-
+            
             if (isset($airSyncBase->BodyPartPreference)) {
                 // process BodyPartPreference elements
             }
-        }
+        }
     }
-
+    
     public function toArray()
     {
-        $result = ;
-
-        foreach ('syncKey', 'collectionId', 'deletesAsMoves', 'conversationMode', 'getChanges', 'windowSize', 'class', 'options' as $key) {
+        $result = array();
+        
+        foreach (array('syncKey', 'collectionId', 'deletesAsMoves', 'conversationMode', 'getChanges', 'windowSize', 'class', 'options') as $key) {
             if (isset($this->$key)) {
                 $result$key = $this->$key;
             }
         }
-
+        
         return $result;
     }
-
+    
     public function &__get($name)
     {
-        if (array_key_exists($name, $this->_elements)) {
-            return $this->_elements$name;
+        if (array_key_exists($name, $this->_elements)) {
+            return $this->_elements$name;
         }
         echo $name . PHP_EOL;
-        return null;
+        return null; 
     }
-
+    
     public function __set($name, $value)
     {
         $this->_elements$name = $value;
     }
-}
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/SyncState.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/Task.php Changed

@@ -14,37 +14,35 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property    string   $class
- * @property    string   $collectionId
- * @property    bool     $deletesAsMoves
- * @property    bool     $getChanges
- * @property    string   $syncKey
- * @property    DateTime $utcDueDate
- * @property    DateTime $utcStartDate
- * @property    int      $windowSize
+ * @property    string  class
+ * @property    string  collectionId
+ * @property    bool    deletesAsMoves
+ * @property    bool    getChanges
+ * @property    string  syncKey
+ * @property    int     windowSize
  */
 class Syncroton_Model_Task extends Syncroton_Model_AXMLEntry
 {
     protected $_xmlBaseElement = 'ApplicationData';
-
-    protected $_properties = 
-        'AirSyncBase' => 
-            'body'                   => 'type' => 'container', 'class' => 'Syncroton_Model_EmailBody',
-        ,
-        'Tasks' => 
-            'categories'              => 'type' => 'container', 'childElement' => 'category',
-            'complete'                => 'type' => 'number',
-            'dateCompleted'           => 'type' => 'datetime',
-            'dueDate'                 => 'type' => 'datetime',
-            'importance'              => 'type' => 'number',
-            'recurrence'              => 'type' => 'container',
-            'reminderSet'             => 'type' => 'number',
-            'reminderTime'            => 'type' => 'datetime',
-            'sensitivity'             => 'type' => 'number',
-            'startDate'               => 'type' => 'datetime',
-            'subject'                 => 'type' => 'string',
-            'utcDueDate'              => 'type' => 'datetime',
-            'utcStartDate'            => 'type' => 'datetime',
-        ,
-    ;
-}
+    
+    protected $_properties = array(
+        'AirSyncBase' => array(
+            'body'                   => array('type' => 'container', 'class' => 'Syncroton_Model_EmailBody')
+        ),
+        'Tasks' => array(
+            'categories'              => array('type' => 'container', 'childElement' => 'category'),
+            'complete'                => array('type' => 'number'),
+            'dateCompleted'           => array('type' => 'datetime'),
+            'dueDate'                 => array('type' => 'datetime'),
+            'importance'              => array('type' => 'number'),
+            'recurrence'              => array('type' => 'container'),
+            'reminderSet'             => array('type' => 'number'),
+            'reminderTime'            => array('type' => 'datetime'),
+            'sensitivity'             => array('type' => 'number'),
+            'startDate'               => array('type' => 'datetime'),
+            'subject'                 => array('type' => 'string'),
+            'utcDueDate'              => array('type' => 'datetime'),
+            'utcStartDate'            => array('type' => 'datetime'),
+        )
+    );
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/TaskRecurrence.php Changed

@@ -14,54 +14,54 @@
  *
  * @package     Syncroton
  * @subpackage  Model
- * @property    string  $class
- * @property    string  $collectionId
- * @property    bool    $deletesAsMoves
- * @property    bool    $getChanges
- * @property    string  $syncKey
- * @property    int     $windowSize
+ * @property    string  class
+ * @property    string  collectionId
+ * @property    bool    deletesAsMoves
+ * @property    bool    getChanges
+ * @property    string  syncKey
+ * @property    int     windowSize
  */
 class Syncroton_Model_TaskRecurrence extends Syncroton_Model_AXMLEntry
 {
     protected $_xmlBaseElement = 'Recurrence';
-
+    
     /**
      * recur types
      */
-    public const TYPE_DAILY          = 0;     // Recurs daily.
-    public const TYPE_WEEKLY         = 1;     // Recurs weekly
-    public const TYPE_MONTHLY        = 2;     // Recurs monthly
-    public const TYPE_MONTHLY_DAYN   = 3;     // Recurs monthly on the nth day
-    public const TYPE_YEARLY         = 5;     // Recurs yearly
-    public const TYPE_YEARLY_DAYN    = 6;     // Recurs yearly on the nth day
-
+    const TYPE_DAILY          = 0;     // Recurs daily.
+    const TYPE_WEEKLY         = 1;     // Recurs weekly
+    const TYPE_MONTHLY        = 2;     // Recurs monthly
+    const TYPE_MONTHLY_DAYN   = 3;     // Recurs monthly on the nth day
+    const TYPE_YEARLY         = 5;     // Recurs yearly
+    const TYPE_YEARLY_DAYN    = 6;     // Recurs yearly on the nth day
+    
     /**
      * day of week constants
      */
-    public const RECUR_DOW_SUNDAY      = 1;
-    public const RECUR_DOW_MONDAY      = 2;
-    public const RECUR_DOW_TUESDAY     = 4;
-    public const RECUR_DOW_WEDNESDAY   = 8;
-    public const RECUR_DOW_THURSDAY    = 16;
-    public const RECUR_DOW_FRIDAY      = 32;
-    public const RECUR_DOW_SATURDAY    = 64;
-
-    protected $_properties = 
-        'Tasks' => 
-            'calendarType'            => 'type' => 'number',
-            'dayOfMonth'              => 'type' => 'number',
-            'dayOfWeek'               => 'type' => 'number',
-            'deadOccur'               => 'type' => 'number',
-            'firstDayOfWeek'          => 'type' => 'number',
-            'interval'                => 'type' => 'number',
-            'isLeapMonth'             => 'type' => 'number',
-            'monthOfYear'             => 'type' => 'number',
-            'occurrences'             => 'type' => 'number',
-            'regenerate'              => 'type' => 'number',
-            'start'                   => 'type' => 'datetime',
-            'type'                    => 'type' => 'number',
-            'until'                   => 'type' => 'datetime',
-            'weekOfMonth'             => 'type' => 'number',
-        ,
-    ;
-}
+    const RECUR_DOW_SUNDAY      = 1;
+    const RECUR_DOW_MONDAY      = 2;
+    const RECUR_DOW_TUESDAY     = 4;
+    const RECUR_DOW_WEDNESDAY   = 8;
+    const RECUR_DOW_THURSDAY    = 16;
+    const RECUR_DOW_FRIDAY      = 32;
+    const RECUR_DOW_SATURDAY    = 64;
+        
+    protected $_properties = array(
+        'Tasks' => array(
+            'calendarType'            => array('type' => 'number'),
+            'dayOfMonth'              => array('type' => 'number'),
+            'dayOfWeek'               => array('type' => 'number'),
+            'deadOccur'               => array('type' => 'number'),
+            'firstDayOfWeek'          => array('type' => 'number'),
+            'interval'                => array('type' => 'number'),
+            'isLeapMonth'             => array('type' => 'number'),
+            'monthOfYear'             => array('type' => 'number'),
+            'occurrences'             => array('type' => 'number'),
+            'regenerate'              => array('type' => 'number'),
+            'start'                   => array('type' => 'datetime'),
+            'type'                    => array('type' => 'number'),
+            'until'                   => array('type' => 'datetime'),
+            'weekOfMonth'             => array('type' => 'number'),
+        )
+    );
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Registry.php Changed

@@ -27,34 +27,33 @@
  */
 class Syncroton_Registry extends ArrayObject
 {
-    public const CALENDAR_DATA_CLASS = 'calendar_data_class';
-    public const CONTACTS_DATA_CLASS = 'contacts_data_class';
-    public const EMAIL_DATA_CLASS    = 'email_data_class';
-    public const NOTES_DATA_CLASS    = 'notes_data_class';
-    public const TASKS_DATA_CLASS    = 'tasks_data_class';
-    public const GAL_DATA_CLASS      = 'gal_data_class';
-
-    public const DEFAULT_POLICY      = 'default_policy';
-    public const PING_TIMEOUT        = 'ping_timeout';
-    public const PING_INTERVAL       = 'ping_interval';
-    public const QUIET_TIME          = 'quiet_time';
-    public const SESSION_VALIDATOR   = 'session_validator';
-    public const MAX_COLLECTIONS     = 'max_collections';
-    public const MAX_PING_INTERVAL   = 'max_ping_interval';
-
-    public const DATABASE            = 'database';
-    public const TRANSACTIONMANAGER  = 'transactionmanager';
-
-    public const CONTENTSTATEBACKEND = 'contentstatebackend';
-    public const DEVICEBACKEND       = 'devicebackend';
-    public const FOLDERBACKEND       = 'folderbackend';
-    public const POLICYBACKEND       = 'policybackend';
-    public const SYNCSTATEBACKEND    = 'syncstatebackend';
-    public const LOGGERBACKEND       = 'loggerBackend';
-
-    public const SLEEP_CALLBACK      = 'sleep_callback';
-    public const WAKEUP_CALLBACK     = 'wakeup_callback';
-
+    const CALENDAR_DATA_CLASS = 'calendar_data_class';
+    const CONTACTS_DATA_CLASS = 'contacts_data_class';
+    const EMAIL_DATA_CLASS    = 'email_data_class';
+    const NOTES_DATA_CLASS    = 'notes_data_class';
+    const TASKS_DATA_CLASS    = 'tasks_data_class';
+    const GAL_DATA_CLASS      = 'gal_data_class';
+    
+    const DEFAULT_POLICY      = 'default_policy';
+    const PING_TIMEOUT        = 'ping_timeout';
+    const PING_INTERVAL       = 'ping_interval';
+    const QUIET_TIME          = 'quiet_time';
+    const SESSION_VALIDATOR   = 'session_validator';
+    const MAX_COLLECTIONS     = 'max_collections';
+    
+    const DATABASE            = 'database';
+    const TRANSACTIONMANAGER  = 'transactionmanager';
+    
+    const CONTENTSTATEBACKEND = 'contentstatebackend';
+    const DEVICEBACKEND       = 'devicebackend';
+    const FOLDERBACKEND       = 'folderbackend';
+    const POLICYBACKEND       = 'policybackend';
+    const SYNCSTATEBACKEND    = 'syncstatebackend';
+    const LOGGERBACKEND       = 'loggerBackend';
+
+    const SLEEP_CALLBACK      = 'sleep_callback';
+    const WAKEUP_CALLBACK     = 'wakeup_callback';
+    
     /**
      * Class name of the singleton registry object.
      * @var string
@@ -63,7 +62,7 @@
 
     /**
      * Registry object provides storage for shared objects.
-     * @var Syncroton_Registry|null
+     * @var Syncroton_Registry
      */
     private static $_registry = null;
 
@@ -88,10 +87,10 @@
     {
         return self::get(self::DATABASE);
     }
-
+    
     /**
-     * return transaction manager class
-     *
+     * return transaction manager class 
+     * 
      * @return Syncroton_TransactionManagerInterface
      */
     public static function getTransactionManager()
@@ -99,10 +98,10 @@
         if (!self::isRegistered(self::TRANSACTIONMANAGER)) {
             self::set(self::TRANSACTIONMANAGER, Syncroton_TransactionManager::getInstance());
         }
-
+        
         return self::get(self::TRANSACTIONMANAGER);
-    }
-
+    } 
+    
     /**
      * Set the default registry instance to a specified instance.
      *
@@ -197,13 +196,13 @@
 
         return $instance->offsetGet($index);
     }
-
+    
     /**
      * returns content state backend
-     *
+     * 
      * creates Syncroton_Backend_Content on the fly if not before via
      * Syncroton_Registry::set(self::CONTENTSTATEBACKEND, $backend);
-     *
+     * 
      * @return Syncroton_Backend_IContent
      */
     public static function getContentStateBackend()
@@ -211,16 +210,16 @@
         if (!self::isRegistered(self::CONTENTSTATEBACKEND)) {
             self::set(self::CONTENTSTATEBACKEND, new Syncroton_Backend_Content(self::getDatabase()));
         }
-
+        
         return self::get(self::CONTENTSTATEBACKEND);
     }
 
     /**
      * returns device backend
-     *
+     * 
      * creates Syncroton_Backend_Device on the fly if not before via
      * Syncroton_Registry::set(self::DEVICEBACKEND, $backend);
-     *
+     * 
      * @return Syncroton_Backend_IDevice
      */
     public static function getDeviceBackend()
@@ -228,16 +227,16 @@
         if (!self::isRegistered(self::DEVICEBACKEND)) {
             self::set(self::DEVICEBACKEND, new Syncroton_Backend_Device(self::getDatabase()));
         }
-
+        
         return self::get(self::DEVICEBACKEND);
     }
 
     /**
      * returns folder backend
-     *
+     * 
      * creates Syncroton_Backend_Folder on the fly if not before via
      * Syncroton_Registry::set(self::FOLDERBACKEND, $backend);
-     *
+     * 
      * @return Syncroton_Backend_IFolder
      */
     public static function getFolderBackend()
@@ -245,10 +244,10 @@
         if (!self::isRegistered(self::FOLDERBACKEND)) {
             self::set(self::FOLDERBACKEND, new Syncroton_Backend_Folder(self::getDatabase()));
         }
-
+        
         return self::get(self::FOLDERBACKEND);
     }
-
+    
     /**
      * Return maximum ping interval (HeartbeatInterval) value (in seconds)
      *
@@ -262,7 +261,7 @@
 
         return self::get(self::PING_INTERVAL);
     }
-
+    
     /**
     /**
      * Return maximum ping interval (HeartbeatInterval) value (in seconds)
@@ -279,10 +278,10 @@
     }
 
     /**
-     * return ping timeout
-     *
-     * sleep "ping timeout" seconds between folder checks in Ping and Sync command
-     *
+     * return ping timeout 
+     * 
+     * sleep "ping timeout" seconds between folder checks in Ping and Sync command 
+     * 
      * @return int
      */
     public static function getPingTimeout()
@@ -290,10 +289,10 @@
         if (!self::isRegistered(self::PING_TIMEOUT)) {
             return 60;
         }
-
+        
         return self::get(self::PING_TIMEOUT);
     }
-
+    
     /**
      * Return maximum number of collections in Sync/Ping request
      *
@@ -306,26 +305,26 @@
 
     /**
      * returns policy backend
-     *
+     * 
      * creates Syncroton_Backend_Policy on the fly if not set before via
      * Syncroton_Registry::set(self::POLICYBACKEND, $backend);
-     *
-     * @return Syncroton_Backend_Policy
+     * 
+     * @return Syncroton_Backend_ISyncState
      */
     public static function getPolicyBackend()
     {
         if (!self::isRegistered(self::POLICYBACKEND)) {
             self::set(self::POLICYBACKEND, new Syncroton_Backend_Policy(self::getDatabase()));
         }
-
+        
         return self::get(self::POLICYBACKEND);
     }
 
     /**
-     * return quiet time
-     *
-     * don't check folders if last sync was "quiet time" seconds ago
-     *
+     * return quiet time 
+     * 
+     * don't check folders if last sync was "quiet time" seconds ago 
+     * 
      * @return int
      */
     public static function getQuietTime()
@@ -333,10 +332,10 @@
         if (!self::isRegistered(self::QUIET_TIME)) {
             return 180;
         }
-
+        
         return self::get(self::QUIET_TIME);
     }
-
+    
     /**
      * Returns sleep callback function
      *
@@ -350,7 +349,7 @@
     public static function getSleepCallback()
     {
         if (!self::isRegistered(self::SLEEP_CALLBACK)) {
-            self::set(self::SLEEP_CALLBACK, function () {});
+            self::set(self::SLEEP_CALLBACK, function() {});
         }
 
         return self::get(self::SLEEP_CALLBACK);
@@ -368,7 +367,7 @@
     public static function getWakeupCallback()
     {
         if (!self::isRegistered(self::WAKEUP_CALLBACK)) {
-            self::set(self::WAKEUP_CALLBACK, function () {});
+            self::set(self::WAKEUP_CALLBACK, function() {});
         }
 
         return self::get(self::WAKEUP_CALLBACK);
@@ -385,7 +384,7 @@
     public static function getSessionValidator()
     {
         if (!self::isRegistered(self::SESSION_VALIDATOR)) {
-            self::set(self::SESSION_VALIDATOR, function () {
+            self::set(self::SESSION_VALIDATOR, function() {
                 return true;
             });
         }
@@ -395,10 +394,10 @@
 
     /**
      * returns syncstate backend
-     *
+     * 
      * creates Syncroton_Backend_SyncState on the fly if not before via
      * Syncroton_Registry::set(self::SYNCSTATEBACKEND, $backend);
-     *
+     * 
      * @return Syncroton_Backend_ISyncState
      */
     public static function getSyncStateBackend()
@@ -406,7 +405,7 @@
         if (!self::isRegistered(self::SYNCSTATEBACKEND)) {
             self::set(self::SYNCSTATEBACKEND, new Syncroton_Backend_SyncState(self::getDatabase()));
         }
-
+        
         return self::get(self::SYNCSTATEBACKEND);
     }
 
@@ -432,34 +431,34 @@
     {
         self::set(self::DATABASE, $db);
     }
-
+    
     public static function setCalendarDataClass($className)
     {
         if (!class_exists($className)) {
             throw new InvalidArgumentException('invalid $_className provided');
         }
-
+    
         self::set(self::CALENDAR_DATA_CLASS, $className);
     }
-
+    
     public static function setContactsDataClass($className)
     {
         if (!class_exists($className)) {
             throw new InvalidArgumentException('invalid $_className provided');
         }
-
+    
         self::set(self::CONTACTS_DATA_CLASS, $className);
     }
-
+    
     public static function setEmailDataClass($className)
     {
         if (!class_exists($className)) {
             throw new InvalidArgumentException('invalid $_className provided');
         }
-
+    
         self::set(self::EMAIL_DATA_CLASS, $className);
     }
-
+    
     public static function setNotesDataClass($className)
     {
         if (!class_exists($className)) {
@@ -474,7 +473,7 @@
         if (!class_exists($className)) {
             throw new InvalidArgumentException('invalid $_className provided');
         }
-
+    
         self::set(self::TASKS_DATA_CLASS, $className);
     }
 
@@ -491,7 +490,7 @@
     {
         self::set(self::TRANSACTIONMANAGER, $manager);
     }
-
+    
     /**
      * Returns TRUE if the $index is a named value in the registry,
      * or FALSE if $index was not found in the registry.
@@ -514,7 +513,7 @@
      * @param array $array data array
      * @param integer $flags ArrayObject flags
      */
-    public function __construct($array = , $flags = parent::ARRAY_AS_PROPS)
+    public function __construct($array = array(), $flags = parent::ARRAY_AS_PROPS)
     {
         parent::__construct($array, $flags);
     }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Server.php Changed

@@ -10,126 +10,113 @@
 
 /**
  * class to handle incoming http ActiveSync requests
- *
+ * 
  * @package     Syncroton
  */
 class Syncroton_Server
 {
-    public const PARAMETER_ATTACHMENTNAME = 0;
-    public const PARAMETER_COLLECTIONID   = 1;
-    public const PARAMETER_ITEMID         = 3;
-    public const PARAMETER_OPTIONS        = 7;
-    public const MAX_HEARTBEAT_INTERVAL   = 3540; // 59 minutes
-
+    const PARAMETER_ATTACHMENTNAME = 0;
+    const PARAMETER_COLLECTIONID   = 1;
+    const PARAMETER_ITEMID         = 3;
+    const PARAMETER_OPTIONS        = 7;
+    const MAX_HEARTBEAT_INTERVAL   = 3540; // 59 minutes
+    
     protected $_body;
-
+    
     /**
      * informations about the currently device
      *
      * @var Syncroton_Backend_IDevice
      */
     protected $_deviceBackend;
-
+    
     /**
      * @var Zend_Log
      */
     protected $_logger;
-
+    
     /**
      * @var Zend_Controller_Request_Http
      */
     protected $_request;
-
+    
     protected $_userId;
-
+    
     public function __construct($userId, Zend_Controller_Request_Http $request = null, $body = null)
     {
         if (Syncroton_Registry::isRegistered('loggerBackend')) {
             $this->_logger = Syncroton_Registry::get('loggerBackend');
         }
-
+        
         $this->_userId  = $userId;
         $this->_request = $request instanceof Zend_Controller_Request_Http ? $request : new Zend_Controller_Request_Http();
         $this->_body    = $body !== null ? $body : fopen('php://input', 'r');
-
-        // Not available on unauthenticated OPTIONS request
-        if (!empty($this->_userId)) {
-            $this->_deviceBackend = Syncroton_Registry::getDeviceBackend();
-        }
-
+        
+        $this->_deviceBackend = Syncroton_Registry::getDeviceBackend();
+        
     }
-
+        
     public function handle()
     {
-        if ($this->_logger instanceof Zend_Log) {
+        if ($this->_logger instanceof Zend_Log)
             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . ' REQUEST METHOD: ' . $this->_request->getMethod());
-        }
-
-        if ($this->_request->getMethod() != "OPTIONS" && empty($this->_userId)) {
-            $this->_logger->warn(__METHOD__ . '::' . __LINE__ . ' Not authenticated');
-            header('WWW-Authenticate: Basic realm="ActiveSync for Kolab"');
-            header('HTTP/1.1 401 Unauthorized');
-            exit;
-        }
-
+        
         switch($this->_request->getMethod()) {
             case 'OPTIONS':
                 $this->_handleOptions();
                 break;
-
+        
             case 'POST':
                 $this->_handlePost();
                 break;
-
+        
             case 'GET':
                 echo "It works!<br>Your userid is: {$this->_userId} and your IP address is: {$_SERVER'REMOTE_ADDR'}.";
                 break;
         }
     }
-
+    
     /**
      * handle options request
      */
     protected function _handleOptions()
     {
         $command = new Syncroton_Command_Options();
-
+    
         $this->_sendHeaders($command->getHeaders());
     }
-
+    
     protected function _sendHeaders(array $headers)
     {
         foreach ($headers as $name => $value) {
             header($name . ': ' . $value);
         }
-    }
-
+    } 
+    
     /**
      * handle post request
      */
     protected function _handlePost()
     {
         $requestParameters = $this->_getRequestParameters($this->_request);
-
-        if ($this->_logger instanceof Zend_Log) {
+        
+        if ($this->_logger instanceof Zend_Log) 
             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . ' REQUEST ' . print_r($requestParameters, true));
-        }
-
+        
         $className = 'Syncroton_Command_' . $requestParameters'command';
-
+        
         if (!class_exists($className)) {
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log)
                 $this->_logger->notice(__METHOD__ . '::' . __LINE__ . " command not supported: " . $requestParameters'command');
-            }
-
+            
             header("HTTP/1.1 501 not implemented");
-
+            
             return;
         }
-
+        
         // get user device
         $device = $this->_getUserDevice($this->_userId, $requestParameters);
-
+        
         if ($requestParameters'contentType' == 'application/vnd.ms-sync.wbxml' || $requestParameters'contentType' == 'application/vnd.ms-sync') {
             // decode wbxml request
             try {
@@ -139,117 +126,112 @@
                     $this->_logDomDocument($requestBody, 'request', __METHOD__, __LINE__);
                 }
             } catch(Syncroton_Wbxml_Exception_UnexpectedEndOfFile $e) {
-                if ($this->_logger instanceof Zend_Log) {
+                if ($this->_logger instanceof Zend_Log)
                     $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " unexpected end of file.");
-                }
-                $requestBody = null;
+                $requestBody = NULL;
             }
         } else {
             $requestBody = $this->_body;
         }
-
+        
         header("MS-Server-ActiveSync: 14.00.0536.000");
 
         // avoid sending HTTP header "Content-Type: text/html" for empty sync responses
         ini_set('default_mimetype', 'application/vnd.ms-sync.wbxml');
-
+        
         try {
             $command = new $className($requestBody, $device, $requestParameters);
-
+        
             $response = $command->handle();
 
             if (!$response) {
                 $response = $command->getResponse();
             }
         } catch (Syncroton_Exception_ProvisioningNeeded $sepn) {
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log) 
                 $this->_logger->info(__METHOD__ . '::' . __LINE__ . " provisioning needed");
-            }
-
+            
             header("HTTP/1.1 449 Retry after sending a PROVISION command");
-
+            
             if (version_compare($device->acsversion, '14.0', '>=')) {
                 $response = $sepn->domDocument;
             } else {
                 // pre 14.0 method
                 return;
             }
-
+            
         } catch (Exception $e) {
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log)
                 $this->_logger->err(__METHOD__ . '::' . __LINE__ . " unexpected exception occured: " . get_class($e));
-            }
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log)
                 $this->_logger->err(__METHOD__ . '::' . __LINE__ . " exception message: " . $e->getMessage());
-            }
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log)
                 $this->_logger->err(__METHOD__ . '::' . __LINE__ . " " . $e->getTraceAsString());
-            }
-
+            
             header("HTTP/1.1 500 Internal server error");
-
+            
             return;
         }
-
+        
         if ($response instanceof DOMDocument) {
             if ($this->_logger instanceof Zend_Log) {
                 $this->_logDomDocument($response, 'response', __METHOD__, __LINE__);
             }
-
+            
             if (isset($command) && $command instanceof Syncroton_Command_ICommand) {
                 $this->_sendHeaders($command->getHeaders());
             }
-
+            
             $outputStream = fopen("php://temp", 'r+');
-
+            
             $encoder = new Syncroton_Wbxml_Encoder($outputStream, 'UTF-8', 3);
-
+            
             try {
-                $encoder->encode($response);
+                 $encoder->encode($response);
             } catch (Syncroton_Wbxml_Exception $swe) {
                 if ($this->_logger instanceof Zend_Log) {
                     $this->_logger->err(__METHOD__ . '::' . __LINE__ . " Could not encode output: " . $swe);
                 }
-
+                
                 header("HTTP/1.1 500 Internal server error");
-
+                
                 return;
             }
-
-            if ($requestParameters'acceptMultipart' == true && isset($command)) {
+            
+            if ($requestParameters'acceptMultipart' == true) {
                 $parts = $command->getParts();
-
+                
                 // output multipartheader
                 $bodyPartCount = 1 + count($parts);
-
+                
                 // number of parts (4 bytes)
                 $header  = pack('i', $bodyPartCount);
-
+                
                 $partOffset = 4 + (($bodyPartCount * 2) * 4);
-
+                
                 // wbxml body start and length
                 $streamStat = fstat($outputStream);
                 $header .= pack('ii', $partOffset, $streamStat'size');
-
+                
                 $partOffset += $streamStat'size';
-
+                
                 // calculate start and length of parts
                 foreach ($parts as $partId => $partStream) {
                     rewind($partStream);
                     $streamStat = fstat($partStream);
-
+                    
                     // part start and length
                     $header .= pack('ii', $partOffset, $streamStat'size');
                     $partOffset += $streamStat'size';
                 }
-
+                
                 echo $header;
             }
-
+            
             // output body
             rewind($outputStream);
             fpassthru($outputStream);
-
+            
             // output multiparts
             if (isset($parts)) {
                 foreach ($parts as $partStream) {
@@ -259,10 +241,10 @@
             }
         }
     }
-
+    
     /**
      * write (possible big) DOMDocument in smaller chunks to log file
-     *
+     * 
      * @param DOMDocument $dom
      * @param string      $action
      * @param string      $method
@@ -278,11 +260,11 @@
 
         $meta_data = stream_get_meta_data($tempStream);
         $filename = $meta_data"uri";
-
+        
         $dom->formatOutput = true;
         $dom->save($filename);
         $dom->formatOutput = false;
-
+        
         rewind($tempStream);
 
         $loops = 0;
@@ -290,19 +272,19 @@
             $this->_logger->debug("{$method}::{$line} xml {$action} ({$loops}):\n" . fread($tempStream, 1048576));
             $loops++;
         }
-
+        
         fclose($tempStream);
     }
-
+    
     /**
      * return request params
-     *
+     * 
      * @return array
      */
     protected function _getRequestParameters(Zend_Controller_Request_Http $request)
     {
         if (strpos($request->getRequestUri(), '&') === false) {
-            $commands = 
+            $commands = array(
                 0  => 'Sync',
                 1  => 'SendMail',
                 2  => 'SmartForward',
@@ -321,9 +303,9 @@
                 19 => 'ItemOperations',
                 20 => 'Provision',
                 21 => 'ResolveRecipients',
-                22 => 'ValidateCert',
-            ;
-
+                22 => 'ValidateCert'
+            );
+            
             $requestParameters = substr($request->getRequestUri(), strpos($request->getRequestUri(), '?'));
 
             $stream = fopen("php://temp", 'r+');
@@ -332,36 +314,35 @@
 
             // unpack the first 4 bytes
             $unpacked = unpack('CprotocolVersion/Ccommand/vlocale', fread($stream, 4));
-
+            
             // 140 => 14.0
             $protocolVersion = substr($unpacked'protocolVersion', 0, -1) . '.' . substr($unpacked'protocolVersion', -1);
             $command = $commands$unpacked'command';
             $locale = $unpacked'locale';
-            $deviceId = null;
-
+            
             // unpack deviceId
             $length = ord(fread($stream, 1));
             if ($length > 0) {
                 $toUnpack = fread($stream, $length);
-
+                
                 $unpacked = unpack("H" . ($length * 2) . "string", $toUnpack);
                 $deviceId = $unpacked'string';
             }
-
+            
             // unpack policyKey
             $length = ord(fread($stream, 1));
             if ($length > 0) {
                 $unpacked  = unpack('Vstring', fread($stream, $length));
                 $policyKey = $unpacked'string';
             }
-
+            
             // unpack device type
             $length = ord(fread($stream, 1));
             if ($length > 0) {
                 $unpacked   = unpack('A' . $length . 'string', fread($stream, $length));
                 $deviceType = $unpacked'string';
             }
-
+            
             while (! feof($stream)) {
                 $tag    = ord(fread($stream, 1));
                 $length = ord(fread($stream, 1));
@@ -374,51 +355,50 @@
                 switch ($tag) {
                     case self::PARAMETER_ATTACHMENTNAME:
                         $unpacked = unpack('A' . $length . 'string', fread($stream, $length));
-
+                        
                         $attachmentName = $unpacked'string';
                         break;
-
+                        
                     case self::PARAMETER_COLLECTIONID:
                         $unpacked = unpack('A' . $length . 'string', fread($stream, $length));
-
+                        
                         $collectionId = $unpacked'string';
                         break;
-
+                        
                     case self::PARAMETER_ITEMID:
                         $unpacked = unpack('A' . $length . 'string', fread($stream, $length));
-
+                        
                         $itemId = $unpacked'string';
                         break;
-
+                        
                     case self::PARAMETER_OPTIONS:
                         $options = ord(fread($stream, 1));
-
-                        $saveInSent      = !!($options & 0x01);
+                        
+                        $saveInSent      = !!($options & 0x01); 
                         $acceptMultiPart = !!($options & 0x02);
                         break;
-
+                        
                     default:
-                        if ($this->_logger instanceof Zend_Log) {
+                        if ($this->_logger instanceof Zend_Log)
                             $this->_logger->crit(__METHOD__ . '::' . __LINE__ . " found unhandled command parameters");
-                        }
-
+                        
                 }
             }
-
-            $result = 
+             
+            $result = array(
                 'protocolVersion' => $protocolVersion,
                 'command'         => $command,
                 'deviceId'        => $deviceId,
-                'deviceType'      => $deviceType ?? null,
-                'policyKey'       => $policyKey ?? null,
-                'saveInSent'      => $saveInSent ?? false,
-                'collectionId'    => $collectionId ?? null,
-                'itemId'          => $itemId ?? null,
-                'attachmentName'  => $attachmentName ?? null,
-                'acceptMultipart' => $acceptMultiPart ?? false,
-            ;
+                'deviceType'      => isset($deviceType)      ? $deviceType      : null,
+                'policyKey'       => isset($policyKey)       ? $policyKey       : null,
+                'saveInSent'      => isset($saveInSent)      ? $saveInSent      : false,
+                'collectionId'    => isset($collectionId)    ? $collectionId    : null,
+                'itemId'          => isset($itemId)          ? $itemId          : null,
+                'attachmentName'  => isset($attachmentName)  ? $attachmentName  : null,
+                'acceptMultipart' => isset($acceptMultiPart) ? $acceptMultiPart : false
+            );
         } else {
-            $result = 
+            $result = array(
                 'protocolVersion' => $request->getServer('HTTP_MS_ASPROTOCOLVERSION'),
                 'command'         => $request->getQuery('Cmd'),
                 'deviceId'        => $request->getQuery('DeviceId'),
@@ -428,49 +408,48 @@
                 'collectionId'    => $request->getQuery('CollectionId'),
                 'itemId'          => $request->getQuery('ItemId'),
                 'attachmentName'  => $request->getQuery('AttachmentName'),
-                'acceptMultipart' => $request->getServer('HTTP_MS_ASACCEPTMULTIPART') == 'T',
-            ;
+                'acceptMultipart' => $request->getServer('HTTP_MS_ASACCEPTMULTIPART') == 'T'
+            );
         }
-
+        
         $result'userAgent'   = $request->getServer('HTTP_USER_AGENT', $result'deviceType');
         $result'contentType' = $request->getServer('CONTENT_TYPE');
-
+        
         return $result;
     }
-
+    
     /**
      * get existing device of owner or create new device for owner
      *
      * @param string $ownerId
      * @param array  $requestParameters
      *
-     * @return Syncroton_Model_IDevice
+     * @return Syncroton_Model_Device
      */
     protected function _getUserDevice($ownerId, $requestParameters)
     {
         try {
             $device = $this->_deviceBackend->getUserDevice($ownerId, $requestParameters'deviceId');
-
+        
             $device->useragent  = $requestParameters'userAgent';
             $device->acsversion = $requestParameters'protocolVersion';
             $device->devicetype = $requestParameters'deviceType';
-
+            
             if ($device->isDirty()) {
                 $device = $this->_deviceBackend->update($device);
             }
-
+        
         } catch (Syncroton_Exception_NotFound $senf) {
-            $device = $this->_deviceBackend->create(new Syncroton_Model_Device(
+            $device = $this->_deviceBackend->create(new Syncroton_Model_Device(array(
                 'owner_id'   => $ownerId,
                 'deviceid'   => $requestParameters'deviceId',
                 'devicetype' => $requestParameters'deviceType',
                 'useragent'  => $requestParameters'userAgent',
                 'acsversion' => $requestParameters'protocolVersion',
-                'policyId'   => Syncroton_Registry::isRegistered(Syncroton_Registry::DEFAULT_POLICY) ? Syncroton_Registry::get(Syncroton_Registry::DEFAULT_POLICY) : null,
-            ));
+                'policyId'   => Syncroton_Registry::isRegistered(Syncroton_Registry::DEFAULT_POLICY) ? Syncroton_Registry::get(Syncroton_Registry::DEFAULT_POLICY) : null
+            )));
         }
 
-        /** @var Syncroton_Model_Device $device */
         return $device;
     }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/TransactionManager.php Changed

@@ -1,7 +1,7 @@
 <?php
 /**
  * Syncroton
- *
+ * 
  * @package     Syncroton
  * @license     http://www.tine20.org/licenses/lgpl.html LGPL Version 3
  * @copyright   Copyright (c) 2008-2012 Metaways Infosystems GmbH (http://www.metaways.de)
@@ -10,17 +10,17 @@
 
 /**
  * Transaction Manger for Syncroton
- *
+ * 
  * This is the central class, all transactions within Syncroton must be handled with.
- * For each supported transactionable (backend) this class start a real transaction on
+ * For each supported transactionable (backend) this class start a real transaction on 
  * the first startTransaction request.
- *
+ * 
  * Transactions of all transactionable will be commited at once when all requested transactions
  * are being commited using this class.
- *
+ * 
  * Transactions of all transactionable will be roll back when one rollBack is requested
  * using this class.
- *
+ * 
  * @package     Syncroton
  */
 class Syncroton_TransactionManager implements Syncroton_TransactionManagerInterface
@@ -28,30 +28,30 @@
     /**
      * @var array holds all transactionables with open transactions
      */
-    protected $_openTransactionables = ;
-
+    protected $_openTransactionables = array();
+    
     /**
      * @var array list of all open (not commited) transactions
      */
-    protected $_openTransactions = ;
+    protected $_openTransactions = array();
     /**
-     * @var ?Syncroton_TransactionManager
+     * @var Syncroton_TransactionManager
      */
-    private static $_instance = null;
-
+    private static $_instance = NULL;
+    
     /**
      * @var Zend_Log
      */
     protected $_logger;
-
+    
     /**
      * don't clone. Use the singleton.
      */
     private function __clone()
     {
-
+        
     }
-
+    
     /**
      * constructor
      */
@@ -61,37 +61,35 @@
             $this->_logger = Syncroton_Registry::get('loggerBackend');
         }
     }
-
+    
     /**
-     * @return Syncroton_TransactionManager
+     * @return Tinebase_TransactionManager
      */
-    public static function getInstance()
+    public static function getInstance() 
     {
-        if (self::$_instance === null) {
-            self::$_instance = new Syncroton_TransactionManager();
+        if (self::$_instance === NULL) {
+            self::$_instance = new Syncroton_TransactionManager;
         }
-
+        
         return self::$_instance;
     }
-
+    
     /**
      * starts a transaction
      *
      * @param   mixed $_transactionable
      * @return  string transactionId
-     * @throws  Exception
+     * @throws  Tinebase_Exception_UnexpectedValue
      */
     public function startTransaction($_transactionable)
     {
-        if ($this->_logger instanceof Zend_Log) {
+        if ($this->_logger instanceof Zend_Log) 
             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . "  startTransaction request");
-        }
-
+        
         if (! in_array($_transactionable, $this->_openTransactionables)) {
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log) 
                 $this->_logger->debug(__METHOD__ . '::' . __LINE__ . "  new transactionable. Starting transaction on this resource");
-            }
-
+            
             if ($_transactionable instanceof Zend_Db_Adapter_Abstract) {
                 #Tinebase_Backend_Sql_Command::setAutocommit($_transactionable,false);
                 $_transactionable->beginTransaction();
@@ -99,20 +97,19 @@
                 $this->rollBack();
                 throw new Syncroton_Exception_UnexpectedValue('Unsupported transactionable!');
             }
-
+            
             array_push($this->_openTransactionables, $_transactionable);
         }
-
-        $transactionId = sha1(mt_rand() . microtime());
+        
+        $transactionId = sha1(mt_rand(). microtime());
         array_push($this->_openTransactions, $transactionId);
-
-        if ($this->_logger instanceof Zend_Log) {
+        
+        if ($this->_logger instanceof Zend_Log) 
             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . "  queued transaction with id $transactionId");
-        }
-
+        
         return $transactionId;
     }
-
+    
     /**
      * commits a transaction
      *
@@ -121,55 +118,51 @@
      */
     public function commitTransaction($_transactionId)
     {
-        if ($this->_logger instanceof Zend_Log) {
+        if ($this->_logger instanceof Zend_Log) 
             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . "  commitTransaction request for $_transactionId");
-        }
-
+        
         $transactionIdx = array_search($_transactionId, $this->_openTransactions);
         if ($transactionIdx !== false) {
             unset($this->_openTransactions$transactionIdx);
         }
-
+        
         $numOpenTransactions = count($this->_openTransactions);
-
+        
         if ($numOpenTransactions === 0) {
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log) 
                 $this->_logger->debug(__METHOD__ . '::' . __LINE__ . "  no more open transactions in queue commiting all transactionables");
-            }
             foreach ($this->_openTransactionables as $transactionableIdx => $transactionable) {
                 if ($transactionable instanceof Zend_Db_Adapter_Abstract) {
                     $transactionable->commit();
                     #Tinebase_Backend_Sql_Command::setAutocommit($transactionable,true);
                 }
             }
-            $this->_openTransactionables = ;
-            $this->_openTransactions = ;
+            $this->_openTransactionables = array();
+            $this->_openTransactions = array();
         } else {
-            if ($this->_logger instanceof Zend_Log) {
+            if ($this->_logger instanceof Zend_Log) 
                 $this->_logger->debug(__METHOD__ . '::' . __LINE__ . "  commiting defered, as there are still $numOpenTransactions in the queue");
-            }
         }
     }
-
+    
     /**
      * perform rollBack on all transactionables with open transactions
-     *
+     * 
      * @return void
      */
     public function rollBack()
     {
-        if ($this->_logger instanceof Zend_Log) {
+        if ($this->_logger instanceof Zend_Log) 
             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . "  rollBack request, rollBack all transactionables");
-        }
-
+        
         foreach ($this->_openTransactionables as $transactionable) {
             if ($transactionable instanceof Zend_Db_Adapter_Abstract) {
                 $transactionable->rollBack();
                 #Tinebase_Backend_Sql_Command::setAutocommit($transactionable,true);
             }
         }
-
-        $this->_openTransactionables = ;
-        $this->_openTransactions = ;
+        
+        $this->_openTransactionables = array();
+        $this->_openTransactions = array();
     }
 }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/TransactionManagerInterface.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Abstract.php Changed

@@ -16,7 +16,7 @@
  * @package     Wbxml
  * @subpackage  Wbxml
  */
-
+ 
 abstract class Syncroton_Wbxml_Abstract
 {
     /**
@@ -25,83 +25,83 @@
      * @var resource
      */
     protected $_stream;
-
+    
     /**
      * the wbxml version
      *
-     * @var int
+     * @var string
      */
     protected $_version;
-
+    
     /**
-     * the Document Public Identifier
+     * the Document Public Identifier 
      *
      * @var string
      */
     protected $_dpi;
-
+    
     /**
      * the current active dtd
      *
-     * @var Syncroton_Wbxml_Dtd_ActiveSync
+     * @var Syncroton_Wbxml_Dtd_Syncml_Abstract
      */
     protected $_dtd;
-
+    
     /**
      * the charSet used in the wbxml file
      *
      * @var string
      */
     protected $_charSet;
-
+    
     /**
      * currently active code page
      *
-     * @var Syncroton_Wbxml_Dtd_ActiveSync_Abstract
+     * @var array
      */
     protected $_codePage;
-
+    
     /**
      * see section 5.5
      *
      */
-    public const DPI_WELLKNOWN = 'WELLKNOWN';
-
+    const DPI_WELLKNOWN = 'WELLKNOWN';
+    
     /**
      * see section 5.5
      *
      */
-    public const DPI_STRINGTABLE = 'STRINGTABLE';
-
-    public const SWITCH_PAGE   = 0x00;
-    public const END           = 0x01;
-    public const ENTITY        = 0x02;
-    public const STR_I         = 0x03;
-    public const LITERAL       = 0x04;
-    public const EXT_I_0       = 0x40;
-    public const EXT_I_1       = 0x41;
-    public const EXT_I_2       = 0x42;
-    public const PI            = 0x43;
-    public const LITERAL_C     = 0x44;
-    public const EXT_T_0       = 0x80;
-    public const EXT_T_1       = 0x81;
-    public const EXT_T_2       = 0x82;
-    public const STR_T         = 0x83;
-    public const LITERAL_A     = 0x84;
-    public const EXT_0         = 0xC0;
-    public const EXT_1         = 0xC1;
-    public const EXT_2         = 0xC2;
-    public const OPAQUE        = 0xC3;
-    public const LITERAL_AC    = 0xC4;
-
+    const DPI_STRINGTABLE = 'STRINGTABLE';
+    
+    const SWITCH_PAGE   = 0x00;
+    const END           = 0x01;
+    const ENTITY        = 0x02;
+    const STR_I         = 0x03;
+    const LITERAL       = 0x04;
+    const EXT_I_0       = 0x40;
+    const EXT_I_1       = 0x41;
+    const EXT_I_2       = 0x42;
+    const PI            = 0x43;
+    const LITERAL_C     = 0x44;
+    const EXT_T_0       = 0x80;
+    const EXT_T_1       = 0x81;
+    const EXT_T_2       = 0x82;
+    const STR_T         = 0x83;
+    const LITERAL_A     = 0x84;
+    const EXT_0         = 0xC0;
+    const EXT_1         = 0xC1;
+    const EXT_2         = 0xC2;
+    const OPAQUE        = 0xC3;
+    const LITERAL_AC    = 0xC4;
+    
     /**
      * the real name for this DPI is "unknown"
      * But Microsoft is using them for their ActiveSync stuff
      * instead defining their own DPI like the sycnml creators did
      *
      */
-    public const DPI_1         = '-//AIRSYNC//DTD AirSync//EN';
-
+    const DPI_1         = '-//AIRSYNC//DTD AirSync//EN';
+    
     /**
      * return wellknown identifiers
      *
@@ -114,12 +114,12 @@
         if(!defined('Syncroton_Wbxml_Abstract::DPI_' . $_uInt)) {
             throw new Syncroton_Wbxml_Exception('unknown wellknown identifier: ' . $_uInt);
         }
-
+        
         $dpi = constant('Syncroton_Wbxml_Abstract::DPI_' . $_uInt);
-
+        
         return $dpi;
     }
-
+    
     /**
      * return multibyte integer
      *
@@ -128,27 +128,27 @@
     protected function _getMultibyteUInt()
     {
         $uInt = 0;
-
+        
         do {
             $byte = $this->_getByte();
             $uInt <<= 7;
             $uInt += ($byte & 127);
         } while (($byte & 128) != 0);
-
+         
         return $uInt;
     }
-
+        
     protected function _getByte()
     {
         $byte = fread($this->_stream, 1);
-
+        
         if($byte === false) {
             throw new Syncroton_Wbxml_Exception("failed reading one byte");
         }
-
+        
         return ord($byte);
     }
-
+    
     protected function _getOpaque($_length)
     {
         $string = '';
@@ -166,7 +166,7 @@
                 $string .= $chunk;
                 $_length -= $len;
             }
-
+            
             if (feof($this->_stream)) {
                 break;
             }
@@ -174,7 +174,7 @@
 
         return $string;
     }
-
+    
     /**
      * get a 0 terminated string
      *
@@ -183,28 +183,28 @@
     protected function _getTerminatedString()
     {
         $string = '';
-
+        
         while (($byte = $this->_getByte()) != 0) {
             $string .= chr($byte);
-        }
-
+        }        
+        
         return $string;
     }
-
+    
     protected function _writeByte($_byte)
     {
         fwrite($this->_stream, chr($_byte));
     }
-
+    
     protected function _writeMultibyteUInt($_integer)
     {
-        $multibyte = null;
+        $multibyte = NULL;
         $remainder = $_integer;
-
+        
         do {
             $byte = ($remainder & 127);
             $remainder >>= 7;
-            if($multibyte === null) {
+            if($multibyte === NULL) {
                 $multibyte = chr($byte);
             } else {
                 $multibyte = chr($byte | 128) . $multibyte;
@@ -213,15 +213,15 @@
 
         fwrite($this->_stream, $multibyte);
     }
-
+    
     protected function _writeString($_string)
     {
         fwrite($this->_stream, $_string);
     }
-
+    
     /**
      * write opaque string to stream
-     *
+     * 
      * @param string|resource $_string
      * @throws Syncroton_Wbxml_Exception
      */
@@ -235,22 +235,22 @@
         }
         $length = ftell($stream);
         rewind($stream);
-
-        $this->_writeByte(Syncroton_Wbxml_Abstract::OPAQUE);
+        
+        $this->_writeByte(Syncroton_Wbxml_Abstract::OPAQUE);
         $this->_writeMultibyteUInt($length);
-        $writenBytes = stream_copy_to_stream($stream, $this->_stream);
-
-        if($writenBytes !== $length) {
-            throw new Syncroton_Wbxml_Exception('blow');
+        $writenBytes = stream_copy_to_stream($stream, $this->_stream);
+        
+        if($writenBytes !== $length) {
+            throw new Syncroton_Wbxml_Exception('blow');
         }
-
+        
         fclose($stream);
     }
-
+    
     protected function _writeTerminatedString($_string)
     {
         $this->_writeByte(Syncroton_Wbxml_Abstract::STR_I);
         fwrite($this->_stream, $_string);
         fwrite($this->_stream, chr(0));
     }
-}
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Decoder.php Changed

@@ -16,30 +16,30 @@
  * @package     Wbxml
  * @subpackage  Wbxml
  */
-
+ 
 class Syncroton_Wbxml_Decoder extends Syncroton_Wbxml_Abstract
 {
     /**
-     * type of Document Public Identifier
+     * type of Document Public Identifier 
      *
      * @var string the type can be Syncroton_Wbxml_Abstract::DPI_STRINGTABLE or Syncroton_Wbxml_Abstract::DPI_WELLKNOWN
      */
     protected $_dpiType;
-
+    
     /**
      * the string table
      *
      * @var array
      */
-    protected $_stringTable = ;
-
+    protected $_stringTable = array();
+    
     /**
      * the xml document
      *
      * @var DOMDocument
      */
     protected $_dom;
-
+    
     /**
      * the main name space / aka the namespace of first tag
      *
@@ -52,39 +52,39 @@
      *
      * @param resource $_stream
      */
-    public function __construct($_stream, $_dpi = null)
+    public function __construct($_stream, $_dpi = NULL)
     {
         if(!is_resource($_stream) || get_resource_type($_stream) != 'stream') {
             throw new Syncroton_Wbxml_Exception('$_stream must be a stream');
         }
-        if($_dpi !== null) {
+        if($_dpi !== NULL) {
             $this->_dpi = $_dpi;
         }
-
+        
         $this->_stream = $_stream;
-
+        
         $this->_version = $this->_getByte();
-
+        
         if(feof($this->_stream)) {
             throw new Syncroton_Wbxml_Exception_UnexpectedEndOfFile();
         }
-
+        
         $this->_getDPI();
-
+        
         $this->_getCharset();
-
+        
         $this->_getStringTable();
-
+        
         // resolve DPI as we have read the stringtable now
         // this->_dpi contains the string table index
         if($this->_dpiType === Syncroton_Wbxml_Abstract::DPI_STRINGTABLE) {
             $this->_dpi = $this->_stringTable$this->_dpi;
         }
-
+        
         #$this->_dtd = Syncroton_Wbxml_Dtd_Factory::factory($this->_dpi);
         $this->_dtd = Syncroton_Wbxml_Dtd_Factory::factory(Syncroton_Wbxml_Dtd_Factory::ACTIVESYNC);
     }
-
+    
     /**
      * return the Document Public Identifier
      *
@@ -95,37 +95,37 @@
     {
         return $this->_dpi;
     }
-
+    
     /**
      * return the wbxml version
      *
-     * @return int
+     * @return string
      */
     public function getVersion()
     {
         return $this->_version;
     }
-
+    
     /**
-     * decodes the tags
+     * decodes the tags 
      *
      * @return DOMDocument the decoded xml
      */
     public function decode()
     {
-        $openTags = null;
-        $node = null;
+        $openTags = NULL;
+        $node = NULL;
         $this->_codePage = $this->_dtd->getCurrentCodePage();
-
+        
         while (!feof($this->_stream)) {
             $byte = $this->_getByte();
-
+            
             switch($byte) {
                 case Syncroton_Wbxml_Abstract::END:
                     $node = $node->parentNode;
                     $openTags--;
                     break;
-
+                    
                 case Syncroton_Wbxml_Abstract::OPAQUE:
                     $length = $this->_getMultibyteUInt();
                     if($length > 0) {
@@ -133,14 +133,14 @@
                         try {
                             // let see if we can decode it. maybe the opaque data is wbxml encoded content
                             $opaqueDataStream = fopen("php://temp", 'r+');
-                            fwrite($opaqueDataStream, $opaque);
+                            fputs($opaqueDataStream, $opaque);
                             rewind($opaqueDataStream);
-
+                            
                             $opaqueContentDecoder = new Syncroton_Wbxml_Decoder($opaqueDataStream);
                             $dom = $opaqueContentDecoder->decode();
-
+                            
                             fclose($opaqueDataStream);
-
+                            
                             foreach($dom->childNodes as $newNode) {
                                 if($newNode instanceof DOMElement) {
                                     $newNode = $this->_dom->importNode($newNode, true);
@@ -149,22 +149,22 @@
                             }
                         } catch (Exception $e) {
                             // if not, just treat it as a string
-                            $node->appendChild($this->_dom->createTextNode($opaque));
+                            $node->appendChild($this->_dom->createTextNode($opaque)); 
                         }
                     }
                     break;
-
+                    
                 case Syncroton_Wbxml_Abstract::STR_I:
                     $string = $this->_getTerminatedString();
-                    $node->appendChild($this->_dom->createTextNode($string));
+                    $node->appendChild($this->_dom->createTextNode($string)); 
                     break;
-
+                    
                 case Syncroton_Wbxml_Abstract::SWITCH_PAGE:
                     $page = $this->_getByte();
                     $this->_codePage = $this->_dtd->switchCodePage($page);
                     #echo "switched to codepage $page\n";
                     break;
-
+                    
                 default:
                     $tagHasAttributes   = (($byte & 0x80) != 0);
                     $tagHasContent      = (($byte & 0x40) != 0);
@@ -179,10 +179,10 @@
                     }
                     $nameSpace    = $this->_codePage->getNameSpace();
                     $codePageName = $this->_codePage->getCodePageName();
-
+                    
                     #echo "Tag: $nameSpace:$tag\n";
-
-                    if ($node === null) {
+                    
+                    if ($node === NULL) {
                         // create the domdocument
                         $node    = $this->_createDomDocument($nameSpace, $tag);
                         $newNode = $node->documentElement;
@@ -192,23 +192,23 @@
                         }
                         $newNode = $node->appendChild($this->_dom->createElementNS('uri:' . $codePageName, $tag));
                     }
-
+                    
                     if ($tagHasAttributes) {
                         $attributes = $this->_getAttributes();
                     }
-
+                    
                     if ($tagHasContent == true) {
                         $node = $newNode;
                         $openTags++;
                     }
-
+                    
                     break;
             }
         }
 
         return $this->_dom;
     }
-
+    
     /**
      * creates the root of the xml document
      *
@@ -217,7 +217,7 @@
     protected function _createDomDocument($_nameSpace, $_tag)
     {
         $this->_dom = $this->_dtd->getDomDocument($_nameSpace, $_tag);
-
+        
         return $this->_dom;
     }
 
@@ -239,7 +239,7 @@
     protected function _getDPI()
     {
         $uInt = $this->_getMultibyteUInt();
-
+        
         if($uInt == 0) {
             // get identifier from stringtable
             $this->_dpiType = Syncroton_Wbxml_Abstract::DPI_STRINGTABLE;
@@ -251,25 +251,27 @@
             $this->_dpi = Syncroton_Wbxml_Abstract::getDPI($uInt);
         }
     }
-
+    
     /**
      * see http://www.iana.org/assignments/character-sets (MIBenum)
      * 106: UTF-8
+     *
      */
     protected function _getCharset()
     {
         $uInt = $this->_getMultibyteUInt();
-
+        
         switch($uInt) {
             case 106:
                 $this->_charSet = 'UTF-8';
                 break;
-
+                
             default:
                 throw new Syncroton_Wbxml_Exception('unsuported charSet: ' . $uInt);
+                break;
         }
     }
-
+    
     /**
      * get string table and store strings indexed by start
      *
@@ -278,27 +280,27 @@
     protected function _getStringTable()
     {
         $length = $this->_getMultibyteUInt();
-
+        
         if($length > 0) {
             $rawStringTable = $this->_getOpaque($length);
-            $index = null;
-            $string = null;
-
+            $index = NULL;
+            $string = NULL;
+            
             for($i = 0; $i < strlen($rawStringTable); $i++) {
-                if($index === null) {
+                if($index === NULL) {
                     $index = $i;
                 }
                 if(ord($rawStringTable$i) != 0) {
                     $string .= $rawStringTable$i;
                 }
-
+                
                 // either the string has ended or we reached a \0
-                if($i + 1 == strlen($rawStringTable) || ord($rawStringTable$i) == 0) {
+                if($i+1 == strlen($rawStringTable) || ord($rawStringTable$i) == 0){
                     $this->_stringTable$index = $string;
-                    $index = null;
-                    $string = null;
+                    $index = NULL;
+                    $string = NULL;
                 }
             }
         }
-    }
-}
+    }    
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync.php Changed

@@ -19,39 +19,39 @@
 
 class Syncroton_Wbxml_Dtd_ActiveSync
 {
-    public const CODEPAGE_AIRSYNC           = 0;
-    public const CODEPAGE_CONTACTS          = 1;
-    public const CODEPAGE_EMAIL             = 2;
-    public const CODEPAGE_AIRNOTIFY         = 3;
-    public const CODEPAGE_CALENDAR          = 4;
-    public const CODEPAGE_MOVE              = 5;
-    public const CODEPAGE_ITEMESTIMATE      = 6;
-    public const CODEPAGE_FOLDERHIERARCHY   = 7;
-    public const CODEPAGE_MEETINGRESPONSE   = 8;
-    public const CODEPAGE_TASKS             = 9;
-    public const CODEPAGE_RESOLVERECIPIENTS = 10;
-    public const CODEPAGE_VALIDATECERT      = 11;
-    public const CODEPAGE_CONTACTS2         = 12;
-    public const CODEPAGE_PING              = 13;
-    public const CODEPAGE_PROVISION         = 14;
-    public const CODEPAGE_SEARCH            = 15;
-    public const CODEPAGE_GAL               = 16;
-    public const CODEPAGE_AIRSYNCBASE       = 17;
-    public const CODEPAGE_SETTINGS          = 18;
-    public const CODEPAGE_DOCUMENTLIBRARY   = 19;
-    public const CODEPAGE_ITEMOPERATIONS    = 20;
-    public const CODEPAGE_COMPOSEMAIL       = 21;
-    public const CODEPAGE_EMAIL2            = 22;
-    public const CODEPAGE_NOTES             = 23;
-    public const CODEPAGE_RIGHTSMANAGEMENT  = 24;
-
+    const CODEPAGE_AIRSYNC           = 0;
+    const CODEPAGE_CONTACTS          = 1;
+    const CODEPAGE_EMAIL             = 2;
+    const CODEPAGE_AIRNOTIFY         = 3;
+    const CODEPAGE_CALENDAR          = 4;
+    const CODEPAGE_MOVE              = 5;
+    const CODEPAGE_ITEMESTIMATE      = 6;
+    const CODEPAGE_FOLDERHIERARCHY   = 7;
+    const CODEPAGE_MEETINGRESPONSE   = 8;
+    const CODEPAGE_TASKS             = 9;
+    const CODEPAGE_RESOLVERECIPIENTS = 10;
+    const CODEPAGE_VALIDATECERT      = 11;
+    const CODEPAGE_CONTACTS2         = 12;
+    const CODEPAGE_PING              = 13;
+    const CODEPAGE_PROVISION         = 14;
+    const CODEPAGE_SEARCH            = 15;
+    const CODEPAGE_GAL               = 16;
+    const CODEPAGE_AIRSYNCBASE       = 17;
+    const CODEPAGE_SETTINGS          = 18;
+    const CODEPAGE_DOCUMENTLIBRARY   = 19;
+    const CODEPAGE_ITEMOPERATIONS    = 20;
+    const CODEPAGE_COMPOSEMAIL       = 21;
+    const CODEPAGE_EMAIL2            = 22;
+    const CODEPAGE_NOTES             = 23;
+    const CODEPAGE_RIGHTSMANAGEMENT  = 24;
+    
     /**
      * variable to hold currently active codepage
      *
      * @var Syncroton_Wbxml_Dtd_ActiveSync_Abstract
      */
     protected $_currentCodePage;
-
+    
     /**
      * the constructor
      *
@@ -60,17 +60,17 @@
     {
         $this->_currentCodePage = new Syncroton_Wbxml_Dtd_ActiveSync_CodePage0();
     }
-
+    
     /**
      * returns reference to current codepage
      *
      * @return Syncroton_Wbxml_Dtd_ActiveSync_Abstract
      */
-    public function getCurrentCodePage()
+    public function getCurrentCodePage() 
     {
         return $this->_currentCodePage;
     }
-
+    
     /**
      * switch to another codepage
      *
@@ -80,12 +80,12 @@
     public function switchCodePage($_codePageId)
     {
         $className = 'Syncroton_Wbxml_Dtd_ActiveSync_CodePage' . $_codePageId;
-
+        
         $this->_currentCodePage = new $className();
-
+        
         return $this->_currentCodePage;
     }
-
+    
     /**
      * get initial dom document
      *
@@ -95,16 +95,16 @@
     {
         // Creates an instance of the DOMImplementation class
         $imp = new DOMImplementation();
-
+        
         // Creates a DOMDocumentType instance
         $dtd = $imp->createDocumentType('AirSync', "-//AIRSYNC//DTD AirSync//EN", "http://www.microsoft.com/");
 
         // Creates a DOMDocument instance
         $dom = $imp->createDocument($_nameSpace, $_tag, $dtd);
-
+        
         $dom->encoding      = 'utf-8';
         $dom->formatOutput  = false;
-
+        
         return $dom;
     }
-}
+}

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/Abstract.php Changed

@@ -16,49 +16,49 @@
  * @package     Wbxml
  * @subpackage  ActiveSync
  */
-
+ 
 abstract class Syncroton_Wbxml_Dtd_ActiveSync_Abstract
 {
     /**
      * codepage number
      *
-     * @var ?integer
+     * @var integer
      */
-    protected $_codePageNumber  = null;
-
+    protected $_codePageNumber  = NULL;
+            
     /**
      * codepage name
      *
-     * @var ?string
+     * @var string
      */
-    protected $_codePageName    = null;
+    protected $_codePageName    = NULL;
 
     /**
      * document page identifier
      * not needed for ActiveSync
      *
-     * @var ?integer
+     * @var integer
      */
-    protected $_dpi             = null;
-
+    protected $_dpi             = NULL;
+    
     /**
      * mapping of tags to id's
      *
      * @var array
      */
-    protected $_tags            = ;
-
+    protected $_tags            = array();
+    
     /**
      * return document page identifier
      * is always NULL for activesync
      *
-     * @return int|null
+     * @return unknown
      */
     public function getDPI()
     {
         return $this->_dpi;
     }
-
+    
     /**
      * get codepage name
      *
@@ -68,7 +68,7 @@
     {
         return $this->_codePageName;
     }
-
+    
     /**
      * get namespace identifier
      *
@@ -78,7 +78,7 @@
     {
         return 'uri:' . $this->_codePageName;
     }
-
+    
     /**
      * get tag identifier
      *
@@ -94,21 +94,21 @@
 
         return $this->_tags$_tag;
     }
-
+    
     /**
      * return tag by given identity
      *
-     * @param int $_identity
-     * @return mixed
+     * @param unknown_type $_identity
+     * @return unknown
      */
     public function getTag($_identity)
     {
         $tag = array_search($_identity, $this->_tags);
-
+        
         if($tag === false) {
             throw new Syncroton_Wbxml_Exception("identity $_identity not found");
         }
-
+        
         return $tag;
     }
-}
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage0.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage1.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage10.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage11.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage12.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage13.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage14.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage15.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage16.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage17.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage18.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage19.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage2.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage20.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage21.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage22.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage23.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage24.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage254.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage3.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage4.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage5.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage6.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage7.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage8.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/ActiveSync/CodePage9.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/Exception/CodePageNotFound.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/Factory.php Changed

@@ -16,28 +16,34 @@
  * @package     Wbxml
  * @subpackage  Wbxml
  */
+
 class Syncroton_Wbxml_Dtd_Factory
 {
-    public const ACTIVESYNC = 'AirSync';
-    public const SYNCML = 'SyncML';
-
+    const ACTIVESYNC='AirSync';
+    
+    const SYNCML='SyncML';
+    
     /**
      * factory function to return a selected contacts backend class
      *
      * @param string $type
-     * @return Syncroton_Wbxml_Dtd_ActiveSync
+     * @return Addressbook_Backend_Interface
      */
-    public static function factory($type)
+    static public function factory ($_type)
     {
-        switch ($type) {
+        switch ($_type) {
             case self::ACTIVESYNC:
                 $instance = new Syncroton_Wbxml_Dtd_ActiveSync();
                 break;
-
+                
+            case self::SYNCML:
+                $instance = new Syncroton_Wbxml_Dtd_Syncml();
+                break;
+                                
             default:
-                throw new Syncroton_Wbxml_Exception('unsupported DTD: ' . $type);
+                throw new Syncroton_Wbxml_Exception('unsupported DTD: ' . $_type);
+                break;
         }
-
         return $instance;
     }
-}
+}

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/Syncml Added

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/Syncml.php Added

@@ -0,0 +1,42 @@
+<?php
+/**
+ * Syncroton
+ *
+ * @package     Wbxml
+ * @subpackage  Syncml
+ * @license     http://www.tine20.org/licenses/lgpl.html LGPL Version 3
+ * @copyright   Copyright (c) 2008-2009 Metaways Infosystems GmbH (http://www.metaways.de)
+ * @author      Lars Kneschke <l.kneschke@metaways.de>
+ * @version     $Id:Factory.php 4968 2008-10-17 09:09:33Z l.kneschke@metaways.de $
+ */
+
+/**
+ * class documentation
+ *
+ * @package     Wbxml
+ * @subpackage  Syncml
+ */
+
+class Syncroton_Wbxml_Dtd_Syncml
+{
+    /**
+     * factory function to return a selected contacts backend class
+     *
+     * @param string $type
+     * @return Addressbook_Backend_Interface
+     */
+    static public function factory ($_type)
+    {
+        switch ($_type) {
+            case 'syncml:syncml1.1':
+            case 'syncml:syncml1.2':
+            case 'syncml:metinf1.1':
+            case 'syncml:metinf1.2':
+            case 'syncml:devinf1.1':
+            case 'syncml:devinf1.2':
+                throw new Syncroton_Wbxml_Exception('unsupported DTD: ' . $_type);
+                break;
+        }
+        return $instance;
+    }
+}

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/Syncml/Abstract.php Added

@@ -0,0 +1,103 @@
+<?php
+/**
+ * Syncroton
+ *
+ * @package     Wbxml
+ * @subpackage  Syncml
+ * @license     http://www.tine20.org/licenses/lgpl.html LGPL Version 3
+ * @copyright   Copyright (c) 2008-2009 Metaways Infosystems GmbH (http://www.metaways.de)
+ * @author      Lars Kneschke <l.kneschke@metaways.de>
+ * @version     $Id:Abstract.php 4968 2008-10-17 09:09:33Z l.kneschke@metaways.de $
+ */
+
+/**
+ * class documentation
+ *
+ * @package     Wbxml
+ * @subpackage  Syncml
+ */
+ 
+class Syncroton_Wbxml_Dtd_Syncml_Abstract
+{     
+    protected $_tags; 
+     
+    protected $_identity;
+    
+    protected $_codePages;
+    
+    protected $_currentCodePage;
+    
+    public function __construct($_initialCodePage = 0x00)
+    {
+        $this->switchCodePage($_initialCodePage);
+    }
+    
+    /**
+     * switch codepage
+     *
+     * @param integer $_id id of the codePage
+     * @return array
+     */
+    public function switchCodePage($_id)
+    {
+        if(!isset($this->_codePages$_id)) {
+            throw new Syncroton_Wbxml_Dtd_Exception_CodePageNotFound('invalid codePage id: ' . $_id);
+        }
+        $this->_currentCodePage = $_id;
+        $this->_tags = $this->_codePages$this->_currentCodePage'tags';
+        $this->_identity = array_flip($this->_tags);
+        
+        return $this->_codePages$this->_currentCodePage;
+    }
+    
+    /**
+     * get currently active codepage
+     *
+     * @return array
+     */
+    public function getCurrentCodePage()
+    {
+        return $this->_codePages$this->_currentCodePage;
+    }
+    
+    public function getTag($_identity)
+    {
+        if(!isset($this->_identity$_identity)) {
+            throw new Syncroton_Wbxml_Exception("identity $_identity not found");
+        }
+        
+        return $this->_identity$_identity;
+    }
+    
+    public function getIdentity($_tag)
+    {
+        if(!isset($this->_tags$_tag)) {
+            var_dump($this->_tags);
+            throw new Syncroton_Wbxml_Exception("tag $_tag not found");
+        }
+        
+        return $this->_tags$_tag;
+    }
+    
+    /**
+     * switch codepage by urn
+     *
+     * @param string $_urn
+     * @return array
+     */
+    public function switchCodePageByUrn($_urn)
+    {
+        $codePageNumber = NULL;
+        foreach($this->_codePages as $codePage) {
+            if($codePage'urn' == $_urn) {
+                $codePageNumber = $codePage'codePageNumber';
+            }
+        }
+        
+        if($codePageNumber === NULL) {
+            throw new Syncroton_Wbxml_Dtd_Exception_CodePageNotFound("codePage with URN $_urn not found");
+        }
+        
+        return $this->switchCodePage($codePageNumber);
+    }
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/Syncml/DevInfo11.php Added

@@ -0,0 +1,71 @@
+<?php
+/**
+ * Syncroton
+ *
+ * @package     Wbxml
+ * @subpackage  Syncml
+ * @license     http://www.tine20.org/licenses/lgpl.html LGPL Version 3
+ * @copyright   Copyright (c) 2008-2009 Metaways Infosystems GmbH (http://www.metaways.de)
+ * @author      Lars Kneschke <l.kneschke@metaways.de>
+ * @version     $Id:DevInfo11.php 4968 2008-10-17 09:09:33Z l.kneschke@metaways.de $
+ */
+
+/**
+ * class documentation
+ *
+ * @package     Wbxml
+ * @subpackage  Syncml
+ */
+ 
+class Syncroton_Wbxml_Dtd_Syncml_DevInfo11 extends Syncroton_Wbxml_Dtd_Syncml_Abstract
+{
+    protected $_codePages = array(
+        0x00 => array(
+            'codePageNumber'=> 0x00,
+            'dtdname'       => 'DevInf',
+            'dpi'           => '-//SYNCML//DTD DevInf 1.1//EN',
+            'url'           => 'http://www.syncml.org/docs/devinf_v11_20020215.dtd',
+            'urn'           => 'syncml:devinf1.1',
+            'tags'          => array(     
+                "CTCap"             => 0x05, 
+                "CTType"            => 0x06, 
+                "DataStore"         => 0x07, 
+                "DataType"          => 0x08, 
+                "DevID"             => 0x09, 
+                "DevInf"            => 0x0a, 
+                "DevTyp"            => 0x0b, 
+                "DisplayName"       => 0x0c, 
+                "DSMem"             => 0x0d, 
+                "Ext"               => 0x0e, 
+                "FwV"               => 0x0f, 
+                "HwV"               => 0x10, 
+                "Man"               => 0x11, 
+                "MaxGUIDSize"       => 0x12, 
+                "MaxID"             => 0x13, 
+                "MaxMem"            => 0x14, 
+                "Mod"               => 0x15, 
+                "OEM"               => 0x16, 
+                "ParamName"         => 0x17, 
+                "PropName"          => 0x18, 
+                "Rx"                => 0x19, 
+                "Rx-Pref"           => 0x1a, 
+                "SharedMem"         => 0x1b, 
+                "Size"              => 0x1c, 
+                "SourceRef"         => 0x1d, 
+                "SwV"               => 0x1e, 
+                "SyncCap"           => 0x1f, 
+                "SyncType"          => 0x20, 
+                "Tx"                => 0x21, 
+                "Tx-Pref"           => 0x22, 
+                "ValEnum"           => 0x23, 
+                "VerCT"             => 0x24, 
+                "VerDTD"            => 0x25, 
+                "XNam"              => 0x26, 
+                "XVal"              => 0x27, 
+                "UTC"               => 0x28, 
+                "SupportNumberOfChanges"=> 0x29, 
+                "SupportLargeObjs"  => 0x2a 
+            )
+        )
+    );
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/Syncml/DevInfo12.php Added

@@ -0,0 +1,80 @@
+<?php
+/**
+ * Syncroton
+ *
+ * @package     Wbxml
+ * @subpackage  Syncml
+ * @license     http://www.tine20.org/licenses/lgpl.html LGPL Version 3
+ * @copyright   Copyright (c) 2008-2009 Metaways Infosystems GmbH (http://www.metaways.de)
+ * @author      Lars Kneschke <l.kneschke@metaways.de>
+ * @version     $Id:DevInfo12.php 4968 2008-10-17 09:09:33Z l.kneschke@metaways.de $
+ */
+
+/**
+ * class documentation
+ *
+ * @package     Wbxml
+ * @subpackage  Syncml
+ */
+ 
+class Syncroton_Wbxml_Dtd_Syncml_DevInfo12 extends Syncroton_Wbxml_Dtd_Syncml_Abstract
+{    
+    protected $_codePages = array(
+        0x00 => array(
+            'codePageNumber'=> 0x00,
+            'dtdname'       => 'DevInf',
+            'dpi'           => '-//OMA//DTD SYNCML-DEVINF 1.2//EN',
+            'url'           => 'http://www.openmobilealliance.org/tech/DTD/OMA-SyncML-Device_Information-DTD-1.2.dtd',
+            'urn'           => 'syncml:devinf1.2',
+            'tags'          => array(     
+                "CTCap"             => 0x05, 
+                "CTType"            => 0x06, 
+                "DataStore"         => 0x07, 
+                "DataType"          => 0x08, 
+                "DevID"             => 0x09, 
+                "DevInf"            => 0x0a, 
+                "DevTyp"            => 0x0b, 
+                "DisplayName"       => 0x0c, 
+                "DSMem"             => 0x0d, 
+                "Ext"               => 0x0e, 
+                "FwV"               => 0x0f, 
+                "HwV"               => 0x10, 
+                "Man"               => 0x11, 
+                "MaxGUIDSize"       => 0x12, 
+                "MaxID"             => 0x13, 
+                "MaxMem"            => 0x14, 
+                "Mod"               => 0x15, 
+                "OEM"               => 0x16, 
+                "ParamName"         => 0x17, 
+                "PropName"          => 0x18, 
+                "Rx"                => 0x19, 
+                "Rx-Pref"           => 0x1a, 
+                "SharedMem"         => 0x1b, 
+                "Size"              => 0x1c, 
+                "SourceRef"         => 0x1d, 
+                "SwV"               => 0x1e, 
+                "SyncCap"           => 0x1f, 
+                "SyncType"          => 0x20, 
+                "Tx"                => 0x21, 
+                "Tx-Pref"           => 0x22, 
+                "ValEnum"           => 0x23, 
+                "VerCT"             => 0x24, 
+                "VerDTD"            => 0x25, 
+                "XNam"              => 0x26, 
+                "XVal"              => 0x27, 
+                "UTC"               => 0x28, 
+                "SupportNumberOfChanges"=> 0x29, 
+                "SupportLargeObjs"  => 0x2a, 
+                "Property"          => 0x2b, 
+                "PropParam"         => 0x2c, 
+                "MaxOccur"          => 0x2d, 
+                "NoTruncate"        => 0x2e, 
+                "Filter-Rx"         => 0x30, 
+                "FilterCap"         => 0x31, 
+                "FilterKeyword"     => 0x32, 
+                "FieldLevel"        => 0x33, 
+                "SupportHierarchicalSync"=> 0x34
+            )
+        )
+    );
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/Syncml/Syncml11.php Added

@@ -0,0 +1,107 @@
+<?php
+/**
+ * Syncroton
+ *
+ * @package     Wbxml
+ * @subpackage  Syncml
+ * @license     http://www.tine20.org/licenses/lgpl.html LGPL Version 3
+ * @copyright   Copyright (c) 2008-2009 Metaways Infosystems GmbH (http://www.metaways.de)
+ * @author      Lars Kneschke <l.kneschke@metaways.de>
+ * @version     $Id:Syncml11.php 4968 2008-10-17 09:09:33Z l.kneschke@metaways.de $
+ */
+
+/**
+ * class documentation
+ *
+ * @package     Wbxml
+ * @subpackage  Syncml
+ */
+ 
+class Syncroton_Wbxml_Dtd_Syncml_Syncml11 extends Syncroton_Wbxml_Dtd_Syncml_Abstract
+{     
+    protected $_codePages = array(
+        0x00 => array(
+            'codePageNumber'=> 0x00,
+            'dtdname'       => 'SyncML',
+            'dpi'           => '-//SYNCML//DTD SyncML 1.1//EN',
+            'url'           => "http://www.syncml.org/docs/syncml_represent_v11_20020213.dtd",
+            'urn'           => 'syncml:syncml1.1',
+            'tags'          => array(     
+                'Add'               => 0x05,
+                'Alert'             => 0x06,
+                'Archive'           => 0x07,
+                'Atomic'            => 0x08,
+                'Chal'              => 0x09,
+                'Cmd'               => 0x0a,
+                'CmdID'             => 0x0b,
+                'CmdRef'            => 0x0c,
+                'Copy'              => 0x0d,
+                'Cred'              => 0x0e,
+                'Data'              => 0x0f,
+                'Delete'            => 0x10,
+                'Exec'              => 0x11,
+                'Final'             => 0x12,
+                'Get'               => 0x13,
+                'Item'              => 0x14,
+                'Lang'              => 0x15,
+                'LocName'           => 0x16,
+                'LocURI'            => 0x17,
+                'Map'               => 0x18,
+                'MapItem'           => 0x19,
+                'Meta'              => 0x1a,
+                'MsgID'             => 0x1b,
+                'MsgRef'            => 0x1c,
+                'NoResp'            => 0x1d,
+                'NoResults'         => 0x1e,
+                'Put'               => 0x1f,
+                'Replace'           => 0x20,
+                'RespURI'           => 0x21,
+                'Results'           => 0x22,
+                'Search'            => 0x23,
+                'Sequence'          => 0x24,
+                'SessionID'         => 0x25,
+                'SftDel'            => 0x26,
+                'Source'            => 0x27,
+                'SourceRef'         => 0x28,
+                'Status'            => 0x29,
+                'Sync'              => 0x2a,
+                'SyncBody'          => 0x2b,
+                'SyncHdr'           => 0x2c,
+                'SyncML'            => 0x2d,
+                'Target'            => 0x2e,
+                'TargetRef'         => 0x2f,
+                'Reserved for future use.' => 0x30,
+                'VerDTD'            => 0x31,
+                'VerProto'          => 0x32,
+                'NumberOfChanges'   => 0x33,
+                'MoreData'          => 0x34
+            )    
+        ),
+        0x01 => array(
+            'codePageNumber'=> 0x01,
+            'dtdname'       => 'MetInf',
+            'dpi'           => '-//SYNCML//DTD MetInf 1.1//EN',
+            'url'           => 'http://www.syncml.org/docs/syncml_metinf_v11_20020215.dtd ',
+            'urn'           => 'syncml:metinf1.1',
+            'tags'          => array(     
+                'Anchor'       => 0x05,
+                'EMI'          => 0x06,
+                'Format'       => 0x07,
+                'FreeID'       => 0x08,
+                'FreeMem'      => 0x09,
+                'Last'         => 0x0a,
+                'Mark'         => 0x0b,
+                'MaxMsgSize'   => 0x0c,
+                'Mem'          => 0x0d,
+                'MetInf'       => 0x0e,
+                'Next'         => 0x0f,
+                'NextNonce'    => 0x10,
+                'SharedMem'    => 0x11,
+                'Size'         => 0x12,
+                'Type'         => 0x13,
+                'Version'      => 0x14,
+                'MaxObjSize'   => 0x15
+            )
+        ) 
+    );    
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Dtd/Syncml/Syncml12.php Added

@@ -0,0 +1,122 @@
+<?php
+/**
+ * Syncroton
+ *
+ * @package     Wbxml
+ * @subpackage  Syncml
+ * @license     http://www.tine20.org/licenses/lgpl.html LGPL Version 3
+ * @copyright   Copyright (c) 2008-2009 Metaways Infosystems GmbH (http://www.metaways.de)
+ * @author      Lars Kneschke <l.kneschke@metaways.de>
+ * @version     $Id:Syncml12.php 4968 2008-10-17 09:09:33Z l.kneschke@metaways.de $
+ */
+
+/**
+ * class documentation
+ *
+ * @package     Wbxml
+ * @subpackage  Syncml
+ */
+ 
+class Syncroton_Wbxml_Dtd_Syncml_Syncml12 extends Syncroton_Wbxml_Dtd_Syncml_Abstract
+{     
+          
+    /**
+     * section 8.2
+     *
+     * @var array
+     */
+    protected $_codePages = array(
+        0x00 => array(
+            'codePageNumber'=> 0x00,
+            'dtdname'       => 'SyncML',
+            'dpi'           => '-//SYNCML//DTD SyncML 1.2//EN',
+            'url'           => 'http://www.openmobilealliance.org/tech/DTD/OMA-TS-SyncML_RepPro_DTD-V1_2.dtd',
+            'urn'           => 'SYNCML:SYNCML1.2',
+            'tags'          => array(     
+                'Add'           => 0x05,
+                'Alert'         => 0x06,
+                'Archive'       => 0x07,
+                'Atomic'        => 0x08,
+                'Chal'          => 0x09,
+                'Cmd'           => 0x0a,
+                'CmdID'         => 0x0b,
+                'CmdRef'        => 0x0c,
+                'Copy'          => 0x0d,
+                'Cred'          => 0x0e,
+                'Data'          => 0x0f,
+                'Delete'        => 0x10,
+                'Exec'          => 0x11,
+                'Final'         => 0x12,
+                'Get'           => 0x13,
+                'Item'          => 0x14,
+                'Lang'          => 0x15,
+                'LocName'       => 0x16,
+                'LocURI'        => 0x17,
+                'Map'           => 0x18,
+                'MapItem'       => 0x19,
+                'Meta'          => 0x1a,
+                'MsgID'         => 0x1b,
+                'MsgRef'        => 0x1c,
+                'NoResp'        => 0x1d,
+                'NoResults'     => 0x1e,
+                'Put'           => 0x1f,
+                'Replace'       => 0x20,
+                'RespURI'       => 0x21,
+                'Results'       => 0x22,
+                'Search'        => 0x23,
+                'Sequence'      => 0x24,
+                'SessionID'     => 0x25,
+                'SftDel'        => 0x26,
+                'Source'        => 0x27,
+                'SourceRef'     => 0x28,
+                'Status'        => 0x29,
+                'Sync'          => 0x2a,
+                'SyncBody'      => 0x2b,
+                'SyncHdr'       => 0x2c,
+                'SyncML'        => 0x2d,
+                'Target'        => 0x2e,
+                'TargetRef'     => 0x2f,
+                'Reserved for future use.' => 0x30,
+                'VerDTD'        => 0x31,
+                'VerProto'      => 0x32,
+                'NumberOfChanges' =>  0x33,
+                'MoreData'      =>  0x34,
+                'Field'         =>  0x35,
+                'Filter'        =>  0x36,
+                'Record'        =>  0x37,
+                'FilterType'    =>  0x38,
+                'SourceParent'  =>  0x39,
+                'TargetParent'  =>  0x3a,
+                'Move'          =>  0x3b,
+                'Correlator'    =>  0x3c
+            )
+        ),
+        0x01 => array(
+            'codePageNumber'=> 0x01,
+            'dtdname'       => 'MetInf',
+            'dpi'           => '-//OMA//DTD SYNCML-METINF 1.2//EN',
+            'url'           => 'http://www.openmobilealliance.org/tech/DTD/OMA-TS-SyncML_MetaInfo_DTD-V1_2.dtd',
+            'urn'           => 'syncml:metinf1.2',
+            'tags'          => array(     
+                'Anchor'       => 0x05,
+                'EMI'          => 0x06,
+                'Format'       => 0x07,
+                'FreeID'       => 0x08,
+                'FreeMem'      => 0x09,
+                'Last'         => 0x0a,
+                'Mark'         => 0x0b,
+                'MaxMsgSize'   => 0x0c,
+                'Mem'          => 0x0d,
+                'MetInf'       => 0x0e,
+                'Next'         => 0x0f,
+                'NextNonce'    => 0x10,
+                'SharedMem'    => 0x11,
+                'Size'         => 0x12,
+                'Type'         => 0x13,
+                'Version'      => 0x14,
+                'MaxObjSize'   => 0x15,
+                'FieldLevel'   => 0x16
+            )
+        ) 
+    );
+}
\ No newline at end of file

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Encoder.php Changed

@@ -16,22 +16,22 @@
  * @package     Wbxml
  * @subpackage  Wbxml
  */
-
+ 
 class Syncroton_Wbxml_Encoder extends Syncroton_Wbxml_Abstract
 {
     /**
      * count level of tags
      *
-     * @var int
+     * @var string
      */
     protected $_level = 0;
-
+    
     /**
      * the constructor
      *
      * @param resource $_stream
-     * @param string   $_charSet
-     * @param int      $_version
+     * @param string $_charSet
+     * @param integer $_version
      */
     public function __construct($_stream, $_charSet = 'UTF-8', $_version = 2)
     {
@@ -43,18 +43,18 @@
     /**
      * initialize internal variables and write wbxml header to stream
      *
-     * @param DOMDocument $_dom
+     * @param string $_urn
      * @todo check if dpi > 0, instead checking the urn
      */
     protected function _initialize($_dom)
     {
         $this->_dtd = Syncroton_Wbxml_Dtd_Factory::factory($_dom->doctype->name);
         $this->_codePage = $this->_dtd->getCurrentCodePage();
-
+        
         // the WBXML version
         $this->_writeByte($this->_version);
-
-        if($this->_codePage->getDPI() === null) {
+        
+        if($this->_codePage->getDPI() === NULL) {
             // the document public identifier
             $this->_writeMultibyteUInt(1);
         } else {
@@ -63,22 +63,22 @@
             $this->_writeMultibyteUInt(0);
             // the offset of the DPI in the string table
             $this->_writeByte(0);
-        }
-
+        }        
+        
         // write the charSet
         $this->_writeCharSet($this->_charSet);
-
-        if($this->_codePage->getDPI() === null) {
+        
+        if($this->_codePage->getDPI() === NULL) {
             // the length of the string table
             $this->_writeMultibyteUInt(0);
         } else {
             // the length of the string table
             $this->_writeMultibyteUInt(strlen($this->_codePage->getDPI()));
             // the dpi
-            $this->_writeString($this->_codePage->getDPI());
-        }
+            $this->_writeString($this->_codePage->getDPI());      
+        }  
     }
-
+    
     /**
      * write charset to stream
      *
@@ -91,28 +91,31 @@
             case 'UTF-8':
                 $this->_writeMultibyteUInt(106);
                 break;
-
+                
             default:
                 throw new Syncroton_Wbxml_Exception('unsuported charSet ' . strtoupper($_charSet));
+                break;
         }
+        
     }
-
+    
     /**
      * start encoding of xml to wbxml
      *
-     * @param DOMDocument $_dom the DOM document
+     * @param string $_xml the xml string
+     * @return resource stream
      */
     public function encode(DOMDocument $_dom)
     {
         $_dom->formatOutput = false;
-
+        
         $this->_initialize($_dom);
         $this->_traverseDom($_dom);
     }
 
     private function getAttributes($node)
     {
-        $attributes = ;
+        $attributes = array();
         if ($node->attributes) {
             for ($i = 0; $i < $node->attributes->length; ++$i) {
                 $attributes$node->attributes->item($i)->name = $node->attributes->item($i)->value;
@@ -121,8 +124,7 @@
         return $attributes;
     }
 
-    private function writeNode($node, $withContent = false, $data = null)
-    {
+    private function writeNode($node, $withContent = false, $data = null) {
         if($this->_codePage->getNameSpace() != $node->namespaceURI) {
             $this->_switchCodePage($node->namespaceURI);
         }
@@ -170,15 +172,14 @@
     /**
      * strip uri: from nameSpace
      *
-     * @param string $_nameSpace
-     *
-     * @return string
+     * @param unknown_type $_nameSpace
+     * @return unknown
      */
     protected function _stripNameSpace($_nameSpace)
     {
         return substr($_nameSpace, 4);
     }
-
+    
     /**
      * writes tag with data to stream
      *
@@ -187,36 +188,36 @@
      * @param bool $_hasContent
      * @param string $_data
      */
-    protected function _writeTag($_tag, $_attributes = null, $_hasContent = false, $_data = null)
+    protected function _writeTag($_tag, $_attributes=NULL, $_hasContent=false, $_data=NULL)
     {
-        if($_hasContent == false && $_data !== null) {
+        if($_hasContent == false && $_data !== NULL) {
             throw new Syncroton_Wbxml_Exception('$_hasContent can not be false, when $_data !== NULL');
         }
-
+        
         // handle the tag
         $identity = $this->_codePage->getIdentity($_tag);
-
+        
         if (is_array($_attributes) && isset($_attributes'uri:Syncroton;encoding')) {
             $encoding = 'opaque';
             unset($_attributes'uri:Syncroton;encoding');
         } else {
             $encoding = 'termstring';
         }
-
+        
         if(!empty($_attributes)) {
             $identity |= 0x80;
         }
-
+        
         if($_hasContent == true) {
             $identity |= 0x40;
         }
-
+        
         $this->_writeByte($identity);
-
+        
         // handle the data
-        if($_data !== null) {
+        if($_data !== NULL) {
             if ($encoding == 'opaque') {
-                $this->_writeOpaqueString(base64_decode($_data));
+                $this->_writeOpaqueString(base64_decode($_data));
             } else {
                 $this->_writeTerminatedString($_data);
             }
@@ -226,19 +227,19 @@
     /**
      * switch code page
      *
-     * @param string $_nameSpace
+     * @param string $_urn
      */
     protected function _switchCodePage($_nameSpace)
     {
         $codePageName = $this->_stripNameSpace($_nameSpace);
-        if(!defined('Syncroton_Wbxml_Dtd_ActiveSync::CODEPAGE_' . strtoupper($codePageName))) {
+        if(!defined('Syncroton_Wbxml_Dtd_ActiveSync::CODEPAGE_'. strtoupper($codePageName))) {
             throw new Syncroton_Wbxml_Exception('codepage ' . $codePageName . ' not found');
         }
         // switch to another codepage
         // no need to write the wbxml header again
-        $codePageId = constant('Syncroton_Wbxml_Dtd_ActiveSync::CODEPAGE_' . strtoupper($codePageName));
+        $codePageId = constant('Syncroton_Wbxml_Dtd_ActiveSync::CODEPAGE_'. strtoupper($codePageName));
         $this->_codePage = $this->_dtd->switchCodePage($codePageId);
-
+        
         $this->_writeByte(Syncroton_Wbxml_Abstract::SWITCH_PAGE);
         $this->_writeByte($codePageId);
     }

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Wbxml/Exception.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync.php Changed

@@ -135,29 +135,30 @@
             $userid = $this->authenticate($_SERVER'PHP_AUTH_USER', $_SERVER'PHP_AUTH_PW');
         }
 
-        if (!empty($userid)) {
-            $this->plugins->exec_hook('ready', 'task' => 'syncroton');
+        if (empty($userid)) {
+            header('WWW-Authenticate: Basic realm="' . $this->app_name . '"');
+            header('HTTP/1.1 401 Unauthorized');
+            exit;
+        }
 
-            // Set log directory per-user (again, in case the username changed above)
-            $this->set_log_dir();
+        $this->plugins->exec_hook('ready', 'task' => 'syncroton');
 
-            // Save user password for Roundcube Framework
-            $this->password = $_SERVER'PHP_AUTH_PW';
-        }
+        // Set log directory per-user (again, in case the username changed above)
+        $this->set_log_dir();
+
+        // Save user password for Roundcube Framework
+        $this->password = $_SERVER'PHP_AUTH_PW';
 
         // Register Syncroton backends/callbacks
         Syncroton_Registry::set(Syncroton_Registry::LOGGERBACKEND, $this->logger);
         Syncroton_Registry::set(Syncroton_Registry::DATABASE, $this->get_dbh());
         Syncroton_Registry::set(Syncroton_Registry::TRANSACTIONMANAGER, kolab_sync_transaction_manager::getInstance());
-        // The unauthenticated OPTIONS request doesn't require these backends and we can't instantiate them without credentials for the underlying storage backend
-        if (!empty($userid)) {
-            Syncroton_Registry::set(Syncroton_Registry::DEVICEBACKEND, new kolab_sync_backend_device());
-            Syncroton_Registry::set(Syncroton_Registry::FOLDERBACKEND, new kolab_sync_backend_folder());
-            Syncroton_Registry::set(Syncroton_Registry::SYNCSTATEBACKEND, new kolab_sync_backend_state());
-            Syncroton_Registry::set(Syncroton_Registry::CONTENTSTATEBACKEND, new kolab_sync_backend_content());
-            Syncroton_Registry::set(Syncroton_Registry::POLICYBACKEND, new kolab_sync_backend_policy());
-            Syncroton_Registry::set(Syncroton_Registry::SLEEP_CALLBACK, $this, 'sleep');
-        }
+        Syncroton_Registry::set(Syncroton_Registry::DEVICEBACKEND, new kolab_sync_backend_device());
+        Syncroton_Registry::set(Syncroton_Registry::FOLDERBACKEND, new kolab_sync_backend_folder());
+        Syncroton_Registry::set(Syncroton_Registry::SYNCSTATEBACKEND, new kolab_sync_backend_state());
+        Syncroton_Registry::set(Syncroton_Registry::CONTENTSTATEBACKEND, new kolab_sync_backend_content());
+        Syncroton_Registry::set(Syncroton_Registry::POLICYBACKEND, new kolab_sync_backend_policy());
+        Syncroton_Registry::set(Syncroton_Registry::SLEEP_CALLBACK, $this, 'sleep');
 
         Syncroton_Registry::setContactsDataClass('kolab_sync_data_contacts');
         Syncroton_Registry::setCalendarDataClass('kolab_sync_data_calendar');
@@ -173,7 +174,7 @@
         Syncroton_Registry::set(Syncroton_Registry::MAX_COLLECTIONS, (int) $this->config->get('activesync_max_folders', 100));
 
         // Run Syncroton
-        $syncroton = new Syncroton_Server($userid ?? null);
+        $syncroton = new Syncroton_Server($userid);
         $syncroton->handle();
     }

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_backend_common.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_backend_device.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_backend_folder.php Changed

@@ -50,19 +50,15 @@
      *
      * @param Syncroton_Model_Device|string $deviceid Device object or identifier
      * @param string                        $class    Class name
-     * @param int                           $syncKey  Sync key
      *
      * @return array List of object identifiers
      */
-    public function getFolderState($deviceid, $class, $syncKey = null)
+    public function getFolderState($deviceid, $class)
     {
         $device_id = $deviceid instanceof Syncroton_Model_IDevice ? $deviceid->id : $deviceid;
 
         $where = $this->db->quote_identifier('device_id') . ' = ' . $this->db->quote($device_id);
         $where = $this->db->quote_identifier('class') . ' = ' . $this->db->quote($class);
-        if ($syncKey) {
-            $where = $this->db->quote_identifier('creation_synckey') . ' < ' . $this->db->quote($syncKey + 1);
-        }
 
         $select = $this->db->query('SELECT * FROM `' . $this->table_name . '` WHERE ' . implode(' AND ', $where));
         $result = ;
@@ -92,11 +88,8 @@
         $select = $this->db->query('SELECT * FROM `' . $this->table_name . '` WHERE ' . implode(' AND ', $where));
         $folder = $this->db->fetch_assoc($select);
 
-        if (!empty($folder'resync')) {
-            throw new Syncroton_Exception_NotFound("Folder $folderid not found because of resync");
-        }
         if (empty($folder)) {
-            throw new Syncroton_Exception_NotFound("Folder $folderid not found");
+            throw new Syncroton_Exception_NotFound('Folder not found');
         }
 
         return $this->get_object($folder);
@@ -127,18 +120,6 @@
         // Reset imap cache so we work with up-to-date folders list
         rcube::get_instance()->get_storage()->clear_cache('mailboxes', true);
 
-        // Retrieve all folders already sent to the client
-        $select = $this->db->query("SELECT * FROM `{$this->table_name}` WHERE `device_id` = ?", $device->id);
-
-        while ($folder = $this->db->fetch_assoc($select)) {
-            if (!empty($folder'resync')) {
-                // Folder re-sync requested
-                return true;
-            }
-
-            $client_folders$folder'folderid' = $this->get_object($folder);
-        }
-
         foreach ($folder_classes as $class) {
             try {
                 // retrieve all folders available in data backend
@@ -151,6 +132,13 @@
             }
         }
 
+        // retrieve all folders sent to the client
+        $select = $this->db->query("SELECT * FROM `{$this->table_name}` WHERE `device_id` = ?", $device->id);
+
+        while ($folder = $this->db->fetch_assoc($select)) {
+            $client_folders$folder'folderid' = $this->get_object($folder);
+        }
+
         ksort($client_folders);
         ksort($server_folders);

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_backend_state.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_data.php Changed

@@ -502,7 +502,7 @@
      *
      * @return array|int Search result as count or array of uids/objects
      */
-    protected function searchEntries($folderid, $filter = , $result_type = self::RESULT_UID, $extraData = null)
+    protected function searchEntries($folderid, $filter = , $result_type = self::RESULT_UID)
     {
         $result = $result_type == self::RESULT_COUNT ? 0 : ;
         $ts     = time();
@@ -510,7 +510,7 @@
         $found  = false;
 
         foreach ($this->extractFolders($folderid) as $fid) {
-            $search = $this->backend->searchEntries($fid, $this->device->deviceid, $this->device->id, $this->modelName, $filter, $result_type, $force, $extraData);
+            $search = $this->backend->searchEntries($fid, $this->device->deviceid, $this->modelName, $filter, $result_type, $force);
             $found = true;
 
             switch ($result_type) {
@@ -555,42 +555,44 @@
      * get all entries changed between two dates
      *
      * @param string   $folderId
-     * @param Syncroton_Model_ISyncState $syncState
+     * @param DateTime $start
+     * @param DateTime $end
      * @param int      $filter_type
      *
      * @return array
      */
-    public function getChangedEntries($folderId, Syncroton_Model_ISyncState $syncState, $filter_type = null)
+    public function getChangedEntries($folderId, DateTime $start, DateTime $end = null, $filter_type = null)
     {
-        $start = $syncState->lastsync;
         $filter   = $this->filter($filter_type);
         $filter = 'changed', '>', $start;
 
-        return $this->searchEntries($folderId, $filter, self::RESULT_UID, $syncState->extraData);
+        if ($end) {
+            $filter = 'changed', '<=', $end;
+        }
+
+        return $this->searchEntries($folderId, $filter, self::RESULT_UID);
     }
 
     /**
      * Get count of entries changed between two dates
      *
      * @param string   $folderId
-     * @param Syncroton_Model_ISyncState $syncState
+     * @param DateTime $start
+     * @param DateTime $end
      * @param int      $filter_type
      *
      * @return int
      */
-    private function getChangedEntriesCount($folderId, Syncroton_Model_ISyncState $syncState, $filter_type = null)
+    public function getChangedEntriesCount($folderId, DateTime $start, DateTime $end = null, $filter_type = null)
     {
-        $start = $syncState->lastsync;
         $filter   = $this->filter($filter_type);
         $filter = 'changed', '>', $start;
 
-        return $this->searchEntries($folderId, $filter, self::RESULT_COUNT, $syncState->extraData);
-    }
-
+        if ($end) {
+            $filter = 'changed', '<=', $end;
+        }
 
-    public function getExtraData(Syncroton_Model_IFolder $folder)
-    {
-        return $this->backend->getExtraData($folder->serverId, $this->device->deviceid);
+        return $this->searchEntries($folderId, $filter, self::RESULT_COUNT);
     }
 
     /**
@@ -636,9 +638,10 @@
      */
     public function getCountOfChanges(Syncroton_Backend_IContent $contentBackend, Syncroton_Model_IFolder $folder, Syncroton_Model_ISyncState $syncState)
     {
+        // @phpstan-ignore-next-line
         $allClientEntries = $contentBackend->getFolderState($this->device, $folder, $syncState->counter);
         $allServerEntries = $this->getServerEntries($folder->serverId, $folder->lastfiltertype);
-        $changedEntries   = $this->getChangedEntriesCount($folder->serverId, $syncState, $folder->lastfiltertype);
+        $changedEntries   = $this->getChangedEntriesCount($folder->serverId, $syncState->lastsync, null, $folder->lastfiltertype);
         $addedEntries     = array_diff($allServerEntries, $allClientEntries);
         $deletedEntries   = array_diff($allClientEntries, $allServerEntries);
 
@@ -657,10 +660,11 @@
     public function hasChanges(Syncroton_Backend_IContent $contentBackend, Syncroton_Model_IFolder $folder, Syncroton_Model_ISyncState $syncState)
     {
         try {
-            if ($this->getChangedEntriesCount($folder->serverId, $syncState, $folder->lastfiltertype)) {
+            if ($this->getChangedEntriesCount($folder->serverId, $syncState->lastsync, null, $folder->lastfiltertype)) {
                 return true;
             }
 
+            // @phpstan-ignore-next-line
             $allClientEntries = $contentBackend->getFolderState($this->device, $folder, $syncState->counter);
 
             // @TODO: Consider looping over all folders here, not in getServerEntries() and
@@ -712,7 +716,7 @@
             // Or (faster) strict UID matching...
             $object = $this->backend->getItem($fid, $this->device->deviceid, $this->modelName, $uid);
 
-            if (!empty($object) && ($crc === null || $crc == $this->objectCRC($uid, $fid))) {
+            if (!empty($object) && ($crc === null || $crc == $this->objectCRC($object'uid', $fid))) {
                 $object'folderId' = $fid;
                 return $object;
             }

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_data_calendar.php Changed

@@ -190,7 +190,7 @@
     public function getEntry(Syncroton_Model_SyncCollection $collection, $serverId, $as_array = false)
     {
         $event  = is_array($serverId) ? $serverId : $this->getObject($collection->collectionId, $serverId);
-        $config = !empty($event'folderId') ? $this->getFolderConfig($event'folderId') : ;
+        $config = $this->getFolderConfig($event'folderId');
         $result = ;
 
         $is_outlook = stripos($this->device->devicetype, 'outlook') !== false;
@@ -691,11 +691,7 @@
         }
 
         // extract event from the invitation
-        try {
-            $event, $existing = $this->get_event_from_invitation($request);
-        } catch (Exception $e) {
-            throw new Syncroton_Exception_Status_MeetingResponse(Syncroton_Exception_Status_MeetingResponse::MEETING_ERROR);
-        }
+        $event, $existing = $this->get_event_from_invitation($request);
         /*
                     switch ($status) {
                         case 'ACCEPTED':  $event'free_busy' = 'busy';      break;
@@ -1250,7 +1246,7 @@
     /**
      * Sanity checks on event input
      *
-     * @param Syncroton_Model_Event|Syncroton_Model_EventException &$entry Entry object
+     * @param Syncroton_Model_IEntry &$entry Entry object
      *
      * @throws Syncroton_Exception_Status_Sync
      */
@@ -1332,14 +1328,14 @@
         $rec = (array) $event'recurrence';
 
         // Add BYDAY if not exists
-        if (($rec'FREQ' ?? '') == 'WEEKLY' && empty($rec'BYDAY')) {
+        if ($rec'FREQ' == 'WEEKLY' && empty($rec'BYDAY')) {
             $days = 'SU', 'MO', 'TU', 'WE', 'TH', 'FR', 'SA';
             $day  = $event'start'->format('w');
 
             $rec'BYDAY' = $days$day;
         }
 
-        if (empty($rec'INTERVAL')) {
+        if (!$rec'INTERVAL') {
             $rec'INTERVAL' = 1;
         }

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_data_contacts.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_data_email.php Changed

@@ -250,14 +250,6 @@
             }
         }
 
-        // Categories (Tags)
-        $result'categories' = $headers->others'categories' ?? ;
-
-        //The body never changes, so make sure we don't re-send it to the client on a change
-        if ($collection->options'_changesOnly' ?? false) {
-            return new Syncroton_Model_Email($result);
-        }
-
         // get truncation and body type
         $airSyncBaseType = Syncroton_Command_Sync::BODY_TYPE_PLAIN_TEXT;
         $truncateAt = null;
@@ -507,6 +499,9 @@
             }
         }
 
+        // Categories (Tags)
+        $result'categories' = $message->headers->others'categories' ?? ;
+
         $is_ios = preg_match('/(iphone|ipad)/i', $this->device->devicetype);
 
         // attachments
@@ -674,7 +669,7 @@
         $result = ;
 
         if (!is_array($list)) {
-            throw new Syncroton_Exception_NotFound("Folder $folder_id not found: no folders available");
+            throw new Syncroton_Exception_NotFound('Folder not found');
         }
 
         // device supports multiple folders?
@@ -691,7 +686,7 @@
         }
 
         if (empty($result)) {
-            throw new Syncroton_Exception_NotFound("Folder $folder_id not found.");
+            throw new Syncroton_Exception_NotFound('Folder not found');
         }
 
         return $result;
@@ -725,8 +720,8 @@
     /**
      * add entry from xml data
      *
-     * @param string                $folderId Folder identifier
-     * @param Syncroton_Model_Email $entry    Entry
+     * @param string                 $folderId Folder identifier
+     * @param Syncroton_Model_IEntry $entry    Entry
      *
      * @return string ID of the created entry
      */
@@ -992,7 +987,6 @@
                 continue;
             }
 
-            $search->revert();
             $uids = $search->get();
             foreach ($uids as $idx => $uid) {
                 $uids$idx = new Syncroton_Model_StoreResponseResult(
@@ -1137,7 +1131,7 @@
         $message = $this->getObject($fileReference);
 
         if (!$message) {
-            throw new Syncroton_Exception_NotFound("Message $fileReference not found");
+            throw new Syncroton_Exception_NotFound('Message not found');
         }
 
         $part = $message->mime_parts$part_id;

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_logger.php Changed

@@ -103,7 +103,6 @@
 
         // if log_file is configured all logs will go to it
         // otherwise use separate file for info/debug and warning/error
-        $file = "undefined";
         if (!$logfile) {
             switch ($mode) {
                 case self::DEBUG:
@@ -129,28 +128,6 @@
             $message = var_export($message, true);
         }
 
-        // write message in logfmt format with extra info when configured to log to STDOUT
-        if ($this->log_driver == 'logfmt') {
-            $user_name = $this->username;
-
-            $output = "name=$file component=syncroton";
-            $params = 'cmd' => 'Cmd', 'device' => 'DeviceId', 'type' => 'DeviceType';
-
-            foreach ($params as $key => $val) {
-                if ($val = $_GET$val) {
-                    $output .= " $key=$val";
-                }
-            }
-
-            if (!empty($user_name)) {
-                $output .= " user=$user_name";
-            }
-            $line = json_encode($message);
-            $output .= " log=$line\n";
-            file_put_contents("php://stdout", $output, FILE_APPEND) !== false;
-            return;
-        }
-
         // add user/request information to the log
         if ($mode <= self::WARN) {
             $device = ;
@@ -161,8 +138,8 @@
             }
 
             foreach ($params as $key => $val) {
-                if (isset($_GET$val)) {
-                    $device$key = $_GET$val;
+                if ($val = $_GET$val) {
+                    $device$key = $val;
                 }
             }

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_message.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_storage.php Changed

@@ -54,11 +54,11 @@
     protected $folder_meta;
     protected $folder_uids;
     protected $folders = ;
+    protected $modseq = ;
     protected $root_meta;
     protected $relations = ;
-    public $relationSupport = true;
+    protected $relationSupport = true;
     protected $tag_rts = ;
-    private $modseq = ;
 
     protected static $instance;
 
@@ -1042,12 +1042,6 @@
 
             // Use COPYUID feature (RFC2359) to get the new UID of the copied message
             if (empty($this->storage->conn->data'COPYUID')) {
-                // Check if the source item actually exists. Cyrus IMAP reports
-                // OK on a MOVE with an invalid UID, But COPYUID will be empty.
-                // This way we only incur the cost of the extra check once the move fails.
-                if (!$this->storage->get_message_headers($uid, $src_name)) {
-                    throw new Syncroton_Exception_Status_MoveItems(Syncroton_Exception_Status_MoveItems::INVALID_SOURCE);
-                }
                 throw new Syncroton_Exception_Status(Syncroton_Exception_Status::SERVER_ERROR);
             }
 
@@ -1141,35 +1135,41 @@
      *
      * @param string $folderid    Folder identifier
      * @param string $deviceid    Device identifier
-     * @param string $device_key  Device primary key
      * @param string $type        Activesync model name (folder type)
      * @param array  $filter      Filter
      * @param int    $result_type Type of the result (see kolab_sync_data::RESULT_* constants)
      * @param bool   $force       Force IMAP folder cache synchronization
-     * @param string $extraData   Extra data as extracted by the getExtraData during the last sync
      *
      * @return array|int Search result as count or array of uids
      */
-    public function searchEntries($folderid, $deviceid, $device_key, $type, $filter, $result_type, $force, $extraData)
+    public function searchEntries($folderid, $deviceid, $type, $filter, $result_type, $force)
     {
         if ($type != self::MODEL_EMAIL) {
-            return $this->searchKolabEntries($folderid, $deviceid, $device_key, $type, $filter, $result_type, $force);
+            return $this->searchKolabEntries($folderid, $deviceid, $type, $filter, $result_type, $force);
         }
 
         $filter_str = 'ALL UNDELETED';
 
-        $getChangesMode = false;
         // convert filter into one IMAP search string
         foreach ($filter as $idx => $filter_item) {
             if (is_array($filter_item)) {
+                // This is a request for changes since last time
+                // we'll use HIGHESTMODSEQ value from the last Sync
                 if ($filter_item0 == 'changed' && $filter_item1 == '>') {
-                    $getChangesMode = true;
+                    $modseq_lasttime = $filter_item2;
+                    $modseq_data     = ;
+                    $modseq = (array) $this->modseq_get($deviceid, $folderid, $modseq_lasttime);
                 }
             } else {
                 $filter_str .= ' ' . $filter_item;
             }
         }
 
+        // get members of modified relations
+        if ($this->relationSupport) {
+            $changed_msgs = $this->getChangesByRelations($folderid, $deviceid, $type, $filter);
+        }
+
         $result = $result_type == kolab_sync_data::RESULT_COUNT ? 0 : ;
 
         $foldername = $this->folder_id2name($folderid, $deviceid);
@@ -1185,39 +1185,27 @@
             $this->storage->folder_sync($foldername);
         }
 
-        $modified = true;
         // We're in "get changes" mode
-        if ($getChangesMode) {
+        if (isset($modseq_data)) {
             $folder_data = $this->storage->folder_data($foldername);
+            $modified    = false;
 
-            // If HIGHESTMODSEQ doesn't exist we can't get changes
+            // If previous HIGHESTMODSEQ doesn't exist we can't get changes
+            // We can only get folder's HIGHESTMODSEQ value and store it for the next try
+            // Skip search if HIGHESTMODSEQ didn't change
             if (!empty($folder_data'HIGHESTMODSEQ')) {
-                // Store modseq for later in getExtraData
-                if (!array_key_exists($deviceid, $this->modseq)) {
-                    $this->modseq$deviceid = ;
-                }
-                $this->modseq$deviceid$folderid = $folder_data'HIGHESTMODSEQ';
-                // After the initial sync we have no extraData
-                if ($extraData) {
-                    $modseq_old = json_decode($extraData)->modseq;
-                    // Skip search if HIGHESTMODSEQ didn't change
-                    if ($folder_data'HIGHESTMODSEQ' == $modseq_old) {
-                        $modified = false;
-                    } else {
+                $modseq_data$foldername = $folder_data'HIGHESTMODSEQ';
+                $modseq_old = $modseq$foldername ?? null;
+                if ($modseq_data$foldername != $modseq_old) {
+                    $modseq_update = true;
+                    if (!empty($modseq) && $modseq_old) {
+                        $modified    = true;
                         $filter_str .= " MODSEQ " . ($modseq_old + 1);
                     }
-                } else {
-                    // If we don't have extra data we can't search for changes.
-                    // Either we are in initial sync, which means there are no changes to find,
-                    // or we are in the migration (no previous extraData), in which case we ignore changes for one sync key
-                    // because we don't have the means to search for the changes. Going forward we'll have the modseq info.
-                    $modified = false;
                 }
-            } else {
-                // We have no way of finding the changes.
-                // We could fall back to search by date or ignore changes, but both seems suboptimal.
-                throw new Syncroton_Exception_Status(Syncroton_Exception_Status::SERVER_ERROR);
             }
+        } else {
+            $modified = true;
         }
 
         // We could use messages cache by replacing search() with index()
@@ -1249,56 +1237,32 @@
             }
         }
 
-        // get members of modified relations
-        if ($this->relationSupport) {
-            $changed_msgs = $this->getChangesByRelations($folderid, $device_key, $type, $filter);
-            // handle relation changes
-            if (!empty($changed_msgs)) {
-                $members = $this->findRelationMembersInFolder($foldername, $changed_msgs, $filter);
-
-                switch ($result_type) {
-                    case kolab_sync_data::RESULT_COUNT:
-                        $result += count($members);
-                        break;
-
-                    case kolab_sync_data::RESULT_UID:
-                        $result = array_values(array_unique(array_merge($result, $members)));
-                        break;
-                }
-            }
-
-        }
-
-        return $result;
-    }
+        // handle relation changes
+        if (!empty($changed_msgs)) {
+            $members = $this->findRelationMembersInFolder($foldername, $changed_msgs, $filter);
 
+            switch ($result_type) {
+                case kolab_sync_data::RESULT_COUNT:
+                    $result += count($members);
+                    break;
 
-    /**
-     * Return extra data that is stored with the sync key and passed in during the search to find changes.
-     *
-     * @param string $folderid Folder identifier
-     * @param string $deviceid Device identifier
-     *
-     * @return string|null Extra data (JSON-encoded)
-     */
-    public function getExtraData($folderid, $deviceid)
-    {
-        //We explicitly return a cached value that was used during the search.
-        //Otherwise we'd risk storing a higher modseq value and missing an update.
-        if (isset($this->modseq$deviceid$folderid)) {
-            return json_encode('modseq' => intval($this->modseq$deviceid$folderid));
+                case kolab_sync_data::RESULT_UID:
+                    $result = array_values(array_unique(array_merge($result, $members)));
+                    break;
+            }
         }
 
-        //If we didn't fetch modseq in the first place we have to fetch it now.
-        $foldername = $this->folder_id2name($folderid, $deviceid);
-        if ($foldername !== null) {
-            $folder_data = $this->storage->folder_data($foldername);
-            if (!empty($folder_data'HIGHESTMODSEQ')) {
-                return json_encode('modseq' => intval($folder_data'HIGHESTMODSEQ'));
+        if (!empty($modseq_update) && !empty($modseq_data)) {
+            $this->modseq_set($deviceid, $folderid, $this->syncTimeStamp, $modseq_data);
+
+            // if previous modseq information does not exist save current set as it,
+            // we would at least be able to detect changes since now
+            if (empty($result) && empty($modseq)) {
+                $this->modseq_set($deviceid, $folderid, $modseq_lasttime ?? 0, $modseq_data);
             }
         }
 
-        return null;
+        return $result;
     }
 
     /**
@@ -1306,7 +1270,6 @@
      *
      * @param string $folderid    Folder identifier
      * @param string $deviceid    Device identifier
-     * @param string $device_key  Device primary key
      * @param string $type        Activesync model name (folder type)
      * @param array  $filter      Filter
      * @param int    $result_type Type of the result (see kolab_sync_data::RESULT_* constants)
@@ -1314,13 +1277,13 @@
      *
      * @return array|int Search result as count or array of uids
      */
-    protected function searchKolabEntries($folderid, $deviceid, $device_key, $type, $filter, $result_type, $force)
+    protected function searchKolabEntries($folderid, $deviceid, $type, $filter, $result_type, $force)
     {
         // there's a PHP Warning from kolab_storage if $filter isn't an array
         if (empty($filter)) {
             $filter = ;
         } elseif ($this->relationSupport && ($type == self::MODEL_TASKS || $type == self::MODEL_NOTES)) {
-            $changed_objects = $this->getChangesByRelations($folderid, $device_key, $type, $filter);
+            $changed_objects = $this->getChangesByRelations($folderid, $deviceid, $type, $filter);
         }
 
         $folder = $this->getFolder($folderid, $deviceid, $type);
@@ -1480,7 +1443,7 @@
      * Detect changes of relation (tag) objects data and assigned objects
      * Returns relation member identifiers
      */
-    protected function getChangesByRelations($folderid, $device_key, $type, $filter)
+    protected function getChangesByRelations($folderid, $deviceid, $type, $filter)
     {
         // get period filter, create new objects filter
         foreach ($filter as $f) {
@@ -1495,7 +1458,7 @@
         }
 
         // get relations state from the last sync
-        $last_state = (array) $this->relations_state_get($device_key, $folderid, $since);
+        $last_state = (array) $this->relations_state_get($deviceid, $folderid, $since);
 
         // get current relations state
         $config  = kolab_storage_config::get_instance();
@@ -1570,19 +1533,9 @@
                 ;
             }
 
-            // If the new and the old timestamp are the same our cache breaks.
-            // We must preserve the previous changes, because if this function is rerun we must detect the same changes again.
-            $sinceFormatted = $since->format('Y-m-d H:i:s');
-            if ($this->syncTimeStamp->format('Y-m-d H:i:s') == $sinceFormatted) {
-                // Preserve the previous timestamp (relations_state_get just checks the overflow bucket first)
-                // FIXME: The one caveat is that we will still update the database and thus overwrite the old entry.
-                // That means if we rerun the same request, the changes will not be detected
-                // => We should not be dealing with timestamps really.
-                $this->relations$folderid$sinceFormatted . "-1" = $this->relations$folderid$sinceFormatted ?? null;
-                $this->relations$folderid$sinceFormatted = null;
-            }
+            $now = new DateTime('now', new DateTimeZone('UTC'));
 
-            $this->relations_state_set($device_key, $folderid, $this->syncTimeStamp, $data);
+            $this->relations_state_set($deviceid, $folderid, $now, $data);
         }
 
         // in mail mode return only message URIs
@@ -1931,96 +1884,141 @@
     }
 
     /**
+     * Save MODSEQ value for a folder
+     */
+    protected function modseq_set($deviceid, $folderid, $synctime, $data)
+    {
+        $synctime = $synctime->format('Y-m-d H:i:s');
+        $rcube    = rcube::get_instance();
+        $db       = $rcube->get_dbh();
+        $old_data = $this->modseq$folderid$synctime ?? null;
+
+        if (empty($old_data)) {
+            $this->modseq$folderid$synctime = $data;
+            $data = json_encode($data);
+
+            $db->set_option('ignore_key_errors', true);
+            $db->query(
+                "INSERT INTO `syncroton_modseq` (`device_id`, `folder_id`, `synctime`, `data`)"
+                . " VALUES (?, ?, ?, ?)",
+                $deviceid,
+                $folderid,
+                $synctime,
+                $data
+            );
+            $db->set_option('ignore_key_errors', false);
+        }
+    }
+
+    /**
+     * Get stored MODSEQ value for a folder
+     */
+    protected function modseq_get($deviceid, $folderid, $synctime)
+    {
+        $synctime = $synctime->format('Y-m-d H:i:s');
+
+        if (empty($this->modseq$folderid$synctime)) {
+            $this->modseq$folderid = ;
+
+            $rcube = rcube::get_instance();
+            $db    = $rcube->get_dbh();
+
+            $db->limitquery(
+                "SELECT `data`, `synctime` FROM `syncroton_modseq`"
+                . " WHERE `device_id` = ? AND `folder_id` = ? AND `synctime` <= ?"
+                . " ORDER BY `synctime` DESC",
+                0,
+                1,
+                $deviceid,
+                $folderid,
+                $synctime
+            );
+
+            if ($row = $db->fetch_assoc()) {
+                $synctime = $row'synctime';
+                // @TODO: make sure synctime from sql is in "Y-m-d H:i:s" format
+                $this->modseq$folderid$synctime = json_decode($row'data', true);
+            }
+
+            // Cleanup: remove all records except the current one
+            $db->query(
+                "DELETE FROM `syncroton_modseq`"
+                . " WHERE `device_id` = ? AND `folder_id` = ? AND `synctime` <> ?",
+                $deviceid,
+                $folderid,
+                $synctime
+            );
+        }
+
+        return $this->modseq$folderid$synctime ?? null;
+    }
+
+    /**
      * Set state of relation objects at specified point in time
      */
-    public function relations_state_set($device_key, $folderid, $synctime, $relations)
+    public function relations_state_set($deviceid, $folderid, $synctime, $relations)
     {
         $synctime = $synctime->format('Y-m-d H:i:s');
+        $rcube    = rcube::get_instance();
+        $db       = $rcube->get_dbh();
+        $old_data = $this->relations$folderid$synctime ?? null;
 
-        // Protect against inserting the same values twice (this code can be executed twice in the same request)
-        if (!isset($this->relations$folderid$synctime)) {
-            $rcube    = rcube::get_instance();
-            $db       = $rcube->get_dbh();
+        if (empty($old_data)) {
             $this->relations$folderid$synctime = $relations;
             $data = rcube_charset::clean(json_encode($relations));
 
-            $result = $db->insert_or_update(
-                'syncroton_relations_state',
-                'device_id' => $device_key, 'folder_id' => $folderid, 'synctime' => $synctime,
-                'data',
-                $data
+            $db->set_option('ignore_key_errors', true);
+            $db->query(
+                "INSERT INTO `syncroton_relations_state`"
+                . " (`device_id`, `folder_id`, `synctime`, `data`)"
+                . " VALUES (?, ?, ?, ?)",
+                $deviceid,
+                $folderid,
+                $synctime,
+                $data
             );
-
-            if ($err = $db->is_error($result)) {
-                throw new Exception("Failed to save relation: {$err}");
-            }
+            $db->set_option('ignore_key_errors', false);
         }
     }
 
     /**
      * Get state of relation objects at specified point in time
      */
-    protected function relations_state_get($device_key, $folderid, $synctime)
+    protected function relations_state_get($deviceid, $folderid, $synctime)
     {
         $synctime = $synctime->format('Y-m-d H:i:s');
 
-        //If we had a collision before
-        if (isset($this->relations$folderid$synctime . "-1")) {
-            return $this->relations$folderid$synctime . "-1";
-        }
-        if (!isset($this->relations$folderid$synctime)) {
+        if (empty($this->relations$folderid$synctime)) {
+            $this->relations$folderid = ;
+
             $rcube = rcube::get_instance();
             $db    = $rcube->get_dbh();
 
             $db->limitquery(
                 "SELECT `data`, `synctime` FROM `syncroton_relations_state`"
-                . " WHERE `device_id` = ? AND `folder_id` = ? AND `synctime` < ?"
+                . " WHERE `device_id` = ? AND `folder_id` = ? AND `synctime` <= ?"
                 . " ORDER BY `synctime` DESC",
                 0,
                 1,
-                $device_key,
+                $deviceid,
                 $folderid,
                 $synctime
             );
-            $row = $db->fetch_assoc();
-            if (!$row) {
-                // Only if we don't have a timestamp that is older than synctime do we return the next best.
-                // We MUST return an entry if there are any, because otherwise we will keep INSERTing new entries in,
-                // relations_state_set
-                $db->limitquery(
-                    "SELECT `data`, `synctime` FROM `syncroton_relations_state`"
-                    . " WHERE `device_id` = ? AND `folder_id` = ?"
-                    . " ORDER BY `synctime` ASC",
-                    0,
-                    1,
-                    $device_key,
-                    $folderid,
-                    $synctime
-                );
-                $row = $db->fetch_assoc();
-            }
-
-            if ($row) {
-                // Don't use $row'synctime' for the internal cache.
-                // The synctime of the found row is usually earlier than the requested synctime.
-                // Note: We use internal cache because there's a call to both hasChanges() and
-                // getChangedEntries() in Sync. It's needed until we add some caching on a higher level.
-                $this->relations$folderid$synctime = json_decode($row'data', true);
 
-                // Cleanup: remove all records older than the current one.
-                // We must use the row's synctime, otherwise we would delete the record we just loaded
-                // We must delete all entries that are before the synctime to clean up old entries,
-                // but we must also delete all entries that are more recent in case the sync gets rerun
-                // with the same timestamp (e.g. when rerunning the same sync request).
-                // Otherwise the number of entries will start to grow with every sync.
-                $db->query(
-                    "DELETE FROM `syncroton_relations_state`"
-                    . " WHERE `device_id` = ? AND `folder_id` = ? AND `synctime` <> ?",
-                    $device_key,
-                    $folderid,
-                    $row'synctime'
-                );
+            if ($row = $db->fetch_assoc()) {
+                $synctime = $row'synctime';
+                // @TODO: make sure synctime from sql is in "Y-m-d H:i:s" format
+                $this->relations$folderid$synctime = json_decode($row'data', true);
             }
+
+            // Cleanup: remove all records except the current one
+            $db->query(
+                "DELETE FROM `syncroton_relations_state`"
+                . " WHERE `device_id` = ? AND `folder_id` = ? AND `synctime` <> ?",
+                $deviceid,
+                $folderid,
+                $synctime
+            );
         }
 
         return $this->relations$folderid$synctime ?? null;

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_storage_kolab4.php Changed

@@ -29,7 +29,7 @@
 class kolab_sync_storage_kolab4 extends kolab_sync_storage
 {
     protected $davStorage = null;
-    public $relationSupport = false;
+    protected $relationSupport = false;
 
     /**
      * This implements the 'singleton' design pattern
@@ -355,7 +355,7 @@
             'serverId'    => "DAV:{$type}:{$folder->id}",
             'parentId'    => 0, // TODO: Folder hierarchy
             'displayName' => $folder->get_name(),
-            'type'        => $this->type_kolab2activesync($folder->default ? "$type.default" : $type),
+            'type'        => $this->type_kolab2activesync($type),
         ;
     }
 
@@ -560,12 +560,4 @@
         // TODO: Subscribe personal DAV folders, for now we assume all are subscribed
         // TODO: Subscribe shared DAV folders
     }
-
-    public function getExtraData($folderid, $deviceid)
-    {
-        if (strpos($folderid, 'DAV:') === 0) {
-            return null;
-        }
-        return parent::getExtraData($folderid, $deviceid);
-    }
 }

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_timezone_converter.php Changed

kolab-syncroton-2.4.2.tar.gz/phpstan.neon Changed

kolab-syncroton-2.4.2.tar.gz/tests/Sync/FoldersTest.php Changed

@@ -3,230 +3,16 @@
 class FoldersTest extends Tests\SyncTestCase
 {
     /**
-     * Cleanup folders
+     * Test FolderSync command
      */
-    public function setUp(): void
+    public function testFolderSync()
     {
         // Note: We essentially assume the test account is in an initial state, extra folders may break tests
         // Anyway, we first remove folders that might have been created during tests in this file
         $this->deleteTestFolder('Test Folder', 'mail');
-        $this->deleteTestFolder('NewFolder', 'mail');
-        $this->deleteTestFolder('NewFolder2', 'mail');
         $this->deleteTestFolder('Test Folder New', 'mail');
         $this->deleteTestFolder('Test Contacts Folder', 'contact');
         $this->deleteTestFolder('Test Contacts New', 'contact');
-        parent::setUp();
-    }
-
-    /**
-     * Test FolderSync command
-     */
-    public function testFolderSyncBasic()
-    {
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <FolderSync xmlns="uri:FolderHierarchy">
-                <SyncKey>0</SyncKey>
-            </FolderSync>
-            EOF;
-
-        $response = $this->request($request, 'FolderSync');
-
-        $this->assertEquals(200, $response->getStatusCode());
-
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-
-        $this->assertSame('1', $xpath->query("//ns:FolderSync/ns:Status")->item(0)->nodeValue);
-        $this->assertSame('1', $xpath->query("//ns:FolderSync/ns:SyncKey")->item(0)->nodeValue);
-        // We expect some folders to exist (dont' know how many)
-        $this->assertTrue(intval($xpath->query("//ns:FolderSync/ns:Changes/ns:Count")->item(0)->nodeValue) > 2);
-
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <FolderSync xmlns="uri:FolderHierarchy">
-                <SyncKey>1</SyncKey>
-            </FolderSync>
-            EOF;
-
-        $response = $this->request($request, 'FolderSync');
-
-        $this->assertEquals(200, $response->getStatusCode());
-
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-
-        $this->assertSame('1', $xpath->query("//ns:FolderSync/ns:Status")->item(0)->nodeValue);
-        $this->assertSame('1', $xpath->query("//ns:FolderSync/ns:SyncKey")->item(0)->nodeValue);
-        // No changes on second sync
-        $this->assertSame(strval(0), $xpath->query("//ns:FolderSync/ns:Changes/ns:Count")->item(0)->nodeValue);
-
-
-        //Clear the creation_synckey (that's the migration scenario)
-        //Shouldn't trigger a change
-        $rcube = \rcube::get_instance();
-        $db    = $rcube->get_dbh();
-        $result = $db->query(
-            "UPDATE `syncroton_folder` SET `creation_synckey` = null",
-        );
-
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <FolderSync xmlns="uri:FolderHierarchy">
-                <SyncKey>1</SyncKey>
-            </FolderSync>
-            EOF;
-
-        $response = $this->request($request, 'FolderSync');
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        $this->printDom($dom);
-        $this->assertSame('1', $xpath->query("//ns:FolderSync/ns:Status")->item(0)->nodeValue);
-        $this->assertSame('1', $xpath->query("//ns:FolderSync/ns:SyncKey")->item(0)->nodeValue);
-        // No changes on second sync
-        $this->assertSame(strval(0), $xpath->query("//ns:FolderSync/ns:Changes/ns:Count")->item(0)->nodeValue);
-    }
-
-    /**
-     * Test invalid sync key
-     */
-    public function testFolderInvalidSyncKey()
-    {
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <FolderSync xmlns="uri:FolderHierarchy">
-                <SyncKey>999</SyncKey>
-            </FolderSync>
-            EOF;
-
-        $response = $this->request($request, 'FolderSync');
-
-        $this->assertEquals(200, $response->getStatusCode());
-
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-
-        $this->assertSame('9', $xpath->query("//ns:FolderSync/ns:Status")->item(0)->nodeValue);
-    }
-
-
-    /**
-     * Test synckey reuse
-     */
-    public function testSyncKeyResend()
-    {
-        $this->deleteTestFolder('NewFolder', 'mail');
-        $this->deleteTestFolder('NewFolder2', 'mail');
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <FolderSync xmlns="uri:FolderHierarchy">
-                <SyncKey>0</SyncKey>
-            </FolderSync>
-            EOF;
-        $response = $this->request($request, 'FolderSync');
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        $this->assertSame('1', $xpath->query("//ns:FolderSync/ns:Status")->item(0)->nodeValue);
-
-        //Now change something
-        $this->createTestFolder("NewFolder", "mail");
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <FolderSync xmlns="uri:FolderHierarchy">
-                <SyncKey>1</SyncKey>
-            </FolderSync>
-            EOF;
-
-        $response = $this->request($request, 'FolderSync');
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        $this->assertSame('1', $xpath->query("//ns:FolderSync/ns:Status")->item(0)->nodeValue);
-        $this->assertSame('2', $xpath->query("//ns:FolderSync/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame(strval(1), $xpath->query("//ns:FolderSync/ns:Changes/ns:Count")->item(0)->nodeValue);
-
-        //Resend the same synckey
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <FolderSync xmlns="uri:FolderHierarchy">
-                <SyncKey>1</SyncKey>
-            </FolderSync>
-            EOF;
-
-        $response = $this->request($request, 'FolderSync');
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        $this->assertSame('1', $xpath->query("//ns:FolderSync/ns:Status")->item(0)->nodeValue);
-        $this->assertSame('2', $xpath->query("//ns:FolderSync/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame(strval(1), $xpath->query("//ns:FolderSync/ns:Changes/ns:Count")->item(0)->nodeValue);
-
-        //And now make sure we can still move on
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <FolderSync xmlns="uri:FolderHierarchy">
-                <SyncKey>2</SyncKey>
-            </FolderSync>
-            EOF;
-        $response = $this->request($request, 'FolderSync');
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        $this->assertSame('1', $xpath->query("//ns:FolderSync/ns:Status")->item(0)->nodeValue);
-        $this->assertSame('2', $xpath->query("//ns:FolderSync/ns:SyncKey")->item(0)->nodeValue);
-
-        //Now add another folder
-        $this->createTestFolder("NewFolder2", "mail");
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <FolderSync xmlns="uri:FolderHierarchy">
-                <SyncKey>2</SyncKey>
-            </FolderSync>
-            EOF;
-        $response = $this->request($request, 'FolderSync');
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        $this->assertSame('1', $xpath->query("//ns:FolderSync/ns:Status")->item(0)->nodeValue);
-        $this->assertSame('3', $xpath->query("//ns:FolderSync/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame(strval(1), $xpath->query("//ns:FolderSync/ns:Changes/ns:Count")->item(0)->nodeValue);
-
-        //And finally make sure we can't go back two synckeys (because that has been cleaned up meanwhile)
-        $this->createTestFolder("NewFolder2", "mail");
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <FolderSync xmlns="uri:FolderHierarchy">
-                <SyncKey>1</SyncKey>
-            </FolderSync>
-            EOF;
-        $response = $this->request($request, 'FolderSync');
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        $this->assertSame('9', $xpath->query("//ns:FolderSync/ns:Status")->item(0)->nodeValue);
-
-        // Cleanup for the other tests
-        $this->deleteTestFolder('NewFolder', 'mail');
-        $this->deleteTestFolder('NewFolder2', 'mail');
-    }
-
-    /**
-     * Test FolderSync command
-     */
-    public function testFolderSync()
-    {
 
         $request = <<<EOF
             <?xml version="1.0" encoding="utf-8"?>
@@ -290,15 +76,15 @@
 
         if ($this->isStorageDriver('kolab4')) {
             $folders = 
-                'Calendar', Syncroton_Command_FolderSync::FOLDERTYPE_CALENDAR,
+                'Calendar', Syncroton_Command_FolderSync::FOLDERTYPE_CALENDAR_USER_CREATED,
                 // Note: Kolab 4 with Cyrus DAV uses Addressbook, but Kolab 3 with iRony would use 'Contacts'
-                '/^(Contacts|Addressbook)$/', Syncroton_Command_FolderSync::FOLDERTYPE_CONTACT,
+                '/^(Contacts|Addressbook)$/', Syncroton_Command_FolderSync::FOLDERTYPE_CONTACT_USER_CREATED,
                 'INBOX', Syncroton_Command_FolderSync::FOLDERTYPE_INBOX,
                 'Drafts', Syncroton_Command_FolderSync::FOLDERTYPE_DRAFTS,
                 'Sent', Syncroton_Command_FolderSync::FOLDERTYPE_SENTMAIL,
                 'Trash', Syncroton_Command_FolderSync::FOLDERTYPE_DELETEDITEMS,
                 // Note: For now Kolab 4 uses the same Calendar folder for calendar and tasks
-                '/^(Tasks|Calendar)$/', Syncroton_Command_FolderSync::FOLDERTYPE_TASK,
+                '/^(Tasks|Calendar)$/', Syncroton_Command_FolderSync::FOLDERTYPE_TASK_USER_CREATED,
             ;
         }

kolab-syncroton-2.4.2.tar.gz/tests/Sync/MoveItemsTest.php Changed

@@ -134,78 +134,14 @@
         $this->assertSame('test sync', $xpath->query("ns:Commands/ns:Add/ns:ApplicationData/Email:Subject", $root)->item(0)->nodeValue);
     }
 
-    public function testInvalidMove()
-    {
-        $this->emptyTestFolder('INBOX', 'mail');
-        $this->emptyTestFolder('Trash', 'mail');
-        $uid = $this->appendMail('INBOX', 'mail.sync1');
-        $this->registerDevice();
-        $inbox = array_search('INBOX', $this->folders);
-        $trash = array_search('Trash', $this->folders);
-
-        // Move item that doesn't exist
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <MoveItems xmlns="uri:Move">
-                <Move>
-                    <SrcMsgId>foobar::99999</SrcMsgId>
-                    <SrcFldId>foobar</SrcFldId>
-                    <DstFldId>foobar</DstFldId>
-                </Move>
-            </MoveItems>
-            EOF;
-
-        $response = $this->request($request, 'MoveItems');
-
-        $this->assertEquals(200, $response->getStatusCode());
-
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        $xpath->registerNamespace('Move', 'uri:Move');
-
-        $root = $xpath->query("//Move:MoveItems/Move:Response")->item(0);
-        $this->assertSame('1', $xpath->query("Move:Status", $root)->item(0)->nodeValue);
-
-        // Move item that doesn't exist
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <MoveItems xmlns="uri:Move">
-                <Move>
-                    <SrcMsgId>{$inbox}::99999</SrcMsgId>
-                    <SrcFldId>{$inbox}</SrcFldId>
-                    <DstFldId>{$trash}</DstFldId>
-                </Move>
-            </MoveItems>
-            EOF;
-
-        $response = $this->request($request, 'MoveItems');
-
-        $this->assertEquals(200, $response->getStatusCode());
-
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        $xpath->registerNamespace('Move', 'uri:Move');
-
-        $root = $xpath->query("//Move:MoveItems/Move:Response")->item(0);
-        $this->assertSame('1', $xpath->query("Move:Status", $root)->item(0)->nodeValue);
-    }
-
     /**
      * Test moving a contact
      */
     public function testMoveContact()
     {
-        if ($this->isStorageDriver('kolab')) {
-            // The Contacts folder is not available, and consequently appendObject fails
-            $this->markTestSkipped('This test only works with the DAV backend.');
-        }
-
         // Test with multi-folder support enabled
         self::$deviceType = 'iphone';
 
-        // @phpstan-ignore-next-line
         $davFolder = $this->isStorageDriver('kolab') ? 'Contacts' : 'Addressbook';
         $this->emptyTestFolder($davFolder, 'contact');
         $this->deleteTestFolder($folderName = 'Test Contacts Folder', 'contact');
@@ -214,7 +150,6 @@
         $this->registerDevice();
 
         $srcFolderId = array_search($davFolder, $this->folders);
-        $this->assertTrue(!empty($srcFolderId));
 
         // Create a contacts folder
         $folderType = Syncroton_Command_FolderSync::FOLDERTYPE_CONTACT_USER_CREATED;
@@ -261,8 +196,6 @@
         $response = $this->request($request, 'Sync');
 
         $this->assertEquals(200, $response->getStatusCode());
-        $root = $xpath->query("//ns:Sync/ns:Collections/ns:Collection")->item(0);
-        $this->assertSame('1', $xpath->query("ns:Status", $root)->item(0)->nodeValue);
 
         $request = <<<EOF
             <?xml version="1.0" encoding="utf-8"?>
@@ -309,7 +242,6 @@
         $xpath = $this->xpath($dom);
 
         $root = $xpath->query("//ns:Sync/ns:Collections/ns:Collection")->item(0);
-        $this->assertSame('1', $xpath->query("ns:Status", $root)->item(0)->nodeValue);
         $this->assertSame($srcFolderId, $xpath->query("ns:CollectionId", $root)->item(0)->nodeValue);
         $this->assertSame(1, $xpath->query("ns:Commands/ns:Add", $root)->count());
         $this->assertSame('Jane', $xpath->query("ns:Commands/ns:Add/ns:ApplicationData/Contacts:FirstName", $root)->item(0)->nodeValue);

kolab-syncroton-2.4.2.tar.gz/tests/Sync/OptionsTest.php Changed

kolab-syncroton-2.4.2.tar.gz/tests/Sync/PingTest.php Deleted

@@ -1,102 +0,0 @@
-<?php
-
-class PingTest extends Tests\SyncTestCase
-{
-
-    /**
-     * Test Ping command
-     */
-    public function testFolderSyncBasic()
-    {
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Ping xmlns="uri:Ping">
-                <HeartbeatInterval>900</HeartbeatInterval>
-                <Folders>
-                    <Folder>
-                        <Id>38b950ebd62cd9a66929c89615d0fc04</Id>
-                        <Class>Email</Class>
-                    </Folder>
-                </Folders>
-            </Ping>
-            EOF;
-
-        $response = $this->request($request, 'Ping');
-
-        $this->assertEquals(200, $response->getStatusCode());
-
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        $this->printDom($dom);
-
-        //Initially we know no folders
-        $this->assertSame('7', $xpath->query("//ns:Ping/ns:Status")->item(0)->nodeValue);
-
-
-        //We discover folders with a foldersync
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <FolderSync xmlns="uri:FolderHierarchy">
-                <SyncKey>0</SyncKey>
-            </FolderSync>
-            EOF;
-
-        $response = $this->request($request, 'FolderSync');
-        $this->assertEquals(200, $response->getStatusCode());
-
-        //Now we get to the actual ping
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Ping xmlns="uri:Ping">
-                <HeartbeatInterval>0</HeartbeatInterval>
-                <Folders>
-                    <Folder>
-                        <Id>38b950ebd62cd9a66929c89615d0fc04</Id>
-                        <Class>Email</Class>
-                    </Folder>
-                </Folders>
-            </Ping>
-            EOF;
-
-        $response = $this->request($request, 'Ping');
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        // $this->printDom($dom);
-        //Initially we know no folders
-        $this->assertSame('2', $xpath->query("//ns:Ping/ns:Status")->item(0)->nodeValue);
-    }
-
-    /**
-     * Test Ping command
-     */
-    public function testUnknownFolder()
-    {
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Ping xmlns="uri:Ping">
-                <HeartbeatInterval>900</HeartbeatInterval>
-                <Folders>
-                    <Folder>
-                        <Id>foobar</Id>
-                        <Class>Email</Class>
-                    </Folder>
-                </Folders>
-            </Ping>
-            EOF;
-
-        $response = $this->request($request, 'Ping');
-
-        $this->assertEquals(200, $response->getStatusCode());
-
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        // $this->printDom($dom);
-
-        $this->assertSame('7', $xpath->query("//ns:Ping/ns:Status")->item(0)->nodeValue);
-    }
-}

kolab-syncroton-2.4.2.tar.gz/tests/Sync/Sync/EmailExtraDataMigrationTest.php Deleted

@@ -1,115 +0,0 @@
-<?php
-
-namespace Tests\Sync\Sync;
-
-class EmailExtraDataMigrationTest extends \Tests\SyncTestCase
-{
-    /**
-     * Test Sync command
-     */
-    public function testSync()
-    {
-        $this->emptyTestFolder('INBOX', 'mail');
-        $this->registerDevice();
-
-
-        // Test INBOX
-        $folderId = '38b950ebd62cd9a66929c89615d0fc04';
-        $syncKey = 0;
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Sync xmlns="uri:AirSync">
-                <Collections>
-                    <Collection>
-                        <SyncKey>{$syncKey}</SyncKey>
-                        <CollectionId>{$folderId}</CollectionId>
-                    </Collection>
-                </Collections>
-            </Sync>
-            EOF;
-
-        $response = $this->request($request, 'Sync');
-        $this->assertEquals(200, $response->getStatusCode());
-        $syncKey++;
-
-        // List mail in INBOX
-        // Append two mail messages
-        $this->appendMail('INBOX', 'mail.sync1');
-        $this->appendMail('INBOX', 'mail.sync2');
-
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Sync xmlns="uri:AirSync" xmlns:AirSyncBase="uri:AirSyncBase">
-                <Collections>
-                    <Collection>
-                        <SyncKey>{$syncKey}</SyncKey>
-                        <CollectionId>{$folderId}</CollectionId>
-                        <DeletesAsMoves>1</DeletesAsMoves>
-                        <GetChanges>1</GetChanges>
-                        <Options>
-                            <FilterType>0</FilterType>
-                            <Conflict>1</Conflict>
-                            <BodyPreference xmlns="uri:AirSyncBase">
-                                <Type>2</Type>
-                                <TruncationSize>51200</TruncationSize>
-                                <AllOrNone>0</AllOrNone>
-                            </BodyPreference>
-                        </Options>
-                    </Collection>
-                </Collections>
-            </Sync>
-            EOF;
-
-        $response = $this->request($request, 'Sync');
-        $this->assertEquals(200, $response->getStatusCode());
-
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-
-        $root = "//ns:Sync/ns:Collections/ns:Collection";
-        $this->assertSame('1', $xpath->query("{$root}/ns:Status")->item(0)->nodeValue);
-        $this->assertSame(strval(++$syncKey), $xpath->query("{$root}/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame($folderId, $xpath->query("{$root}/ns:CollectionId")->item(0)->nodeValue);
-        $this->assertSame(2, $xpath->query("{$root}/ns:Commands/ns:Add")->count());
-
-        // Simulate migration by clearing extra_data
-        $this->runSQLQuery("UPDATE syncroton_synckey SET extra_data = null;");
-
-        // List the rest of the mail
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Sync xmlns="uri:AirSync" xmlns:AirSyncBase="uri:AirSyncBase">
-                <Collections>
-                    <Collection>
-                        <SyncKey>{$syncKey}</SyncKey>
-                        <CollectionId>{$folderId}</CollectionId>
-                        <DeletesAsMoves>1</DeletesAsMoves>
-                        <GetChanges>1</GetChanges>
-                        <Options>
-                            <FilterType>0</FilterType>
-                            <Conflict>1</Conflict>
-                            <BodyPreference xmlns="uri:AirSyncBase">
-                                <Type>2</Type>
-                                <TruncationSize>51200</TruncationSize>
-                                <AllOrNone>0</AllOrNone>
-                            </BodyPreference>
-                        </Options>
-                    </Collection>
-                </Collections>
-            </Sync>
-            EOF;
-
-        $response = $this->request($request, 'Sync');
-
-        $this->assertEquals(200, $response->getStatusCode());
-        // We expect an empty response without a change
-        $this->assertEquals(0, $response->getBody()->getSize());
-
-        return $syncKey;
-    }
-
-
-}

kolab-syncroton-2.4.2.tar.gz/tests/Sync/Sync/EmailITipTest.php Deleted

@@ -1,81 +0,0 @@
-<?php
-
-namespace Tests\Sync\Sync;
-
-class EmailITipTest extends \Tests\SyncTestCase
-{
-    /**
-     * Test Sync with invalid itip
-     */
-    public function testSyncWithInvalidITip()
-    {
-        $this->emptyTestFolder('INBOX', 'mail');
-        $this->registerDevice();
-
-        // Test INBOX
-        $folderId = '38b950ebd62cd9a66929c89615d0fc04';
-        $syncKey = 0;
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Sync xmlns="uri:AirSync">
-                <Collections>
-                    <Collection>
-                        <SyncKey>{$syncKey}</SyncKey>
-                        <CollectionId>{$folderId}</CollectionId>
-                    </Collection>
-                </Collections>
-            </Sync>
-            EOF;
-
-        $response = $this->request($request, 'Sync');
-        $this->assertEquals(200, $response->getStatusCode());
-        $syncKey++;
-
-        // Append messages
-        $this->appendMail('INBOX', 'mail.itip1');
-        $this->appendMail('INBOX', 'mail.itip.invalid');
-        $this->appendMail('INBOX', 'mail.sync2');
-
-        // Test that the synchornization works with the invalid itip in the middle
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Sync xmlns="uri:AirSync" xmlns:AirSyncBase="uri:AirSyncBase">
-                <Collections>
-                    <Collection>
-                        <SyncKey>{$syncKey}</SyncKey>
-                        <CollectionId>{$folderId}</CollectionId>
-                        <DeletesAsMoves>1</DeletesAsMoves>
-                        <GetChanges>1</GetChanges>
-                        <Options>
-                            <FilterType>0</FilterType>
-                            <Conflict>1</Conflict>
-                            <BodyPreference xmlns="uri:AirSyncBase">
-                                <Type>2</Type>
-                                <TruncationSize>51200</TruncationSize>
-                                <AllOrNone>0</AllOrNone>
-                            </BodyPreference>
-                        </Options>
-                    </Collection>
-                </Collections>
-            </Sync>
-            EOF;
-
-        $response = $this->request($request, 'Sync');
-
-        $this->assertEquals(200, $response->getStatusCode());
-
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-
-        // print($dom->saveXML());
-
-        $root = "//ns:Sync/ns:Collections/ns:Collection";
-        $this->assertSame('1', $xpath->query("{$root}/ns:Status")->item(0)->nodeValue);
-        $this->assertSame(strval(++$syncKey), $xpath->query("{$root}/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame($folderId, $xpath->query("{$root}/ns:CollectionId")->item(0)->nodeValue);
-        // We expect all three messages to synchronize, even if we fail to parse the invitation in the middle
-        $this->assertSame(3, $xpath->query("{$root}/ns:Commands/ns:Add")->count());
-    }
-}

kolab-syncroton-2.4.2.tar.gz/tests/Sync/Sync/EmailTest.php Changed

@@ -153,221 +153,18 @@
         $root .= "/ns:Commands/ns:Add";
         $this->assertStringMatchesFormat("{$folderId}::%d", $xpath->query("{$root}/ns:ServerId")->item(0)->nodeValue);
         $this->assertSame('sync test with attachment', $xpath->query("{$root}/ns:ApplicationData/Email:Subject")->item(0)->nodeValue);
-        $this->assertSame(1, $xpath->query("{$root}/ns:ApplicationData/AirSyncBase:Body")->count());
 
         return $syncKey;
     }
 
     /**
-     * Test empty sync response
-     *
-     * @depends testSync
-     */
-    public function testEmptySync($syncKey)
-    {
-        $folderId = '38b950ebd62cd9a66929c89615d0fc04';
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Sync xmlns="uri:AirSync" xmlns:AirSyncBase="uri:AirSyncBase">
-                <Collections>
-                    <Collection>
-                        <SyncKey>{$syncKey}</SyncKey>
-                        <CollectionId>{$folderId}</CollectionId>
-                        <DeletesAsMoves>1</DeletesAsMoves>
-                        <GetChanges>1</GetChanges>
-                        <Options>
-                            <FilterType>0</FilterType>
-                            <Conflict>1</Conflict>
-                            <BodyPreference xmlns="uri:AirSyncBase">
-                                <Type>2</Type>
-                                <TruncationSize>51200</TruncationSize>
-                                <AllOrNone>0</AllOrNone>
-                            </BodyPreference>
-                        </Options>
-                    </Collection>
-                </Collections>
-            </Sync>
-            EOF;
-
-        $response = $this->request($request, 'Sync');
-
-        $this->assertEquals(200, $response->getStatusCode());
-        // We expect an empty response without a change
-        $this->assertEquals(0, $response->getBody()->getSize());
-
-        return $syncKey;
-    }
-
-    /**
-     * Test flag change
-     *
-     * @depends testEmptySync
-     */
-    public function testFlagChange($syncKey)
-    {
-        $this->assertTrue($this->markMailAsRead('INBOX', '*'));
-
-        $folderId = '38b950ebd62cd9a66929c89615d0fc04';
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Sync xmlns="uri:AirSync" xmlns:AirSyncBase="uri:AirSyncBase">
-                <Collections>
-                    <Collection>
-                        <SyncKey>{$syncKey}</SyncKey>
-                        <CollectionId>{$folderId}</CollectionId>
-                        <DeletesAsMoves>1</DeletesAsMoves>
-                        <GetChanges>1</GetChanges>
-                        <Options>
-                            <FilterType>0</FilterType>
-                            <Conflict>1</Conflict>
-                            <BodyPreference xmlns="uri:AirSyncBase">
-                                <Type>2</Type>
-                                <TruncationSize>51200</TruncationSize>
-                                <AllOrNone>0</AllOrNone>
-                            </BodyPreference>
-                        </Options>
-                    </Collection>
-                </Collections>
-            </Sync>
-            EOF;
-
-        $response = $this->request($request, 'Sync');
-
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        // print($dom->saveXML());
-
-        $root = "//ns:Sync/ns:Collections/ns:Collection";
-        $this->assertSame('1', $xpath->query("{$root}/ns:Status")->item(0)->nodeValue);
-        $this->assertSame(strval(++$syncKey), $xpath->query("{$root}/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame($folderId, $xpath->query("{$root}/ns:CollectionId")->item(0)->nodeValue);
-        $this->assertSame(0, $xpath->query("{$root}/ns:Commands/ns:Add")->count());
-        $this->assertSame(2, $xpath->query("{$root}/ns:Commands/ns:Change")->count());
-        $this->assertSame(2, $xpath->query("{$root}/ns:Commands/ns:Change/ns:ApplicationData/Email:Read")->count());
-        $this->assertSame('0', $xpath->query("{$root}/ns:Commands/ns:Change/ns:ApplicationData/Email:Read")->item(0)->nodeValue);
-        $this->assertSame('0', $xpath->query("{$root}/ns:Commands/ns:Change/ns:ApplicationData/Email:Read")->item(1)->nodeValue);
-
-        $this->assertSame(0, $xpath->query("{$root}/ns:Commands/ns:Change/ns:ApplicationData/AirSyncBase:Body")->count());
-        return $syncKey;
-    }
-
-    /**
-     * Retry flag change
-     * Resending the same syncKey should result in the same changes.
-     *
-     * @depends testFlagChange
-     */
-    public function testRetryFlagChange($syncKey)
-    {
-        $syncKey--;
-        $folderId = '38b950ebd62cd9a66929c89615d0fc04';
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Sync xmlns="uri:AirSync" xmlns:AirSyncBase="uri:AirSyncBase">
-                <Collections>
-                    <Collection>
-                        <SyncKey>{$syncKey}</SyncKey>
-                        <CollectionId>{$folderId}</CollectionId>
-                        <DeletesAsMoves>1</DeletesAsMoves>
-                        <GetChanges>1</GetChanges>
-                        <Options>
-                            <FilterType>0</FilterType>
-                            <Conflict>1</Conflict>
-                            <BodyPreference xmlns="uri:AirSyncBase">
-                                <Type>2</Type>
-                                <TruncationSize>51200</TruncationSize>
-                                <AllOrNone>0</AllOrNone>
-                            </BodyPreference>
-                        </Options>
-                    </Collection>
-                </Collections>
-            </Sync>
-            EOF;
-
-        $response = $this->request($request, 'Sync');
-
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        // print($dom->saveXML());
-
-        $root = "//ns:Sync/ns:Collections/ns:Collection";
-        $this->assertSame('1', $xpath->query("{$root}/ns:Status")->item(0)->nodeValue);
-        //FIXME I'm not sure why we get syncKey + 2, I suppose we just always increase the current synckey by one.
-        $this->assertSame(strval($syncKey += 2), $xpath->query("{$root}/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame($folderId, $xpath->query("{$root}/ns:CollectionId")->item(0)->nodeValue);
-        $this->assertSame(0, $xpath->query("{$root}/ns:Commands/ns:Add")->count());
-        $this->assertSame(2, $xpath->query("{$root}/ns:Commands/ns:Change")->count());
-
-        $serverId1 = $xpath->query("{$root}/ns:Commands/ns:Change/ns:ServerId")->item(0)->nodeValue;
-
-        return 
-            'syncKey' => $syncKey,
-            'serverId' => $serverId1,
-        ;
-    }
-
-    /**
      * Test updating message properties from client
      *
-     * @depends testRetryFlagChange
+     * @depends testSync
      */
-    public function testChangeFromClient($values)
+    public function testChangeFromClient($syncKey)
     {
-        $folderId = '38b950ebd62cd9a66929c89615d0fc04';
-        $syncKey = $values'syncKey';
-        $serverId = $values'serverId';
-
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Sync xmlns="uri:AirSync" xmlns:Syncroton="uri:Syncroton" xmlns:AirSyncBase="uri:AirSyncBase" xmlns:Email="uri:Email" xmlns:Email2="uri:Email2" xmlns:Tasks="uri:Tasks">
-                <Collections>
-                    <Collection xmlns:default="uri:Email" xmlns:default1="uri:AirSyncBase">
-                        <SyncKey>{$syncKey}</SyncKey>
-                        <CollectionId>{$folderId}</CollectionId>
-                        <Commands xmlns:default="uri:Email" xmlns:default1="uri:AirSyncBase">
-                            <Change xmlns:default="uri:Email" xmlns:default1="uri:AirSyncBase">
-                                <ServerId>{$serverId}</ServerId>
-                                <ApplicationData>
-                                    <Email:Read xmlns="uri:Email">0</Email:Read>
-                                    <Email:Flag xmlns="uri:Email"/>
-                                </ApplicationData>
-                            </Change>
-                        </Commands>
-                    </Collection>
-                </Collections>
-            </Sync>
-            EOF;
-
-        $response = $this->request($request, 'Sync');
-
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        // print($dom->saveXML());
-
-        $root = "//ns:Sync/ns:Collections/ns:Collection";
-        $this->assertSame('1', $xpath->query("{$root}/ns:Status")->item(0)->nodeValue);
-        $this->assertSame(strval(++$syncKey), $xpath->query("{$root}/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame($folderId, $xpath->query("{$root}/ns:CollectionId")->item(0)->nodeValue);
-        $this->assertSame(0, $xpath->query("{$root}/ns:Commands/ns:Add")->count());
-        //The server doesn't have to report back successful changes
-        $this->assertSame(0, $xpath->query("{$root}/ns:Commands/ns:Change")->count());
-
-        $emails = $this->listEmails('INBOX', '*');
-        $uid = explode("::", $serverId)1;
-        $this->assertSame(2, count($emails));
-        $this->assertTrue(!array_key_exists('SEEN', $emails$uid));
-
-        return 
-            'syncKey' => $syncKey,
-            'serverId' => $serverId,
-        ;
+        $this->markTestIncomplete();
     }
 
     /**
@@ -375,99 +172,8 @@
      *
      * @depends testChangeFromClient
      */
-    public function testDeleteFromClient($values)
+    public function testDeleteFromClient($syncKey)
     {
-        $folderId = '38b950ebd62cd9a66929c89615d0fc04';
-        $syncKey = $values'syncKey';
-        $serverId = $values'serverId';
-
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Sync xmlns="uri:AirSync" xmlns:Syncroton="uri:Syncroton" xmlns:AirSyncBase="uri:AirSyncBase" xmlns:Email="uri:Email" xmlns:Email2="uri:Email2" xmlns:Tasks="uri:Tasks">
-                <Collections>
-                    <Collection xmlns:default="uri:Email" xmlns:default1="uri:AirSyncBase">
-                        <SyncKey>{$syncKey}</SyncKey>
-                        <CollectionId>{$folderId}</CollectionId>
-                        <Commands xmlns:default="uri:Email" xmlns:default1="uri:AirSyncBase">
-                            <Delete xmlns:default="uri:Email" xmlns:default1="uri:AirSyncBase">
-                                <ServerId>{$serverId}</ServerId>
-                            </Delete>
-                        </Commands>
-                    </Collection>
-                </Collections>
-            </Sync>
-            EOF;
-
-        $response = $this->request($request, 'Sync');
-
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        // print($dom->saveXML());
-
-        $root = "//ns:Sync/ns:Collections/ns:Collection";
-        $this->assertSame('1', $xpath->query("{$root}/ns:Status")->item(0)->nodeValue);
-        $this->assertSame(strval(++$syncKey), $xpath->query("{$root}/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame($folderId, $xpath->query("{$root}/ns:CollectionId")->item(0)->nodeValue);
-        $this->assertSame(0, $xpath->query("{$root}/ns:Commands/ns:Add")->count());
-        $this->assertSame(0, $xpath->query("{$root}/ns:Commands/ns:Change")->count());
-        $this->assertSame(0, $xpath->query("{$root}/ns:Commands/ns:Delete")->count());
-
-        $emails = $this->listEmails('INBOX', '*');
-        $uid = explode("::", $serverId)1;
-        $this->assertSame(2, count($emails));
-        $this->assertTrue($emails$uid'DELETED');
-
-        return $syncKey;
+        $this->markTestIncomplete();
     }
-
-
-    /**
-    * Test a sync key that doesn't exist yet.
-    * @depends testDeleteFromClient
-    */
-    public function testInvalidSyncKey($syncKey)
-    {
-        $syncKey++;
-        $folderId = '38b950ebd62cd9a66929c89615d0fc04';
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Sync xmlns="uri:AirSync" xmlns:AirSyncBase="uri:AirSyncBase">
-                <Collections>
-                    <Collection>
-                        <SyncKey>{$syncKey}</SyncKey>
-                        <CollectionId>{$folderId}</CollectionId>
-                        <DeletesAsMoves>1</DeletesAsMoves>
-                        <GetChanges>1</GetChanges>
-                        <Options>
-                            <FilterType>0</FilterType>
-                            <Conflict>1</Conflict>
-                            <BodyPreference xmlns="uri:AirSyncBase">
-                                <Type>2</Type>
-                                <TruncationSize>51200</TruncationSize>
-                                <AllOrNone>0</AllOrNone>
-                            </BodyPreference>
-                        </Options>
-                    </Collection>
-                </Collections>
-            </Sync>
-            EOF;
-
-        $response = $this->request($request, 'Sync');
-
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        // print($dom->saveXML());
-
-        $root = "//ns:Sync/ns:Collections/ns:Collection";
-        $this->assertSame('3', $xpath->query("{$root}/ns:Status")->item(0)->nodeValue);
-        $this->assertSame('0', $xpath->query("{$root}/ns:SyncKey")->item(0)->nodeValue);
-
-        //We have to start over after this. The sync state was removed.
-        return 0;
-    }
-
 }

kolab-syncroton-2.4.2.tar.gz/tests/Sync/Sync/InconsistencyTest.php Deleted

@@ -1,146 +0,0 @@
-<?php
-
-namespace Tests\Sync\Sync;
-
-class InconsistencyTest extends \Tests\SyncTestCase
-{
-    /**
-     * Test Sync command
-     */
-    public function testSync()
-    {
-        $this->emptyTestFolder('INBOX', 'mail');
-        $this->registerDevice();
-
-        // Append two mail messages
-        $uid1 = $this->appendMail('INBOX', 'mail.sync1');
-        $this->appendMail('INBOX', 'mail.sync2');
-
-        // Initial sync
-        $folderId = '38b950ebd62cd9a66929c89615d0fc04';
-        $syncKey = 0;
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Sync xmlns="uri:AirSync">
-                <Collections>
-                    <Collection>
-                        <SyncKey>{$syncKey}</SyncKey>
-                        <CollectionId>{$folderId}</CollectionId>
-                    </Collection>
-                </Collections>
-            </Sync>
-            EOF;
-
-        $response = $this->request($request, 'Sync');
-        $this->assertEquals(200, $response->getStatusCode());
-        $syncKey++;
-
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Sync xmlns="uri:AirSync" xmlns:AirSyncBase="uri:AirSyncBase">
-                <Collections>
-                    <Collection>
-                        <SyncKey>{$syncKey}</SyncKey>
-                        <CollectionId>{$folderId}</CollectionId>
-                        <DeletesAsMoves>1</DeletesAsMoves>
-                        <GetChanges>1</GetChanges>
-                        <WindowSize>2</WindowSize>
-                        <Options>
-                            <FilterType>0</FilterType>
-                            <Conflict>1</Conflict>
-                            <BodyPreference xmlns="uri:AirSyncBase">
-                                <Type>2</Type>
-                                <TruncationSize>51200</TruncationSize>
-                                <AllOrNone>0</AllOrNone>
-                            </BodyPreference>
-                        </Options>
-                    </Collection>
-                </Collections>
-            </Sync>
-            EOF;
-
-        $response = $this->request($request, 'Sync');
-
-        $this->assertEquals(200, $response->getStatusCode());
-
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-
-        $root = "//ns:Sync/ns:Collections/ns:Collection";
-        $this->assertSame('1', $xpath->query("{$root}/ns:Status")->item(0)->nodeValue);
-        $this->assertSame(strval(++$syncKey), $xpath->query("{$root}/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame($folderId, $xpath->query("{$root}/ns:CollectionId")->item(0)->nodeValue);
-        $this->assertSame(2, $xpath->query("{$root}/ns:Commands/ns:Add")->count());
-
-        // Initial sync is complete
-        // We now artifically create a sync inconsistency be deleting the content part of the first mail.
-        // This replicates a situation that we've seen, but don't know yet how it was created in the first place.
-        $rcube = \rcube::get_instance();
-        $db    = $rcube->get_dbh();
-        $result = $db->query(
-            "DELETE FROM `syncroton_content`"
-            . " WHERE `contentid` = ?",
-            "$folderId::$uid1"
-        );
-        $this->assertNull($db->is_error($result));
-
-        // Now sync again
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Sync xmlns="uri:AirSync" xmlns:AirSyncBase="uri:AirSyncBase">
-                <Collections>
-                    <Collection>
-                        <SyncKey>{$syncKey}</SyncKey>
-                        <CollectionId>{$folderId}</CollectionId>
-                        <DeletesAsMoves>1</DeletesAsMoves>
-                        <GetChanges>1</GetChanges>
-                        <Options>
-                            <FilterType>0</FilterType>
-                            <Conflict>1</Conflict>
-                            <BodyPreference xmlns="uri:AirSyncBase">
-                                <Type>2</Type>
-                                <TruncationSize>51200</TruncationSize>
-                                <AllOrNone>0</AllOrNone>
-                            </BodyPreference>
-                        </Options>
-                    </Collection>
-                </Collections>
-            </Sync>
-            EOF;
-
-        $response = $this->request($request, 'Sync');
-
-        $this->assertEquals(200, $response->getStatusCode());
-
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-
-        $root = "//ns:Sync/ns:Collections/ns:Collection";
-        $this->assertSame('1', $xpath->query("{$root}/ns:Status")->item(0)->nodeValue);
-        $this->assertSame(strval(++$syncKey), $xpath->query("{$root}/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame($folderId, $xpath->query("{$root}/ns:CollectionId")->item(0)->nodeValue);
-        $this->assertSame(1, $xpath->query("{$root}/ns:Commands/ns:Add")->count());
-
-
-        //Assert that we have all content parts back
-        $sync = \kolab_sync::get_instance();
-        $device = $sync->storage()->device_get(self::$deviceId);
-
-        $result = $db->query(
-            "SELECT `contentid` FROM `syncroton_content`"
-            . " WHERE `device_id` = ?",
-            $device'ID'
-        );
-        $data = ;
-        while ($state = $db->fetch_assoc($result)) {
-            $data = $state;
-        }
-        $this->assertSame(2, count($data));
-
-        return $syncKey;
-    }
-
-}

kolab-syncroton-2.4.2.tar.gz/tests/Sync/Sync/RelationsTest.php Deleted

@@ -1,279 +0,0 @@
-<?php
-
-namespace Tests\Sync\Sync;
-
-class RelationsTest extends \Tests\SyncTestCase
-{
-    protected function initialSyncRequest($folderId)
-    {
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Sync xmlns="uri:AirSync">
-                <Collections>
-                    <Collection>
-                        <SyncKey>0</SyncKey>
-                        <CollectionId>{$folderId}</CollectionId>
-                    </Collection>
-                </Collections>
-            </Sync>
-            EOF;
-        return $this->request($request, 'Sync');
-    }
-
-    protected function syncRequest($syncKey, $folderId, $windowSize = null)
-    {
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Sync xmlns="uri:AirSync" xmlns:AirSyncBase="uri:AirSyncBase">
-                <Collections>
-                    <Collection>
-                        <SyncKey>{$syncKey}</SyncKey>
-                        <CollectionId>{$folderId}</CollectionId>
-                        <DeletesAsMoves>1</DeletesAsMoves>
-                        <GetChanges>1</GetChanges>
-                        <WindowSize>{$windowSize}</WindowSize>
-                        <Options>
-                            <FilterType>0</FilterType>
-                            <Conflict>1</Conflict>
-                            <BodyPreference xmlns="uri:AirSyncBase">
-                                <Type>2</Type>
-                                <TruncationSize>51200</TruncationSize>
-                                <AllOrNone>0</AllOrNone>
-                            </BodyPreference>
-                        </Options>
-                    </Collection>
-                </Collections>
-            </Sync>
-            EOF;
-        return $this->request($request, 'Sync');
-    }
-
-    private function getRelationsState($device_id, $folderId)
-    {
-        $db    = \rcube::get_instance()->get_dbh();
-        $result = $db->query(
-            "SELECT `data`, `synctime` FROM `syncroton_relations_state`"
-            . " WHERE `device_id` = ? AND `folder_id` = ?"
-            . " ORDER BY `synctime` DESC",
-            $device_id,
-            $folderId
-        );
-        $data = ;
-        while ($state = $db->fetch_assoc($result)) {
-            $data = $state;
-        }
-        return $data;
-    }
-
-    /**
-     * Test Sync command
-     */
-    public function testRelationsSync()
-    {
-        $sync = \kolab_sync::get_instance();
-        if (!$sync->storage()->relationSupport) {
-            $this->markTestSkipped('No relation support');
-        }
-
-        $this->emptyTestFolder('INBOX', 'mail');
-        $this->emptyTestFolder('Configuration', 'configuration');
-        $this->registerDevice();
-
-        // Test INBOX
-        $folderId = '38b950ebd62cd9a66929c89615d0fc04';
-        $syncKey = 0;
-        $response = $this->initialSyncRequest($folderId);
-        $this->assertEquals(200, $response->getStatusCode());
-
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-
-        $this->assertSame('1', $xpath->query("//ns:Sync/ns:Collections/ns:Collection/ns:Status")->item(0)->nodeValue);
-        $this->assertSame(strval(++$syncKey), $xpath->query("//ns:Sync/ns:Collections/ns:Collection/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame('Email', $xpath->query("//ns:Sync/ns:Collections/ns:Collection/ns:Class")->item(0)->nodeValue);
-        $this->assertSame($folderId, $xpath->query("//ns:Sync/ns:Collections/ns:Collection/ns:CollectionId")->item(0)->nodeValue);
-
-        // First we append
-        $uid1 = $this->appendMail('INBOX', 'mail.sync1');
-        $uid2 = $this->appendMail('INBOX', 'mail.sync2');
-        $this->appendMail('INBOX', 'mail.sync1', 'sync1' => 'sync3');
-        $this->appendMail('INBOX', 'mail.sync1', 'sync1' => 'sync4');
-
-        $sync = \kolab_sync::get_instance();
-
-        $device = $sync->storage()->device_get(self::$deviceId);
-
-        //Add a tag
-        $sync->storage()->updateItem($folderId, $device'ID', \kolab_sync_storage::MODEL_EMAIL, $uid1, null, 'categories' => 'test1');
-        sleep(1);
-
-        $response = $this->syncRequest($syncKey, $folderId, 10);
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        $root = "//ns:Sync/ns:Collections/ns:Collection";
-        $this->assertSame('1', $xpath->query("{$root}/ns:Status")->item(0)->nodeValue);
-        $this->assertSame(strval(++$syncKey), $xpath->query("{$root}/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame($folderId, $xpath->query("{$root}/ns:CollectionId")->item(0)->nodeValue);
-        $this->assertSame(4, $xpath->query("{$root}/ns:Commands/ns:Add")->count());
-
-        $root .= "/ns:Commands/ns:Add";
-        $this->assertSame(1, $xpath->query("{$root}/ns:ApplicationData/Email:Categories")->count());
-        $this->assertSame("test1", $xpath->query("{$root}/ns:ApplicationData/Email:Categories")->item(0)->nodeValue);
-
-        //Add a second tag
-        $sync->storage()->updateItem($folderId, $device'ID', \kolab_sync_storage::MODEL_EMAIL, $uid1, null, 'categories' => 'test1', 'test2');
-        sleep(1); // Necessary to make sure we pick up on the tag.
-
-        $response = $this->syncRequest($syncKey, $folderId, 10);
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-
-        $root = "//ns:Sync/ns:Collections/ns:Collection";
-        $this->assertSame('1', $xpath->query("{$root}/ns:Status")->item(0)->nodeValue);
-        $this->assertSame(strval(++$syncKey), $xpath->query("{$root}/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame($folderId, $xpath->query("{$root}/ns:CollectionId")->item(0)->nodeValue);
-        $this->assertSame(0, $xpath->query("{$root}/ns:Commands/ns:Add")->count());
-        $this->assertSame(1, $xpath->query("{$root}/ns:Commands/ns:Change")->count());
-        $root .= "/ns:Commands/ns:Change";
-        $this->assertSame(1, $xpath->query("{$root}/ns:ApplicationData/Email:Categories")->count());
-        //FIXME not sure what I'm doing wrong, but the xml looks ok
-        $this->assertSame("test1test2", $xpath->query("{$root}/ns:ApplicationData/Email:Categories")->item(0)->nodeValue);
-
-        $retries = 2;
-        $syncKey--;
-        // Rerun the same command and make sure we get the same result
-        for ($i = 0; $i < $retries; $i++) {
-            $response = $this->syncRequest($syncKey, $folderId, 10);
-            $this->assertEquals(200, $response->getStatusCode());
-            $dom = $this->fromWbxml($response->getBody());
-            $xpath = $this->xpath($dom);
-
-            $root = "//ns:Sync/ns:Collections/ns:Collection";
-            $this->assertSame('1', $xpath->query("{$root}/ns:Status")->item(0)->nodeValue);
-            $this->assertSame($folderId, $xpath->query("{$root}/ns:CollectionId")->item(0)->nodeValue);
-            $this->assertSame(0, $xpath->query("{$root}/ns:Commands/ns:Add")->count());
-            $this->assertSame(1, $xpath->query("{$root}/ns:Commands/ns:Change")->count());
-            $root .= "/ns:Commands/ns:Change";
-            $this->assertSame(1, $xpath->query("{$root}/ns:ApplicationData/Email:Categories")->count());
-            //FIXME not sure what I'm doing wrong, but the xml looks ok
-            $this->assertSame("test1test2", $xpath->query("{$root}/ns:ApplicationData/Email:Categories")->item(0)->nodeValue);
-
-            // Assert the db state
-            $this->assertSame(2, count($this->getRelationsState($device'ID', $folderId)));
-            // Make sure we have a new timestamp after the first iteration.
-            // This way we can potentially catch errors when we end up using the same or a different timestamp.
-            sleep(1);
-        }
-        $syncKey += ($retries + 1);
-
-        // Reset to no tags
-        $sync->storage()->updateItem($folderId, $device'ID', \kolab_sync_storage::MODEL_EMAIL, $uid1, null, 'categories' => );
-        sleep(1); // Necessary to make sure we pick up on the tag.
-
-        $response = $this->syncRequest($syncKey, $folderId, 10);
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-
-        $root = "//ns:Sync/ns:Collections/ns:Collection";
-        $this->assertSame('1', $xpath->query("{$root}/ns:Status")->item(0)->nodeValue);
-        $this->assertSame(strval(++$syncKey), $xpath->query("{$root}/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame($folderId, $xpath->query("{$root}/ns:CollectionId")->item(0)->nodeValue);
-        $this->assertSame(0, $xpath->query("{$root}/ns:Commands/ns:Add")->count());
-        $this->assertSame(1, $xpath->query("{$root}/ns:Commands/ns:Change")->count());
-        $root .= "/ns:Commands/ns:Change";
-        $this->assertSame(0, $xpath->query("{$root}/ns:ApplicationData/Email:Categories")->count());
-        //FIXME this currently fails because we omit the empty categories element
-        // $this->assertSame("", $xpath->query("{$root}/ns:ApplicationData/Email:Categories")->item(0)->nodeValue);
-
-
-        // Assert the db state
-        $this->assertSame(2, count($this->getRelationsState($device'ID', $folderId)));
-
-        $response = $this->syncRequest($syncKey, $folderId, 10);
-        $this->assertEquals(200, $response->getStatusCode());
-        // We expect an empty response without a change
-        $this->assertEquals(0, $response->getBody()->getSize());
-        // print($dom->saveXML());
-
-        return $syncKey;
-    }
-
-    public function testPing()
-    {
-        // Setup with a tag and an initial sync completed
-        $folderId = '38b950ebd62cd9a66929c89615d0fc04';
-        $sync = \kolab_sync::get_instance();
-        $device = $sync->storage()->device_get(self::$deviceId);
-
-        $uid1 = $this->appendMail('INBOX', 'mail.sync1');
-        $sync->storage()->updateItem($folderId, $device'ID', \kolab_sync_storage::MODEL_EMAIL, $uid1, null, 'categories' => 'test1');
-        sleep(1);
-
-        $response = $this->syncRequest(0, $folderId, 10);
-        $this->assertEquals(200, $response->getStatusCode());
-        $response = $this->syncRequest(1, $folderId, 10);
-        $this->assertEquals(200, $response->getStatusCode());
-
-
-        $this->assertSame(2, count($this->getRelationsState($device'ID', $folderId)));
-
-        // Make sure the timestamp changes
-        sleep(1);
-
-        // Pings should not change the number of relation states
-        for ($i=0; $i < 2; $i++) {
-            $request = <<<EOF
-                <?xml version="1.0" encoding="utf-8"?>
-                <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-                <Ping xmlns="uri:Ping">
-                    <HeartbeatInterval>0</HeartbeatInterval>
-                    <Folders>
-                        <Folder>
-                            <Id>$folderId</Id>
-                            <Class>Email</Class>
-                        </Folder>
-                    </Folders>
-                </Ping>
-                EOF;
-
-            $response = $this->request($request, 'Ping');
-
-            $this->assertEquals(200, $response->getStatusCode());
-            $this->assertSame(1, count($this->getRelationsState($device'ID', $folderId)));
-        }
-
-        // This simulates a specific case where we had:
-        // * An old lastsync timestamp (because the folders were not actively synchronized)
-        // * The folder was still included in the ping command
-        // => This resulted in the relations code never finding a relation, and thus not cleaning up, but it still inserted new entries
-        $db    = \rcube::get_instance()->get_dbh();
-        $result = $db->query(
-            "UPDATE `syncroton_synckey` SET `lastsync` = '2023-06-23 13:15:03'"
-        );
-
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Ping xmlns="uri:Ping">
-                <HeartbeatInterval>0</HeartbeatInterval>
-                <Folders>
-                    <Folder>
-                        <Id>$folderId</Id>
-                        <Class>Email</Class>
-                    </Folder>
-                </Folders>
-            </Ping>
-            EOF;
-
-        $response = $this->request($request, 'Ping');
-
-        $this->assertEquals(200, $response->getStatusCode());
-        $this->assertSame(1, count($this->getRelationsState($device'ID', $folderId)));
-
-    }
-}

kolab-syncroton-2.4.2.tar.gz/tests/SyncTestCase.php Changed

@@ -7,7 +7,6 @@
     protected static ?\GuzzleHttp\Client $client;
     protected static ?string $deviceId;
     protected static ?string $deviceType;
-    protected static ?string $host;
     protected static ?string $username;
     protected static ?string $password;
     protected static bool $authenticated = false;
@@ -37,7 +36,6 @@
 
         self::$username = $config->get('activesync_test_username');
         self::$password = $config->get('activesync_test_password');
-        self::$host = $config->get('activesync_test_host', 'http://localhost:8000');
 
         if (empty(self::$username)) {
             return;
@@ -50,12 +48,12 @@
         $db->query('DELETE FROM syncroton_folder');
         $db->query('DELETE FROM syncroton_data');
         $db->query('DELETE FROM syncroton_data_folder');
+        $db->query('DELETE FROM syncroton_modseq');
         $db->query('DELETE FROM syncroton_content');
-        $db->query('DELETE FROM syncroton_relations_state');
 
         self::$client = new \GuzzleHttp\Client(
                 'http_errors' => false,
-                'base_uri' => self::$host,
+                'base_uri' => 'http://localhost:8000',
                 'verify' => false,
                 'auth' => self::$username, self::$password,
                 'connect_timeout' => 10,
@@ -88,7 +86,6 @@
             $db->query('DELETE FROM syncroton_device');
             $db->query('DELETE FROM syncroton_synckey');
             $db->query('DELETE FROM syncroton_folder');
-            $db->query('DELETE FROM syncroton_relations_state');
         }
     }
 
@@ -118,41 +115,13 @@
         $uid = $imap->save_message($folder, $source, '', $is_file);
 
         if ($uid === false) {
-            exit("Failed to append mail {$filename} into {$folder}");
+            exit("Failed to append mail into {$folder}");
         }
 
         return $uid;
     }
 
     /**
-     * Run A SQL query
-     */
-    protected function runSQLQuery($query)
-    {
-        $sync = \kolab_sync::get_instance();
-        $db = $sync->get_dbh();
-        $db->query($query);
-    }
-
-    /**
-     * Mark an email message as read over IMAP
-     */
-    protected function markMailAsRead($folder, $uids)
-    {
-        $imap = $this->getImapStorage();
-        return $imap->set_flag($uids, 'SEEN', $folder);
-    }
-
-    /**
-     * List emails over IMAP
-     */
-    protected function listEmails($folder, $uids)
-    {
-        $imap = $this->getImapStorage();
-        return $imap->list_flags($folder, $uids);
-    }
-
-    /**
      * Append an DAV object to a DAV/IMAP folder
      */
     protected function appendObject($foldername, $filename, $type)
@@ -175,9 +144,9 @@
             if ($imap->folder_exists($foldername)) {
                 // TODO
                 exit("Not implemented for Kolab v3 storage driver");
-            } else {
-                exit("Folder is missing");
             }
+
+            return;
         }
 
         $dav = $this->getDavStorage();
@@ -222,27 +191,6 @@
     }
 
     /**
-     * Create a folder
-     */
-    protected function createTestFolder($name, $type)
-    {
-        // Create IMAP folders
-        if ($type == 'mail' || $this->isStorageDriver('kolab')) {
-            $imap = $this->getImapStorage();
-            //TODO set type if not mail
-            $imap->create_folder($name, true);
-
-            $metadata = ;
-            $metadata'FOLDER' = ;
-            $metadata'FOLDER'self::$deviceId = ;
-            $metadata'FOLDER'self::$deviceId'S' = '1';
-            $imap->set_metadata($name, '/private/vendor/kolab/activesync' => json_encode($metadata));
-
-            return;
-        }
-    }
-
-    /**
      * Remove all objects from a folder
      */
     protected function emptyTestFolder($name, $type)
@@ -402,7 +350,6 @@
         $xpath = new \DOMXpath($dom);
         $xpath->registerNamespace("ns", $dom->documentElement->namespaceURI);
         $xpath->registerNamespace("AirSync", "uri:AirSync");
-        $xpath->registerNamespace("AirSyncBase", "uri:AirSyncBase");
         $xpath->registerNamespace("Calendar", "uri:Calendar");
         $xpath->registerNamespace("Contacts", "uri:Contacts");
         $xpath->registerNamespace("Email", "uri:Email");
@@ -412,25 +359,4 @@
 
         return $xpath;
     }
-
-    /**
-      * Pretty print the DOM
-      */
-    protected function printDom($dom)
-    {
-        $dom->formatOutput = true;
-        print($dom->saveXML());
-    }
-
-    /**
-     * adapter for phpunit < 9
-     */
-    public static function assertMatchesRegularExpression(string $arg1, string $arg2, string $message = ''): void
-    {
-        if (method_exists("PHPUnit\Framework\TestCase", "assertMatchesRegularExpression")) {
-            parent::assertMatchesRegularExpression($arg1, $arg2, $message);
-        } else {
-            parent::assertRegExp($arg1, $arg2);
-        }
-    }
 }

kolab-syncroton-2.4.2.tar.gz/tests/src/mail.itip.invalid Deleted

@@ -1,51 +0,0 @@
-MIME-Version: 1.0
-Date: Thu, 07 Dec 2023 13:29:14 +0100
-Message-ID: <14ab307198d32cee00b38ffb54c9e577@nestle.kolab.ch>
-From: "Organizer" <$from>
-To: <$to>
-Subject: Invalid itip invitation
-Content-Type: multipart/alternative;
- boundary="=_f39ac9438326f676a8d562e163aa31e0"
-
---=_f39ac9438326f676a8d562e163aa31e0
-Content-Transfer-Encoding: quoted-printable
-Content-Type: text/plain; charset=UTF-8;
- format=flowed
-
-*Test*
---=_f39ac9438326f676a8d562e163aa31e0
-Content-Transfer-Encoding: 8bit
-Content-Type: text/calendar; charset=UTF-8; method=REQUEST; name=event.ics
-
-BEGIN:VCALENDAR
-VERSION:2.0
-PRODID:-//Roundcube 1.5-git//Sabre VObject 4.5.3//EN
-CALSCALE:GREGORIAN
-METHOD:REQUEST
-BEGIN:VTIMEZONE
-TZID:Europe/Warsaw
-BEGIN:DAYLIGHT
-DTSTART:20230326T010000
-TZOFFSETFROM:+0100
-TZOFFSETTO:+0200
-TZNAME:CEST
-END:DAYLIGHT
-BEGIN:DAYLIGHT
-DTSTART:20240331T010000
-TZOFFSETFROM:+0100
-TZOFFSETTO:+0200
-TZNAME:CEST
-END:DAYLIGHT
-BEGIN:STANDARD
-DTSTART:20231029T010000
-TZOFFSETFROM:+0200
-TZOFFSETTO:+0100
-TZNAME:CET
-END:STANDARD
-END:VTIMEZONE
-BEGIN:VEVENT
-DTSTART;TZID=Europe/Warsaw:20231207T140000
-END:VEVENT
-END:VCALENDAR
-
---=_f39ac9438326f676a8d562e163aa31e0--

kolab-syncroton.dsc Changed

Build Results
RPM Lint

Refresh

Comments for request 3268 0

Request History

mollekopf created request 10 months ago

New release 2.4.2.12

mollekopf superseded request 10 months ago

superseded by 3271