Request 2723 (accepted)

Overview

Request 2723 (accepted)

Rebuild against new erlang-eimap package (should be accepted after eimap has been build). This patch also fixes restart issues on package upgrade

Created by dhoffend about 4 years ago
In state accepted
Open review for Admin

Submit guam

Submit package home:dhoffend:bra...Kolab:Winterfell / guam to package Kolab:Winterfell / guam

debian.changelog Changed

debian.tar.gz/postinst Changed

@@ -7,9 +7,28 @@
             openssl dhparam -out /etc/guam/dh_2048.pem -2 2048 >/dev/null 2>&1
         fi
 
-        if [ -L "/etc/systemd/system/guam.service" ]; then
-            systemctl unmask guam || :
+        # This will only remove masks created by d-s-h on package removal.
+        deb-systemd-helper unmask 'guam.service' >/dev/null || true
+
+        # was-enabled defaults to true, so new installations run enable.
+        if deb-systemd-helper --quiet was-enabled 'guam.service'; then
+                # Enables the unit on first installation, creates new
+                # symlinks on upgrades if the unit file has changed.
+                deb-systemd-helper enable 'guam.service' >/dev/null || true
+        else
+                # Update the statefile to add new symlinks (if any), which need to be
+                # cleaned up on purge. Also remove old symlinks.
+                deb-systemd-helper update-state 'guam.service' >/dev/null || true
+        fi
+
+        # start or restart on install/updated
+        systemctl --system daemon-reload >/dev/null || true
+        if [ -n "$2" ]; then
+                _dh_action=restart
+        else
+                _dh_action=start
         fi
+        deb-systemd-invoke $_dh_action 'guam.service' >/dev/null || true
     ;;
 esac

guam.dsc Changed

Build Results
RPM Lint

Refresh

Comments for request 2723 1

dhoffend wrote about 4 years ago

The postinst update basically to ensure that a) the package stays enable when guam was enabled in the first place b) systemd gets reloaded if the unit file has changed during installation c) guam gets started (new installation) or restarted (on upgrade)

Request History

dhoffend created request about 4 years ago

Rebuild against new erlang-eimap package (should be accepted after eimap has been build). This patch also fixes restart issues on package upgrade

vanmeeuwen accepted review about 4 years ago

vanmeeuwen accepted request about 4 years ago