Request 3285 (superseded)

This request is superseded by request 3288 (Show diff)

Overview

Request 3285 (superseded)

New release 2.4.2.17

Created by mollekopf 5 months ago
In state superseded
Superseded by 3288
Open review for Admin
Open review for vanmeeuwen
Open review for mollekopf
Open review for kolab-developers

Submit kolab-syncroton

Submit package Kolab:16:Testing / kolab-syncroton to package Kolab:16 / kolab-syncroton

kolab-syncroton.spec Changed

@@ -17,12 +17,6 @@
 
 %{!?php_inidir: %global php_inidir %{_sysconfdir}/php.d}
 
-%if 0%{?suse_version} < 1 && 0%{?fedora} < 1 && 0%{?rhel} < 7
-%global with_systemd 0
-%else
-%global with_systemd 1
-%endif
-
 %if 0%{?suse_version}
 %global httpd_group www
 %global httpd_name apache2
@@ -43,7 +37,7 @@
 %global upstream_version 2.4.2
 
 Name:           kolab-syncroton
-Version: 2.4.2.31
+Version: 2.4.2.17
 Release:        1%{?dist}
 Summary:        ActiveSync for Kolab Groupware
 
@@ -112,7 +106,6 @@
 
 cp -a lib %{buildroot}/%{_datadir}/%{name}/.
 cp -a index.php %{buildroot}/%{_datadir}/%{name}/.
-cp -a bin %{buildroot}/%{_datadir}/%{name}/.
 
 %if 0%{?plesk}
 cp -a %SOURCE2 %{buildroot}/%{_sysconfdir}/roundcubemail/kolab_syncroton.inc.php
@@ -171,7 +164,7 @@
 %post
 if  -f "%{php_inidir}/apc.ini" -o -f "%{php_inidir}/apcu.ini" ; then
     if  ! -z "`grep ^apc.enabled=1 %{php_inidir}/apc{,u}.ini 2>/dev/null`" ; then
-%if 0%{?with_systemd}
+%if 0%{?fedora} > 15
         /bin/systemctl condrestart %{httpd_name}.service
 %else
         /sbin/service %{httpd_name} condrestart
@@ -183,27 +176,6 @@
     /bin/systemctl reload php-fpm.service || :
 fi
 
-if  -f "/usr/lib/systemd/system/plesk-php74-fpm.service" ; then
-    /bin/systemctl reload plesk-php74-fpm.service || :
-fi
-
-if  -f "/usr/lib/systemd/system/plesk-php80-fpm.service" ; then
-    /bin/systemctl reload plesk-php80-fpm.service || :
-fi
-
-if  -f "/usr/lib/systemd/system/plesk-php81-fpm.service" ; then
-    /bin/systemctl reload plesk-php81-fpm.service || :
-fi
-
-if  -f "/usr/lib/systemd/system/plesk-php82-fpm.service" ; then
-    /bin/systemctl reload plesk-php82-fpm.service || :
-fi
-
-if  -f "/usr/lib/systemd/system/plesk-php83-fpm.service" ; then
-    /bin/systemctl reload plesk-php83-fpm.service || :
-fi
-
-
 
 %if 0%{?plesk} > 0 && 0%{?rhel} == 7
 php="/opt/plesk/php/7.4/bin/php"

debian.changelog Changed

debian.tar.gz/dirs Changed

debian.tar.gz/install Changed

kolab-syncroton-2.4.2.tar.gz/bin Deleted

kolab-syncroton-2.4.2.tar.gz/bin/delete-device.php Deleted

@@ -1,97 +0,0 @@
-#!/usr/bin/env php
-<?php
-/*
- +--------------------------------------------------------------------------+
- | Kolab Sync (ActiveSync for Kolab)                                        |
- |                                                                          |
- | Copyright (C) 2024, Apheleia IT AG <contact@apheleia-it.ch>         |
- |                                                                          |
- | This program is free software: you can redistribute it and/or modify     |
- | it under the terms of the GNU Affero General Public License as published |
- | by the Free Software Foundation, either version 3 of the License, or     |
- | (at your option) any later version.                                      |
- |                                                                          |
- | This program is distributed in the hope that it will be useful,          |
- | but WITHOUT ANY WARRANTY; without even the implied warranty of           |
- | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the             |
- | GNU Affero General Public License for more details.                      |
- |                                                                          |
- | You should have received a copy of the GNU Affero General Public License |
- | along with this program. If not, see <http://www.gnu.org/licenses/>      |
- +--------------------------------------------------------------------------+
- | Author: Christian Mollekopf <mollekopf@apheleia-it.ch>                      |
- +--------------------------------------------------------------------------+
-*/
-
-
-define('RCUBE_INSTALL_PATH', realpath(dirname(__FILE__) . '/../') . '/');
-define('RCUBE_PLUGINS_DIR', RCUBE_INSTALL_PATH . 'lib/plugins/');
-
-// Define include path
-$include_path  = RCUBE_INSTALL_PATH . 'lib' . PATH_SEPARATOR;
-$include_path .= RCUBE_INSTALL_PATH . 'lib/ext' . PATH_SEPARATOR;
-$include_path .= ini_get('include_path');
-set_include_path($include_path);
-
-// include composer autoloader (if available)
-if (@file_exists(RCUBE_INSTALL_PATH . 'vendor/autoload.php')) {
-    require RCUBE_INSTALL_PATH . 'vendor/autoload.php';
-}
-
-// include global functions from Roundcube Framework
-require_once 'Roundcube/bootstrap.php';
-
-$opts = rcube_utils::get_opt(
-    's' => 'since', // Deletes *all* devices that haven't been used since the given timestamp. Doesn't take owner and device id into account. Timestamp format e.g.: "2024-11-01"
-    'o' => 'owner',
-    'd' => 'deviceid',
-);
-
-$rcube = \rcube::get_instance();
-$db    = $rcube->get_dbh();
-
-if (!empty($opts'since')) {
-    $since = $opts'since';
-    $since = new DateTime($since);
-    print("Removing all devices that haven't been used since: " . $since->format('Y-m-d H:i:s') . "\n");
-
-    $db->query(
-        "DELETE FROM `syncroton_device`"
-        . " WHERE `lastping` < ? OR `lastping` = NULL",
-        $since->format('Y-m-d H:i:s')
-    );
-    return;
-}
-
-if (empty($opts'deviceid')) {
-    rcube::raise_error("Device id not specified (--deviceid).", false, true);
-}
-$device = $opts'deviceid';
-
-if (empty($opts'owner')) {
-    rcube::raise_error("owner not specified (--owner).", false, true);
-}
-$owner = $opts'owner';
-
-$select = $db->query(
-    "SELECT `user_id` FROM `users`"
-    . " WHERE `username` = ?"
-    . " ORDER BY `user_id` DESC",
-    \strtolower($owner)
-);
-
-if ($data = $db->fetch_assoc($select)) {
-    $userid = $data'user_id';
-} else {
-    rcube::raise_error("User not found in roundcube database, aborting: $email.", false, true);
-}
-
-print("Found the user with id: $userid\n");
-
-$db->query(
-    "DELETE FROM syncroton_device WHERE owner_id = ? AND deviceid = ?",
-    $userid,
-    $device
-);
-
-print("Deleted the device with the deviceid: $deviceid\n");

kolab-syncroton-2.4.2.tar.gz/bin/inspect.php Deleted

@@ -1,244 +0,0 @@
-#!/usr/bin/env php
-<?php
-/*
- +--------------------------------------------------------------------------+
- | Kolab Sync (ActiveSync for Kolab)                                        |
- |                                                                          |
- | Copyright (C) 2024, Apheleia IT AG <contact@apheleia-it.ch>         |
- |                                                                          |
- | This program is free software: you can redistribute it and/or modify     |
- | it under the terms of the GNU Affero General Public License as published |
- | by the Free Software Foundation, either version 3 of the License, or     |
- | (at your option) any later version.                                      |
- |                                                                          |
- | This program is distributed in the hope that it will be useful,          |
- | but WITHOUT ANY WARRANTY; without even the implied warranty of           |
- | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the             |
- | GNU Affero General Public License for more details.                      |
- |                                                                          |
- | You should have received a copy of the GNU Affero General Public License |
- | along with this program. If not, see <http://www.gnu.org/licenses/>      |
- +--------------------------------------------------------------------------+
- | Author: Christian Mollekopf <mollekopf@apheleia-it.ch>                      |
- +--------------------------------------------------------------------------+
-*/
-
-
-define('RCUBE_INSTALL_PATH', realpath(dirname(__FILE__) . '/../') . '/');
-define('RCUBE_PLUGINS_DIR', RCUBE_INSTALL_PATH . 'lib/plugins/');
-
-// Define include path
-$include_path  = RCUBE_INSTALL_PATH . 'lib' . PATH_SEPARATOR;
-$include_path .= RCUBE_INSTALL_PATH . 'lib/ext' . PATH_SEPARATOR;
-$include_path .= ini_get('include_path');
-set_include_path($include_path);
-
-// include composer autoloader (if available)
-if (@file_exists(RCUBE_INSTALL_PATH . 'vendor/autoload.php')) {
-    require RCUBE_INSTALL_PATH . 'vendor/autoload.php';
-}
-
-// include global functions from Roundcube Framework
-require_once 'Roundcube/bootstrap.php';
-
-$opts = rcube_utils::get_opt(
-    'e' => 'email',
-    'p' => 'adminpassword',
-    'd' => 'debug',
-);
-
-if (empty($opts'email')) {
-    rcube::raise_error("Email address not specified (--email).", false, true);
-}
-$email = $opts'email';
-
-$proxyAuth = false;
-if ($password = $opts'adminpassword') {
-    $proxyAuth = true;
-    $user = "cyrus-admin";
-} else {
-    $password = $opts'password';
-}
-
-if (empty($password)) {
-    rcube::raise_error("Password not specified (--adminpassword/--password).", false, true);
-}
-
-$rcube = rcube::get_instance();
-$default_port = $rcube->config->get('default_port', 143);
-$default_host = $rcube->config->get('default_host');
-$imap = new \rcube_imap_generic();
-if ($proxyAuth) {
-    $options'auth_cid' = $user;
-    $options'auth_pw' = $password;
-}
-$options'auth_type' = 'PLAIN';
-$options'port' = $default_port;
-$options'socket_options' = 
-    'ssl' => 
-        'verify_peer_name' => false,
-        'verify_peer' => false,
-        'allow_self_signed' => true
-    
-;
-
-ini_set('display_errors', 1);
-error_reporting(E_ALL);
-
-$debug = !empty($opts'debug');
-
-$imap->setDebug($debug);
-if (!$imap->connect($default_host, $email, $password, $options)) {
-    rcube::raise_error("Failed to connect to imap.", false, true);
-}
-
-$rcube = \rcube::get_instance();
-$db    = $rcube->get_dbh();
-
-$select = $db->query(
-    "SELECT `user_id` FROM `users`"
-    . " WHERE `username` = ?"
-    . " ORDER BY `user_id` DESC",
-    \strtolower($email)
-);
-
-if ($data = $db->fetch_assoc($select)) {
-    $userid = $data'user_id';
-} else {
-    rcube::raise_error("User not found in roundcube database (only available after first login): $email.", false, true);
-}
-
-print("Found the user with id: $userid\n");
-
-$devicesSelect = $db->query(
-    "SELECT `id`, `deviceid`, `devicetype` FROM `syncroton_device`"
-    . " WHERE `owner_id` = ?",
-    $userid
-);
-
-$result = ;
-while ($data = $db->fetch_assoc($devicesSelect)) {
-    $deviceid = $data"deviceid";
-    $device_id = $data"id";
-
-    $result$device_id'deviceid' = $deviceid;
-    $result$device_id'devicetype' = $data"devicetype";
-
-    $select = $db->limitquery(
-        "SELECT `counter`, `lastsync` FROM `syncroton_synckey`"
-        . " WHERE `device_id` = ? AND `type` = 'FolderSync'"
-        . " ORDER BY `counter` DESC",
-        0,
-        1,
-        $device_id
-    );
-
-    if ($data = $db->fetch_assoc($select)) {
-        $result$device_id'FolderSync' = 
-            "counter" => $data'counter',
-            "lastsync" => $data'lastsync',
-        ;
-    } else {
-        echo("Synckey not found.\n");
-    }
-
-    $folderSelect = $db->query(
-        "SELECT * FROM `syncroton_folder`"
-        . " WHERE `device_id` = ?",
-        $device_id
-    );
-
-    while ($folder = $db->fetch_assoc($folderSelect)) {
-        $select = $db->limitquery(
-            "SELECT `counter`, `lastsync`, `extra_data` FROM `syncroton_synckey`"
-            . " WHERE `device_id` = ? AND `type` = ?"
-            . " ORDER BY `counter` DESC",
-            0,
-            1,
-            $device_id,
-            $folder'id'
-        );
-
-        if ($data = $db->fetch_assoc($select)) {
-            $result$device_id'folders'$folder'id' = 
-                "counter" => $data'counter',
-                "lastsync" => $data'lastsync',
-                "lastfiltertype" => $data'lastfiltertype' ?? null,
-                "modseq" => $data'extra_data' ? json_decode($data'extra_data')->modseq : null,
-            ;
-        }
-
-        $result$device_id'folders'$folder'id''name' = $folder'displayname';
-
-        $imap->select($folder'displayname');
-        $result$device_id'folders'$folder'id''imapModseq' = $imap->data'HIGHESTMODSEQ' ?? null;
-
-        $index = $imap->search($folder'displayname', 'ALL UNDELETED', false, 'COUNT');
-        if (!$index->is_error()) {
-            $result$device_id'folders'$folder'id''imapMessagecount' = $index->count();
-        }
-
-        $select = $db->query(
-            "SELECT count(*) FROM `syncroton_content`"
-            . " WHERE `device_id` = ? AND `folder_id` = ?",
-            $device_id,
-            $folder'id'
-        );
-
-        if ($data = $db->fetch_assoc($select)) {
-            $result$device_id'folders'$folder'id''contentCount' = array_values($data)0;
-        }
-    }
-}
-
-if ($debug) {
-    var_export($result);
-}
-
-function println($output) {
-    print("{$output}\n");
-}
-
-function filterType($value) {
-	if (!$value) {
-		return "No filter";
-	}
-	switch($value) {
-		case 0: return "No filter";
-		case 1: return "1 day";
-		case 2: return "3 days";
-		case 3: return "1 week";
-		case 4: return "2 weeks";
-		case 5: return "1 month";
-		case 6: return "3 months";
-		case 7: return "6 months";
-		case 8: return "Filter by incomplete tasks";
-	}
-	return "Unknown value: $value";
-}
-
-println("");
-foreach ($result  as $deviceId => $values) {
-    println("Device: $deviceId");
-    println("  Last folder sync: " . $values'FolderSync''lastsync');
-    println("  Folder sync count: " . $values'FolderSync''counter');
-    println("  Folders:");
-    foreach ($values'folders' ??  as $folderId => $folder) {
-        println("    " . $folder'name' . " ($folderId)");
-        $messageCount = $folder'contentCount';
-        $totalCount = $folder'imapMessagecount' ?? "unknown";
-        $modseq = $folder'modseq' ?? "none";
-        $imapModseq = $folder'imapModseq';
-        // We're not using modseq for groupware folders
-        if ($messageCount == $totalCount && ($modseq == "none" || $modseq == $imapModseq)) {
-            println("    Status: Fully Synced ($messageCount messages)");
-        } else {
-            println("    Status: Incomplete ($messageCount/$totalCount messages)");
-            println("    Modseq: " . $modseq . "/" . $imapModseq);
-        }
-        println("    Last sync: " . ($folder'lastsync' ?? "None"));
-        println("    Number of syncs: " . ($folder'counter' ?? "None"));
-        println("    Filter type: " . filterType($folder'lastfiltertype' ?? null));
-        println("");
-    }
-}

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Command/Sync.php Changed

@@ -599,26 +599,7 @@
             }
         }
 
-        // Handle Calendar folders first.
-        // Outlook can't match MeetingRequest with an event that wasn't synced yet, which
-        // leads to duplicated events in Outlook's calendar.
-        uasort(
-            $this->_collections,
-            function ($a, $b) {
-                $ac = $a->folder && $a->folder->class == Syncroton_Data_Factory::CLASS_CALENDAR;
-                $bc = $b->folder && $b->folder->class == Syncroton_Data_Factory::CLASS_CALENDAR;
-                if ($ac) {
-                    return $bc ? 0 : -1;
-                }
-                return $bc ? 1 : 0;
-            }
-        );
-
         foreach ($this->_collections as $collectionData) {
-            if ($this->_logger instanceof Zend_Log) {
-                $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " Processing {$collectionData->collectionId}...");
-            }
-
             $collectionChanges = 0;
 
             /**
@@ -670,7 +651,7 @@
                     if(is_array($collectionData->syncState->pendingdata)) {
                         $serverModifications = $collectionData->syncState->pendingdata;
                         if ($this->_logger instanceof Zend_Log) {
-                            $this->_logger->info(__METHOD__ . '::' . __LINE__ . " restored from sync state: (added/changed/deleted) " . count($serverModifications'added') . '/' . count($serverModifications'changed') . '/' . count($serverModifications'deleted') . ' entries for sync from server to client');
+                            $this->_logger->info(__METHOD__ . '::' . __LINE__ . " restored from sync state: (added/changed/deleted) " . count($serverModifications'added') . '/' . count($serverModifications'changed') . '/' . count($serverModifications'deleted')  . ' entries for sync from server to client');
                         }
                     } else {
                         try {
@@ -796,7 +777,7 @@
                 if ($this->_logger instanceof Zend_Log) {
                     $this->_logger->info(__METHOD__ . '::' . __LINE__ . " Processing collection " . $collectionData->collectionId);
                 }
-
+                
                 // send reponse for newly added entries
                 if(!empty($clientModifications'added')) {
                     foreach($clientModifications'added' as $entryData) {
@@ -896,7 +877,7 @@
                         // continue to next entry, as there is not enough memory left for the current entry
                         // this will lead to MoreAvailable at the end and the entry will be synced during the next Sync command
                         if ($this->_logger instanceof Zend_Log) {
-                            $this->_logger->info(__METHOD__ . '::' . __LINE__ . " memory exhausted for entry: " . $serverId);
+                            $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " memory exhausted for entry: " . $serverId);
                         }
 
                         break;
@@ -930,8 +911,6 @@
 
                         $applicationData = $change->appendChild($this->_outputDom->createElementNS('uri:AirSync', 'ApplicationData'));
 
-                        $collectionData->options'_changesOnly' = true;
-
                         $dataController
                             ->getEntry($collectionData, $serverId)
                             ->appendXML($applicationData, $this->_device);
@@ -944,7 +923,7 @@
                         // continue to next entry, as there is not enough memory left for the current entry
                         // this will lead to MoreAvailable at the end and the entry will be synced during the next Sync command
                         if ($this->_logger instanceof Zend_Log) {
-                            $this->_logger->info(__METHOD__ . '::' . __LINE__ . " memory exhausted for entry: " . $serverId);
+                            $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " memory exhausted for entry: " . $serverId);
                         }
 
                         break;

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Model/AXMLEntry.php Changed

@@ -223,31 +223,6 @@
     }
 
     /**
-     * Fix date-time string input
-     *
-     * @param string $date Date time string
-     *
-     * @return string
-     */
-    protected function _fixDateTimeString($date)
-    {
-        // Note: Some clients send date-time in local charset instead of ascii
-        // It is not supported by PHP DateTime constructor
-
-        $from = 
-            '١','٢','٣','٤','٥','٦','٧','٨','٩','٠', // arabic
-            '۱','۲','۳','۴','۵','۶','۷','۸','۹','۰', // persian
-        ;
-
-        $to = 
-            '1','2','3','4','5','6','7','8','9','0',
-            '1','2','3','4','5','6','7','8','9','0',
-        ;
-
-        return str_replace($from, $to, $date);
-    }
-
-    /**
      *
      * @param string $element
      * @throws InvalidArgumentException
@@ -309,7 +284,7 @@
                     break;
 
                 case 'datetime':
-                    $property = new DateTime($this->_fixDateTimeString((string) $xmlElement), new DateTimeZone('UTC'));
+                    $property = new DateTime((string) $xmlElement, new DateTimeZone('UTC'));
                     break;
 
                 case 'number':

kolab-syncroton-2.4.2.tar.gz/lib/ext/Syncroton/Server.php Changed

@@ -52,10 +52,7 @@
         $this->_request = $request instanceof Zend_Controller_Request_Http ? $request : new Zend_Controller_Request_Http();
         $this->_body    = $body !== null ? $body : fopen('php://input', 'r');
 
-        // Not available on unauthenticated OPTIONS request
-        if (!empty($this->_userId)) {
-            $this->_deviceBackend = Syncroton_Registry::getDeviceBackend();
-        }
+        $this->_deviceBackend = Syncroton_Registry::getDeviceBackend();
 
     }
 
@@ -65,13 +62,6 @@
             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . ' REQUEST METHOD: ' . $this->_request->getMethod());
         }
 
-        if ($this->_request->getMethod() != "OPTIONS" && empty($this->_userId)) {
-            $this->_logger->warn(__METHOD__ . '::' . __LINE__ . ' Not authenticated');
-            header('WWW-Authenticate: Basic realm="ActiveSync for Kolab"');
-            header('HTTP/1.1 401 Unauthorized');
-            exit;
-        }
-
         switch($this->_request->getMethod()) {
             case 'OPTIONS':
                 $this->_handleOptions();

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync.php Changed

@@ -135,6 +135,12 @@
             $userid = $this->authenticate($_SERVER'PHP_AUTH_USER', $_SERVER'PHP_AUTH_PW');
         }
 
+        if (empty($userid)) {
+            header('WWW-Authenticate: Basic realm="' . $this->app_name . '"');
+            header('HTTP/1.1 401 Unauthorized');
+            exit;
+        }
+
         $this->plugins->exec_hook('ready', 'task' => 'syncroton');
 
         // Set log directory per-user (again, in case the username changed above)
@@ -147,15 +153,12 @@
         Syncroton_Registry::set(Syncroton_Registry::LOGGERBACKEND, $this->logger);
         Syncroton_Registry::set(Syncroton_Registry::DATABASE, $this->get_dbh());
         Syncroton_Registry::set(Syncroton_Registry::TRANSACTIONMANAGER, kolab_sync_transaction_manager::getInstance());
-        // The unauthenticated OPTIONS request doesn't require these backends and we can't instantiate them without credentials for the underlying storage backend
-        if (!empty($userid)) {
-            Syncroton_Registry::set(Syncroton_Registry::DEVICEBACKEND, new kolab_sync_backend_device());
-            Syncroton_Registry::set(Syncroton_Registry::FOLDERBACKEND, new kolab_sync_backend_folder());
-            Syncroton_Registry::set(Syncroton_Registry::SYNCSTATEBACKEND, new kolab_sync_backend_state());
-            Syncroton_Registry::set(Syncroton_Registry::CONTENTSTATEBACKEND, new kolab_sync_backend_content());
-            Syncroton_Registry::set(Syncroton_Registry::POLICYBACKEND, new kolab_sync_backend_policy());
-            Syncroton_Registry::set(Syncroton_Registry::SLEEP_CALLBACK, $this, 'sleep');
-        }
+        Syncroton_Registry::set(Syncroton_Registry::DEVICEBACKEND, new kolab_sync_backend_device());
+        Syncroton_Registry::set(Syncroton_Registry::FOLDERBACKEND, new kolab_sync_backend_folder());
+        Syncroton_Registry::set(Syncroton_Registry::SYNCSTATEBACKEND, new kolab_sync_backend_state());
+        Syncroton_Registry::set(Syncroton_Registry::CONTENTSTATEBACKEND, new kolab_sync_backend_content());
+        Syncroton_Registry::set(Syncroton_Registry::POLICYBACKEND, new kolab_sync_backend_policy());
+        Syncroton_Registry::set(Syncroton_Registry::SLEEP_CALLBACK, $this, 'sleep');
 
         Syncroton_Registry::setContactsDataClass('kolab_sync_data_contacts');
         Syncroton_Registry::setCalendarDataClass('kolab_sync_data_calendar');

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_data.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_data_calendar.php Changed

@@ -190,7 +190,7 @@
     public function getEntry(Syncroton_Model_SyncCollection $collection, $serverId, $as_array = false)
     {
         $event  = is_array($serverId) ? $serverId : $this->getObject($collection->collectionId, $serverId);
-        $config = !empty($event'folderId') ? $this->getFolderConfig($event'folderId') : ;
+        $config = $this->getFolderConfig($event'folderId');
         $result = ;
 
         $is_outlook = stripos($this->device->devicetype, 'outlook') !== false;
@@ -691,11 +691,7 @@
         }
 
         // extract event from the invitation
-        try {
-            $event, $existing = $this->get_event_from_invitation($request);
-        } catch (Exception $e) {
-            throw new Syncroton_Exception_Status_MeetingResponse(Syncroton_Exception_Status_MeetingResponse::MEETING_ERROR);
-        }
+        $event, $existing = $this->get_event_from_invitation($request);
         /*
                     switch ($status) {
                         case 'ACCEPTED':  $event'free_busy' = 'busy';      break;
@@ -1332,14 +1328,14 @@
         $rec = (array) $event'recurrence';
 
         // Add BYDAY if not exists
-        if (($rec'FREQ' ?? '') == 'WEEKLY' && empty($rec'BYDAY')) {
+        if ($rec'FREQ' == 'WEEKLY' && empty($rec'BYDAY')) {
             $days = 'SU', 'MO', 'TU', 'WE', 'TH', 'FR', 'SA';
             $day  = $event'start'->format('w');
 
             $rec'BYDAY' = $days$day;
         }
 
-        if (empty($rec'INTERVAL')) {
+        if (!$rec'INTERVAL') {
             $rec'INTERVAL' = 1;
         }

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_data_email.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_message.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_storage.php Changed

@@ -56,7 +56,7 @@
     protected $folders = ;
     protected $root_meta;
     protected $relations = ;
-    public $relationSupport = true;
+    protected $relationSupport = true;
     protected $tag_rts = ;
     private $modseq = ;
 
@@ -1564,19 +1564,9 @@
                 ;
             }
 
-            // If the new and the old timestamp are the same our cache breaks.
-            // We must preserve the previous changes, because if this function is rerun we must detect the same changes again.
-            $sinceFormatted = $since->format('Y-m-d H:i:s');
-            if ($this->syncTimeStamp->format('Y-m-d H:i:s') == $sinceFormatted) {
-                // Preserve the previous timestamp (relations_state_get just checks the overflow bucket first)
-                // FIXME: The one caveat is that we will still update the database and thus overwrite the old entry.
-                // That means if we rerun the same request, the changes will not be detected
-                // => We should not be dealing with timestamps really.
-                $this->relations$folderid$sinceFormatted . "-1" = $this->relations$folderid$sinceFormatted ?? null;
-                $this->relations$folderid$sinceFormatted = null;
-            }
+            $now = new DateTime('now', new DateTimeZone('UTC'));
 
-            $this->relations_state_set($device_key, $folderid, $this->syncTimeStamp, $data);
+            $this->relations_state_set($device_key, $folderid, $now, $data);
         }
 
         // in mail mode return only message URIs
@@ -1930,21 +1920,23 @@
     public function relations_state_set($device_key, $folderid, $synctime, $relations)
     {
         $synctime = $synctime->format('Y-m-d H:i:s');
+        $rcube    = rcube::get_instance();
+        $db       = $rcube->get_dbh();
+        $old_data = $this->relations$folderid$synctime ?? null;
 
-        // Protect against inserting the same values twice (this code can be executed twice in the same request)
-        if (!isset($this->relations$folderid$synctime)) {
-            $rcube    = rcube::get_instance();
-            $db       = $rcube->get_dbh();
+        if (empty($old_data)) {
             $this->relations$folderid$synctime = $relations;
             $data = rcube_charset::clean(json_encode($relations));
 
-            $result = $db->insert_or_update(
-                'syncroton_relations_state',
-                'device_id' => $device_key, 'folder_id' => $folderid, 'synctime' => $synctime,
-                'data',
-                $data
+            $result = $db->query(
+                "INSERT INTO `syncroton_relations_state`"
+                . " (`device_id`, `folder_id`, `synctime`, `data`)"
+                . " VALUES (?, ?, ?, ?)",
+                $device_key,
+                $folderid,
+                $synctime,
+                $data
             );
-
             if ($err = $db->is_error($result)) {
                 throw new Exception("Failed to save relation: {$err}");
             }
@@ -1958,17 +1950,15 @@
     {
         $synctime = $synctime->format('Y-m-d H:i:s');
 
-        //If we had a collision before
-        if (isset($this->relations$folderid$synctime . "-1")) {
-            return $this->relations$folderid$synctime. "-1";
-        }
-        if (!isset($this->relations$folderid$synctime)) {
+        if (empty($this->relations$folderid$synctime)) {
+            $this->relations$folderid = ;
+
             $rcube = rcube::get_instance();
             $db    = $rcube->get_dbh();
 
             $db->limitquery(
                 "SELECT `data`, `synctime` FROM `syncroton_relations_state`"
-                . " WHERE `device_id` = ? AND `folder_id` = ? AND `synctime` < ?"
+                . " WHERE `device_id` = ? AND `folder_id` = ? AND `synctime` <= ?"
                 . " ORDER BY `synctime` DESC",
                 0,
                 1,
@@ -1978,26 +1968,19 @@
             );
 
             if ($row = $db->fetch_assoc()) {
-                // Don't use $row'synctime' for the internal cache.
-                // The synctime of the found row is usually earlier than the requested synctime.
-                // Note: We use internal cache because there's a call to both hasChanges() and
-                // getChangedEntries() in Sync. It's needed until we add some caching on a higher level.
+                $synctime = $row'synctime';
+                // @TODO: make sure synctime from sql is in "Y-m-d H:i:s" format
                 $this->relations$folderid$synctime = json_decode($row'data', true);
-
-                // Cleanup: remove all records older than the current one.
-                // We must use the row's synctime, otherwise we would delete the record we just loaded
-                // We must delete all entries that are before the synctime to clean up old entries,
-                // but we must also delete all entries that are more recent in case the sync gets rerun
-                // with the same timestamp (e.g. when rerunning the same sync request).
-                // Otherwise the number of entries will start to grow with every sync.
-                $db->query(
-                    "DELETE FROM `syncroton_relations_state`"
-                    . " WHERE `device_id` = ? AND `folder_id` = ? AND `synctime` <> ?",
-                    $device_key,
-                    $folderid,
-                    $row'synctime'
-                );
             }
+
+            // Cleanup: remove all records except the current one
+            $db->query(
+                "DELETE FROM `syncroton_relations_state`"
+                . " WHERE `device_id` = ? AND `folder_id` = ? AND `synctime` <> ?",
+                $device_key,
+                $folderid,
+                $synctime
+            );
         }
 
         return $this->relations$folderid$synctime ?? null;

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_storage_kolab4.php Changed

kolab-syncroton-2.4.2.tar.gz/lib/kolab_sync_timezone_converter.php Changed

kolab-syncroton-2.4.2.tar.gz/tests/Sync/FoldersTest.php Changed

@@ -76,15 +76,15 @@
 
         if ($this->isStorageDriver('kolab4')) {
             $folders = 
-                'Calendar', Syncroton_Command_FolderSync::FOLDERTYPE_CALENDAR,
+                'Calendar', Syncroton_Command_FolderSync::FOLDERTYPE_CALENDAR_USER_CREATED,
                 // Note: Kolab 4 with Cyrus DAV uses Addressbook, but Kolab 3 with iRony would use 'Contacts'
-                '/^(Contacts|Addressbook)$/', Syncroton_Command_FolderSync::FOLDERTYPE_CONTACT,
+                '/^(Contacts|Addressbook)$/', Syncroton_Command_FolderSync::FOLDERTYPE_CONTACT_USER_CREATED,
                 'INBOX', Syncroton_Command_FolderSync::FOLDERTYPE_INBOX,
                 'Drafts', Syncroton_Command_FolderSync::FOLDERTYPE_DRAFTS,
                 'Sent', Syncroton_Command_FolderSync::FOLDERTYPE_SENTMAIL,
                 'Trash', Syncroton_Command_FolderSync::FOLDERTYPE_DELETEDITEMS,
                 // Note: For now Kolab 4 uses the same Calendar folder for calendar and tasks
-                '/^(Tasks|Calendar)$/', Syncroton_Command_FolderSync::FOLDERTYPE_TASK,
+                '/^(Tasks|Calendar)$/', Syncroton_Command_FolderSync::FOLDERTYPE_TASK_USER_CREATED,
             ;
         }

kolab-syncroton-2.4.2.tar.gz/tests/Sync/OptionsTest.php Changed

kolab-syncroton-2.4.2.tar.gz/tests/Sync/Sync/EmailTest.php Changed

@@ -153,7 +153,6 @@
         $root .= "/ns:Commands/ns:Add";
         $this->assertStringMatchesFormat("{$folderId}::%d", $xpath->query("{$root}/ns:ServerId")->item(0)->nodeValue);
         $this->assertSame('sync test with attachment', $xpath->query("{$root}/ns:ApplicationData/Email:Subject")->item(0)->nodeValue);
-        $this->assertSame(1, $xpath->query("{$root}/ns:ApplicationData/AirSyncBase:Body")->count());
 
         return $syncKey;
     }
@@ -246,11 +245,7 @@
         $this->assertSame($folderId, $xpath->query("{$root}/ns:CollectionId")->item(0)->nodeValue);
         $this->assertSame(0, $xpath->query("{$root}/ns:Commands/ns:Add")->count());
         $this->assertSame(2, $xpath->query("{$root}/ns:Commands/ns:Change")->count());
-        $this->assertSame(2, $xpath->query("{$root}/ns:Commands/ns:Change/ns:ApplicationData/Email:Read")->count());
-        $this->assertSame('0', $xpath->query("{$root}/ns:Commands/ns:Change/ns:ApplicationData/Email:Read")->item(0)->nodeValue);
-        $this->assertSame('0', $xpath->query("{$root}/ns:Commands/ns:Change/ns:ApplicationData/Email:Read")->item(1)->nodeValue);
 
-        $this->assertSame(0, $xpath->query("{$root}/ns:Commands/ns:Change/ns:ApplicationData/AirSyncBase:Body")->count());
         return $syncKey;
     }

kolab-syncroton-2.4.2.tar.gz/tests/Sync/Sync/RelationsTest.php Deleted

@@ -1,212 +0,0 @@
-<?php
-
-namespace Tests\Sync\Sync;
-
-class RelationsTest extends \Tests\SyncTestCase
-{
-
-    protected function initialSyncRequest($folderId) {
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Sync xmlns="uri:AirSync">
-                <Collections>
-                    <Collection>
-                        <SyncKey>0</SyncKey>
-                        <CollectionId>{$folderId}</CollectionId>
-                    </Collection>
-                </Collections>
-            </Sync>
-            EOF;
-        return $this->request($request, 'Sync');
-    }
-
-    protected function syncRequest($syncKey, $folderId, $windowSize = null) {
-        $request = <<<EOF
-            <?xml version="1.0" encoding="utf-8"?>
-            <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
-            <Sync xmlns="uri:AirSync" xmlns:AirSyncBase="uri:AirSyncBase">
-                <Collections>
-                    <Collection>
-                        <SyncKey>{$syncKey}</SyncKey>
-                        <CollectionId>{$folderId}</CollectionId>
-                        <DeletesAsMoves>1</DeletesAsMoves>
-                        <GetChanges>1</GetChanges>
-                        <WindowSize>{$windowSize}</WindowSize>
-                        <Options>
-                            <FilterType>0</FilterType>
-                            <Conflict>1</Conflict>
-                            <BodyPreference xmlns="uri:AirSyncBase">
-                                <Type>2</Type>
-                                <TruncationSize>51200</TruncationSize>
-                                <AllOrNone>0</AllOrNone>
-                            </BodyPreference>
-                        </Options>
-                    </Collection>
-                </Collections>
-            </Sync>
-            EOF;
-        return $this->request($request, 'Sync');
-    }
-
-    /**
-     * Test Sync command
-     */
-    public function testRelationsSync()
-    {
-        $sync = \kolab_sync::get_instance();
-        if (!$sync->storage()->relationSupport) {
-            $this->markTestSkipped('No relation support');
-        }
-
-        $this->emptyTestFolder('INBOX', 'mail');
-        $this->emptyTestFolder('Configuration', 'configuration');
-        $this->registerDevice();
-
-        // Test INBOX
-        $folderId = '38b950ebd62cd9a66929c89615d0fc04';
-        $syncKey = 0;
-        $response = $this->initialSyncRequest($folderId);
-        $this->assertEquals(200, $response->getStatusCode());
-
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-
-        $this->assertSame('1', $xpath->query("//ns:Sync/ns:Collections/ns:Collection/ns:Status")->item(0)->nodeValue);
-        $this->assertSame(strval(++$syncKey), $xpath->query("//ns:Sync/ns:Collections/ns:Collection/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame('Email', $xpath->query("//ns:Sync/ns:Collections/ns:Collection/ns:Class")->item(0)->nodeValue);
-        $this->assertSame($folderId, $xpath->query("//ns:Sync/ns:Collections/ns:Collection/ns:CollectionId")->item(0)->nodeValue);
-
-        // First we append 
-        $uid1 = $this->appendMail('INBOX', 'mail.sync1');
-        $uid2 = $this->appendMail('INBOX', 'mail.sync2');
-        $this->appendMail('INBOX', 'mail.sync1', 'sync1' => 'sync3');
-        $this->appendMail('INBOX', 'mail.sync1', 'sync1' => 'sync4');
-
-        $sync = \kolab_sync::get_instance();
-
-        $device = $sync->storage()->device_get(self::$deviceId);
-
-        //Add a tag
-        $sync->storage()->updateItem($folderId, $device'ID', \kolab_sync_storage::MODEL_EMAIL, $uid1, null, 'categories' => 'test1');
-        sleep(1);
-
-        $response = $this->syncRequest($syncKey, $folderId, 10);
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-        $root = "//ns:Sync/ns:Collections/ns:Collection";
-        $this->assertSame('1', $xpath->query("{$root}/ns:Status")->item(0)->nodeValue);
-        $this->assertSame(strval(++$syncKey), $xpath->query("{$root}/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame($folderId, $xpath->query("{$root}/ns:CollectionId")->item(0)->nodeValue);
-        $this->assertSame(4, $xpath->query("{$root}/ns:Commands/ns:Add")->count());
-
-        $root .= "/ns:Commands/ns:Add";
-        $this->assertSame(1, $xpath->query("{$root}/ns:ApplicationData/Email:Categories")->count());
-        $this->assertSame("test1", $xpath->query("{$root}/ns:ApplicationData/Email:Categories")->item(0)->nodeValue);
-
-        //Add a second tag
-        $sync->storage()->updateItem($folderId, $device'ID', \kolab_sync_storage::MODEL_EMAIL, $uid1, null, 'categories' => 'test1', 'test2');
-        sleep(1); // Necessary to make sure we pick up on the tag.
-
-        $response = $this->syncRequest($syncKey, $folderId, 10);
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-
-        $root = "//ns:Sync/ns:Collections/ns:Collection";
-        $this->assertSame('1', $xpath->query("{$root}/ns:Status")->item(0)->nodeValue);
-        $this->assertSame(strval(++$syncKey), $xpath->query("{$root}/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame($folderId, $xpath->query("{$root}/ns:CollectionId")->item(0)->nodeValue);
-        $this->assertSame(0, $xpath->query("{$root}/ns:Commands/ns:Add")->count());
-        $this->assertSame(1, $xpath->query("{$root}/ns:Commands/ns:Change")->count());
-        $root .= "/ns:Commands/ns:Change";
-        $this->assertSame(1, $xpath->query("{$root}/ns:ApplicationData/Email:Categories")->count());
-        //FIXME not sure what I'm doing wrong, but the xml looks ok
-        $this->assertSame("test1test2", $xpath->query("{$root}/ns:ApplicationData/Email:Categories")->item(0)->nodeValue);
-
-        $retries = 2;
-        $syncKey--;
-        // Rerun the same command and make sure we get the same result
-        for ($i = 0; $i < $retries; $i++) {
-            $response = $this->syncRequest($syncKey, $folderId, 10);
-            $this->assertEquals(200, $response->getStatusCode());
-            $dom = $this->fromWbxml($response->getBody());
-            $xpath = $this->xpath($dom);
-
-            $root = "//ns:Sync/ns:Collections/ns:Collection";
-            $this->assertSame('1', $xpath->query("{$root}/ns:Status")->item(0)->nodeValue);
-            $this->assertSame($folderId, $xpath->query("{$root}/ns:CollectionId")->item(0)->nodeValue);
-            $this->assertSame(0, $xpath->query("{$root}/ns:Commands/ns:Add")->count());
-            $this->assertSame(1, $xpath->query("{$root}/ns:Commands/ns:Change")->count());
-            $root .= "/ns:Commands/ns:Change";
-            $this->assertSame(1, $xpath->query("{$root}/ns:ApplicationData/Email:Categories")->count());
-            //FIXME not sure what I'm doing wrong, but the xml looks ok
-            $this->assertSame("test1test2", $xpath->query("{$root}/ns:ApplicationData/Email:Categories")->item(0)->nodeValue);
-
-            // Assert the db state
-            $rcube = \rcube::get_instance();
-            $db    = $rcube->get_dbh();
-            $result = $db->query(
-                "SELECT `data`, `synctime` FROM `syncroton_relations_state`"
-                . " WHERE `device_id` = ? AND `folder_id` = ?"
-                . " ORDER BY `synctime` DESC",
-                $device'ID',
-                $folderId
-            );
-            $data = ;
-            while ($state = $db->fetch_assoc($result)) {
-                $data = $state;
-            }
-            $this->assertSame(2, count($data));
-            // Make sure we have a new timestamp after the first iteration.
-            // This way we can potentially catch errors when we end up using the same or a different timestamp.
-            sleep(1);
-        }
-        $syncKey += ($retries + 1);
-
-        // Reset to no tags
-        $sync->storage()->updateItem($folderId, $device'ID', \kolab_sync_storage::MODEL_EMAIL, $uid1, null, 'categories' => );
-        sleep(1); // Necessary to make sure we pick up on the tag.
-
-        $response = $this->syncRequest($syncKey, $folderId, 10);
-        $this->assertEquals(200, $response->getStatusCode());
-        $dom = $this->fromWbxml($response->getBody());
-        $xpath = $this->xpath($dom);
-
-        $root = "//ns:Sync/ns:Collections/ns:Collection";
-        $this->assertSame('1', $xpath->query("{$root}/ns:Status")->item(0)->nodeValue);
-        $this->assertSame(strval(++$syncKey), $xpath->query("{$root}/ns:SyncKey")->item(0)->nodeValue);
-        $this->assertSame($folderId, $xpath->query("{$root}/ns:CollectionId")->item(0)->nodeValue);
-        $this->assertSame(0, $xpath->query("{$root}/ns:Commands/ns:Add")->count());
-        $this->assertSame(1, $xpath->query("{$root}/ns:Commands/ns:Change")->count());
-        $root .= "/ns:Commands/ns:Change";
-        $this->assertSame(0, $xpath->query("{$root}/ns:ApplicationData/Email:Categories")->count());
-        //FIXME this currently fails because we omit the empty categories element
-        // $this->assertSame("", $xpath->query("{$root}/ns:ApplicationData/Email:Categories")->item(0)->nodeValue);
-        
-
-        // Assert the db state
-        $result = $db->query(
-            "SELECT `data`, `synctime` FROM `syncroton_relations_state`"
-            . " WHERE `device_id` = ? AND `folder_id` = ?"
-            . " ORDER BY `synctime` DESC",
-            $device'ID',
-            $folderId
-        );
-        $data = ;
-        while ($state = $db->fetch_assoc($result)) {
-            $data = $state;
-        }
-        $this->assertSame(2, count($data));
-
-        $response = $this->syncRequest($syncKey, $folderId, 10);
-        $this->assertEquals(200, $response->getStatusCode());
-        // We expect an empty response without a change
-        $this->assertEquals(0, $response->getBody()->getSize());
-        // print($dom->saveXML());
-
-        return $syncKey;
-    }
-}
-

kolab-syncroton-2.4.2.tar.gz/tests/SyncTestCase.php Changed

@@ -51,7 +51,6 @@
         $db->query('DELETE FROM syncroton_data');
         $db->query('DELETE FROM syncroton_data_folder');
         $db->query('DELETE FROM syncroton_content');
-        $db->query('DELETE FROM syncroton_relations_state');
 
         self::$client = new \GuzzleHttp\Client(
                 'http_errors' => false,
@@ -88,7 +87,6 @@
             $db->query('DELETE FROM syncroton_device');
             $db->query('DELETE FROM syncroton_synckey');
             $db->query('DELETE FROM syncroton_folder');
-            $db->query('DELETE FROM syncroton_relations_state');
         }
     }
 
@@ -118,7 +116,7 @@
         $uid = $imap->save_message($folder, $source, '', $is_file);
 
         if ($uid === false) {
-            exit("Failed to append mail {$filename} into {$folder}");
+            exit("Failed to append mail into {$folder}");
         }
 
         return $uid;
@@ -381,7 +379,6 @@
         $xpath = new \DOMXpath($dom);
         $xpath->registerNamespace("ns", $dom->documentElement->namespaceURI);
         $xpath->registerNamespace("AirSync", "uri:AirSync");
-        $xpath->registerNamespace("AirSyncBase", "uri:AirSyncBase");
         $xpath->registerNamespace("Calendar", "uri:Calendar");
         $xpath->registerNamespace("Contacts", "uri:Contacts");
         $xpath->registerNamespace("Email", "uri:Email");

kolab-syncroton.dsc Changed

Build Results
RPM Lint

Refresh

Comments for request 3285 0

Request History

mollekopf created request 5 months ago

New release 2.4.2.17

mollekopf superseded request 5 months ago

superseded by 3288