Request 3324 (review)

Overview

Request 3324 (review)

Fix `UnicodeDecodeError` in wallace

Created by sicherha 3 months ago
In state review
Open review for kolab-developers

Submit pykolab-python3

Submit package home:sicher...es:Kolab:16 / pykolab-python3 to package Kolab:16:Testing / pykolab-python3

pykolab.spec Changed

@@ -56,7 +56,7 @@
 Summary:            Kolab Groupware Solution
 Name:               pykolab
 Version: 0.9.0.7
-Release:            1%{?dist}
+Release:            2%{?dist}
 License:            GPLv3+
 Group:              Applications/System
 URL:                http://kolab.org/
@@ -64,6 +64,8 @@
 Source0:            pykolab-%{upstream_version}.tar.gz
 Source1:            pykolab.logrotate
 
+Patch0001:          0001-T8337-Fix-UnicodeDecodeError-in-wallace.patch
+
 BuildRoot:          %{_tmppath}/%{name}-%{version}-%{release}-root
 BuildArch:          noarch
 
@@ -251,6 +253,7 @@
 
 %prep
 %setup -q -n %{name}-%{upstream_version}
+%patch0001 -p1
 
 %build
 autoreconf -v || automake --add-missing && autoreconf -v
@@ -617,6 +620,9 @@
 %attr(0700,%{kolab_user},%{kolab_group}) %dir %{_var}/spool/pykolab/wallace
 
 %changelog
+* Fri Sep 20 2022 Christoph Erhardt <kolab@sicherha.de> - 0.9.0.7-2
+- Fix `UnicodeDecodeError` in wallace
+
 * Tue Aug  2 2022 Christian Mollekopf <mollekopf@apheleia-it.ch> - 0.8.23-2
 - Python3 support on centos 8

0001-T8337-Fix-UnicodeDecodeError-in-wallace.patch Added

@@ -0,0 +1,29 @@
+From 0b38809701d43140840c8e83fc0b4c90ef272163 Mon Sep 17 00:00:00 2001
+Message-ID: <0b38809701d43140840c8e83fc0b4c90ef272163.1726868869.git.kolab@sicherha.de>
+From: Christoph Erhardt <kolab@sicherha.de>
+Date: Fri, 20 Sep 2024 23:42:37 +0200
+Subject: PATCH T8337: Fix `UnicodeDecodeError` in wallace
+
+Reviewers: mollekopf
+
+Differential Revision: https://git.kolab.org/D4959
+---
+ wallace/modules.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/wallace/modules.py b/wallace/modules.py
+index f774e6e..e4a4ab6 100644
+--- a/wallace/modules.py
++++ b/wallace/modules.py
+@@ -369,7 +369,7 @@ def cb_action_ACCEPT(module, filepath):
+     log.debug(_("Accepting message in: %r") %(filepath), level=8)
+ 
+     # parse message headers
+-    message = Parser().parse(open(filepath, 'r'), True)
++    message = Parser().parse(open(filepath, 'r', encoding="utf8", errors="ignore"), True)
+ 
+     messageid = message'message-id' if 'message-id' in message else None
+     sender = formataddr(x) for x in getaddresses(message.get_all('X-Kolab-From', ))
+-- 
+2.46.1
+

debian.changelog Changed

debian.series Changed

pykolab.dsc Changed

Build Results
RPM Lint

Refresh

Comments for request 3324 0

Request History

sicherha created request 3 months ago

Fix `UnicodeDecodeError` in wallace