Request 3335 (accepted)

Overview

Request 3335 (accepted)

New release 0.4.8.6

Created by mollekopf about 1 month ago
In state accepted
Open review for Admin
Open review for vanmeeuwen
Open review for mollekopf
Open review for kolab-developers

Submit iRony

Submit package Kolab:16:Testing / iRony to package Kolab:16 / iRony

iRony.spec Changed

debian.changelog Changed

iRony-0.4.8.tar.gz/lib/Kolab/DAV/Auth/HTTPBasic.php Changed

iRony-0.4.8.tar.gz/lib/Kolab/DAV/Node.php Changed

@@ -161,7 +161,7 @@
      */
     protected function fileData($name, $data = null)
     {
-        if ($this->data && $this->data'type') {
+        if ($this->data && !empty($this->data'type')) {
             $type = $this->data'type';
         }
         else {
@@ -170,11 +170,10 @@
 
         // $data can be a resource or a string
         if (is_resource($data)) {
-            // $data can be php://input or php://temp
-            // php://input is not seekable, we need to "convert"
-            // it to seekable resource, fstat/rewind later will work
+            // It can be php://input or php://temp resource stream.
+            // php://input is seekable on recent PHP versions, but fstat() fails so we can't use it
             $meta = stream_get_meta_data($data);
-            if (!$meta'seekable') {
+            if (empty($meta'seekable') || fstat($data) === false) {
                 $new_data = fopen('php://temp','r+');
                 stream_copy_to_stream($data, $new_data);
                 rewind($new_data);

iRony.dsc Changed

Build Results
RPM Lint

Refresh

Comments for request 3335 0

Request History

mollekopf created request about 1 month ago

New release 0.4.8.6

mollekopf accepted request 2 days ago