Request 3336 (accepted)

This request supersedes: request 3334 (Show diff)

Overview

Request 3336 (accepted)

New release 0.5.14.12

Created by mollekopf about 1 month ago
In state accepted
Supersedes 3334
Open review for Admin
Open review for vanmeeuwen
Open review for mollekopf
Open review for kolab-developers

Submit chwala

Submit package Kolab:16:Testing / chwala to package Kolab:16 / chwala

chwala.spec Changed

chwala-0.5.14.tar.gz/lib/drivers/kolab/kolab_file_storage.php Changed

@@ -145,7 +145,7 @@
     private function select_host($username)
     {
         // Get IMAP host
-        $host = $this->rc->config->get('default_host');
+        $host = $this->rc->config->get('imap_host', $this->rc->config->get('default_host'));
 
         if (is_array($host)) {
             list($user, $domain) = explode('@', $username);
@@ -187,11 +187,10 @@
 
         $login_lc     = $this->rc->config->get('login_lc');
         $default_port = $this->rc->config->get('default_port', 143);
+        $ssl          = null;
 
         // parse $host
         $a_host = parse_url($host);
-        $port = null;
-        $ssl = null;
         if (!empty($a_host'host')) {
             $host = $a_host'host';
             $ssl = (isset($a_host'scheme') && in_array($a_host'scheme', array('ssl','imaps','tls'))) ? $a_host'scheme' : null;
@@ -203,7 +202,7 @@
             }
         }
 
-        if (!$port) {
+        if (empty($port)) {
             $port = $default_port;
         }
 
@@ -1055,7 +1054,7 @@
         $folders = array_values($folders);
 
         // In extended format we return array of arrays
-        if ($params'extended') {
+        if (!empty($params'extended')) {
             if (!$rights && $params'permissions') {
                 // get list of known writable folders from cache
                 $cache_key   = 'mailboxes.permissions';

chwala-0.5.14.tar.gz/lib/file_api_lib.php Changed

chwala-0.5.14.tar.gz/lib/file_wopi.php Changed

chwala.dsc Changed

debian.changelog Changed

Build Results
RPM Lint

Refresh

Comments for request 3336 0

Request History

mollekopf created request about 1 month ago

New release 0.5.14.12

mollekopf accepted request 4 days ago